Title: Invalid emit for class+namespace using module=commonJs in TS 3.9 · Issue #37118 · microsoft/TypeScript · GitHub
Open Graph Title: Invalid emit for class+namespace using module=commonJs in TS 3.9 · Issue #37118 · microsoft/TypeScript
X Title: Invalid emit for class+namespace using module=commonJs in TS 3.9 · Issue #37118 · microsoft/TypeScript
Description: TypeScript Version: 3.9.0-dev.20200228 Search Terms: export namespace Code With target = ES2017, module = commonJS export class Color { static readonly x = new Color(); } export namespace Color { export const a = 1 } Expected behavior: I...
Open Graph Description: TypeScript Version: 3.9.0-dev.20200228 Search Terms: export namespace Code With target = ES2017, module = commonJS export class Color { static readonly x = new Color(); } export namespace Color { e...
X Description: TypeScript Version: 3.9.0-dev.20200228 Search Terms: export namespace Code With target = ES2017, module = commonJS export class Color { static readonly x = new Color(); } export namespace Color { e...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/37118
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Invalid emit for class+namespace using module=commonJs in TS 3.9","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!--\r\nPlease try to reproduce the issue with the latest published version. It may have already been fixed.\r\nFor npm: `typescript@next`\r\nThis is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly\r\n-->\r\n**TypeScript Version:** 3.9.0-dev.20200228\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:**\r\n- export\r\n- namespace\r\n\r\n**Code**\r\nWith `target = ES2017`, `module = commonJS`\r\n\r\n```ts\r\nexport class Color {\r\n static readonly x = new Color();\r\n}\r\n\r\nexport namespace Color {\r\n export const a = 1\r\n}\r\n```\r\n\r\n**Expected behavior:**\r\nIn TS 3.8, this emits:\r\n\r\n```js\r\nObject.defineProperty(exports, \"__esModule\", { value: true });\r\nclass Color {\r\n}\r\nexports.Color = Color;\r\nColor.x = new Color();\r\n(function (Color) {\r\n Color.a = 1;\r\n})(Color = exports.Color || (exports.Color = {}));\r\n```\r\n\r\n**Actual behavior:**\r\nIn TS 3.9, this emits:\r\n\r\n```js\r\nObject.defineProperty(exports, \"__esModule\", { value: true });\r\nconst Color = /** @class */ (() => {\r\n class Color {\r\n }\r\n Color.x = new Color();\r\n return Color;\r\n})();\r\nexports.Color = Color;\r\n(function (Color) {\r\n Color.a = 1;\r\n})(Color = exports.Color || (exports.Color = {}));\r\nexports.Color = Color;\r\n```\r\n\r\nWhich is not valid since it tries to reassign a constant value: `Color = exports.Color`\r\n\r\n\r\n- [TS 3.8.2](https://www.typescriptlang.org/play/?module=1&ts=3.9.0-dev.20200227&ssl=7&ssc=21&pln=7&pc=26#code/PQKgtBldO38MU5EBQACE70GED2ADgJ4BOAlgOYAWALugBQDGAlOgLJmMl4DOeAZnXwkCeEgEMaZPADsAdOgCCAG2Xpy1Gj3UBTHjpIA3HQBM5GLOgAynHTP0n0AVxkmD6GlR3sAkgBVrW3sdBQBlHW8bRjt9ORoADzoyGQ8vdAJuACsdRjpuPDp+MXRlIP10ZKKSAFtJaXkLFCbmltakEGBUVB140RI6RmVxHm18ZWKAbwxsdB4aOsZdcRNZZSJ0ePQAXnQZHQB3XDxxknpmAG4ugF8unr66GXFqvQJxaKOT9CmZ9DuxAdkc3Q4m26AAjKgbkA)\r\n- [TS 3.9](https://www.typescriptlang.org/play/?module=1&ssl=13&ssc=1&pln=5&pc=1#code/PQKgtBldO38MU5EBQACE70GED2ADgJ4BOAlgOYAWALugBQDGAlOgLJmMl4DOeAZnXwkCeEgEMaZPADsAdOgCCAG2Xpy1Gj3UBTHjpIA3HQBM5GLOgAynHTP0n0AVxkmD6GlR3sAkgBVrW3sdBQBlHW8bRjt9ORoADzoyGQ8vdAJuACsdRjpuPDp+MXRlIP10ZKKSAFtJaXkLFCbmltakEGBUVB140RI6RmVxHm18ZWKAbwxsdB4aOsZdcRNZZSJ0ePQAXnQZHQB3XDxxknpmAG5UAF8unr66GXFqvQJxaKOT9CmZ9DuxAdkc3Q4m26AAjNdUEA)\r\n","author":{"url":"https://github.com/mjbvz","@type":"Person","name":"mjbvz"},"datePublished":"2020-02-28T22:22:30Z","url":"https://github.com/microsoft/TypeScript/issues/37118"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:5f5dc103-6ff1-8455-ec1e-5157e8689fc1 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CFA0:EA09B:24168DB:2FD646B:6B0194C6 |
| html-safe-nonce | 5f88f0a46a5b03d9b7cdc90956a6db06e0d34b3a194fea8ca8c353010bd0809e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRkEwOkVBMDlCOjI0MTY4REI6MkZENjQ2Qjo2QjAxOTRDNiIsInZpc2l0b3JfaWQiOiI0ODMyOTM0ODUyMzg0ODg4MDA2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | acb060cf4fc9766b27ea08c866705f4bb8a29e2595bb1e556fc2444e4f9966c6 |
| hovercard-subject-tag | issue:573037608 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/37118/issue_layout |
| twitter:image | https://opengraph.githubassets.com/11c9b17de7a6027ef735cf21c7184305487cee6e8cf2de58889ffe1e45aeb073/microsoft/TypeScript/issues/37118 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/11c9b17de7a6027ef735cf21c7184305487cee6e8cf2de58889ffe1e45aeb073/microsoft/TypeScript/issues/37118 |
| og:image:alt | TypeScript Version: 3.9.0-dev.20200228 Search Terms: export namespace Code With target = ES2017, module = commonJS export class Color { static readonly x = new Color(); } export namespace Color { e... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mjbvz |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width