Title: Strict null check flow analysis broken by unrelated branch logic · Issue #36028 · microsoft/TypeScript · GitHub
Open Graph Title: Strict null check flow analysis broken by unrelated branch logic · Issue #36028 · microsoft/TypeScript
X Title: Strict null check flow analysis broken by unrelated branch logic · Issue #36028 · microsoft/TypeScript
Description: TypeScript Version: 3.8.0-dev.20200104 Search Terms: flow, branch, unrelated Code type PendingRequest
Open Graph Description: TypeScript Version: 3.8.0-dev.20200104 Search Terms: flow, branch, unrelated Code type PendingRequest
X Description: TypeScript Version: 3.8.0-dev.20200104 Search Terms: flow, branch, unrelated Code type PendingRequest<T, E> = { pending: true; response: T | null; error: E | null; }; type IdleRequest<T, E...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/36028
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Strict null check flow analysis broken by unrelated branch logic","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!--\r\nPlease try to reproduce the issue with the latest published version. It may have already been fixed.\r\nFor npm: `typescript@next`\r\nThis is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly\r\n-->\r\n**TypeScript Version:** 3.8.0-dev.20200104\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:**\r\n\r\nflow, branch, unrelated\r\n\r\n**Code**\r\n\r\n```ts\r\ntype PendingRequest\u003cT, E> = {\r\n pending: true;\r\n response: T | null;\r\n error: E | null;\r\n};\r\n\r\ntype IdleRequest\u003cT, E> = {\r\n pending: false;\r\n response: T | null;\r\n error: E | null;\r\n};\r\n\r\ntype MyRequest\u003cT, E> = PendingRequest\u003cT, E> | IdleRequest\u003cT, E>;\r\n\r\nconst request: MyRequest\u003cstring, {}> = { pending: false, response: 'hello', error: null };\r\n\r\nfunction someFlow() {\r\n if (!request.response) return;\r\n console.log(request.pending);\r\n return request.response.toUpperCase();\r\n}\r\n\r\nfunction someFlow2() {\r\n if (!request.response) return;\r\n console.log(request.pending ? 'pending' : 'nothing');\r\n return request.response.toUpperCase();\r\n}\r\n```\r\n\r\n**Expected behavior:**\r\n\r\n`someFlow2` works just like `someFlow`.\r\n\r\n**Actual behavior:**\r\n\r\n`someFlow2` contains an unhandled null case.\r\n\r\n\r\n\r\n**Playground Link:** \u003c!-- A link to a TypeScript Playground \"Share\" link which demonstrates this behavior -->\r\n\r\n[Click me!](https://www.typescriptlang.org/play/index.html?ts=3.8.0-dev.20200104&ssl=1&ssc=1&pln=27&pc=2#code/C4TwDgpgBAChB2ATAlvA5gJQgRwK4QGdgAeAFQBooBRAPigF4oBvAKCikiVTQC4pgATvgDcbKAMJgA9vAIQ+pKAB8o8XABt1o9hAECpAvlWWqNWlgF9RLUJCgBJROohY8hEhWp1GrdpxTofABmAIbqctrikjJyCiZqmpG6+obU8WaiViw24NAAsiCu+ERklLQMsAgBmDjFHmV0Ko7ORe6lXtYAxjHAUW5EfAWtJUQC3JRMFt7MHFXcwWFylBIE0rLyUADkABYQmlKblMkGfAnqUFksQbjwncDIMlAEUgC2EABi6lIA7gAUAJTMMTsZBBKC-ACEEn6wAAdCs1nJARJgLgBPBIuxurIpM5YV80L9oXVYf5uP9MVFUei+iSETEILDgFIAKpgSACADCITkAMy2Wut3uj2eb0+PwATACgewQWDIcT3PDoutkRBqRjgVBsc88QSibUlWT0FAAPxbY1oTZQPibeBSYDbbibClalFo+C0pX09ZM1ns3Tc3muixAA)\r\n\r\n**Related Issues:** \u003c!-- Did you find other bugs that looked similar? -->\r\n\r\nhttps://github.com/microsoft/TypeScript/issues/9998 is about trade-offs in flow analysis, but I'm not sure if this case is a bug or known tradeoff. At least for me it was unexpected.","author":{"url":"https://github.com/donaldpipowitch","@type":"Person","name":"donaldpipowitch"},"datePublished":"2020-01-06T14:16:45Z","url":"https://github.com/microsoft/TypeScript/issues/36028"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:35c82e59-ac46-bbd0-bbe2-9ab29600daa9 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B302:27D3AD:EE88DA:12F75B0:6B010A71 |
| html-safe-nonce | 5d53c149e7b96b384415fe544e992a73c19e2249827733d126997d9fc090e708 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzAyOjI3RDNBRDpFRTg4REE6MTJGNzVCMDo2QjAxMEE3MSIsInZpc2l0b3JfaWQiOiIzNjE2NjkwMDE1MzkwMjk2MTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 25e20d4b1baa00af44967e453134296b56247f479ff6aac16d896d7e7c666e43 |
| hovercard-subject-tag | issue:545749613 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/36028/issue_layout |
| twitter:image | https://opengraph.githubassets.com/179ff389b46fbbbba5debde9a59d42d4f590e6eca5672fe3a50acadf80696c53/microsoft/TypeScript/issues/36028 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/179ff389b46fbbbba5debde9a59d42d4f590e6eca5672fe3a50acadf80696c53/microsoft/TypeScript/issues/36028 |
| og:image:alt | TypeScript Version: 3.8.0-dev.20200104 Search Terms: flow, branch, unrelated Code type PendingRequest |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | donaldpipowitch |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width