René's URL Explorer Experiment


Title: Extend createMethodSignature and updateMethodSignature with 'modifiers' argument · Issue #35959 · microsoft/TypeScript · GitHub

Open Graph Title: Extend createMethodSignature and updateMethodSignature with 'modifiers' argument · Issue #35959 · microsoft/TypeScript

X Title: Extend createMethodSignature and updateMethodSignature with 'modifiers' argument · Issue #35959 · microsoft/TypeScript

Description: Search Terms updateMethodSignature, createMethodSignature Suggestion It should be possible to provide an array of Modifiers (or undefined) to the createMethodSignature and updateMethodSignature functions. Use Cases When using the TypeScr...

Open Graph Description: Search Terms updateMethodSignature, createMethodSignature Suggestion It should be possible to provide an array of Modifiers (or undefined) to the createMethodSignature and updateMethodSignature fun...

X Description: Search Terms updateMethodSignature, createMethodSignature Suggestion It should be possible to provide an array of Modifiers (or undefined) to the createMethodSignature and updateMethodSignature fun...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/35959

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Extend createMethodSignature and updateMethodSignature with 'modifiers' argument","articleBody":"## Search Terms\r\n\r\n\u003c!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->\r\nupdateMethodSignature, createMethodSignature\r\n\r\n## Suggestion\r\n\r\n\u003c!-- A summary of what you'd like to see added or changed -->\r\nIt should be possible to provide an array of Modifiers (or `undefined`) to the `createMethodSignature` and `updateMethodSignature` functions.\r\n\r\n## Use Cases\r\n\r\n\u003c!--\r\nWhat do you want to use this for?\r\nWhat shortcomings exist with current approaches?\r\n-->\r\n\r\nWhen using the TypeScript compiler APIs, TypeScript provides numerous `create` and `update` functions that can be used to generate an AST, for example from Custom Transformers. However, for `MethodSignature`s, which may have modifiers such as the `static` keyword, there's no option to create or update their modifiers. This breaks [one of my libraries](https://github.com/wessberg/ts-clone-node) which sole purpose is to simply deep-clone a TypeScript node. A workaround is to manually patch the modifiers, however I hope this can be part of the function (as it is for others, like `createPropertySignature` and `updatePropertySignature`).\r\n\r\n## Examples\r\n\r\n\u003c!-- Show how this would be used and what the behavior would be -->\r\n\r\n```typescript\r\nimport {createMethodSignature, createNodeArray, createModifier, SyntaxKind} from \"typescript\";\r\n\r\ncreateMethodSignature(\r\n    createNodeArray([\r\n        createModifier(SyntaxKind.StaticKeyword)\r\n    ]),\r\n    node.typeParameters,\r\n    node.parameters,\r\n    node.type,\r\n    node.name,\r\n    node.questionToken\r\n);\r\n```\r\n\r\nHowever, the above example would be a breaking change since the first parameter expects a NodeArray of type parameters, so an alternative solution would be to accept it as the last argument.\r\n\r\n## Checklist\r\n\r\nMy suggestion meets these guidelines:\r\n\r\n* [X] This wouldn't be a breaking change in existing TypeScript/JavaScript code\r\n* [X] This wouldn't change the runtime behavior of existing JavaScript code\r\n* [X] This could be implemented without emitting different JS based on the types of the expressions\r\n* [X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)\r\n* [X] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).\r\n","author":{"url":"https://github.com/wessberg","@type":"Person","name":"wessberg"},"datePublished":"2020-01-02T12:12:36Z","url":"https://github.com/microsoft/TypeScript/issues/35959"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:5a337dab-ed82-75cf-b998-fcea3e224902
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBCBE:38C5CF:75D001:99D85E:6B00D46B
html-safe-noncea24ec9a4c6227859b8b8732f9a344365eb6bdb93e3dd43cc35ee2889b210f701
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQ0JFOjM4QzVDRjo3NUQwMDE6OTlEODVFOjZCMDBENDZCIiwidmlzaXRvcl9pZCI6IjEyNzkwMDUwMzQ0OTQ4NzQ3MzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac06ba24838ea93ee773e66e89cf2b169d4f8eb5263f921a2460c978663fdd3f67
hovercard-subject-tagissue:544555173
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/35959/issue_layout
twitter:imagehttps://opengraph.githubassets.com/922164fc1e28684354fb5351308c6780fc6b24c7345997ff05758fd5803ee280/microsoft/TypeScript/issues/35959
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/922164fc1e28684354fb5351308c6780fc6b24c7345997ff05758fd5803ee280/microsoft/TypeScript/issues/35959
og:image:altSearch Terms updateMethodSignature, createMethodSignature Suggestion It should be possible to provide an array of Modifiers (or undefined) to the createMethodSignature and updateMethodSignature fun...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewessberg
hostnamegithub.com
expected-hostnamegithub.com
None85bbdfe2b6ba16e234513bc6ceff5d848ef8449820c900692a2b4e67061931e5
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4943239a6d2c591325dad6e5c313e1cafda877f6
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/35959#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F35959
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F35959
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/35959
Reloadhttps://github.com/microsoft/TypeScript/issues/35959
Reloadhttps://github.com/microsoft/TypeScript/issues/35959
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests307 (307)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/35959
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/35959
Extend createMethodSignature and updateMethodSignature with 'modifiers' argumenthttps://github.com/microsoft/TypeScript/issues/35959#top
Domain: APIRelates to the public API for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20API%22
In DiscussionNot yet reached consensushttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22In%20Discussion%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
https://github.com/wessberg
Frederik Wessberg (wessberg)https://github.com/wessberg
on Jan 2, 2020https://github.com/microsoft/TypeScript/issues/35959#issue-544555173
one of my librarieshttps://github.com/wessberg/ts-clone-node
TypeScript's Design Goalshttps://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Domain: APIRelates to the public API for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20API%22
In DiscussionNot yet reached consensushttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22In%20Discussion%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
on Jan 31, 2020https://github.com/microsoft/TypeScript/issues/35959#event-2998833673
https://github.com/wessberg
Frederik Wessberg (wessberg)https://github.com/wessberg
on Jul 3, 2020https://github.com/microsoft/TypeScript/issues/35959#issuecomment-653677086
#35282https://github.com/microsoft/TypeScript/pull/35282
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/35959
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/35959
Domain: APIRelates to the public API for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20API%22
In DiscussionNot yet reached consensushttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22In%20Discussion%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.