René's URL Explorer Experiment


Title: Design Meeting Notes, 12/20/2019 · Issue #35807 · microsoft/TypeScript · GitHub

Open Graph Title: Design Meeting Notes, 12/20/2019 · Issue #35807 · microsoft/TypeScript

X Title: Design Meeting Notes, 12/20/2019 · Issue #35807 · microsoft/TypeScript

Description: A Stricter Subtype Relationship Issue: #35414 PR: #35659 We have this thing where we perform union subtype reduction - reducing constituents of unions when a union contains a supertype. But we sort unions by a type IDs, but that's not a ...

Open Graph Description: A Stricter Subtype Relationship Issue: #35414 PR: #35659 We have this thing where we perform union subtype reduction - reducing constituents of unions when a union contains a supertype. But we sort...

X Description: A Stricter Subtype Relationship Issue: #35414 PR: #35659 We have this thing where we perform union subtype reduction - reducing constituents of unions when a union contains a supertype. But we sort...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/35807

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Design Meeting Notes, 12/20/2019","articleBody":"# A Stricter Subtype Relationship\r\n\r\n\r\n* Issue: https://github.com/microsoft/TypeScript/issues/35414\r\n* PR: https://github.com/microsoft/TypeScript/pull/35659\r\n\r\n* We have this thing where we perform union subtype reduction - reducing constituents of unions when a union contains a supertype.\r\n* But we sort unions by a type IDs, but that's not a \"stable\" ordering.\r\n    * Our current subtype relationship contains \"ties\" though - several types can be subtypes of each other.\r\n    * First type ID wins, so if you reorder declarations/instantiations in your program, the behavior changes! That's undesirable.\r\n* The solution is to avoid places where types can \"tie\" in which types are supertypes.\r\n* It's strictly a good thing in subtype reduction, but it can have effects elsewhere.\r\n    * One effect that's measured is that two constituents might be preserved in a reduced union (something we're willing to take).\r\n    * Additionally, because of our union merging, we might have different effects on which signatures are present.\r\n    * Also seeing differences in overload resolution because overload resolution does a subtype pass.\r\n        * Historical reasons for saying `any` is not the best type to choose from.\r\n* These changes introduce a lot of potential breaks elsewhere, so we introduced a separate relationship to the compiler.\r\n    * Ideally we'd use this new subtype relationship everywhere, but we don't want to impact too much.\r\n* Example breaks seem \"good\" but hard to deal with.\r\n* Could we imagine a strict mode that uses the strict subtype relationship?\r\n    * Maybe! It's worth thinking about.\r\n* As a compiler writer, what relationship do I use?\r\n    * \\[\\[rules that went by too fast, but you can consult with the team]]\r\n* Conclusion\r\n    * Turn it on just for subtype reduction.\r\n    * Try it out everywhere, see what breaks, see if it can fit under a strict mode - i.e. `--strictSubtypes` but with a better name.\r\n\r\n# Assume Changes Only Affect Dependencies\r\n\r\n* Issue: https://github.com/microsoft/TypeScript/issues/33329\r\n* PR: https://github.com/microsoft/TypeScript/pull/35711\r\n\r\n* VS Code has a tool called `gulp-tsb`\r\n    * Its `--watch` is faster than `tsc --watch` because it assumes only direct dependencies will be affected.\r\n    * Common case is that they won't, so it's a nice optimization to iterate quickly, but it's definitely very sloppy/inaccurate.\r\n    * Takes incremental check time down from 14 seconds to 1 second.\r\n* \\[\\[Bikeshed on name]]\r\n\r\n# Type-Only Imports/Exports\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/35200\r\n\r\n* Scenarios\r\n    * Re-export a type in `isolatedModules`\r\n    * Stop eliding imports when I do DI\r\n    * \r\n* Behavior\r\n    * Changed default emit behavior to preserve imports\r\n    * Flag to opt in to the old behavior\r\n* Effect\r\n    * Can increase bundle sizes 👎\r\n    * Hard to determine where to fix 👎\r\n    * Runtime behavior might break, or you might not notice the change at all 👎\r\n* Proposals to mitigate issues\r\n    * Proposal 1\r\n        * Add error on regular imports used only as types.\r\n        * Disable error via a flag.\r\n    * Proposal 2\r\n        * Keep today's emit behavior.\r\n        * Opt into preserved imports via a flag\r\n        * Optionally enable this in `tsc --init`\r\n        * Optionally add a flag to force type-only imports for identifiers used only as types\r\n    * Proposal 3\r\n        * Transition plan\r\n* 3 years from now where do we want to be?\r\n    * Can we remove things from the import list under `isolatedModules` currently?\r\n        * Yes\r\n     * Anecdotal from Wesley: when I transitioned our unit tests into modules, there were a lot of issues because our unittests were only being included via type-imports.\r\n        * Experience is that elision has undesirable behavior\r\n    * This is a very big breaking change even if you phase it over several releases.\r\n        * People are in an unknown state of what they want - only make noise (i.e. give an error) when the intent isn't clear.\r\n* Can this be a strict mode flag?\r\n    * Strict flags have never affected emit.\r\n* Could this be mitigated with a tristate flag?\r\n    * Well then what's the default?\r\n* Conclusion:\r\n    * The safer proposal 2\r\n        * Leaves our options open\r\n    * Implement option as a tristate\r\n    * `preserve` be default in `tsc --init`\r\n    * Send PRs to 3rd party tools\r\n        * Turn it on in scaffolding tools\r\n        * Babel\r\n            * Need to signal to the team, maybe need a flag (@hzoo).\r\n\r\n# Use Getters for Live Bindings\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/33587\r\n\r\n* Turns out even we were giving people \"wrong\" exports because of this.\r\n* Let's do it.","author":{"url":"https://github.com/DanielRosenwasser","@type":"Person","name":"DanielRosenwasser"},"datePublished":"2019-12-20T21:26:17Z","url":"https://github.com/microsoft/TypeScript/issues/35807"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:a8154052-299e-f1f1-0705-a0b087c56260
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC05A:1D86C4:CBA622:103B55C:6B010007
html-safe-nonce75416484fb739d6f98efed5640e9b99eda7645e08d8d433302056ee9a6b7734c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDVBOjFEODZDNDpDQkE2MjI6MTAzQjU1Qzo2QjAxMDAwNyIsInZpc2l0b3JfaWQiOiI3MjExMTIzMDkzODkxMjUyMjMyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaceb47629fcba4dc905d488839eb3f1cbae06c108878bc8954640572ec98463211
hovercard-subject-tagissue:541207224
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/35807/issue_layout
twitter:imagehttps://opengraph.githubassets.com/711e9358a5f3ca6ffae2f9c3d5c70c7163fec5dcf654bd7e0d8999ad7a153de9/microsoft/TypeScript/issues/35807
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/711e9358a5f3ca6ffae2f9c3d5c70c7163fec5dcf654bd7e0d8999ad7a153de9/microsoft/TypeScript/issues/35807
og:image:altA Stricter Subtype Relationship Issue: #35414 PR: #35659 We have this thing where we perform union subtype reduction - reducing constituents of unions when a union contains a supertype. But we sort...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDanielRosenwasser
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/35807#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F35807
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F35807
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/35807
Reloadhttps://github.com/microsoft/TypeScript/issues/35807
Reloadhttps://github.com/microsoft/TypeScript/issues/35807
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/35807
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/35807
Design Meeting Notes, 12/20/2019https://github.com/microsoft/TypeScript/issues/35807#top
Design NotesNotes from our design meetingshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Notes%22
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
on Dec 20, 2019https://github.com/microsoft/TypeScript/issues/35807#issue-541207224
Destructuring of optional fn + default function value gets signature from the value #35414https://github.com/microsoft/TypeScript/issues/35414
Increase selectivity of subtype relationship for signatures #35659https://github.com/microsoft/TypeScript/pull/35659
tsc --watch --incremental recompiles are too slow for use with VS Code source  #33329https://github.com/microsoft/TypeScript/issues/33329
Add assumeChangesOnlyAffectDirectDependencies as a option to skip checking and generating .d.ts files for files indirectly importing affected file #35711https://github.com/microsoft/TypeScript/pull/35711
#35200https://github.com/microsoft/TypeScript/pull/35200
Henry (@hzoo)https://github.com/hzoo
#33587https://github.com/microsoft/TypeScript/pull/33587
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Design NotesNotes from our design meetingshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Notes%22
on Dec 20, 2019https://github.com/microsoft/TypeScript/issues/35807#event-2902115154
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
on Dec 20, 2019https://github.com/microsoft/TypeScript/issues/35807#issuecomment-568104752
Playgroundhttps://www.typescriptlang.org/play/#code/JYOwLgpgTgZghgYwgAgKoGdrIN4FgBQyRyIcAthAFzJwgCeA3AQL4EGiSyIoDKADhATA4AGwxYIAD0ggAJujSYoOAsRLkqydGCigA5k0LE4eiAH5qIAK5kARtEOt8BWYJFwoKGFZAIwwAHsQZGB0cSgACklqWjoASmpJEIVww1cEd09kb19-IOT+QWExJSiY+gTkJNDkQqFRVLZ8dMyUEQgwZCslakbmtw82jq0BepLoajrivoIAelnkAEF0dGA9Ult25DAA5AhEAAtkALADrHsEOG6UAJhkAANY+5o5Y7480hFkPigAgSh-BB0AR0KNpkpkABeLpKQzXZTQ0FFBqwpotQbIdqddABChBTQ+ADWIACAHcQIY5gsAEJWTpTFFYGqnFCkKC-UlYMB0AQAGi0ASpyE5WgOASsIlkyDIcEJKHQViyItEpLgdAUfGACEJIU6oCFpxqCCCsmAHwAdOw7hFQuEIji8SAIHFkAAyV0FMGMyIOiD4uIuvBGIi+-HmkwQRxAA
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jan 5, 2020https://github.com/microsoft/TypeScript/issues/35807#event-2922205933
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/35807
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/35807
Design NotesNotes from our design meetingshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Notes%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.