René's URL Explorer Experiment


Title: perf: exponential slowdown due to type narrowing with enums / type unions · Issue #35205 · microsoft/TypeScript · GitHub

Open Graph Title: perf: exponential slowdown due to type narrowing with enums / type unions · Issue #35205 · microsoft/TypeScript

X Title: perf: exponential slowdown due to type narrowing with enums / type unions · Issue #35205 · microsoft/TypeScript

Description: TypeScript Version: 3.8.0-dev.20191119 Also reproduceable in earlier versions. A quick scan through older versions shows TS 2.0 has a check time of 0.2s, which regressed to 1.9s in TS 2.1. Search Terms: performance, union types, enum, fl...

Open Graph Description: TypeScript Version: 3.8.0-dev.20191119 Also reproduceable in earlier versions. A quick scan through older versions shows TS 2.0 has a check time of 0.2s, which regressed to 1.9s in TS 2.1. Search T...

X Description: TypeScript Version: 3.8.0-dev.20191119 Also reproduceable in earlier versions. A quick scan through older versions shows TS 2.0 has a check time of 0.2s, which regressed to 1.9s in TS 2.1. Search T...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/35205

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"perf: exponential slowdown due to type narrowing with enums / type unions","articleBody":"**TypeScript Version:** 3.8.0-dev.20191119\r\n\r\nAlso reproduceable in earlier versions. A quick scan through older versions shows TS 2.0 has a check time of 0.2s, which regressed to 1.9s in TS 2.1.\r\n\r\n**Search Terms:** performance, union types, enum, flow analysis, type narrowing\r\n\r\n**Code**\r\n\r\n```ts\r\nexport enum Choice {\r\n  One,\r\n  Two,\r\n}\r\n\r\nconst choice: Choice = Choice.One;\r\nconst choiceOne = Choice.One;\r\n\r\nif (choice === choiceOne) {}\r\nif (choice === choiceOne) {}\r\nif (choice === choiceOne) {}\r\nif (choice === choiceOne) {}\r\nif (choice === choiceOne) {}\r\nif (choice === choiceOne) {}\r\nif (choice === choiceOne) {}\r\nif (choice === choiceOne) {}\r\nif (choice === choiceOne) {}\r\nif (choice === choiceOne) {}\r\nif (choice === choiceOne) {}\r\nif (choice === choiceOne) {}\r\nif (choice === choiceOne) {}\r\nif (choice === choiceOne) {}\r\nif (choice === choiceOne) {}\r\n```\r\n\r\n**Expected behavior:**\r\nType checking of this single file completes in the order of milliseconds.\r\n\r\nA real world example of this issue has been reported in the Angular repo for code generated by the template type checker: https://github.com/angular/angular/issues/33532. Angular has a code generator that emits TypeScript code to typecheck Angular templates.\r\n\r\n**Actual behavior:**\r\n\r\nEach additional if-statement is causing the type checking phase to roughly double in time. The above sample takes ~2.9s in the \"Check\" phase, as reported in the diagnostics report:\r\n\r\n```\r\nFiles:            2\r\nLines:         4381\r\nNodes:        13211\r\nIdentifiers:   5483\r\nSymbols:       3528\r\nTypes:         1225\r\nMemory used: 42102K\r\nI/O read:     0.00s\r\nI/O write:    0.00s\r\nParse time:   0.12s\r\nBind time:    0.04s\r\nCheck time:   2.87s\r\nEmit time:    0.00s\r\nTotal time:   3.03s\r\n```\r\n\r\nAdding one additional `if` statement increases the Check time to ~6.5s:\r\n\r\n```\r\nFiles:            2\r\nLines:         4382\r\nNodes:        13217\r\nIdentifiers:   5485\r\nSymbols:       3528\r\nTypes:         1225\r\nMemory used: 49768K\r\nI/O read:     0.00s\r\nI/O write:    0.00s\r\nParse time:   0.13s\r\nBind time:    0.05s\r\nCheck time:   6.43s\r\nEmit time:    0.00s\r\nTotal time:   6.61s\r\n```\r\n\r\nThese options **do** resolve the exponential slowdown:\r\n- Changing the type of either `choice` or `choiceOne` to `any`\r\n- inlining `choiceOne` into the if-statements\r\n\r\nThese options do **not** resolve the exponential slowdown:\r\n- Reducing the enum to a single option\r\n- Changing the type of choice into `Choice.One`\r\n- Replacing the enum with a type union\r\n\r\nNote that all these options do reduce the time, however adding additional if-statements still shows exponential slowdown.\r\n\r\n**Playground Link:**\r\n\r\nTerminal reproduction to get insight in timings:\r\n```\r\nnpx typescript@3.8.0-dev.20191119 sample.ts --diagnostics --noEmit --lib es5 --strict false --typeRoots []\r\n```\r\n\r\nSource code for `sample.ts` is found above, under _Code_.\r\n\r\n**Related Issues:** Not really","author":{"url":"https://github.com/JoostK","@type":"Person","name":"JoostK"},"datePublished":"2019-11-19T20:00:03Z","url":"https://github.com/microsoft/TypeScript/issues/35205"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:73be80db-be99-a1bb-0362-6fc0e1329591
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8F68:149F72:17BEB1:1FAD42:6B016395
html-safe-nonce3f068336cf9d6bb81d8ddae835c036ba085fa1b7d22ba447f9f0757f1caa7d2b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjY4OjE0OUY3MjoxN0JFQjE6MUZBRDQyOjZCMDE2Mzk1IiwidmlzaXRvcl9pZCI6IjI0MDg2MTg1OTMzOTk5NTYzNzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbee0264392ccad340f6483e175a7c25e92740457e295d7f6fac842c65f87a81a
hovercard-subject-tagissue:525233088
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/35205/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f87dd5428e6d48e2539c56b31de5d131087f942d5305aac2f230b692977875cd/microsoft/TypeScript/issues/35205
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f87dd5428e6d48e2539c56b31de5d131087f942d5305aac2f230b692977875cd/microsoft/TypeScript/issues/35205
og:image:altTypeScript Version: 3.8.0-dev.20191119 Also reproduceable in earlier versions. A quick scan through older versions shows TS 2.0 has a check time of 0.2s, which regressed to 1.9s in TS 2.1. Search T...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJoostK
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/35205#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F35205
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F35205
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/35205
Reloadhttps://github.com/microsoft/TypeScript/issues/35205
Reloadhttps://github.com/microsoft/TypeScript/issues/35205
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/35205
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/35205
#35332https://github.com/microsoft/TypeScript/pull/35332
perf: exponential slowdown due to type narrowing with enums / type unionshttps://github.com/microsoft/TypeScript/issues/35205#top
#35332https://github.com/microsoft/TypeScript/pull/35332
https://github.com/ahejlsberg
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
Fix AvailableA PR has been opened for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fix%20Available%22
TypeScript 3.8.0https://github.com/microsoft/TypeScript/milestone/102
https://github.com/JoostK
Joost Koehoorn (JoostK)https://github.com/JoostK
on Nov 19, 2019https://github.com/microsoft/TypeScript/issues/35205#issue-525233088
angular/angular#33532https://github.com/angular/angular/issues/33532
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
on Nov 22, 2019https://github.com/microsoft/TypeScript/issues/35205#event-2824693644
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Wesley Wigham (weswigham)https://github.com/weswigham
on Nov 22, 2019https://github.com/microsoft/TypeScript/issues/35205#event-2824693763
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
TypeScript 3.8.0https://github.com/microsoft/TypeScript/milestone/102
on Nov 22, 2019https://github.com/microsoft/TypeScript/issues/35205#event-2824693860
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Wesley Wigham (weswigham)https://github.com/weswigham
on Nov 25, 2019https://github.com/microsoft/TypeScript/issues/35205#event-2829315631
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#35332https://github.com/microsoft/TypeScript/pull/35332
on Nov 25, 2019https://github.com/microsoft/TypeScript/issues/35205#event-2829950612
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Fix AvailableA PR has been opened for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fix%20Available%22
on Nov 25, 2019https://github.com/microsoft/TypeScript/issues/35205#event-2829957083
microsofthttps://github.com/microsoft
on Oct 21, 2025https://github.com/microsoft/TypeScript/issues/35205#event-20416825168
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/35205
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/35205
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
Fix AvailableA PR has been opened for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fix%20Available%22
TypeScript 3.8.0https://github.com/microsoft/TypeScript/milestone/102
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.