René's URL Explorer Experiment


Title: TS Server: Return description of why a given refactoring cannot be applied · Issue #35098 · microsoft/TypeScript · GitHub

Open Graph Title: TS Server: Return description of why a given refactoring cannot be applied · Issue #35098 · microsoft/TypeScript

X Title: TS Server: Return description of why a given refactoring cannot be applied · Issue #35098 · microsoft/TypeScript

Description: Follow up on #34930 Search terms refactor / refactoring Problem In VS Code, I often try to extract something to a function only to discover that this is not possible for the my current selection. The current UX for this is poor, since we...

Open Graph Description: Follow up on #34930 Search terms refactor / refactoring Problem In VS Code, I often try to extract something to a function only to discover that this is not possible for the my current selection. T...

X Description: Follow up on #34930 Search terms refactor / refactoring Problem In VS Code, I often try to extract something to a function only to discover that this is not possible for the my current selection. T...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/35098

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"TS Server: Return description of why a given refactoring cannot be applied","articleBody":"Follow up on #34930\r\n\r\n**Search terms**\r\n- refactor / refactoring\r\n\r\n## Problem\r\nIn VS Code, I often try to extract something to a function only to discover that this is not possible for the my current selection. The current UX for this is poor, since we offer no explanation of why the selection is not extractable.\r\n\r\n## Proposal\r\nTo fix this, we would like to have TS Server return a human readable message about why a refactoring cannot be applied. Client could then surface this information to users\r\n\r\nWith this proposal, TS Server would no silently longer dropping invalid refactorings like it does today and instead always return them but with an additional error message attached..\r\n\r\n## Protocol proposal\r\nI believe this simplest approach is to add a new `errorDescription` field on `ApplicableRefactorInfo`:\r\n\r\n```ts\r\ninterface ApplicableRefactorInfo {\r\n    name: string;\r\n    description: string;\r\n    inlineable?: boolean;\r\n    actions: RefactorActionInfo[];\r\n\r\n    errorDescription?: string;\r\n}\r\n```\r\n\r\nClient would be expected to not to try to resolve invalid refactorings.\r\n\r\nTo implement this in a way that won't break existing clients, we also need a way for a client to express that they can handle these invalid refactorings:\r\n\r\n```ts\r\ninterface GetApplicableRefactorsRequestArgs extends FileLocationOrRangeRequestArgs {\r\n    // better name?\r\n    returnInvalidRefactorings?: boolean;\r\n}\r\n```\r\n\r\nIf `returnInvalidRefactorings` is not set, the TS Server should preserve its existing behavior, i.e. drop invalid refactorings\r\n\r\n","author":{"url":"https://github.com/mjbvz","@type":"Person","name":"mjbvz"},"datePublished":"2019-11-14T07:48:35Z","url":"https://github.com/microsoft/TypeScript/issues/35098"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:6d6e39a4-3166-b394-5d6b-419ade8c9e80
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9DA4:7A60E:96842B:C46245:6B00E1C8
html-safe-nonce3f35f1b41f83994253199ce14b040afc734c72f0c0d2592a0920ab98a821c558
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5REE0OjdBNjBFOjk2ODQyQjpDNDYyNDU6NkIwMEUxQzgiLCJ2aXNpdG9yX2lkIjoiNDYxMzA2MTE3NDI2MTUwNjUwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac51906fdeb55c329f98315aaa03bb1779c3aa6d332d7653d3e0bb27820898dc10
hovercard-subject-tagissue:522683482
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/35098/issue_layout
twitter:imagehttps://opengraph.githubassets.com/5cbb936b539b4588bd95e27d4b3434bee04282211cd6f475ccd2c8f572c1b0f6/microsoft/TypeScript/issues/35098
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5cbb936b539b4588bd95e27d4b3434bee04282211cd6f475ccd2c8f572c1b0f6/microsoft/TypeScript/issues/35098
og:image:altFollow up on #34930 Search terms refactor / refactoring Problem In VS Code, I often try to extract something to a function only to discover that this is not possible for the my current selection. T...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemjbvz
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/35098#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F35098
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F35098
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/35098
Reloadhttps://github.com/microsoft/TypeScript/issues/35098
Reloadhttps://github.com/microsoft/TypeScript/issues/35098
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/35098
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/35098
#37871https://github.com/microsoft/TypeScript/pull/37871
TS Server: Return description of why a given refactoring cannot be appliedhttps://github.com/microsoft/TypeScript/issues/35098#top
#37871https://github.com/microsoft/TypeScript/pull/37871
https://github.com/PranavSenthilnathan
https://github.com/minestarks
Domain: LS: Refactoringse.g. extract to constant or function, rename symbolhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20LS%3A%20Refactorings%22
Domain: LS: TSServerIssues related to the TSServerhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20LS%3A%20TSServer%22
In DiscussionNot yet reached consensushttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22In%20Discussion%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
TypeScript 4.0.0https://github.com/microsoft/TypeScript/milestone/114
https://github.com/mjbvz
Matt Bierner (mjbvz)https://github.com/mjbvz
on Nov 14, 2019https://github.com/microsoft/TypeScript/issues/35098#issue-522683482
#34930https://github.com/microsoft/TypeScript/issues/34930
https://github.com/amcasey
Andrew Casey (amcasey)https://github.com/amcasey
on Nov 15, 2019https://github.com/microsoft/TypeScript/issues/35098#issuecomment-554151789
https://github.com/amcasey
Andrew Casey (amcasey)https://github.com/amcasey
on Nov 15, 2019https://github.com/microsoft/TypeScript/issues/35098#issuecomment-554152043
https://github.com/mjbvz
Matt Bierner (mjbvz)https://github.com/mjbvz
on Nov 18, 2019https://github.com/microsoft/TypeScript/issues/35098#issuecomment-555182451
Andrew Casey (@amcasey)https://github.com/amcasey
TSServer: Refactor trigger reason #35096https://github.com/microsoft/TypeScript/issues/35096
https://github.com/mjbvz
Matt Bierner (mjbvz)https://github.com/mjbvz
on Nov 19, 2019https://github.com/microsoft/TypeScript/issues/35098#issuecomment-555758556
microsoft/vscode#85160https://github.com/microsoft/vscode/issues/85160
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Domain: LS: Refactoringse.g. extract to constant or function, rename symbolhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20LS%3A%20Refactorings%22
Domain: LS: TSServerIssues related to the TSServerhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20LS%3A%20TSServer%22
In DiscussionNot yet reached consensushttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22In%20Discussion%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
on Nov 19, 2019https://github.com/microsoft/TypeScript/issues/35098#event-2813354695
Matt Bierner (mjbvz)https://github.com/mjbvz
Mine Starks (minestarks)https://github.com/minestarks
on Feb 26, 2020https://github.com/microsoft/TypeScript/issues/35098#event-3075144964
Mine Starks (minestarks)https://github.com/minestarks
Pranav Senthilnathan (PranavSenthilnathan)https://github.com/PranavSenthilnathan
on Feb 27, 2020https://github.com/microsoft/TypeScript/issues/35098#event-3079739401
Mine Starks (minestarks)https://github.com/minestarks
TypeScript 4.0https://github.com/microsoft/TypeScript/milestone/114
on Mar 25, 2020https://github.com/microsoft/TypeScript/issues/35098#event-3165699176
Pranav Senthilnathan (PranavSenthilnathan)https://github.com/PranavSenthilnathan
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#37871https://github.com/microsoft/TypeScript/pull/37871
on Jun 22, 2020https://github.com/microsoft/TypeScript/issues/35098#event-3468876734
https://github.com/StingyJack
Andrew Stanton (StingyJack)https://github.com/StingyJack
on Jun 23, 2022https://github.com/microsoft/TypeScript/issues/35098#issuecomment-1163892395
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/35098
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/35098
Pranav Senthilnathan (PranavSenthilnathan)https://github.com/PranavSenthilnathan
Mine Starks (minestarks)https://github.com/minestarks
Domain: LS: Refactoringse.g. extract to constant or function, rename symbolhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20LS%3A%20Refactorings%22
Domain: LS: TSServerIssues related to the TSServerhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20LS%3A%20TSServer%22
In DiscussionNot yet reached consensushttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22In%20Discussion%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
TypeScript 4.0.0https://github.com/microsoft/TypeScript/milestone/114
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.