Title: Implementing interface puts relative imports · Issue #34995 · microsoft/TypeScript · GitHub
Open Graph Title: Implementing interface puts relative imports · Issue #34995 · microsoft/TypeScript
X Title: Implementing interface puts relative imports · Issue #34995 · microsoft/TypeScript
Description: TypeScript Version: 3.7.2 Code git clone https://github.com/microsoft/vscode.git yarn open VSCode on anythingQuickAccess.ts type in the top: class FooHandler implements IEditorGroup { } fix the error by letting it implement the interface...
Open Graph Description: TypeScript Version: 3.7.2 Code git clone https://github.com/microsoft/vscode.git yarn open VSCode on anythingQuickAccess.ts type in the top: class FooHandler implements IEditorGroup { } fix the err...
X Description: TypeScript Version: 3.7.2 Code git clone https://github.com/microsoft/vscode.git yarn open VSCode on anythingQuickAccess.ts type in the top: class FooHandler implements IEditorGroup { } fix the err...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/34995
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Implementing interface puts relative imports","articleBody":"**TypeScript Version:** `3.7.2`\r\n\r\n**Code**\r\n\r\n* `git clone https://github.com/microsoft/vscode.git`\r\n* `yarn`\r\n* open VSCode on `anythingQuickAccess.ts`\r\n* type in the top:\r\n\r\n```ts\r\nclass FooHandler implements IEditorGroup {\r\n\r\n}\r\n```\r\n\r\n* fix the error by letting it implement the interface\r\n\r\n**Expected behavior:**\r\nCode that gets generated does not use inline imports.\r\n\r\n**Actual behavior:**\r\nCode that gets generated adds inline imports:\r\n\r\n```ts\r\nclass FooHandler implements IEditorGroup {\r\n\tonDidGroupChange: Event\u003cIGroupChangeEvent>;\r\n\tonWillDispose: Event\u003cvoid>;\r\n\tid: number;\r\n\tindex: number;\r\n\tlabel: string;\r\n\tariaLabel: string;\r\n\tactiveEditorPane: import(\"../../../common/editor\").IVisibleEditorPane | undefined;\r\n\tactiveEditor: IEditorInput | null;\r\n\tpreviewEditor: IEditorInput | null;\r\n\tcount: number;\r\n\tstickyCount: number;\r\n\teditors: readonly IEditorInput[];\r\n\tgetEditors(order: EditorsOrder, options?: { excludeSticky?: boolean | undefined; } | undefined): readonly IEditorInput[] {\r\n\t\tthrow new Error('Method not implemented.');\r\n\t}\r\n\tgetEditorByIndex(index: number): IEditorInput | undefined {\r\n\t\tthrow new Error('Method not implemented.');\r\n\t}\r\n\tgetIndexOfEditor(editor: IEditorInput): number {\r\n\t\tthrow new Error('Method not implemented.');\r\n\t}\r\n\topenEditor(editor: IEditorInput, options?: import(\"../../../../platform/editor/common/editor\").IEditorOptions | ITextEditorOptions | undefined): Promise\u003cimport(\"../../../common/editor\").IEditorPane | null> {\r\n\t\tthrow new Error('Method not implemented.');\r\n\t}\r\n\topenEditors(editors: import(\"../../../common/editor\").IEditorInputWithOptions[]): Promise\u003cimport(\"../../../common/editor\").IEditorPane | null> {\r\n\t\tthrow new Error('Method not implemented.');\r\n\t}\r\n\tisOpened(editor: IEditorInput): boolean {\r\n\t\tthrow new Error('Method not implemented.');\r\n\t}\r\n\tisPinned(editor: IEditorInput): boolean {\r\n\t\tthrow new Error('Method not implemented.');\r\n\t}\r\n\tisSticky(editorOrIndex: number | IEditorInput): boolean {\r\n\t\tthrow new Error('Method not implemented.');\r\n\t}\r\n\tisActive(editor: IEditorInput): boolean {\r\n\t\tthrow new Error('Method not implemented.');\r\n\t}\r\n\tmoveEditor(editor: IEditorInput, target: IEditorGroup, options?: import(\"../../../services/editor/common/editorGroupsService\").IMoveEditorOptions | undefined): void {\r\n\t\tthrow new Error('Method not implemented.');\r\n\t}\r\n\tcopyEditor(editor: IEditorInput, target: IEditorGroup, options?: import(\"../../../services/editor/common/editorGroupsService\").ICopyEditorOptions | undefined): void {\r\n\t\tthrow new Error('Method not implemented.');\r\n\t}\r\n\tcloseEditor(editor?: IEditorInput | undefined, options?: import(\"../../../services/editor/common/editorGroupsService\").ICloseEditorOptions | undefined): Promise\u003cvoid> {\r\n\t\tthrow new Error('Method not implemented.');\r\n\t}\r\n\tcloseEditors(editors: IEditorInput[] | import(\"../../../services/editor/common/editorGroupsService\").ICloseEditorsFilter, options?: import(\"../../../services/editor/common/editorGroupsService\").ICloseEditorOptions | undefined): Promise\u003cvoid> {\r\n\t\tthrow new Error('Method not implemented.');\r\n\t}\r\n\tcloseAllEditors(options?: import(\"../../../services/editor/common/editorGroupsService\").ICloseAllEditorsOptions | undefined): Promise\u003cvoid> {\r\n\t\tthrow new Error('Method not implemented.');\r\n\t}\r\n\treplaceEditors(editors: import(\"../../../services/editor/common/editorGroupsService\").IEditorReplacement[]): Promise\u003cvoid> {\r\n\t\tthrow new Error('Method not implemented.');\r\n\t}\r\n\tpinEditor(editor?: IEditorInput | undefined): void {\r\n\t\tthrow new Error('Method not implemented.');\r\n\t}\r\n\tstickEditor(editor?: IEditorInput | undefined): void {\r\n\t\tthrow new Error('Method not implemented.');\r\n\t}\r\n\tunstickEditor(editor?: IEditorInput | undefined): void {\r\n\t\tthrow new Error('Method not implemented.');\r\n\t}\r\n\tfocus(): void {\r\n\t\tthrow new Error('Method not implemented.');\r\n\t}\r\n\tinvokeWithinContext\u003cT>(fn: (accessor: import(\"../../../../platform/instantiation/common/instantiation\").ServicesAccessor) => T): T {\r\n\t\tthrow new Error('Method not implemented.');\r\n\t}\r\n\r\n}\r\n```\r\n","author":{"url":"https://github.com/bpasero","@type":"Person","name":"bpasero"},"datePublished":"2019-11-08T15:22:35Z","url":"https://github.com/microsoft/TypeScript/issues/34995"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a213940c-af15-6d12-26c8-763302c2a4a1 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BAFC:DB09F:C2E93A:F9CC33:6B01003E |
| html-safe-nonce | 661f9483c99bcaa02c038823d0254e75c35a65461306d78c1039d2b370932569 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQUZDOkRCMDlGOkMyRTkzQTpGOUNDMzM6NkIwMTAwM0UiLCJ2aXNpdG9yX2lkIjoiMTU4MjcyODc2NjQzMjU0Mjc4MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 702887d154e2267b8ab2ecc5b79f101366b21583eec02f4c5bc19095d3282641 |
| hovercard-subject-tag | issue:520073735 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/34995/issue_layout |
| twitter:image | https://opengraph.githubassets.com/5cd67081546337f132ab7b27afc5d7fb81717326eafb9ab26dab9efd2212947f/microsoft/TypeScript/issues/34995 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5cd67081546337f132ab7b27afc5d7fb81717326eafb9ab26dab9efd2212947f/microsoft/TypeScript/issues/34995 |
| og:image:alt | TypeScript Version: 3.7.2 Code git clone https://github.com/microsoft/vscode.git yarn open VSCode on anythingQuickAccess.ts type in the top: class FooHandler implements IEditorGroup { } fix the err... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | bpasero |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width