René's URL Explorer Experiment


Title: Design Meeting Notes, 9/27/2019 · Issue #34573 · microsoft/TypeScript · GitHub

Open Graph Title: Design Meeting Notes, 9/27/2019 · Issue #34573 · microsoft/TypeScript

X Title: Design Meeting Notes, 9/27/2019 · Issue #34573 · microsoft/TypeScript

Description: Errors for Certain Asssertions and Never-Returning Functions #33622 We now need to do control flow analysis for statement-expression level calls. But resolving the expression that's being called (i.e. f in f(x, y, z)) can kick off more c...

Open Graph Description: Errors for Certain Asssertions and Never-Returning Functions #33622 We now need to do control flow analysis for statement-expression level calls. But resolving the expression that's being called (i...

X Description: Errors for Certain Asssertions and Never-Returning Functions #33622 We now need to do control flow analysis for statement-expression level calls. But resolving the expression that's being calle...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/34573

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Design Meeting Notes, 9/27/2019","articleBody":"# Errors for Certain Asssertions and Never-Returning Functions\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/33622\r\n\r\n* We now need to do control flow analysis for statement-expression level calls.\r\n* But resolving the expression that's being called (i.e. `f` in `f(x, y, z)`) can kick off more control-flow analysis.\r\n    * And that can cause a loop in the control flow graph, which we can't make sense of.\r\n* Instead of erroring on the call, why not call \r\n    * \\[\\[@weswigham fill this in]]\r\n* But this also forces you to add an explicit annotation for something like\r\n\r\n  ```ts\r\n  const tester: Tester = new Tester();\r\n  ```\r\n* The alternative is that we just \"let control flow analysis do its thing\" but that causes breaks in the compiler itself.\r\n    * This also means that we're hitting other issues which *don't* related\r\n* These declarations really should never be considered circularity errors but they are.\r\n    * But you can't know they're \"unrelated\" until you resolve them which could cause that circularity!\r\n* Maybe you kind of want to get the type of something as if control flow had never taken effect?\r\n    * Can you even do this?\r\n    * Also, would it be confusing to fall back back to a different type only some of the time here?\r\n* Discuss offline.\r\n* Do we need more time to figure this out?\r\n    * This seems like the minimal viable product that solves most of the use-cases.\r\n* Alternative PR which breaks existing code is not viable.\r\n* Resolution\r\n    * This is technically a breaking change - document it.\r\n    * This is a reasonable start - we can iterate on the implementation later.\r\n    * Seed a StackOverflow question because this is confusing.\r\n\r\n# Narrowing non-declared union types\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/30593\r\n\r\n* Basically the idea is that we only narrow when the type a variable is declared with (the \"declared type\") determines if we should narrow using discriminated unions.\r\n    * What is desired is that once something is narrowed to a discriminatable union type, we should correctly narrow on each discrimination.\r\n* What is the crux of the change?\r\n    * Currently tracks only the last union that's been encountered.\r\n    * Question is whether or not adding in a stack or \"limited-depth buffer\" is appropriate.\r\n* Conclusion: Need to actually give feedback on the implementation.\r\n\r\n# Improved Template String Support in Type-Checking\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/32064\r\n\r\n* Non-controversial.\r\n* Does this allow template literals for string literal types?\r\n    * Not currently.\r\n* Ship it!\r\n\r\n# ts-nocheck in TS files\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/33383\r\n\r\n* We support `ts-ignore` in both JS and TS files.\r\n* We support `ts-nocheck` in JS files, but not TS files!\r\n* Valuable for migration scenarios.\r\n* Do we offer suggestions to ts-ignore in TypeScript?\r\n    * Yes in JS files, no in TS files.\r\n* Does this play well with declaration file emit?\r\n    * The same is true of ts-ignore today.\r\n* Conclusion\r\n    * 3.7-bound","author":{"url":"https://github.com/DanielRosenwasser","@type":"Person","name":"DanielRosenwasser"},"datePublished":"2019-10-18T20:37:22Z","url":"https://github.com/microsoft/TypeScript/issues/34573"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:ec3f81e1-296b-8649-ee62-71dc7b4ab89c
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE036:117C62:BCE801:FD8593:6B00F85B
html-safe-nonced5299ad28d8a4a6159339a058da9be27e71d490277705579091cafcbda4f56ec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDM2OjExN0M2MjpCQ0U4MDE6RkQ4NTkzOjZCMDBGODVCIiwidmlzaXRvcl9pZCI6IjgxMTQ5NTcxNDk4Mjc4MjM3MDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaca12fb6bda4dfb076c3ca95b27d36182c1dcdb37589d9388f1adefd04ef926f1f
hovercard-subject-tagissue:509299187
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/34573/issue_layout
twitter:imagehttps://opengraph.githubassets.com/75ec67f99a4846f167e4e019fb18cd2d84a27995b9e33b32c8efce63200257b3/microsoft/TypeScript/issues/34573
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/75ec67f99a4846f167e4e019fb18cd2d84a27995b9e33b32c8efce63200257b3/microsoft/TypeScript/issues/34573
og:image:altErrors for Certain Asssertions and Never-Returning Functions #33622 We now need to do control flow analysis for statement-expression level calls. But resolving the expression that's being called (i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDanielRosenwasser
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/34573#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F34573
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F34573
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/34573
Reloadhttps://github.com/microsoft/TypeScript/issues/34573
Reloadhttps://github.com/microsoft/TypeScript/issues/34573
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/34573
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/34573
Design Meeting Notes, 9/27/2019https://github.com/microsoft/TypeScript/issues/34573#top
Design NotesNotes from our design meetingshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Notes%22
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
on Oct 18, 2019https://github.com/microsoft/TypeScript/issues/34573#issue-509299187
#33622https://github.com/microsoft/TypeScript/pull/33622
Wesley Wigham (@weswigham)https://github.com/weswigham
#30593https://github.com/microsoft/TypeScript/pull/30593
#32064https://github.com/microsoft/TypeScript/pull/32064
#33383https://github.com/microsoft/TypeScript/pull/33383
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Design NotesNotes from our design meetingshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Notes%22
on Oct 18, 2019https://github.com/microsoft/TypeScript/issues/34573#event-2726199066
https://github.com/IllusionMH
Andrii Dieiev (IllusionMH)https://github.com/IllusionMH
on Oct 25, 2019https://github.com/microsoft/TypeScript/issues/34573#issuecomment-546321364
TS 2.7 at leasthttps://www.typescriptlang.org/play/index.html?ts=2.7.2#code/DYUwLgBAhgXBAGB3A9gJwNYGcIEsB2EATAHQDs0eAJhMFGCKvANwCwAUO1BALwQDkiVMjwBzPqw5suvAWiy4CJclCo06DcUA
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Nov 19, 2019https://github.com/microsoft/TypeScript/issues/34573#event-2813120999
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/34573
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/34573
Design NotesNotes from our design meetingshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Notes%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.