René's URL Explorer Experiment


Title: Design Meeting Notes, 9/20/2019 · Issue #34572 · microsoft/TypeScript · GitHub

Open Graph Title: Design Meeting Notes, 9/20/2019 · Issue #34572 · microsoft/TypeScript

X Title: Design Meeting Notes, 9/20/2019 · Issue #34572 · microsoft/TypeScript

Description: Control Flow Updates Assertions in Control Flow #32695 Now it correctly reasons about exhaustive switch statements. We used to detect this only syntactically - if you have a switch as the last statement, we would remove undefined from th...

Open Graph Description: Control Flow Updates Assertions in Control Flow #32695 Now it correctly reasons about exhaustive switch statements. We used to detect this only syntactically - if you have a switch as the last stat...

X Description: Control Flow Updates Assertions in Control Flow #32695 Now it correctly reasons about exhaustive switch statements. We used to detect this only syntactically - if you have a switch as the last stat...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/34572

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Design Meeting Notes, 9/20/2019","articleBody":"# Control Flow Updates\r\n\r\n## Assertions in Control Flow\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/32695\r\n\r\n* Now it correctly reasons about exhaustive switch statements.\r\n    * We used to detect this only syntactically - if you have a `switch` as the last statement, we would remove `undefined` from the return type.\r\n    * But that wasn't sufficient. People kept complaining that it didn't catch specialized cases.\r\n    * Leveraging the general Control Flow Analysis (CFA) logic is really the best way to do this.\r\n    * This also means we can do well on exhaustive `if` statements.\r\n    * ```ts\r\n      function f44(x: \"a\" | \"b\") {\r\n          if (someCondition()) {\r\n              switch (x) {\r\n                  case \"a\": return 100;\r\n                  case \"b\": return 200;\r\n              }\r\n              // now considered unreachable,\r\n              // return type doesn't include 'undefined' anymore.\r\n              x;\r\n          }\r\n          throw \"oops\"\r\n      }\r\n      ```\r\n* Caveat: by adding this \"smarter\" logic, we consider code that's meant to be defensive against unchecked JS code to be \"unreachable\".\r\n    * ```ts\r\n      function f46(x: \"a\" | \"b\") {\r\n          switch (x) {\r\n              case \"a\": return 100;\r\n              case \"b\": return 200;\r\n          }\r\n          // now considered unreachable - but\r\n          // a JS user could've passed in \"c\"!\r\n          throw \"oops\"\r\n      }\r\n      ```\r\n    * The way to fix this is to add a `default` to the `switch`/statement.\r\n    * ```diff\r\n       function f46(x: \"a\" | \"b\") {\r\n           switch (x) {\r\n               case \"a\": return 100;\r\n               case \"b\": return 200;\r\n      +        default: // empty default\r\n           }\r\n           // now considered unreachable - but\r\n           // a JS user could've passed in \"c\"!\r\n           throw \"oops\"\r\n       }\r\n      ```\r\n* Does add about 2% overhead on the checker... are committed to optimizing it.\r\n\r\n## Improved Caching in CFA\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/33510\r\n\r\n* Wins back some perf.\r\n    * Reduces check time by 1-2% in larger project.\r\n* A while back, we added a class of caching for class of code that does thousands and thousands of assignments with arithmetic.\r\n    * If you need to re-evaluate the types at each assignment site, then this blows up the control flow graph and you have to traverse up the graph each time.\r\n    * So we added caching.\r\n* This change makes it so that we only cache when we hit re-entrancy because it's usually not necessary to begin with.\r\n* Does this mean that the lookup of every narrowed type gets invoked at least twice?\r\n    * *\\[thinks]* No?\r\n* Does this mean that we only cache every other node?\r\n    * Maybe. It sounds like that may or may not be the intended effect of the code.\r\n* Caching for control flow paths that precede loops.\r\n    * Also find a way to cache when re-entrancy before a loop.\r\n\r\n# Public Class Field Semantics Update\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/33509\r\n\r\n* Class fields might be changing to \\[\\[Define]] semantics.\r\n* This is different from what TypeScript does, and we're trying to mitigate issues for existing code.\r\n* In 3.6, we allowed ambient classes (classes with `declare` or in `.d.ts` files) to have accessors.\r\n    * Allows us to recognize that a property came from a getter/setter.\r\n* In 3.7:\r\n    * *Emit* accessors in `.d.ts` files.\r\n    * New syntax to say a property declaration has no emit.\r\n    * Provide a flag to emit \\[\\[Set]] semantics.\r\n        * `legacyClassFields` to opt in to old behavior.\r\n        * `true` by default in 3.7\r\n    * Error on overrides that would be problems with \\[\\[Define]].\r\n* What breaks?\r\n    * Disallow accessor/property overrides.\r\n        * Properties can only override properties.\r\n        * Accessors can only override accessors.\r\n        * Only exception is when the base declaration is abstract or comes from an interface.\r\n        * Should we provide a codefix for it?\r\n            * But it's not semantics-preserving.\r\n* Property overrides accessors\r\n    * Before\r\n      ```ts\r\n      class Base {\r\n          _p: unknown;\r\n          get p() {\r\n              return _p;\r\n          }\r\n          set p(v: unknown) {\r\n              this._p = v;\r\n          }\r\n      }\r\n      class Derived extends Base {\r\n          p = 10;\r\n      }\r\n      ```\r\n    * Before\r\n      ```ts\r\n      class Base {\r\n          _p: unknown;\r\n          get p() {\r\n              return _p;\r\n          }\r\n          set p(v: unknown) {\r\n              this._p = v;\r\n          }\r\n      }\r\n      class Derived extends Base {\r\n          declare p: number;\r\n          constructor() {\r\n              this.p = 10;\r\n          }\r\n      }\r\n      ```\r\n* Ran the changes on DefinitelyTyped, our test suites, asked Googlers to try it out.\r\n    * Property overrides accessor\r\n        * Angular 2 - looks like you can move to a constructor assignment.\r\n    * Accessor overrides property\r\n        * VS Code and Azure SDK ran into something here.\r\n* We could potentially remove some initialization code if we can determine there are no ways to \"witness\" the values.\r\n* Are we going to change our emit for methods to reflect enumerability?\r\n    * This feels like the only point we can change class members.\r\n* The emit here does feel bad.\r\n    * We have opinionated defaults for downlevel iteration.","author":{"url":"https://github.com/DanielRosenwasser","@type":"Person","name":"DanielRosenwasser"},"datePublished":"2019-10-18T20:36:32Z","url":"https://github.com/microsoft/TypeScript/issues/34572"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:10a8bacb-4207-4952-1296-701fac088980
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD9AA:2679E9:2159C25:2C7E049:6B018AF6
html-safe-nonce0c87ce5b2ce04d782a21d0eca0a2144e4d8588adb361254ecdf1dfd4154f8ea2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUFBOjI2NzlFOToyMTU5QzI1OjJDN0UwNDk6NkIwMThBRjYiLCJ2aXNpdG9yX2lkIjoiNTAyMTc5NTIzNzM4MzczNjA1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacbcc24090a1aef1dcca23795f4f80caa4d55ede6fcce8c5162292cce78a171cb5
hovercard-subject-tagissue:509298741
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/34572/issue_layout
twitter:imagehttps://opengraph.githubassets.com/33874545101d441fbc1108c11a286bb524858cd42155a7b6977e478f45c99fbf/microsoft/TypeScript/issues/34572
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/33874545101d441fbc1108c11a286bb524858cd42155a7b6977e478f45c99fbf/microsoft/TypeScript/issues/34572
og:image:altControl Flow Updates Assertions in Control Flow #32695 Now it correctly reasons about exhaustive switch statements. We used to detect this only syntactically - if you have a switch as the last stat...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDanielRosenwasser
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/34572#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F34572
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F34572
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/34572
Reloadhttps://github.com/microsoft/TypeScript/issues/34572
Reloadhttps://github.com/microsoft/TypeScript/issues/34572
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/34572
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/34572
Design Meeting Notes, 9/20/2019https://github.com/microsoft/TypeScript/issues/34572#top
Design NotesNotes from our design meetingshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Notes%22
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
on Oct 18, 2019https://github.com/microsoft/TypeScript/issues/34572#issue-509298741
#32695https://github.com/microsoft/TypeScript/pull/32695
#33510https://github.com/microsoft/TypeScript/pull/33510
#33509https://github.com/microsoft/TypeScript/pull/33509
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Design NotesNotes from our design meetingshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Notes%22
on Oct 18, 2019https://github.com/microsoft/TypeScript/issues/34572#event-2726176499
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Nov 19, 2019https://github.com/microsoft/TypeScript/issues/34572#event-2813120986
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/34572
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/34572
Design NotesNotes from our design meetingshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Notes%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.