Title: Design Meeting Notes, 9/20/2019 · Issue #34572 · microsoft/TypeScript · GitHub
Open Graph Title: Design Meeting Notes, 9/20/2019 · Issue #34572 · microsoft/TypeScript
X Title: Design Meeting Notes, 9/20/2019 · Issue #34572 · microsoft/TypeScript
Description: Control Flow Updates Assertions in Control Flow #32695 Now it correctly reasons about exhaustive switch statements. We used to detect this only syntactically - if you have a switch as the last statement, we would remove undefined from th...
Open Graph Description: Control Flow Updates Assertions in Control Flow #32695 Now it correctly reasons about exhaustive switch statements. We used to detect this only syntactically - if you have a switch as the last stat...
X Description: Control Flow Updates Assertions in Control Flow #32695 Now it correctly reasons about exhaustive switch statements. We used to detect this only syntactically - if you have a switch as the last stat...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/34572
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Design Meeting Notes, 9/20/2019","articleBody":"# Control Flow Updates\r\n\r\n## Assertions in Control Flow\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/32695\r\n\r\n* Now it correctly reasons about exhaustive switch statements.\r\n * We used to detect this only syntactically - if you have a `switch` as the last statement, we would remove `undefined` from the return type.\r\n * But that wasn't sufficient. People kept complaining that it didn't catch specialized cases.\r\n * Leveraging the general Control Flow Analysis (CFA) logic is really the best way to do this.\r\n * This also means we can do well on exhaustive `if` statements.\r\n * ```ts\r\n function f44(x: \"a\" | \"b\") {\r\n if (someCondition()) {\r\n switch (x) {\r\n case \"a\": return 100;\r\n case \"b\": return 200;\r\n }\r\n // now considered unreachable,\r\n // return type doesn't include 'undefined' anymore.\r\n x;\r\n }\r\n throw \"oops\"\r\n }\r\n ```\r\n* Caveat: by adding this \"smarter\" logic, we consider code that's meant to be defensive against unchecked JS code to be \"unreachable\".\r\n * ```ts\r\n function f46(x: \"a\" | \"b\") {\r\n switch (x) {\r\n case \"a\": return 100;\r\n case \"b\": return 200;\r\n }\r\n // now considered unreachable - but\r\n // a JS user could've passed in \"c\"!\r\n throw \"oops\"\r\n }\r\n ```\r\n * The way to fix this is to add a `default` to the `switch`/statement.\r\n * ```diff\r\n function f46(x: \"a\" | \"b\") {\r\n switch (x) {\r\n case \"a\": return 100;\r\n case \"b\": return 200;\r\n + default: // empty default\r\n }\r\n // now considered unreachable - but\r\n // a JS user could've passed in \"c\"!\r\n throw \"oops\"\r\n }\r\n ```\r\n* Does add about 2% overhead on the checker... are committed to optimizing it.\r\n\r\n## Improved Caching in CFA\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/33510\r\n\r\n* Wins back some perf.\r\n * Reduces check time by 1-2% in larger project.\r\n* A while back, we added a class of caching for class of code that does thousands and thousands of assignments with arithmetic.\r\n * If you need to re-evaluate the types at each assignment site, then this blows up the control flow graph and you have to traverse up the graph each time.\r\n * So we added caching.\r\n* This change makes it so that we only cache when we hit re-entrancy because it's usually not necessary to begin with.\r\n* Does this mean that the lookup of every narrowed type gets invoked at least twice?\r\n * *\\[thinks]* No?\r\n* Does this mean that we only cache every other node?\r\n * Maybe. It sounds like that may or may not be the intended effect of the code.\r\n* Caching for control flow paths that precede loops.\r\n * Also find a way to cache when re-entrancy before a loop.\r\n\r\n# Public Class Field Semantics Update\r\n\r\nhttps://github.com/microsoft/TypeScript/pull/33509\r\n\r\n* Class fields might be changing to \\[\\[Define]] semantics.\r\n* This is different from what TypeScript does, and we're trying to mitigate issues for existing code.\r\n* In 3.6, we allowed ambient classes (classes with `declare` or in `.d.ts` files) to have accessors.\r\n * Allows us to recognize that a property came from a getter/setter.\r\n* In 3.7:\r\n * *Emit* accessors in `.d.ts` files.\r\n * New syntax to say a property declaration has no emit.\r\n * Provide a flag to emit \\[\\[Set]] semantics.\r\n * `legacyClassFields` to opt in to old behavior.\r\n * `true` by default in 3.7\r\n * Error on overrides that would be problems with \\[\\[Define]].\r\n* What breaks?\r\n * Disallow accessor/property overrides.\r\n * Properties can only override properties.\r\n * Accessors can only override accessors.\r\n * Only exception is when the base declaration is abstract or comes from an interface.\r\n * Should we provide a codefix for it?\r\n * But it's not semantics-preserving.\r\n* Property overrides accessors\r\n * Before\r\n ```ts\r\n class Base {\r\n _p: unknown;\r\n get p() {\r\n return _p;\r\n }\r\n set p(v: unknown) {\r\n this._p = v;\r\n }\r\n }\r\n class Derived extends Base {\r\n p = 10;\r\n }\r\n ```\r\n * Before\r\n ```ts\r\n class Base {\r\n _p: unknown;\r\n get p() {\r\n return _p;\r\n }\r\n set p(v: unknown) {\r\n this._p = v;\r\n }\r\n }\r\n class Derived extends Base {\r\n declare p: number;\r\n constructor() {\r\n this.p = 10;\r\n }\r\n }\r\n ```\r\n* Ran the changes on DefinitelyTyped, our test suites, asked Googlers to try it out.\r\n * Property overrides accessor\r\n * Angular 2 - looks like you can move to a constructor assignment.\r\n * Accessor overrides property\r\n * VS Code and Azure SDK ran into something here.\r\n* We could potentially remove some initialization code if we can determine there are no ways to \"witness\" the values.\r\n* Are we going to change our emit for methods to reflect enumerability?\r\n * This feels like the only point we can change class members.\r\n* The emit here does feel bad.\r\n * We have opinionated defaults for downlevel iteration.","author":{"url":"https://github.com/DanielRosenwasser","@type":"Person","name":"DanielRosenwasser"},"datePublished":"2019-10-18T20:36:32Z","url":"https://github.com/microsoft/TypeScript/issues/34572"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:10a8bacb-4207-4952-1296-701fac088980 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D9AA:2679E9:2159C25:2C7E049:6B018AF6 |
| html-safe-nonce | 0c87ce5b2ce04d782a21d0eca0a2144e4d8588adb361254ecdf1dfd4154f8ea2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOUFBOjI2NzlFOToyMTU5QzI1OjJDN0UwNDk6NkIwMThBRjYiLCJ2aXNpdG9yX2lkIjoiNTAyMTc5NTIzNzM4MzczNjA1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | bcc24090a1aef1dcca23795f4f80caa4d55ede6fcce8c5162292cce78a171cb5 |
| hovercard-subject-tag | issue:509298741 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/34572/issue_layout |
| twitter:image | https://opengraph.githubassets.com/33874545101d441fbc1108c11a286bb524858cd42155a7b6977e478f45c99fbf/microsoft/TypeScript/issues/34572 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/33874545101d441fbc1108c11a286bb524858cd42155a7b6977e478f45c99fbf/microsoft/TypeScript/issues/34572 |
| og:image:alt | Control Flow Updates Assertions in Control Flow #32695 Now it correctly reasons about exhaustive switch statements. We used to detect this only syntactically - if you have a switch as the last stat... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | DanielRosenwasser |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width