René's URL Explorer Experiment


Title: Issues working with Generic Constraints · Issue #34567 · microsoft/TypeScript · GitHub

Open Graph Title: Issues working with Generic Constraints · Issue #34567 · microsoft/TypeScript

X Title: Issues working with Generic Constraints · Issue #34567 · microsoft/TypeScript

Description: TypeScript Version: 3.6.4 Search Terms: generic, generics, constraints Context Hello Typescript team! I've been working on updating my team's typescript codebase from v 3.2.1 to v 3.6.4 I'm having some issues updating my codebase to supp...

Open Graph Description: TypeScript Version: 3.6.4 Search Terms: generic, generics, constraints Context Hello Typescript team! I've been working on updating my team's typescript codebase from v 3.2.1 to v 3.6.4 I'm having ...

X Description: TypeScript Version: 3.6.4 Search Terms: generic, generics, constraints Context Hello Typescript team! I've been working on updating my team's typescript codebase from v 3.2.1 to v 3.6.4 I&#...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/34567

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Issues working with Generic Constraints","articleBody":"**TypeScript Version:**  3.6.4\r\n\r\n**Search Terms:**\r\ngeneric, generics, constraints\r\n\r\n**Context**\r\nHello Typescript team!\r\n\r\nI've been working on updating my team's typescript codebase from v 3.2.1 to v 3.6.4\r\n\r\nI'm having some issues updating my codebase to support the breaking changes, and wanted to start a discussion to see if what I'm coming across is by design, and if so, what is the recommended solution for working through it.\r\n\r\nBelow I'll create a simplified example of the issue we're having, and I've verified that the issue only appears after and including Typescript 3.5.  I believe the issue may be related to [this](https://github.com/Microsoft/TypeScript/pull/30637)\r\n\r\n**Code**\r\n\r\n```ts\r\ninterface StoreParams {\r\n  key1: string;\r\n  key2: number;\r\n  key3: string[];\r\n}\r\n\r\nfunction get\u003cKey extends keyof StoreParams>(key: Key): StoreParams[Key] | null {\r\n  const key1Return: string = 'key1Return';\r\n  const key2Return: number = 2;\r\n  const key3Return: string[] = ['a', 'b', 'c'];\r\n\r\n  if (key === 'key1') {\r\n    return key1Return;\r\n  }\r\n\r\n  if (key === 'key2') {\r\n    return key2Return;\r\n  }\r\n\r\n  if (key === 'key3') {\r\n    return key3Return;\r\n  }\r\n\r\n  return null;\r\n}\r\n```\r\n\r\n**Expected behavior:**\r\nNo compiler errors\r\n\r\n**Actual behavior:**\r\nThe above code results in an error in each of the key return statements, respectively they are:\r\n\r\n```\r\nType 'string' is not assignable to type 'StoreParams[Key] | null'.\r\n```\r\n\r\n```\r\nType 'number' is not assignable to type 'StoreParams[Key] | null'.\r\n```\r\n\r\n```\r\nType 'string[]' is not assignable to type 'StoreParams[Key]'.\r\n  Type 'string[]' is not assignable to type 'never'.\r\n```\r\n\r\nIt seems in each of the return statements, the return type is still `StoreParams[Key] | null`, where `Key` has not been filtered down after the `if` statement which normally acts as a type guard for `key`.\r\n\r\nIf I replace the generic `Key` with just `keyof StoreParams`, the type guards seem to work on `key`, but I've lost the benefit of the generic in that I'm still just returning `StoreParams[keyof StoreParams]`, meaning in each of the return statements I can return `string | number | string[] | null`.\r\n\r\n**Playground Link:** [Link here](http://www.typescriptlang.org/play/?ssl=16&ssc=10&pln=1&pc=1#code/JYOwLgpgTgZghgYwgAgMpgPZQgBTlOAWwGdkBvAKGWQGsIBPARgC5liwpQBzAbitoYAmViACuhAEbQ+1OvQDMrdpxBcA2gF0+AXwoUYokAjDAMIZFwhgAPAGkGyCAA9IIACak5GGGkzY8BCQAfAAUcqz29ACUrOhYuPhExGqRGsgAPshiADbZ5PwIZuwCTABKVqJQIEoc3MgAvMgA5HKM5WCVIE0yyIUgxXKC7Z0i4lJQDciCPX0DDPLDVTUq6mmNak1wTQA0zRI7zQhNWnrUwD5hDvXXza1NUfnU1NgdVSVtFVU9uvznyJf0Bo3FpCe6PJ4vTolIafEDfU7IP4AoGNEEKMGUJ7ISFvOQLWHw-g48w5bI6IA)\r\n\r\n**Related Issues:**\r\n","author":{"url":"https://github.com/Dsan10s","@type":"Person","name":"Dsan10s"},"datePublished":"2019-10-18T17:22:26Z","url":"https://github.com/microsoft/TypeScript/issues/34567"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:61addae4-04de-9d0f-8cf3-bf36af85879d
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB7AE:6FAD8:9D09AE:CC0CCD:6B00E18D
html-safe-nonce12ed90f66840556f234247455debe92d669d0ab47fa9aabcfb3f7044dbe93480
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0FFOjZGQUQ4OjlEMDlBRTpDQzBDQ0Q6NkIwMEUxOEQiLCJ2aXNpdG9yX2lkIjoiMzk4NjQwNDEyNTU1NzQ0OTEwMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac05beac1103a06e93b4783420b0e1f96600179d6f062b8a9695ce4c06fdf45ae0
hovercard-subject-tagissue:509214728
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/34567/issue_layout
twitter:imagehttps://opengraph.githubassets.com/c30a0a1deb340bfe2649f9014776d5634d1092130f162688f20d61866a8a80de/microsoft/TypeScript/issues/34567
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c30a0a1deb340bfe2649f9014776d5634d1092130f162688f20d61866a8a80de/microsoft/TypeScript/issues/34567
og:image:altTypeScript Version: 3.6.4 Search Terms: generic, generics, constraints Context Hello Typescript team! I've been working on updating my team's typescript codebase from v 3.2.1 to v 3.6.4 I'm having ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDsan10s
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/34567#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F34567
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F34567
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/34567
Reloadhttps://github.com/microsoft/TypeScript/issues/34567
Reloadhttps://github.com/microsoft/TypeScript/issues/34567
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/34567
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/34567
Issues working with Generic Constraintshttps://github.com/microsoft/TypeScript/issues/34567#top
Design LimitationConstraints of the existing architecture prevent this from being fixedhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Limitation%22
https://github.com/Dsan10s
Danny Sanchez (Dsan10s)https://github.com/Dsan10s
on Oct 18, 2019https://github.com/microsoft/TypeScript/issues/34567#issue-509214728
thishttps://github.com/Microsoft/TypeScript/pull/30637
Link herehttp://www.typescriptlang.org/play/?ssl=16&ssc=10&pln=1&pc=1#code/JYOwLgpgTgZghgYwgAgMpgPZQgBTlOAWwGdkBvAKGWQGsIBPARgC5liwpQBzAbitoYAmViACuhAEbQ+1OvQDMrdpxBcA2gF0+AXwoUYokAjDAMIZFwhgAPAGkGyCAA9IIACak5GGGkzY8BCQAfAAUcqz29ACUrOhYuPhExGqRGsgAPshiADbZ5PwIZuwCTABKVqJQIEoc3MgAvMgA5HKM5WCVIE0yyIUgxXKC7Z0i4lJQDciCPX0DDPLDVTUq6mmNak1wTQA0zRI7zQhNWnrUwD5hDvXXza1NUfnU1NgdVSVtFVU9uvznyJf0Bo3FpCe6PJ4vTolIafEDfU7IP4AoGNEEKMGUJ7ISFvOQLWHw-g48w5bI6IA
https://github.com/jack-williams
Jack Williams (jack-williams)https://github.com/jack-williams
on Oct 18, 2019https://github.com/microsoft/TypeScript/issues/34567#issuecomment-543927279
#33014https://github.com/microsoft/TypeScript/issues/33014
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Design LimitationConstraints of the existing architecture prevent this from being fixedhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Limitation%22
on Oct 30, 2019https://github.com/microsoft/TypeScript/issues/34567#event-2757821266
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on Oct 30, 2019https://github.com/microsoft/TypeScript/issues/34567#issuecomment-548134196
#33014https://github.com/microsoft/TypeScript/issues/33014
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jun 1, 2021https://github.com/microsoft/TypeScript/issues/34567#event-4828177126
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/34567
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/34567
Design LimitationConstraints of the existing architecture prevent this from being fixedhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Limitation%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.