Title: Type discrimination in function calls for callable types doesn't work if discriminating property is optional · Issue #34529 · microsoft/TypeScript · GitHub
Open Graph Title: Type discrimination in function calls for callable types doesn't work if discriminating property is optional · Issue #34529 · microsoft/TypeScript
X Title: Type discrimination in function calls for callable types doesn't work if discriminating property is optional · Issue #34529 · microsoft/TypeScript
Description: TypeScript Version: 3.7.0-dev.20191015 Search Terms: type discrimination, callable, signatures, implicit any Code function test( a: | { type?: 1; property: (a: number) => void } | { type: 2; property: (a: string) => void }, ) { return a....
Open Graph Description: TypeScript Version: 3.7.0-dev.20191015 Search Terms: type discrimination, callable, signatures, implicit any Code function test( a: | { type?: 1; property: (a: number) => void } | { type: 2; proper...
X Description: TypeScript Version: 3.7.0-dev.20191015 Search Terms: type discrimination, callable, signatures, implicit any Code function test( a: | { type?: 1; property: (a: number) => void } | { type: 2; pro...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/34529
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Type discrimination in function calls for callable types doesn't work if discriminating property is optional","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** 3.7.0-dev.20191015\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** type discrimination, callable, signatures, implicit any\r\n\r\n**Code**\r\n\r\n```ts\r\nfunction test(\r\n a:\r\n | { type?: 1; property: (a: number) => void }\r\n | { type: 2; property: (a: string) => void },\r\n) {\r\n return a.property\r\n}\r\n\r\n\r\ntest({\r\n property: (x) => { // complaining that x implicitly has type any\r\n console.log('hi')\r\n },\r\n})\r\n```\r\n\r\n**Expected behavior:**\r\n\r\n`x` should be inferred to be `number`.\r\n\r\n**Actual behavior:**\r\n\r\n`x` is `any`.\r\n\r\nIf you change `type?: 1` to `type: 1`, it works as expected.\r\n\r\n**Playground Link:** [link](http://www.typescriptlang.org/play/index.html#code/GYVwdgxgLglg9mABFApgZygCgFCMQQwC5c9EAfRAb2QE8AHFAfkMQEYBuROgJzge6g0WmIojAgAtgCMU3AJSIAvAD5EANzgwAJogC+JPBWqCGLAEycefWYOGiM3GGADmCles07dAGmwLKJNwoUCDcSPgAdFb8gtj62NioGJgBeNE2QoiYAB5uqtQA9AWIEHASdAA2+E5OzsgAFvhQiNmIMOUVMBAwUBU0iI1otAwEYDQGJQhocBUoERVwzpgA5PUwy3IkPnFyQA)\r\n\r\n**Related Issues:** #7294 (closed with #29011 - see second half of the original post, I believe it describes why this issue occurs)\r\n","author":{"url":"https://github.com/connorjclark","@type":"Person","name":"connorjclark"},"datePublished":"2019-10-17T02:38:27Z","url":"https://github.com/microsoft/TypeScript/issues/34529"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:526033eb-46a1-ebc6-3c0f-060615d4e82e |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8D1A:29FFA9:61B2CB:7D9B02:6B00DE2F |
| html-safe-nonce | d14a4f508e29cd0aeb45d7e8cd03fe2679f8bd5ae32672dfada5ca714f8594d6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDFBOjI5RkZBOTo2MUIyQ0I6N0Q5QjAyOjZCMDBERTJGIiwidmlzaXRvcl9pZCI6Ijc3OTc2NjExMTUwNzYzNjk5NjciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f84bdde7fc23f68d84db90aa414182f3a62c7bd2fda9058769e44ac846cb1b54 |
| hovercard-subject-tag | issue:508197297 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/34529/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c45f2973b471f62971574aec13d00f250ff4243a5b2caa4ebdd2c6ac12a8562e/microsoft/TypeScript/issues/34529 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c45f2973b471f62971574aec13d00f250ff4243a5b2caa4ebdd2c6ac12a8562e/microsoft/TypeScript/issues/34529 |
| og:image:alt | TypeScript Version: 3.7.0-dev.20191015 Search Terms: type discrimination, callable, signatures, implicit any Code function test( a: | { type?: 1; property: (a: number) => void } | { type: 2; proper... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | connorjclark |
| hostname | github.com |
| expected-hostname | github.com |
| None | 043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5425dc24e8bd8d6fca9641a12afc984825a43875 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width