Title: [3.7.0-beta] Child class cannot override base member function with arrow function · Issue #33855 · microsoft/TypeScript · GitHub
Open Graph Title: [3.7.0-beta] Child class cannot override base member function with arrow function · Issue #33855 · microsoft/TypeScript
X Title: [3.7.0-beta] Child class cannot override base member function with arrow function · Issue #33855 · microsoft/TypeScript
Description: TypeScript Version: 3.7.0-dev.20190927 (works on 3.7.0-dev.20190926) Search Terms: TS2424, member function Code class BaseClass { foo() { return null; } } class ChildClass extends BaseClass { foo = () => null; } Expected behavior: In 3.6...
Open Graph Description: TypeScript Version: 3.7.0-dev.20190927 (works on 3.7.0-dev.20190926) Search Terms: TS2424, member function Code class BaseClass { foo() { return null; } } class ChildClass extends BaseClass { foo =...
X Description: TypeScript Version: 3.7.0-dev.20190927 (works on 3.7.0-dev.20190926) Search Terms: TS2424, member function Code class BaseClass { foo() { return null; } } class ChildClass extends BaseClass { foo =...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/33855
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[3.7.0-beta] Child class cannot override base member function with arrow function","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** 3.7.0-dev.20190927 (works on 3.7.0-dev.20190926)\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:**\r\nTS2424, member function\r\n\r\n**Code**\r\n\r\n```ts\r\nclass BaseClass {\r\n foo() {\r\n return null;\r\n }\r\n}\r\n\r\nclass ChildClass extends BaseClass {\r\n foo = () => null;\r\n}\r\n```\r\n\r\n**Expected behavior:**\r\nIn 3.6.3 and \u003c=3.7.0-dev.20190926, this code would compile without error\r\n\r\n**Actual behavior:**\r\n```\r\nerror TS2424: Class 'BaseClass' defines instance member function 'foo', but extended class 'ChildClass' defines it as instance member property.\r\n\r\n8 foo = () => null;\r\n ~~~\r\n```\r\n\r\nSince our code has to compile down to ES5 (to support IE11), we need to perform some sort of method binding on methods that reference `this`. With this change, it means we would need to make *all* possibly-overridable member functions arrow functions\r\n\r\n\r\n**Playground Link:** http://www.typescriptlang.org/play/index.html?ts=3.7-Beta#code/MYGwhgzhAEBCkFMDC4rQN4Cho+gMwHsCAKASg21yoCcEAXAV2oDtpmGQQBuSnAX0wDMoSDCQALAJYgAJilHQEADzoJmMmPAjJUMLFUIFoAXmhkTAPjYdugoA\r\n\r\n**Related Issues:** \u003c!-- Did you find other bugs that looked similar? -->\r\n","author":{"url":"https://github.com/MLoughry","@type":"Person","name":"MLoughry"},"datePublished":"2019-10-07T17:52:23Z","url":"https://github.com/microsoft/TypeScript/issues/33855"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:aeeff618-fc9b-7a16-464b-bb001202fc9c |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B01C:10531B:1B17AB4:22A645E:6B0197B4 |
| html-safe-nonce | 8b9b8969dfe73562f4a3d7c5dabd29733c29ab51f6d99e6f86794d4d37b810fb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDFDOjEwNTMxQjoxQjE3QUI0OjIyQTY0NUU6NkIwMTk3QjQiLCJ2aXNpdG9yX2lkIjoiMzg3ODUwNTU1MzQyMDQ1NzkwOCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 05d9855a74879da98031cf2cb03b5eb1ac1c417f710c00babe76ba24f5992970 |
| hovercard-subject-tag | issue:503599334 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/33855/issue_layout |
| twitter:image | https://opengraph.githubassets.com/bed5463988c4b8fe0b1f87ae511a1b53be6feb43037c010e7e64e34450003d79/microsoft/TypeScript/issues/33855 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bed5463988c4b8fe0b1f87ae511a1b53be6feb43037c010e7e64e34450003d79/microsoft/TypeScript/issues/33855 |
| og:image:alt | TypeScript Version: 3.7.0-dev.20190927 (works on 3.7.0-dev.20190926) Search Terms: TS2424, member function Code class BaseClass { foo() { return null; } } class ChildClass extends BaseClass { foo =... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MLoughry |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width