Title: VSCode - generate accessors fixup on readonly field removes modifier · Issue #33836 · microsoft/TypeScript · GitHub
Open Graph Title: VSCode - generate accessors fixup on readonly field removes modifier · Issue #33836 · microsoft/TypeScript
X Title: VSCode - generate accessors fixup on readonly field removes modifier · Issue #33836 · microsoft/TypeScript
Description: TypeScript Version: 3.6.2 Search Terms: VSCode generate accessors Logged issue with VSCode repo, but they asked my to create an issue "upstream" microsoft/vscode#81135 Steps to Reproduce: Create private field with readonly modifier Highl...
Open Graph Description: TypeScript Version: 3.6.2 Search Terms: VSCode generate accessors Logged issue with VSCode repo, but they asked my to create an issue "upstream" microsoft/vscode#81135 Steps to Reproduce: Create pr...
X Description: TypeScript Version: 3.6.2 Search Terms: VSCode generate accessors Logged issue with VSCode repo, but they asked my to create an issue "upstream" microsoft/vscode#81135 Steps to Reproduce:...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/33836
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"VSCode - generate accessors fixup on readonly field removes modifier","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** 3.6.2\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** VSCode generate accessors\r\n\r\nLogged issue with VSCode repo, but they asked my to create an issue \"upstream\"\r\nhttps://github.com/microsoft/vscode/issues/81135\r\n\r\nSteps to Reproduce:\r\n\r\n1. Create private field with readonly modifier\r\n2. Highlight line and generate accessors\r\n3. get property created without set property ( correct ), but readonly modifier removed from field\r\n\r\n**Code**\r\n\r\n```ts\r\n// before\r\nclass MyClass {\r\n\r\n private readonly _myField: number;\r\n\r\n}\r\n\r\n\r\n// after\r\nclass MyClass {\r\n\r\n private _myField: number;\r\n\r\n public get myField() {\r\n return this._myField;\r\n }\r\n}\r\n```\r\n\r\n**Expected behavior:**\r\n\r\n``readonly`` modifier should remain on private field.\r\nGET accessor created\r\nSET accessor NOT created\r\n\r\n**Actual behavior:**\r\n\r\n``readonly`` modifier is removed.\r\nGET accessor created\r\nSET accessor NOT created\r\n\r\n**Playground Link:** \u003c!-- A link to a TypeScript Playground \"Share\" link which demonstrates this behavior -->\r\n\r\n**Related Issues:** \u003c!-- Did you find other bugs that looked similar? -->\r\n","author":{"url":"https://github.com/slaneyrw","@type":"Person","name":"slaneyrw"},"datePublished":"2019-10-07T00:08:16Z","url":"https://github.com/microsoft/TypeScript/issues/33836"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:f3afe226-5312-cb44-b91e-ee7c2d257617 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8300:DA744:AFD149:ED326A:6B00F664 |
| html-safe-nonce | ccba3d6c741539c3feba1ddf6aa0b236d60a8b3646ac063e9d41ee4a2931fee4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzAwOkRBNzQ0OkFGRDE0OTpFRDMyNkE6NkIwMEY2NjQiLCJ2aXNpdG9yX2lkIjoiMTM0MzUzNTk1NzY3ODI0MzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ccfa48a8b1a5fd2bfa7b75814d4ed92921eb20eb4dff4ca77e3dd71e5acbd740 |
| hovercard-subject-tag | issue:503180876 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/33836/issue_layout |
| twitter:image | https://opengraph.githubassets.com/f7d6649d2449f036444c7b7cf168243d835bbf96b4ba2fe56ac1d35eeee12409/microsoft/TypeScript/issues/33836 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f7d6649d2449f036444c7b7cf168243d835bbf96b4ba2fe56ac1d35eeee12409/microsoft/TypeScript/issues/33836 |
| og:image:alt | TypeScript Version: 3.6.2 Search Terms: VSCode generate accessors Logged issue with VSCode repo, but they asked my to create an issue "upstream" microsoft/vscode#81135 Steps to Reproduce: Create pr... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | slaneyrw |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width