René's URL Explorer Experiment


Title: Improve semicolon detection experience for new files · Issue #32831 · microsoft/TypeScript · GitHub

Open Graph Title: Improve semicolon detection experience for new files · Issue #32831 · microsoft/TypeScript

X Title: Improve semicolon detection experience for new files · Issue #32831 · microsoft/TypeScript

Description: TypeScript Version: 3.6.0-dev.20190810 Search Terms: semicolon format auto import Repo For a very simple project: tsconfig.json { "compilerOptions": { "module": "commonjs", "target": "es2016", "jsx": "preserve" }, "exclude": [ "node_modu...

Open Graph Description: TypeScript Version: 3.6.0-dev.20190810 Search Terms: semicolon format auto import Repo For a very simple project: tsconfig.json { "compilerOptions": { "module": "commonjs", "target": "es2016", "jsx...

X Description: TypeScript Version: 3.6.0-dev.20190810 Search Terms: semicolon format auto import Repo For a very simple project: tsconfig.json { "compilerOptions": { "module": "commonjs&q...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/32831

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Improve semicolon detection experience for new files","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:**  3.6.0-dev.20190810\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:**\r\n- semicolon\r\n- format\r\n- auto import\r\n\r\n**Repo**\r\n\r\nFor a very simple project:\r\n\r\n`tsconfig.json`\r\n```json\r\n{\r\n    \"compilerOptions\": {\r\n        \"module\": \"commonjs\",\r\n        \"target\": \"es2016\",\r\n        \"jsx\": \"preserve\"\r\n    },\r\n    \"exclude\": [\r\n        \"node_modules\",\r\n    ]\r\n}\r\n```\r\n\r\n`constants.ts`\r\n```ts\r\nexport const a = 1\r\nexport const b = 1\r\nexport const c = 1\r\nexport const d = 1\r\nexport const e = 1\r\nexport const f = 1\r\n```\r\n\r\n`main.ts`\r\n```ts\r\nconsole.log(a)\r\n```\r\n\r\n1. Trigger auto import quick fix in `main.ts` on `a`\r\n\r\n**Expected behavior:**\r\nSince `constants.js` does not use semicolons, the import should not have a semi colon\r\n\r\n**Actual behavior:**\r\nThe added import has a semi colon\r\n\r\nI believe this is because the current semicolon detection logic (#31801) requires some number of examples in the current file to learn from. For new files, this means we always default to using semicolons even if the rest of the project is semicolonless\r\n\r\nI can understand why we do this, but as a user I found it frustrating that TS would still insert semicolons until I added a certain number of imports (or other statements that are also used by the detection code). I don't know if looking at the rest of your project code is feasible or not for semicolon detection but we should discuss if we can improve the experience for new files\r\n\r\n/cc @andrewbranch \r\n\r\n**Related Issues:** \u003c!-- Did you find other bugs that looked similar? -->\r\n- #19882","author":{"url":"https://github.com/mjbvz","@type":"Person","name":"mjbvz"},"datePublished":"2019-08-12T23:19:14Z","url":"https://github.com/microsoft/TypeScript/issues/32831"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:6854c88f-b345-2c41-6209-1909f5e9555d
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id99B2:8AE25:4CD052:65AE4C:6B019C58
html-safe-nonce31ef35594d5f3d3a94b6ac73c73ff6ea951b7bbd9302465b109197159fe0725d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OUIyOjhBRTI1OjRDRDA1Mjo2NUFFNEM6NkIwMTlDNTgiLCJ2aXNpdG9yX2lkIjoiNTk1MTY5NTg1MzU2NjY2Mzc2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc200125b697b9647aa8dc1c0b97a57609ea15916fae55245286baeb75e1ebd2c
hovercard-subject-tagissue:479891234
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/32831/issue_layout
twitter:imagehttps://opengraph.githubassets.com/5c62aa94041f19a9512568afa0cedb1ba6afcef84b53e818cce1e7fc28cbd9cc/microsoft/TypeScript/issues/32831
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5c62aa94041f19a9512568afa0cedb1ba6afcef84b53e818cce1e7fc28cbd9cc/microsoft/TypeScript/issues/32831
og:image:altTypeScript Version: 3.6.0-dev.20190810 Search Terms: semicolon format auto import Repo For a very simple project: tsconfig.json { "compilerOptions": { "module": "commonjs", "target": "es2016", "jsx...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemjbvz
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/32831#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F32831
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F32831
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/32831
Reloadhttps://github.com/microsoft/TypeScript/issues/32831
Reloadhttps://github.com/microsoft/TypeScript/issues/32831
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/32831
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/32831
#33402https://github.com/microsoft/TypeScript/pull/33402
Improve semicolon detection experience for new fileshttps://github.com/microsoft/TypeScript/issues/32831#top
#33402https://github.com/microsoft/TypeScript/pull/33402
https://github.com/andrewbranch
Experience EnhancementNoncontroversial enhancementshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Experience%20Enhancement%22
Fix AvailableA PR has been opened for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fix%20Available%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
TypeScript 3.7.0https://github.com/microsoft/TypeScript/milestone/98
https://github.com/mjbvz
Matt Bierner (mjbvz)https://github.com/mjbvz
on Aug 12, 2019https://github.com/microsoft/TypeScript/issues/32831#issue-479891234
#31801https://github.com/microsoft/TypeScript/pull/31801
Andrew Branch (@andrewbranch)https://github.com/andrewbranch
autoimport should care about semicolons #19882https://github.com/microsoft/TypeScript/issues/19882
https://github.com/mjbvz
Matt Bierner (mjbvz)https://github.com/mjbvz
on Aug 15, 2019https://github.com/microsoft/TypeScript/issues/32831#issuecomment-521748302
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Andrew Branch (andrewbranch)https://github.com/andrewbranch
on Aug 16, 2019https://github.com/microsoft/TypeScript/issues/32831#event-2563279452
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Experience EnhancementNoncontroversial enhancementshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Experience%20Enhancement%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
on Aug 16, 2019https://github.com/microsoft/TypeScript/issues/32831#event-2563282141
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
TypeScript 3.7.0https://github.com/microsoft/TypeScript/milestone/98
on Aug 16, 2019https://github.com/microsoft/TypeScript/issues/32831#event-2563282225
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Fix AvailableA PR has been opened for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fix%20Available%22
on Sep 16, 2019https://github.com/microsoft/TypeScript/issues/32831#event-2637378989
Andrew Branch (andrewbranch)https://github.com/andrewbranch
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#33402https://github.com/microsoft/TypeScript/pull/33402
on Sep 26, 2019https://github.com/microsoft/TypeScript/issues/32831#event-2666589507
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/32831
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/32831
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Experience EnhancementNoncontroversial enhancementshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Experience%20Enhancement%22
Fix AvailableA PR has been opened for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fix%20Available%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
TypeScript 3.7.0https://github.com/microsoft/TypeScript/milestone/98
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.