Title: Improve semicolon detection experience for new files · Issue #32831 · microsoft/TypeScript · GitHub
Open Graph Title: Improve semicolon detection experience for new files · Issue #32831 · microsoft/TypeScript
X Title: Improve semicolon detection experience for new files · Issue #32831 · microsoft/TypeScript
Description: TypeScript Version: 3.6.0-dev.20190810 Search Terms: semicolon format auto import Repo For a very simple project: tsconfig.json { "compilerOptions": { "module": "commonjs", "target": "es2016", "jsx": "preserve" }, "exclude": [ "node_modu...
Open Graph Description: TypeScript Version: 3.6.0-dev.20190810 Search Terms: semicolon format auto import Repo For a very simple project: tsconfig.json { "compilerOptions": { "module": "commonjs", "target": "es2016", "jsx...
X Description: TypeScript Version: 3.6.0-dev.20190810 Search Terms: semicolon format auto import Repo For a very simple project: tsconfig.json { "compilerOptions": { "module": "commonjs&q...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/32831
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Improve semicolon detection experience for new files","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** 3.6.0-dev.20190810\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:**\r\n- semicolon\r\n- format\r\n- auto import\r\n\r\n**Repo**\r\n\r\nFor a very simple project:\r\n\r\n`tsconfig.json`\r\n```json\r\n{\r\n \"compilerOptions\": {\r\n \"module\": \"commonjs\",\r\n \"target\": \"es2016\",\r\n \"jsx\": \"preserve\"\r\n },\r\n \"exclude\": [\r\n \"node_modules\",\r\n ]\r\n}\r\n```\r\n\r\n`constants.ts`\r\n```ts\r\nexport const a = 1\r\nexport const b = 1\r\nexport const c = 1\r\nexport const d = 1\r\nexport const e = 1\r\nexport const f = 1\r\n```\r\n\r\n`main.ts`\r\n```ts\r\nconsole.log(a)\r\n```\r\n\r\n1. Trigger auto import quick fix in `main.ts` on `a`\r\n\r\n**Expected behavior:**\r\nSince `constants.js` does not use semicolons, the import should not have a semi colon\r\n\r\n**Actual behavior:**\r\nThe added import has a semi colon\r\n\r\nI believe this is because the current semicolon detection logic (#31801) requires some number of examples in the current file to learn from. For new files, this means we always default to using semicolons even if the rest of the project is semicolonless\r\n\r\nI can understand why we do this, but as a user I found it frustrating that TS would still insert semicolons until I added a certain number of imports (or other statements that are also used by the detection code). I don't know if looking at the rest of your project code is feasible or not for semicolon detection but we should discuss if we can improve the experience for new files\r\n\r\n/cc @andrewbranch \r\n\r\n**Related Issues:** \u003c!-- Did you find other bugs that looked similar? -->\r\n- #19882","author":{"url":"https://github.com/mjbvz","@type":"Person","name":"mjbvz"},"datePublished":"2019-08-12T23:19:14Z","url":"https://github.com/microsoft/TypeScript/issues/32831"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:6854c88f-b345-2c41-6209-1909f5e9555d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 99B2:8AE25:4CD052:65AE4C:6B019C58 |
| html-safe-nonce | 31ef35594d5f3d3a94b6ac73c73ff6ea951b7bbd9302465b109197159fe0725d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OUIyOjhBRTI1OjRDRDA1Mjo2NUFFNEM6NkIwMTlDNTgiLCJ2aXNpdG9yX2lkIjoiNTk1MTY5NTg1MzU2NjY2Mzc2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c200125b697b9647aa8dc1c0b97a57609ea15916fae55245286baeb75e1ebd2c |
| hovercard-subject-tag | issue:479891234 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/32831/issue_layout |
| twitter:image | https://opengraph.githubassets.com/5c62aa94041f19a9512568afa0cedb1ba6afcef84b53e818cce1e7fc28cbd9cc/microsoft/TypeScript/issues/32831 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5c62aa94041f19a9512568afa0cedb1ba6afcef84b53e818cce1e7fc28cbd9cc/microsoft/TypeScript/issues/32831 |
| og:image:alt | TypeScript Version: 3.6.0-dev.20190810 Search Terms: semicolon format auto import Repo For a very simple project: tsconfig.json { "compilerOptions": { "module": "commonjs", "target": "es2016", "jsx... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mjbvz |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width