Title: TypeGuarding not applied with explicit instanceof comparison to true/false · Issue #32819 · microsoft/TypeScript · GitHub
Open Graph Title: TypeGuarding not applied with explicit instanceof comparison to true/false · Issue #32819 · microsoft/TypeScript
X Title: TypeGuarding not applied with explicit instanceof comparison to true/false · Issue #32819 · microsoft/TypeScript
Description: From microsoft/vscode#77921 TypeScript Version: 3.6.0-dev.20190810 Search Terms: type guard instanceof Code function foo(target: Number | String) { if (target instanceof String === true) { target.toLowerCase(); } } Expected behavior: No ...
Open Graph Description: From microsoft/vscode#77921 TypeScript Version: 3.6.0-dev.20190810 Search Terms: type guard instanceof Code function foo(target: Number | String) { if (target instanceof String === true) { target.t...
X Description: From microsoft/vscode#77921 TypeScript Version: 3.6.0-dev.20190810 Search Terms: type guard instanceof Code function foo(target: Number | String) { if (target instanceof String === true) { target.t...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/32819
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"TypeGuarding not applied with explicit instanceof comparison to true/false","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\nFrom https://github.com/microsoft/vscode/issues/77921\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** 3.6.0-dev.20190810\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:**\r\n- type guard\r\n- instanceof\r\n\r\n**Code**\r\n\r\n```ts\r\nfunction foo(target: Number | String) {\r\n if (target instanceof String === true) {\r\n target.toLowerCase();\r\n }\r\n}\r\n```\r\n\r\n**Expected behavior:**\r\nNo compile error.\r\n\r\nType of `target` in the conditional statement should be `String`\r\n\r\n**Actual behavior:**\r\nError: `Property 'toLowerCase' does not exist on type 'String | Number'.\r\n Property 'toLowerCase' does not exist on type 'Number'.`\r\n\r\nThe guarding works properly if you omit the explicit `=== true`:\r\n\r\n```ts\r\nfunction foo(target: Number | String) {\r\n if (target instanceof String) {\r\n target.toLowerCase();\r\n }\r\n}\r\n```\r\n\r\n\r\n\r\n**Playground Link:** \u003c!-- A link to a TypeScript Playground \"Share\" link which demonstrates this behavior -->\r\n\r\n**Related Issues:** \u003c!-- Did you find other bugs that looked similar? -->\r\n","author":{"url":"https://github.com/mjbvz","@type":"Person","name":"mjbvz"},"datePublished":"2019-08-12T18:04:15Z","url":"https://github.com/microsoft/TypeScript/issues/32819"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:330ea6dd-4cde-c41a-88a0-2c53bcf353d5 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 92B0:3A8E64:11BEE5:179B7D:6B018498 |
| html-safe-nonce | 74c334d22b1bc4d006518a210312904de724e266af885cbefd1f9e1ae07bde74 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MkIwOjNBOEU2NDoxMUJFRTU6MTc5QjdEOjZCMDE4NDk4IiwidmlzaXRvcl9pZCI6IjI0MTMyOTkwMzQwMTA3ODA4MjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 676c161deb20a428aaa6354abcf8dbb0386e040e2f51319edcb5548adce5ca6c |
| hovercard-subject-tag | issue:479777079 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/32819/issue_layout |
| twitter:image | https://opengraph.githubassets.com/61ba40a8a849651e74f076fb615554d3a780dd66d60d942f255903b4d68e7e2d/microsoft/TypeScript/issues/32819 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/61ba40a8a849651e74f076fb615554d3a780dd66d60d942f255903b4d68e7e2d/microsoft/TypeScript/issues/32819 |
| og:image:alt | From microsoft/vscode#77921 TypeScript Version: 3.6.0-dev.20190810 Search Terms: type guard instanceof Code function foo(target: Number | String) { if (target instanceof String === true) { target.t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mjbvz |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width