Title: Generic index access on target type and return based on discriminated types do not work. · Issue #32698 · microsoft/TypeScript · GitHub
Open Graph Title: Generic index access on target type and return based on discriminated types do not work. · Issue #32698 · microsoft/TypeScript
X Title: Generic index access on target type and return based on discriminated types do not work. · Issue #32698 · microsoft/TypeScript
Description: TypeScript Version: ^3.5.0 Search Terms: index access target type discriminated types Code interface TypeA {a: string; } interface TypeB {b: string; } class A implements TypeA {public a: string = ""; } class B implements TypeB {public b:...
Open Graph Description: TypeScript Version: ^3.5.0 Search Terms: index access target type discriminated types Code interface TypeA {a: string; } interface TypeB {b: string; } class A implements TypeA {public a: string = "...
X Description: TypeScript Version: ^3.5.0 Search Terms: index access target type discriminated types Code interface TypeA {a: string; } interface TypeB {b: string; } class A implements TypeA {public a: string = &...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/32698
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Generic index access on target type and return based on discriminated types do not work.","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** ^3.5.0\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** index access target type discriminated types\r\n\r\n\r\n**Code**\r\n\r\n```ts\r\ninterface TypeA {a: string; }\r\ninterface TypeB {b: string; }\r\n\r\nclass A implements TypeA {public a: string = \"\"; }\r\nclass B implements TypeB {public b: string = \"\"; }\r\n\r\nenum Types {\r\n A= \"a\", B = \"b\",\r\n}\r\n\r\ninterface TypeInterfaces {\r\n [Types.A]: TypeA;\r\n [Types.B]: TypeB;\r\n}\r\n\r\nfunction create\u003cT extends Types>(type: T): TypeInterfaces[T] {\r\n if (type === Types.A) {\r\n return new A;\r\n } else if (type === Types.B) {\r\n return new B;\r\n }\r\n\r\n throw new Error();\r\n}\r\n```\r\n\r\n**Expected behavior:**\r\nThe compiler knows with discriminated types exactly what it needs to return and there are no errors as in 3.4 or lower.\r\n\r\n**Actual behavior:**\r\nThe compiler gives an error that we cannot assign the returned A or B to TypeA & TypeB regardless of the fact that we actually know for sure with discriminated types that we need to return either TypeA or TypeB.\r\n\r\n**Playground Link:** \u003c!-- A link to a TypeScript Playground \"Share\" link which demonstrates this behavior -->\r\n[Try it on playground](https://www.typescriptlang.org/play/#code/JYOwLgpgTgZghgYwgAgCoE8AOECCyDecAXMgM5hSgDmA3MgL4BQoksiKG2AQgQEYnlKIWg0aMEAGzilSyPMAC2mCRAURwszrgKYArrwnAEyYmQrVkAXmQAiG3SaTpsnouWr1YTVgg98egyNkfjMhKitbe1FGdV0FNB9ZfEZkOWsbOBsAGmQedN5sxiZmcGh4JATsAElStiQklOQAbS1SADocAF0SLRwaRpbEtq5uyt9+4phdEAQwYAB7EGQEKAg4SAAeVGQIAA9IEAATb2xSAD4ACjAfHoBKHp8a1nKIUhbOgkbgGGQrnytLNZWh1bp9UqlVmBdFAliAIAB3OT9VL0HYSUgob6-a7YAFAoZcUHJcHISHQ2EI3LI6KpMAACyg80RcMRAFEoIyoBdbhNGEA)\r\n\r\n**Related Issues:** \u003c!-- Did you find other bugs that looked similar? -->\r\nThis issue was specifically introduced here for v3.5 https://github.com/microsoft/TypeScript/pull/30769 by @ahejlsberg when it was decided to have the target type on index types as intersections.\r\n","author":{"url":"https://github.com/archfz","@type":"Person","name":"archfz"},"datePublished":"2019-08-03T21:25:31Z","url":"https://github.com/microsoft/TypeScript/issues/32698"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:59b4056c-434c-7889-7af3-1d14ec9f0098 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E04A:117C62:236E524:2F461E2:6B019822 |
| html-safe-nonce | 650c8c7c63e40d015761fe0d3e65975c6f0346e5b6e33ac29a313c50a92eea4a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDRBOjExN0M2MjoyMzZFNTI0OjJGNDYxRTI6NkIwMTk4MjIiLCJ2aXNpdG9yX2lkIjoiNTQ0ODEzMDQ3MTYyMTkyNDg5OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8d83c32b5fe210d1c9837841ce7faf768c197a77bc761cdbff102ff917701c08 |
| hovercard-subject-tag | issue:476490765 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/32698/issue_layout |
| twitter:image | https://opengraph.githubassets.com/3c0aeb0808967526d33b721e0b162c74f7de399d9a1761d0af7a5f43b1283898/microsoft/TypeScript/issues/32698 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3c0aeb0808967526d33b721e0b162c74f7de399d9a1761d0af7a5f43b1283898/microsoft/TypeScript/issues/32698 |
| og:image:alt | TypeScript Version: ^3.5.0 Search Terms: index access target type discriminated types Code interface TypeA {a: string; } interface TypeB {b: string; } class A implements TypeA {public a: string = "... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | archfz |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width