Title: Suggestions regression since 3.6.0-dev.20190713 · Issue #32441 · microsoft/TypeScript · GitHub
Open Graph Title: Suggestions regression since 3.6.0-dev.20190713 · Issue #32441 · microsoft/TypeScript
X Title: Suggestions regression since 3.6.0-dev.20190713 · Issue #32441 · microsoft/TypeScript
Description: TypeScript Version: 3.6.0-dev.20190717 (first version with problem 3.6.0-dev.20190713) Search Terms: completion, completionInfo, autoimport It is hard to provide repro code since this problem is found in large (4388 files processed by TS...
Open Graph Description: TypeScript Version: 3.6.0-dev.20190717 (first version with problem 3.6.0-dev.20190713) Search Terms: completion, completionInfo, autoimport It is hard to provide repro code since this problem is fo...
X Description: TypeScript Version: 3.6.0-dev.20190717 (first version with problem 3.6.0-dev.20190713) Search Terms: completion, completionInfo, autoimport It is hard to provide repro code since this problem is fo...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/32441
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Suggestions regression since 3.6.0-dev.20190713","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** `3.6.0-dev.20190717` (first version with problem `3.6.0-dev.20190713`)\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** completion, completionInfo, autoimport\r\n\r\nIt is hard to provide repro code since this problem is found in large (4388 files processed by TS) code base with closed source.\r\n\r\nHowever I see two regressions:\r\n1) Performance hit even for suggestions for variables/imports in current file\r\n2) Suggestions of other files exports are missing (even if there is already one named import from file where expected completion item located)\r\n\r\n\r\n**Performance problem**\r\n\r\n```js\r\nimport { getSelectorData } from 'tools/store-reference';\r\n...\r\nfunction retrieveValue() {\r\n const valueType = getSe/* cursor here */\r\n}\r\n\r\n```\r\nIn TS Server log is see huge difference in performance and value for **Semantic work**\r\n\r\nLog for `3.6.0-dev.20190713` (and later)\r\n```\r\nInfo 4207 [15:36:38.239] request:\r\n {\"seq\":26,\"type\":\"request\",\"command\":\"completionInfo\",\"arguments\":{\"file\":\"\u003cfilename>\",\"line\":30,\"offset\":28,\"includeExternalModuleExports\":true,\"includeInsertTextCompletions\":true}}\r\nInfo 4208 [15:36:38.240] getCompletionData: Get current token: 0\r\nInfo 4209 [15:36:38.240] getCompletionData: Is inside comment: 0\r\nInfo 4210 [15:36:38.240] getCompletionData: Get previous token 1: 0\r\nInfo 4211 [15:36:38.240] getCompletionData: Get previous token 2: 0\r\nInfo 4212 [15:36:38.240] getCompletionsAtPosition: isCompletionListBlocker: 0\r\nInfo 4213 [15:36:49.509] getCompletionData: Semantic work: 11269\r\nInfo 4214 [15:36:49.518] getCompletionsAtPosition: getCompletionEntriesFromSymbols: 8\r\nPerf 4215 [15:36:49.525] 26::completionInfo: elapsed time (in milliseconds) 11286.3765\r\nInfo 4216 [15:36:49.526] response: \u003cresponse object>\r\n```\r\n\r\nLog for `3.6.0-dev.20190712`\r\n```\r\nInfo 4180 [15:47:10.169] request:\r\n {\"seq\":23,\"type\":\"request\",\"command\":\"completionInfo\",\"arguments\":{\"file\":\"\u003cfilename>\",\"line\":30,\"offset\":28,\"includeExternalModuleExports\":true,\"includeInsertTextCompletions\":true}}\r\nInfo 4181 [15:47:10.170] getCompletionData: Get current token: 0\r\nInfo 4182 [15:47:10.170] getCompletionData: Is inside comment: 0\r\nInfo 4183 [15:47:10.170] getCompletionData: Get previous token 1: 0\r\nInfo 4184 [15:47:10.170] getCompletionData: Get previous token 2: 0\r\nInfo 4185 [15:47:10.171] getCompletionsAtPosition: isCompletionListBlocker: 1\r\nInfo 4186 [15:47:10.238] getCompletionData: Semantic work: 67\r\nInfo 4187 [15:47:10.250] getCompletionsAtPosition: getCompletionEntriesFromSymbols: 11\r\nPerf 4188 [15:47:10.260] 23::completionInfo: elapsed time (in milliseconds) 90.6148\r\nInfo 4189 [15:47:10.261] response: \u003cresponse object (has more values than latest versions)>\r\n```\r\n\r\n**Suggestion form other files**\r\n\r\n```js\r\nimport { getSelectorData /*correctly suggest dispatchAction and other exports here*/ } from 'tools/store-reference';\r\n...\r\ndispatchAction/*no suggestion here*/\r\n```\r\n\r\n\r\nThis is project written in JS has `@types` packages in `node_modules` 1 level above project `package.json` (since it isn't commited for everyone)\r\n\r\n**Related Issues:**\r\nProbably related to #31893 however it is unclear why there is big performance hit for \"local\" suggestions and why I'm unable to see suggestions from other files even (in the same folder).\r\nI would understand why there might be no globals `@types/*` that are not specified in `package.json`, but not sure why there are no suggestion from other files at all.\r\n\r\nWould be glad to follow instructions that will help to narrow this problem, however cannot provide source code.","author":{"url":"https://github.com/IllusionMH","@type":"Person","name":"IllusionMH"},"datePublished":"2019-07-17T14:19:38Z","url":"https://github.com/microsoft/TypeScript/issues/32441"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e06c8957-b853-ebd9-d034-2c63912238ca |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B9CC:1201C:BE320E:FE8888:6B00F506 |
| html-safe-nonce | 739936c987462ff4216202677bf49018ca01c9a277381ea99a908cd9882b2606 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUNDOjEyMDFDOkJFMzIwRTpGRTg4ODg6NkIwMEY1MDYiLCJ2aXNpdG9yX2lkIjoiMTA2NTI3OTg4OTgxODU4MDIzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 832a0244daa87112127885271ba61a59ba14b713e1eda97b97cbfd36a7557f42 |
| hovercard-subject-tag | issue:469243230 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/32441/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b0774ac4559c1d3f610d6c791ffe644057449f82a878fff2462389bdad438f15/microsoft/TypeScript/issues/32441 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b0774ac4559c1d3f610d6c791ffe644057449f82a878fff2462389bdad438f15/microsoft/TypeScript/issues/32441 |
| og:image:alt | TypeScript Version: 3.6.0-dev.20190717 (first version with problem 3.6.0-dev.20190713) Search Terms: completion, completionInfo, autoimport It is hard to provide repro code since this problem is fo... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | IllusionMH |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width