René's URL Explorer Experiment


Title: Suggestions regression since 3.6.0-dev.20190713 · Issue #32441 · microsoft/TypeScript · GitHub

Open Graph Title: Suggestions regression since 3.6.0-dev.20190713 · Issue #32441 · microsoft/TypeScript

X Title: Suggestions regression since 3.6.0-dev.20190713 · Issue #32441 · microsoft/TypeScript

Description: TypeScript Version: 3.6.0-dev.20190717 (first version with problem 3.6.0-dev.20190713) Search Terms: completion, completionInfo, autoimport It is hard to provide repro code since this problem is found in large (4388 files processed by TS...

Open Graph Description: TypeScript Version: 3.6.0-dev.20190717 (first version with problem 3.6.0-dev.20190713) Search Terms: completion, completionInfo, autoimport It is hard to provide repro code since this problem is fo...

X Description: TypeScript Version: 3.6.0-dev.20190717 (first version with problem 3.6.0-dev.20190713) Search Terms: completion, completionInfo, autoimport It is hard to provide repro code since this problem is fo...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/32441

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Suggestions regression since 3.6.0-dev.20190713","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:**  `3.6.0-dev.20190717` (first version with problem `3.6.0-dev.20190713`)\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** completion, completionInfo, autoimport\r\n\r\nIt is hard to provide repro code since this problem is found in large (4388 files processed by TS) code base with closed source.\r\n\r\nHowever I see two regressions:\r\n1) Performance hit even for suggestions for variables/imports in current file\r\n2) Suggestions of other files exports are missing (even if there is already one named import from file where expected completion item located)\r\n\r\n\r\n**Performance problem**\r\n\r\n```js\r\nimport { getSelectorData } from 'tools/store-reference';\r\n...\r\nfunction retrieveValue() {\r\n    const valueType = getSe/* cursor here */\r\n}\r\n\r\n```\r\nIn TS Server log is see huge difference in performance and value for **Semantic work**\r\n\r\nLog for `3.6.0-dev.20190713` (and later)\r\n```\r\nInfo 4207 [15:36:38.239] request:\r\n    {\"seq\":26,\"type\":\"request\",\"command\":\"completionInfo\",\"arguments\":{\"file\":\"\u003cfilename>\",\"line\":30,\"offset\":28,\"includeExternalModuleExports\":true,\"includeInsertTextCompletions\":true}}\r\nInfo 4208 [15:36:38.240] getCompletionData: Get current token: 0\r\nInfo 4209 [15:36:38.240] getCompletionData: Is inside comment: 0\r\nInfo 4210 [15:36:38.240] getCompletionData: Get previous token 1: 0\r\nInfo 4211 [15:36:38.240] getCompletionData: Get previous token 2: 0\r\nInfo 4212 [15:36:38.240] getCompletionsAtPosition: isCompletionListBlocker: 0\r\nInfo 4213 [15:36:49.509] getCompletionData: Semantic work: 11269\r\nInfo 4214 [15:36:49.518] getCompletionsAtPosition: getCompletionEntriesFromSymbols: 8\r\nPerf 4215 [15:36:49.525] 26::completionInfo: elapsed time (in milliseconds) 11286.3765\r\nInfo 4216 [15:36:49.526] response: \u003cresponse object>\r\n```\r\n\r\nLog for `3.6.0-dev.20190712`\r\n```\r\nInfo 4180 [15:47:10.169] request:\r\n    {\"seq\":23,\"type\":\"request\",\"command\":\"completionInfo\",\"arguments\":{\"file\":\"\u003cfilename>\",\"line\":30,\"offset\":28,\"includeExternalModuleExports\":true,\"includeInsertTextCompletions\":true}}\r\nInfo 4181 [15:47:10.170] getCompletionData: Get current token: 0\r\nInfo 4182 [15:47:10.170] getCompletionData: Is inside comment: 0\r\nInfo 4183 [15:47:10.170] getCompletionData: Get previous token 1: 0\r\nInfo 4184 [15:47:10.170] getCompletionData: Get previous token 2: 0\r\nInfo 4185 [15:47:10.171] getCompletionsAtPosition: isCompletionListBlocker: 1\r\nInfo 4186 [15:47:10.238] getCompletionData: Semantic work: 67\r\nInfo 4187 [15:47:10.250] getCompletionsAtPosition: getCompletionEntriesFromSymbols: 11\r\nPerf 4188 [15:47:10.260] 23::completionInfo: elapsed time (in milliseconds) 90.6148\r\nInfo 4189 [15:47:10.261] response: \u003cresponse object (has more values than latest versions)>\r\n```\r\n\r\n**Suggestion form other files**\r\n\r\n```js\r\nimport { getSelectorData /*correctly suggest dispatchAction and other exports here*/ } from 'tools/store-reference';\r\n...\r\ndispatchAction/*no suggestion here*/\r\n```\r\n\r\n\r\nThis is project written in JS has `@types` packages in `node_modules` 1 level above project `package.json` (since it isn't commited for everyone)\r\n\r\n**Related Issues:**\r\nProbably related to #31893 however it is unclear why there is big performance hit for \"local\" suggestions and why I'm unable to see suggestions from other files even (in the same folder).\r\nI would understand why there might be no globals `@types/*` that are not specified in `package.json`, but not sure why there are no suggestion from other files at all.\r\n\r\nWould be glad to follow instructions that will help to narrow this problem, however cannot provide source code.","author":{"url":"https://github.com/IllusionMH","@type":"Person","name":"IllusionMH"},"datePublished":"2019-07-17T14:19:38Z","url":"https://github.com/microsoft/TypeScript/issues/32441"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:e06c8957-b853-ebd9-d034-2c63912238ca
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB9CC:1201C:BE320E:FE8888:6B00F506
html-safe-nonce739936c987462ff4216202677bf49018ca01c9a277381ea99a908cd9882b2606
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOUNDOjEyMDFDOkJFMzIwRTpGRTg4ODg6NkIwMEY1MDYiLCJ2aXNpdG9yX2lkIjoiMTA2NTI3OTg4OTgxODU4MDIzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac832a0244daa87112127885271ba61a59ba14b713e1eda97b97cbfd36a7557f42
hovercard-subject-tagissue:469243230
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/32441/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b0774ac4559c1d3f610d6c791ffe644057449f82a878fff2462389bdad438f15/microsoft/TypeScript/issues/32441
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b0774ac4559c1d3f610d6c791ffe644057449f82a878fff2462389bdad438f15/microsoft/TypeScript/issues/32441
og:image:altTypeScript Version: 3.6.0-dev.20190717 (first version with problem 3.6.0-dev.20190713) Search Terms: completion, completionInfo, autoimport It is hard to provide repro code since this problem is fo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameIllusionMH
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/32441#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F32441
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F32441
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/32441
Reloadhttps://github.com/microsoft/TypeScript/issues/32441
Reloadhttps://github.com/microsoft/TypeScript/issues/32441
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/32441
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/32441
#32517https://github.com/microsoft/TypeScript/pull/32517
Suggestions regression since 3.6.0-dev.20190713https://github.com/microsoft/TypeScript/issues/32441#top
#32517https://github.com/microsoft/TypeScript/pull/32517
https://github.com/andrewbranch
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
Fix AvailableA PR has been opened for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fix%20Available%22
TypeScript 3.7.0https://github.com/microsoft/TypeScript/milestone/98
https://github.com/IllusionMH
Andrii Dieiev (IllusionMH)https://github.com/IllusionMH
on Jul 17, 2019https://github.com/microsoft/TypeScript/issues/32441#issue-469243230
#31893https://github.com/microsoft/TypeScript/pull/31893
Andrii Dieiev (IllusionMH)https://github.com/IllusionMH
on Jul 17, 2019https://github.com/microsoft/TypeScript/issues/32441#event-2489625933
https://github.com/IllusionMH
Andrii Dieiev (IllusionMH)https://github.com/IllusionMH
on Jul 17, 2019https://github.com/microsoft/TypeScript/issues/32441#issuecomment-512283967
#31893 (comment)https://github.com/microsoft/TypeScript/pull/31893#issuecomment-502163680
Andrew Branch (@andrewbranch)https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
on Jul 17, 2019https://github.com/microsoft/TypeScript/issues/32441#event-2489960528
Andrew Branch (andrewbranch)https://github.com/andrewbranch
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
Needs InvestigationThis issue needs a team member to investigate its status.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Investigation%22
on Jul 17, 2019https://github.com/microsoft/TypeScript/issues/32441#event-2489961009
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
on Jul 17, 2019https://github.com/microsoft/TypeScript/issues/32441#issuecomment-512346206
#31893https://github.com/microsoft/TypeScript/pull/31893
https://github.com/IllusionMH
Andrii Dieiev (IllusionMH)https://github.com/IllusionMH
on Jul 17, 2019https://github.com/microsoft/TypeScript/issues/32441#issuecomment-512351431
https://github.com/fatcerberus
Bruce Pascoe (fatcerberus)https://github.com/fatcerberus
on Jul 17, 2019https://github.com/microsoft/TypeScript/issues/32441#issuecomment-512361751
#31893https://github.com/microsoft/TypeScript/pull/31893
https://github.com/IllusionMH
Andrii Dieiev (IllusionMH)https://github.com/IllusionMH
on Jul 17, 2019https://github.com/microsoft/TypeScript/issues/32441#issuecomment-512391333
#31893 (review)https://github.com/microsoft/TypeScript/pull/31893#pullrequestreview-254809440
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
on Jul 17, 2019https://github.com/microsoft/TypeScript/issues/32441#issuecomment-512407704
#31893https://github.com/microsoft/TypeScript/pull/31893
#31893https://github.com/microsoft/TypeScript/pull/31893
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
on Jul 17, 2019https://github.com/microsoft/TypeScript/issues/32441#issuecomment-512568059
https://github.com/IllusionMH
Andrii Dieiev (IllusionMH)https://github.com/IllusionMH
on Jul 17, 2019https://github.com/microsoft/TypeScript/issues/32441#issuecomment-512586100
Andrew Branch (@andrewbranch)https://github.com/andrewbranch
Debugging Language Service in VS Codehttps://github.com/microsoft/TypeScript/wiki/Debugging-Language-Service-in-VS-Code#debugging-tsserver-server-side
ndbhttps://github.com/GoogleChromeLabs/ndb
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
on Jul 17, 2019https://github.com/microsoft/TypeScript/issues/32441#issuecomment-512588484
https://github.com/IllusionMH
Andrii Dieiev (IllusionMH)https://github.com/IllusionMH
on Jul 17, 2019https://github.com/microsoft/TypeScript/issues/32441#issuecomment-512594854
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
on Jul 17, 2019https://github.com/microsoft/TypeScript/issues/32441#issuecomment-512595707
https://github.com/IllusionMH
Andrii Dieiev (IllusionMH)https://github.com/IllusionMH
on Jul 17, 2019https://github.com/microsoft/TypeScript/issues/32441#issuecomment-512598085
https://github.com/IllusionMH
Andrii Dieiev (IllusionMH)https://github.com/IllusionMH
on Jul 18, 2019https://github.com/microsoft/TypeScript/issues/32441#issuecomment-512805241
https://github.com/andrewbranch
Andrew Branch (andrewbranch)https://github.com/andrewbranch
on Jul 22, 2019https://github.com/microsoft/TypeScript/issues/32441#issuecomment-513873953
Andrew Branch (andrewbranch)https://github.com/andrewbranch
TypeScript 3.7.0https://github.com/microsoft/TypeScript/milestone/98
TypeScript 3.6.1https://github.com/microsoft/TypeScript/milestone/100
on Jul 22, 2019https://github.com/microsoft/TypeScript/issues/32441#event-2500907079
Andrew Branch (andrewbranch)https://github.com/andrewbranch
TypeScript 3.6.1https://github.com/microsoft/TypeScript/milestone/100
TypeScript 3.7.0https://github.com/microsoft/TypeScript/milestone/98
on Aug 12, 2019https://github.com/microsoft/TypeScript/issues/32441#event-2550969224
Andrew Branch (andrewbranch)https://github.com/andrewbranch
Fix AvailableA PR has been opened for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fix%20Available%22
Needs InvestigationThis issue needs a team member to investigate its status.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Investigation%22
on Sep 16, 2019https://github.com/microsoft/TypeScript/issues/32441#event-2637380637
Andrew Branch (andrewbranch)https://github.com/andrewbranch
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#32517https://github.com/microsoft/TypeScript/pull/32517
on Sep 27, 2019https://github.com/microsoft/TypeScript/issues/32441#event-2669834183
microsofthttps://github.com/microsoft
on Oct 21, 2025https://github.com/microsoft/TypeScript/issues/32441#event-20416725747
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/32441
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/32441
Andrew Branch (andrewbranch)https://github.com/andrewbranch
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
Fix AvailableA PR has been opened for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fix%20Available%22
TypeScript 3.7.0https://github.com/microsoft/TypeScript/milestone/98
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.