Title: Type alias name (union) is not preserved when using index access/lookup types · Issue #32287 · microsoft/TypeScript · GitHub
Open Graph Title: Type alias name (union) is not preserved when using index access/lookup types · Issue #32287 · microsoft/TypeScript
X Title: Type alias name (union) is not preserved when using index access/lookup types · Issue #32287 · microsoft/TypeScript
Description: TypeScript Version: 3.5.2 Search Terms: indexed access lookup types type alias naming Code Given: type MyUnion = 1 | 2 | 3; // Hover this type MyObject = { value: MyUnion }; If I hover over MyObject, I see { value: MyUnion; }. However, g...
Open Graph Description: TypeScript Version: 3.5.2 Search Terms: indexed access lookup types type alias naming Code Given: type MyUnion = 1 | 2 | 3; // Hover this type MyObject = { value: MyUnion }; If I hover over MyObjec...
X Description: TypeScript Version: 3.5.2 Search Terms: indexed access lookup types type alias naming Code Given: type MyUnion = 1 | 2 | 3; // Hover this type MyObject = { value: MyUnion }; If I hover over MyObjec...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/32287
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Type alias name (union) is not preserved when using index access/lookup types","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** 3.5.2\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** indexed access lookup types type alias naming\r\n\r\n**Code**\r\n\r\nGiven:\r\n\r\n```ts\r\ntype MyUnion = 1 | 2 | 3;\r\n\r\n// Hover this\r\ntype MyObject = { value: MyUnion };\r\n```\r\n\r\nIf I hover over `MyObject`, I see `{ value: MyUnion; }`.\r\n\r\nHowever, given:\r\n\r\n``` ts\r\ntype MyRecord = {\r\n Foo: 1;\r\n Bar: 2;\r\n Baz: 3;\r\n}\r\n\r\ntype MyUnion = MyRecord[keyof MyRecord];\r\n\r\n// Hover this\r\ntype MyObject = { value: MyUnion };\r\n```\r\n\r\nIf I hover over `MyObject`, I see `{ value: 1 | 2 | 3; }`.\r\n\r\nI would expect the same behaviour as we see in my first example (`{ value: MyUnion; }`). The name of the type alias, `MyUnion`, should be preserved and its usage/reference inside of `MyObject` should be shown.\r\n\r\nTo give some context on my real world use case for this: I am using [Unionize](https://github.com/pelotom/unionize) to create tagged unions (to avoid boilerplate for constructors, matchers, and type predicates). However, because of the issue described above, the types become very difficult to inspect/read: https://github.com/pelotom/unionize/issues/60.\r\n\r\nUnder the hood, Unionize does something like this:\r\n\r\n``` ts\r\ntype Foo = { foo: number };\r\ntype Bar = { bar: number };\r\ntype Baz = { baz: number };\r\n\r\ntype MyUnionRecord = {\r\n Foo: Foo;\r\n Bar: Bar;\r\n Baz: Baz;\r\n};\r\n\r\ntype MyUnionTaggedRecord = { [K in keyof MyUnionRecord]: { tag: K; value: MyUnionRecord[K] } };\r\ntype MyUnion = MyUnionTaggedRecord[keyof MyUnionTaggedRecord];\r\n\r\n// Hover this\r\ntype MyObject = { value: MyUnion };\r\n```\r\n\r\nIf we hover over `MyObject` here, we see:\r\n\r\n``` ts\r\n{\r\n value: {\r\n tag: \"Foo\";\r\n value: Foo;\r\n } | {\r\n tag: \"Bar\";\r\n value: Bar;\r\n } | {\r\n tag: \"Baz\";\r\n value: Baz;\r\n };\r\n}\r\n```\r\n\r\n… when we really want to see `{ value: MyUnion }`.\r\n\r\nAs I demonstrated in https://github.com/pelotom/unionize/issues/60, this scales really badly, e.g. when nesting unions.","author":{"url":"https://github.com/OliverJAsh","@type":"Person","name":"OliverJAsh"},"datePublished":"2019-07-08T00:03:34Z","url":"https://github.com/microsoft/TypeScript/issues/32287"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:073e3657-acc9-af68-92f9-396159752892 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BFB2:299992:A97AAE:E05F5A:6B01BBC4 |
| html-safe-nonce | b200fa7cef5d98e549e2873fec0c02a31261fa01b32296559106f94157a1aa2e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRkIyOjI5OTk5MjpBOTdBQUU6RTA1RjVBOjZCMDFCQkM0IiwidmlzaXRvcl9pZCI6IjEyOTE2MjU2ODg1MjAwNDc1NTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 655854e4e307e3211f7bcaaaa8e0c016c9702dd96b8c654cdf2df7f22d236b2d |
| hovercard-subject-tag | issue:465007276 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/32287/issue_layout |
| twitter:image | https://opengraph.githubassets.com/37d3dec56633ef8658c8735a25666a2e3d979ad676c8403be158aa2f0ef8a6ec/microsoft/TypeScript/issues/32287 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/37d3dec56633ef8658c8735a25666a2e3d979ad676c8403be158aa2f0ef8a6ec/microsoft/TypeScript/issues/32287 |
| og:image:alt | TypeScript Version: 3.5.2 Search Terms: indexed access lookup types type alias naming Code Given: type MyUnion = 1 | 2 | 3; // Hover this type MyObject = { value: MyUnion }; If I hover over MyObjec... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | OliverJAsh |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width