Title: Bug Report + Proposal: Object.assign() · Issue #31982 · microsoft/TypeScript · GitHub
Open Graph Title: Bug Report + Proposal: Object.assign() · Issue #31982 · microsoft/TypeScript
X Title: Bug Report + Proposal: Object.assign() · Issue #31982 · microsoft/TypeScript
Description: TypeScript Version: 3.4.0-dev.201xxxxx Search Terms: Object.assign return type Code let test1: string = Object.assign({ a: 1 }, { a: "one" }).a // $ExpectError let test2: number = Object.assign({ a: 1 }, { a: "one" }).a // No error // $E...
Open Graph Description: TypeScript Version: 3.4.0-dev.201xxxxx Search Terms: Object.assign return type Code let test1: string = Object.assign({ a: 1 }, { a: "one" }).a // $ExpectError let test2: number = Object.assign({ a...
X Description: TypeScript Version: 3.4.0-dev.201xxxxx Search Terms: Object.assign return type Code let test1: string = Object.assign({ a: 1 }, { a: "one" }).a // $ExpectError let test2: number = Object....
Opengraph URL: https://github.com/microsoft/TypeScript/issues/31982
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Bug Report + Proposal: Object.assign()","articleBody":"\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** 3.4.0-dev.201xxxxx\r\n\r\n**Search Terms:** Object.assign return type\r\n\r\n**Code**\r\n\r\n1.\r\n\r\n```ts\r\nlet test1: string = Object.assign({ a: 1 }, { a: \"one\" }).a\r\n// $ExpectError\r\nlet test2: number = Object.assign({ a: 1 }, { a: \"one\" }).a // No error\r\n```\r\n\r\n2.\r\n```ts\r\n// $ExpectError\r\nObject.assign({ a: 1, b: 2 }, \"hi\").toLowerCase() // No error\r\n```\r\n\r\n3.\r\n\r\n```ts\r\n// $ExpectError\r\nObject.assign({ a: 1, b: 2 }, \"hi\").length // No error\r\n```\r\n\r\n**Expected behavior:**\r\n\r\n1.\r\n\r\n> Type 'string' is not assignable to type 'number'\r\n\r\n2.\r\n\r\n> Property 'toLowerCase' does not exist on type ...\r\n\r\n3. \r\n\r\n> Property 'length' does not exist on type ...\r\n\r\n**Actual behavior:**\r\n\r\nNo errors raised.\r\n\r\n**Playground Link:** [Link](https://www.typescriptlang.org/play/#src=%2F%2F%20Pass%0D%0Alet%20test1%3A%20string%20%3D%20Object.assign(%7B%20a%3A%201%20%7D%2C%20%7B%20a%3A%20%22one%22%20%7D).a%0D%0A%0D%0A%2F%2F%20Failure%0D%0A%2F%2F%20Should%20raise%3A%0D%0A%2F%2F%20%20%20%20%20Type%20'string'%20is%20not%20assignable%20to%20type%20'number'%0D%0A%2F%2F%20%24ExpectError%0D%0Alet%20test2%3A%20number%20%3D%20Object.assign(%7B%20a%3A%201%20%7D%2C%20%7B%20a%3A%20%22one%22%20%7D).a%0D%0A%0D%0A%2F%2F%20Pass%0D%0Alet%20test3%3A%20string%20%3D%20Object.assign(%7B%20a%3A%201%20%7D%2C%20%7B%20a%3A%20(0%20as%20any)%20%7D).a%0D%0A%0D%0A%2F%2F%20Pass%0D%0Alet%20test4%3A%20number%20%3D%20Object.assign(%7B%20a%3A%201%20%7D%2C%20%7B%20a%3A%20undefined%20%7D).a%0D%0A%0D%0A%2F%2F%20Pass...%20sort%20of%0D%0A%2F%2F%20Should%20raise%3A%0D%0A%2F%2F%20%20%20%20%20Type%20'number'%20is%20not%20assignable%20to%20type%20'string'%0D%0A%2F%2F%20Note%3A%20The%20the%20error%20message%20is%20incorrect%20and%20demonstrative%20of%20the%20issue%20at%20hand.%0D%0A%2F%2F%20%24ExpectError%0D%0Alet%20test5%3A%20string%20%3D%20Object.assign(%7B%20a%3A%201%20%7D%2C%20%7B%20a%3A%20%7B%7D%20%7D).a%20%0D%0A%0D%0A%2F%2F%20Failure%0D%0A%2F%2F%20Should%20raise%3A%0D%0A%2F%2F%20%20%20%20%20Property%20'toLowerCase'%20does%20not%20exist%20on%20type%20...%0D%0A%2F%2F%20%24ExpectError%0D%0AObject.assign(%7B%20a%3A%201%2C%20b%3A%202%20%7D%2C%20%22hi%22).toLowerCase()%20%2F%2F%20test6%0D%0A%0D%0A%2F%2F%20Pass%0D%0AObject.assign(%7B%20a%3A%201%2C%20b%3A%202%20%7D%2C%20%22hi%22)%5B%22a%22%5D%20%2F%2F%20test7%0D%0A%0D%0A%2F%2F%20Pass%0D%0Alet%20test8%3A%20string%20%3D%20Object.assign(%7B%20a%3A%201%2C%20b%3A%202%20%7D%2C%20%22hi%22)%5B0%5D%0D%0A%0D%0A%2F%2F%20Pass%0D%0A%2F%2F%20Correctly%20raises%3A%0D%0A%2F%2F%20%20%20%20%20Type%20'string'%20is%20not%20assignable%20to%20type%20'number'%0D%0A%2F%2F%20%24ExpectError%0D%0Alet%20test9%3A%20number%20%3D%20Object.assign(%7B%20a%3A%201%2C%20b%3A%202%20%7D%2C%20%22hi%22)%5B0%5D%0D%0A%0D%0A%2F%2F%20Failure%0D%0A%2F%2F%20Should%20raise%3A%0D%0A%2F%2F%20%20%20%20%20Property%20'length'%20does%20not%20exist%20on%20type%20...%0D%0A%2F%2F%20%24ExpectError%0D%0AObject.assign(%7B%20a%3A%201%2C%20b%3A%202%20%7D%2C%20%22hi%22).length%20%2F%2F%20test10%0D%0A%0D%0A%2F%2F%20Pass%0D%0Alet%20test11%3A%20number%20%3D%20Object.assign(%7B%20a%3A%201%2C%20b%3A%202%20%7D%2C%20%5B1%2C%202%2C%203%5D)%5B0%5D%0D%0A%0D%0A%2F%2F%20Pass%0D%0A%2F%2F%20Correctly%20raises%3A%0D%0A%2F%2F%20%20%20%20%20Type%20'number'%20is%20not%20assignable%20to%20type%20'string'%0D%0A%2F%2F%20%24ExpectError%0D%0Alet%20test12%3A%20string%20%3D%20Object.assign(%7B%20a%3A%201%2C%20b%3A%202%20%7D%2C%20%5B1%2C%202%2C%203%5D)%5B0%5D%0D%0A)\r\n\r\n**Related Issues:** \r\n\r\n* https://github.com/microsoft/TypeScript/pull/30481\r\n* https://github.com/microsoft/TypeScript/issues/29348\r\n\r\n# Proposal\r\n\r\n```ts\r\ntype IndexerReturnType\u003cT extends ArrayLike\u003cany>> = T extends ArrayLike\u003cinfer V> ? V : any;\r\n\r\ntype ArrayLikeIndexer\u003cT> = T extends ArrayLike\u003cany> ? { [k: number]: IndexerReturnType\u003cT> } : never \r\n\r\ntype PickDefined\u003cT> = {\r\n [P in keyof T]: T[P] extends undefined ? never : T[P]\r\n};\r\n\r\ntype Assign\u003cA, B> = A extends object ? (\r\n B extends object ?\r\n Pick\u003cA, Exclude\u003ckeyof A, keyof B>> & PickDefined\u003cB> :\r\n A & ArrayLikeIndexer\u003cB>\r\n) : (A & B)\r\n\r\ndeclare function assign\u003cA, B>(a: A, b: B): Assign\u003cA, B>\r\n```\r\n\r\n**Note 1**: _`PickDefined\u003cT>` is necessary with `strictNullChecks` enabled._\r\n**Note 2**: _In the definition of `Assign\u003cA, B>` I would have expected the usage of `keyof B` to need to be replaced with `keyof PickDefined\u003cB>`. It seems, that's _presently_ not the case - so I've opted to omit it and avoid any potential slow-down. Nonetheless, I must admit that I'm hazy as to why this is permissible._\r\n\r\nObviously to keep things brief I've just covered the single `source` use-case rather than providing overloads with several source. The definition is nonetheless chainable i.e. `Assign\u003cA, Assign\u003cB, C>>` etc. \r\n\r\n**Playground Link:** [Link](https://www.typescriptlang.org/play/#src=%2F%2F%20*****%20Proposed%20Definition%20*****%0D%0A%0D%0Atype%20IndexerReturnType%3CT%20extends%20ArrayLike%3Cany%3E%3E%20%3D%20T%20extends%20ArrayLike%3Cinfer%20V%3E%20%3F%20V%20%3A%20any%3B%0D%0A%0D%0Atype%20ArrayLikeIndexer%3CT%3E%20%3D%20T%20extends%20ArrayLike%3Cany%3E%20%3F%20%7B%20%5Bk%3A%20number%5D%3A%20IndexerReturnType%3CT%3E%20%7D%20%3A%20never%20%0D%0A%0D%0Atype%20PickDefined%3CT%3E%20%3D%20%7B%0D%0A%20%20%20%20%5BP%20in%20keyof%20T%5D%3A%20T%5BP%5D%20extends%20undefined%20%3F%20never%20%3A%20T%5BP%5D%0D%0A%7D%3B%0D%0A%0D%0Atype%20Assign%3CA%2C%20B%3E%20%3D%20A%20extends%20object%20%3F%20(%0D%0A%20%20%20%20B%20extends%20object%20%3F%20Pick%3CA%2C%20Exclude%3Ckeyof%20A%2C%20keyof%20B%3E%3E%20%26%20PickDefined%3CB%3E%20%3A%20A%20%26%20ArrayLikeIndexer%3CB%3E%0D%0A)%20%3A%20(A%20%26%20B)%0D%0A%0D%0A%2F%2F%20Note%3A%20In%20the%20above%20I%20would%20have%20expected%20%60keyof%20B%60%20to%20need%20to%20be%20%60keyof%20PickDefined%3CB%3E%60%2C%0D%0A%2F%2F%20however%20that's%20*presently*%20not%20the%20case%20-%20so%20no%20point%20slowing%20TypeScript%20down.%0D%0A%0D%0Adeclare%20function%20assign%3CA%2C%20B%3E(a%3A%20A%2C%20b%3A%20B)%3A%20Assign%3CA%2C%20B%3E%0D%0A%0D%0A%2F%2F%20*****%20Tests%20*****%0D%0A%0D%0A%2F%2F%20Pass%0D%0Alet%20test1%3A%20string%20%3D%20assign(%7B%20a%3A%201%20%7D%2C%20%7B%20a%3A%20%22one%22%20%7D).a%0D%0A%0D%0A%2F%2F%20Pass%0D%0A%2F%2F%20Correctly%20raises%3A%0D%0A%2F%2F%20%20%20%20%20Type%20'string'%20is%20not%20assignable%20to%20type%20'number'%0D%0A%2F%2F%20%24ExpectError%0D%0Alet%20test2%3A%20number%20%3D%20assign(%7B%20a%3A%201%20%7D%2C%20%7B%20a%3A%20%22one%22%20%7D).a%0D%0A%0D%0A%2F%2F%20Pass%0D%0Alet%20test3%3A%20string%20%3D%20assign(%7B%20a%3A%201%20%7D%2C%20%7B%20a%3A%20(0%20as%20any)%20%7D).a%0D%0A%0D%0A%2F%2F%20Pass%0D%0Alet%20test4%3A%20number%20%3D%20assign(%7B%20a%3A%201%20%7D%2C%20%7B%20a%3A%20undefined%20%7D).a%0D%0A%0D%0A%2F%2F%20Pass%0D%0A%2F%2F%20Correctly%20raises%3A%0D%0A%2F%2F%20%20%20%20%20Type%20'number'%20is%20not%20assignable%20to%20type%20'string'%0D%0A%2F%2F%20%24ExpectError%0D%0Alet%20test5%3A%20string%20%3D%20assign(%7B%20a%3A%201%20%7D%2C%20%7B%20a%3A%20%7B%7D%20%7D).a%20%0D%0A%0D%0A%2F%2F%20Pass%0D%0A%2F%2F%20Correctly%20raises%3A%0D%0A%2F%2F%20%20%20%20%20Property%20'toLowerCase'%20does%20not%20exist%20on%20type%20...%0D%0A%2F%2F%20%24ExpectError%0D%0Aassign(%7B%20a%3A%201%2C%20b%3A%202%20%7D%2C%20%22hi%22).toLowerCase()%20%2F%2F%20test6%0D%0A%0D%0A%2F%2F%20Pass%0D%0Aassign(%7B%20a%3A%201%2C%20b%3A%202%20%7D%2C%20%22hi%22)%5B%22a%22%5D%20%2F%2F%20test7%0D%0A%0D%0A%2F%2F%20Pass%0D%0Alet%20test8%3A%20string%20%3D%20assign(%7B%20a%3A%201%2C%20b%3A%202%20%7D%2C%20%22hi%22)%5B0%5D%0D%0A%0D%0A%2F%2F%20Pass%0D%0A%2F%2F%20Correctly%20raises%3A%0D%0A%2F%2F%20%20%20%20%20Type%20'string'%20is%20not%20assignable%20to%20type%20'number'%0D%0A%2F%2F%20%24ExpectError%0D%0Alet%20test9%3A%20number%20%3D%20assign(%7B%20a%3A%201%2C%20b%3A%202%20%7D%2C%20%22hi%22)%5B0%5D%0D%0A%0D%0A%2F%2F%20Pass%0D%0A%2F%2F%20Correctly%20raises%3A%0D%0A%2F%2F%20%20%20%20%20Property%20'length'%20does%20not%20exist%20on%20type%20...%0D%0A%2F%2F%20%24ExpectError%0D%0Aassign(%7B%20a%3A%201%2C%20b%3A%202%20%7D%2C%20%22hi%22).length%20%2F%2F%20test10%0D%0A%0D%0A%2F%2F%20Pass%0D%0Alet%20test11%3A%20number%20%3D%20assign(%7B%20a%3A%201%2C%20b%3A%202%20%7D%2C%20%5B1%2C%202%2C%203%5D)%5B0%5D%0D%0A%0D%0A%2F%2F%20Pass%0D%0A%2F%2F%20Correctly%20raises%3A%0D%0A%2F%2F%20%20%20%20%20Type%20'number'%20is%20not%20assignable%20to%20type%20'string'%0D%0A%2F%2F%20%24ExpectError%0D%0Alet%20test12%3A%20string%20%3D%20assign(%7B%20a%3A%201%2C%20b%3A%202%20%7D%2C%20%5B1%2C%202%2C%203%5D)%5B0%5D%0D%0A) (For posterity please enable `strictNullChecks`)","author":{"url":"https://github.com/Benjamin-Dobell","@type":"Person","name":"Benjamin-Dobell"},"datePublished":"2019-06-19T15:25:16Z","url":"https://github.com/microsoft/TypeScript/issues/31982"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:9466b3d0-f446-a692-5c2c-b4e76bbc3b4a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E2F8:27D3AD:3090D7C:3DAD80D:6B01C74A |
| html-safe-nonce | b4c63b7e335a6c67f8975248380c3fe8c27067361996845c353e4de4fb9e5924 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMkY4OjI3RDNBRDozMDkwRDdDOjNEQUQ4MEQ6NkIwMUM3NEEiLCJ2aXNpdG9yX2lkIjoiNTY2MTkwNDQyMDAxMTYyNDI2NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8e02427e55cacd09a9f465820d2d70777185e0c6d2bf8d07517dfbe04062af39 |
| hovercard-subject-tag | issue:458079416 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/31982/issue_layout |
| twitter:image | https://opengraph.githubassets.com/83524fe10929b6bf1d8ccab4d6c831a2e5d8c9fd57c46e337d0aa2b9c359578c/microsoft/TypeScript/issues/31982 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/83524fe10929b6bf1d8ccab4d6c831a2e5d8c9fd57c46e337d0aa2b9c359578c/microsoft/TypeScript/issues/31982 |
| og:image:alt | TypeScript Version: 3.4.0-dev.201xxxxx Search Terms: Object.assign return type Code let test1: string = Object.assign({ a: 1 }, { a: "one" }).a // $ExpectError let test2: number = Object.assign({ a... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Benjamin-Dobell |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width