René's URL Explorer Experiment


Title: Type guard fails for a part of an object · Issue #31755 · microsoft/TypeScript · GitHub

Open Graph Title: Type guard fails for a part of an object · Issue #31755 · microsoft/TypeScript

X Title: Type guard fails for a part of an object · Issue #31755 · microsoft/TypeScript

Description: TypeScript Version: 3.4.5 Search Terms: type guard object destructuring, type guard object key Code export type GROUP_TYPE = 'group_1' | 'group_2'; export function isGroup(g: any): g is GROUP_TYPE { const allowedGroups: GROUP_TYPE[] = ['...

Open Graph Description: TypeScript Version: 3.4.5 Search Terms: type guard object destructuring, type guard object key Code export type GROUP_TYPE = 'group_1' | 'group_2'; export function isGroup(g: any): g is GROUP_TYPE ...

X Description: TypeScript Version: 3.4.5 Search Terms: type guard object destructuring, type guard object key Code export type GROUP_TYPE = 'group_1' | 'group_2'; export function isGroup(g: any): ...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/31755

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Type guard fails for a part of an object","articleBody":"**TypeScript Version:**  3.4.5\r\n\r\n**Search Terms:** type guard object destructuring, type guard object key\r\n\r\n**Code**\r\n```ts\r\nexport type GROUP_TYPE = 'group_1' | 'group_2';\r\n\r\nexport function isGroup(g: any): g is GROUP_TYPE {\r\n    const allowedGroups: GROUP_TYPE[] = ['group_1', 'group_2'];\r\n    return allowedGroups.indexOf(g) !== -1;\r\n}\r\n\r\nfunction getPermissions(query: { group: GROUP_TYPE }) {/* do something */ }\r\n\r\nfunction goodFunction(query: { group: string }) {\r\n    if (!isGroup(query.group))\r\n        return;\r\n\r\n    const { group } = query;\r\n\r\n    return getPermissions({ ...query, group });\r\n}\r\n\r\nfunction sameFunction(query: { group: string }) {\r\n    if (!isGroup(query.group))\r\n        return;\r\n\r\n    return getPermissions(query); // Error here\r\n    //   _________________^^^^^\r\n/*\r\nArgument of type '{ group: string; }' is not assignable to parameter of type '{ group: GROUP_TYPE; }'.\r\n ...\r\n*/\r\n}\r\n```\r\n\r\n**Expected behavior:**\r\nBoth functions (goodFunction, sameFunction) should be valid typescript code\r\n\r\n**Actual behavior:**\r\nWe see TS error\r\n```\r\nArgument of type '{ group: string; }' is not assignable to parameter of type '{ group: GROUP_TYPE; }'.\r\n  Types of property 'group' are incompatible.\r\n    Type 'string' is not assignable to type 'GROUP_TYPE'.\r\n```\r\nit thinks that `query.group` is steel a `string` when passing as arguments, but knows it is a `GROUP_TYPE` when gets it from object.\r\n\r\n**Playground Link:** \r\n[link to playground](https://www.typescriptlang.org/play/#src=export%20type%20GROUP_TYPE%20%3D%20'group_1'%20%7C%20'group_2'%3B%0D%0A%0D%0Aexport%20function%20isGroup(g%3A%20any)%3A%20g%20is%20GROUP_TYPE%20%7B%0D%0A%20%20%20%20const%20allowedGroups%3A%20GROUP_TYPE%5B%5D%20%3D%20%5B'group_1'%2C%20'group_2'%5D%3B%0D%0A%20%20%20%20return%20allowedGroups.indexOf(g)%20!%3D%3D%20-1%3B%0D%0A%7D%0D%0A%0D%0Afunction%20getPermissions(query%3A%20%7B%20group%3A%20GROUP_TYPE%20%7D)%20%7B%2F*%20do%20something%20*%2F%20%7D%0D%0A%0D%0Afunction%20goodFunction(query%3A%20%7B%20group%3A%20string%20%7D)%20%7B%0D%0A%20%20%20%20if%20(!isGroup(query.group))%0D%0A%20%20%20%20%20%20%20%20return%3B%0D%0A%0D%0A%20%20%20%20const%20%7B%20group%20%7D%20%3D%20query%3B%0D%0A%0D%0A%20%20%20%20return%20getPermissions(%7B%20...query%2C%20group%20%7D)%3B%0D%0A%7D%0D%0A%0D%0Afunction%20sameFunction(query%3A%20%7B%20group%3A%20string%20%7D)%20%7B%0D%0A%20%20%20%20if%20(!isGroup(query.group))%0D%0A%20%20%20%20%20%20%20%20return%3B%0D%0A%0D%0A%20%20%20%20return%20getPermissions(query)%3B%0D%0A%7D)\r\n\r\n\r\n","author":{"url":"https://github.com/tomfun","@type":"Person","name":"tomfun"},"datePublished":"2019-06-04T10:29:48Z","url":"https://github.com/microsoft/TypeScript/issues/31755"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:a4e1dce7-9de8-cfba-6334-1feec326a58a
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC60C:A20F9:BDCC1F:FDAC47:6B00F250
html-safe-nonce76a5040c54d455c61e6e9769e19491add43e024b0f15eb4e2c85168f7c4e0939
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjBDOkEyMEY5OkJEQ0MxRjpGREFDNDc6NkIwMEYyNTAiLCJ2aXNpdG9yX2lkIjoiNjE2NTc5OTM3MTk3Njc5ODgwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac4dbc4e9d2639bcc2f494b5a6773a029da7ef3046730b3a7e3d92d1e192848418
hovercard-subject-tagissue:451918798
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/31755/issue_layout
twitter:imagehttps://opengraph.githubassets.com/df238ddcd813ae67b6709eb685abafbc63ca6777870f552e6fd2bec72759c5f5/microsoft/TypeScript/issues/31755
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/df238ddcd813ae67b6709eb685abafbc63ca6777870f552e6fd2bec72759c5f5/microsoft/TypeScript/issues/31755
og:image:altTypeScript Version: 3.4.5 Search Terms: type guard object destructuring, type guard object key Code export type GROUP_TYPE = 'group_1' | 'group_2'; export function isGroup(g: any): g is GROUP_TYPE ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametomfun
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/31755#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F31755
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F31755
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/31755
Reloadhttps://github.com/microsoft/TypeScript/issues/31755
Reloadhttps://github.com/microsoft/TypeScript/issues/31755
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/31755
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/31755
Type guard fails for a part of an objecthttps://github.com/microsoft/TypeScript/issues/31755#top
DuplicateAn existing issue was already createdhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Duplicate%22
https://github.com/tomfun
Greg (tomfun)https://github.com/tomfun
on Jun 4, 2019https://github.com/microsoft/TypeScript/issues/31755#issue-451918798
link to playgroundhttps://www.typescriptlang.org/play/#src=export%20type%20GROUP_TYPE%20%3D%20'group_1'%20%7C%20'group_2'%3B%0D%0A%0D%0Aexport%20function%20isGroup(g%3A%20any)%3A%20g%20is%20GROUP_TYPE%20%7B%0D%0A%20%20%20%20const%20allowedGroups%3A%20GROUP_TYPE%5B%5D%20%3D%20%5B'group_1'%2C%20'group_2'%5D%3B%0D%0A%20%20%20%20return%20allowedGroups.indexOf(g)%20!%3D%3D%20-1%3B%0D%0A%7D%0D%0A%0D%0Afunction%20getPermissions(query%3A%20%7B%20group%3A%20GROUP_TYPE%20%7D)%20%7B%2F*%20do%20something%20*%2F%20%7D%0D%0A%0D%0Afunction%20goodFunction(query%3A%20%7B%20group%3A%20string%20%7D)%20%7B%0D%0A%20%20%20%20if%20(!isGroup(query.group))%0D%0A%20%20%20%20%20%20%20%20return%3B%0D%0A%0D%0A%20%20%20%20const%20%7B%20group%20%7D%20%3D%20query%3B%0D%0A%0D%0A%20%20%20%20return%20getPermissions(%7B%20...query%2C%20group%20%7D)%3B%0D%0A%7D%0D%0A%0D%0Afunction%20sameFunction(query%3A%20%7B%20group%3A%20string%20%7D)%20%7B%0D%0A%20%20%20%20if%20(!isGroup(query.group))%0D%0A%20%20%20%20%20%20%20%20return%3B%0D%0A%0D%0A%20%20%20%20return%20getPermissions(query)%3B%0D%0A%7D
https://github.com/jack-williams
Jack Williams (jack-williams)https://github.com/jack-williams
on Jun 4, 2019https://github.com/microsoft/TypeScript/issues/31755#issuecomment-498669080
commenthttps://github.com/microsoft/TypeScript/issues/30506#issuecomment-474802840
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
DuplicateAn existing issue was already createdhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Duplicate%22
on Jun 4, 2019https://github.com/microsoft/TypeScript/issues/31755#event-2388610746
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
on Jun 6, 2019https://github.com/microsoft/TypeScript/issues/31755#issuecomment-499602652
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jun 6, 2019https://github.com/microsoft/TypeScript/issues/31755#event-2395176636
microsofthttps://github.com/microsoft
on Oct 21, 2025https://github.com/microsoft/TypeScript/issues/31755#event-20416694122
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/31755
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/31755
DuplicateAn existing issue was already createdhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Duplicate%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.