Title: Type guard fails for a part of an object · Issue #31755 · microsoft/TypeScript · GitHub
Open Graph Title: Type guard fails for a part of an object · Issue #31755 · microsoft/TypeScript
X Title: Type guard fails for a part of an object · Issue #31755 · microsoft/TypeScript
Description: TypeScript Version: 3.4.5 Search Terms: type guard object destructuring, type guard object key Code export type GROUP_TYPE = 'group_1' | 'group_2'; export function isGroup(g: any): g is GROUP_TYPE { const allowedGroups: GROUP_TYPE[] = ['...
Open Graph Description: TypeScript Version: 3.4.5 Search Terms: type guard object destructuring, type guard object key Code export type GROUP_TYPE = 'group_1' | 'group_2'; export function isGroup(g: any): g is GROUP_TYPE ...
X Description: TypeScript Version: 3.4.5 Search Terms: type guard object destructuring, type guard object key Code export type GROUP_TYPE = 'group_1' | 'group_2'; export function isGroup(g: any): ...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/31755
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Type guard fails for a part of an object","articleBody":"**TypeScript Version:** 3.4.5\r\n\r\n**Search Terms:** type guard object destructuring, type guard object key\r\n\r\n**Code**\r\n```ts\r\nexport type GROUP_TYPE = 'group_1' | 'group_2';\r\n\r\nexport function isGroup(g: any): g is GROUP_TYPE {\r\n const allowedGroups: GROUP_TYPE[] = ['group_1', 'group_2'];\r\n return allowedGroups.indexOf(g) !== -1;\r\n}\r\n\r\nfunction getPermissions(query: { group: GROUP_TYPE }) {/* do something */ }\r\n\r\nfunction goodFunction(query: { group: string }) {\r\n if (!isGroup(query.group))\r\n return;\r\n\r\n const { group } = query;\r\n\r\n return getPermissions({ ...query, group });\r\n}\r\n\r\nfunction sameFunction(query: { group: string }) {\r\n if (!isGroup(query.group))\r\n return;\r\n\r\n return getPermissions(query); // Error here\r\n // _________________^^^^^\r\n/*\r\nArgument of type '{ group: string; }' is not assignable to parameter of type '{ group: GROUP_TYPE; }'.\r\n ...\r\n*/\r\n}\r\n```\r\n\r\n**Expected behavior:**\r\nBoth functions (goodFunction, sameFunction) should be valid typescript code\r\n\r\n**Actual behavior:**\r\nWe see TS error\r\n```\r\nArgument of type '{ group: string; }' is not assignable to parameter of type '{ group: GROUP_TYPE; }'.\r\n Types of property 'group' are incompatible.\r\n Type 'string' is not assignable to type 'GROUP_TYPE'.\r\n```\r\nit thinks that `query.group` is steel a `string` when passing as arguments, but knows it is a `GROUP_TYPE` when gets it from object.\r\n\r\n**Playground Link:** \r\n[link to playground](https://www.typescriptlang.org/play/#src=export%20type%20GROUP_TYPE%20%3D%20'group_1'%20%7C%20'group_2'%3B%0D%0A%0D%0Aexport%20function%20isGroup(g%3A%20any)%3A%20g%20is%20GROUP_TYPE%20%7B%0D%0A%20%20%20%20const%20allowedGroups%3A%20GROUP_TYPE%5B%5D%20%3D%20%5B'group_1'%2C%20'group_2'%5D%3B%0D%0A%20%20%20%20return%20allowedGroups.indexOf(g)%20!%3D%3D%20-1%3B%0D%0A%7D%0D%0A%0D%0Afunction%20getPermissions(query%3A%20%7B%20group%3A%20GROUP_TYPE%20%7D)%20%7B%2F*%20do%20something%20*%2F%20%7D%0D%0A%0D%0Afunction%20goodFunction(query%3A%20%7B%20group%3A%20string%20%7D)%20%7B%0D%0A%20%20%20%20if%20(!isGroup(query.group))%0D%0A%20%20%20%20%20%20%20%20return%3B%0D%0A%0D%0A%20%20%20%20const%20%7B%20group%20%7D%20%3D%20query%3B%0D%0A%0D%0A%20%20%20%20return%20getPermissions(%7B%20...query%2C%20group%20%7D)%3B%0D%0A%7D%0D%0A%0D%0Afunction%20sameFunction(query%3A%20%7B%20group%3A%20string%20%7D)%20%7B%0D%0A%20%20%20%20if%20(!isGroup(query.group))%0D%0A%20%20%20%20%20%20%20%20return%3B%0D%0A%0D%0A%20%20%20%20return%20getPermissions(query)%3B%0D%0A%7D)\r\n\r\n\r\n","author":{"url":"https://github.com/tomfun","@type":"Person","name":"tomfun"},"datePublished":"2019-06-04T10:29:48Z","url":"https://github.com/microsoft/TypeScript/issues/31755"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:a4e1dce7-9de8-cfba-6334-1feec326a58a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C60C:A20F9:BDCC1F:FDAC47:6B00F250 |
| html-safe-nonce | 76a5040c54d455c61e6e9769e19491add43e024b0f15eb4e2c85168f7c4e0939 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjBDOkEyMEY5OkJEQ0MxRjpGREFDNDc6NkIwMEYyNTAiLCJ2aXNpdG9yX2lkIjoiNjE2NTc5OTM3MTk3Njc5ODgwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 4dbc4e9d2639bcc2f494b5a6773a029da7ef3046730b3a7e3d92d1e192848418 |
| hovercard-subject-tag | issue:451918798 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/31755/issue_layout |
| twitter:image | https://opengraph.githubassets.com/df238ddcd813ae67b6709eb685abafbc63ca6777870f552e6fd2bec72759c5f5/microsoft/TypeScript/issues/31755 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/df238ddcd813ae67b6709eb685abafbc63ca6777870f552e6fd2bec72759c5f5/microsoft/TypeScript/issues/31755 |
| og:image:alt | TypeScript Version: 3.4.5 Search Terms: type guard object destructuring, type guard object key Code export type GROUP_TYPE = 'group_1' | 'group_2'; export function isGroup(g: any): g is GROUP_TYPE ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tomfun |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width