René's URL Explorer Experiment


Title: TS 3.5 new error when using keyof with assignment to copy property · Issue #31382 · microsoft/TypeScript · GitHub

Open Graph Title: TS 3.5 new error when using keyof with assignment to copy property · Issue #31382 · microsoft/TypeScript

X Title: TS 3.5 new error when using keyof with assignment to copy property · Issue #31382 · microsoft/TypeScript

Description: TypeScript Version: 3.4.0-dev.201xxxxx Search Terms: keyof property Code export interface I { x: string; y: number; } function copy(from: I, to: I, key: keyof I) { const value = from[key]; if (typeof value === 'string') { to[key] = value...

Open Graph Description: TypeScript Version: 3.4.0-dev.201xxxxx Search Terms: keyof property Code export interface I { x: string; y: number; } function copy(from: I, to: I, key: keyof I) { const value = from[key]; if (type...

X Description: TypeScript Version: 3.4.0-dev.201xxxxx Search Terms: keyof property Code export interface I { x: string; y: number; } function copy(from: I, to: I, key: keyof I) { const value = from[key]; if (type...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/31382

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"TS 3.5 new error when using keyof with assignment to copy property","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:**  3.4.0-dev.201xxxxx\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:**\r\n- keyof\r\n- property\r\n\r\n\r\n**Code**\r\n\r\n```ts\r\nexport interface I {\r\n    x: string;\r\n    y: number;\r\n}\r\n\r\nfunction copy(from: I, to: I, key: keyof I) {\r\n    const value = from[key];\r\n    if (typeof value === 'string') {\r\n        to[key] = value\r\n    }\r\n} \r\n```\r\n\r\n**Expected behavior:**\r\nThis compiles under TS 3.4.5 without any errors\r\n\r\n**Actual behavior:**\r\nIn TS 3.5, this is a compile error: \r\n\r\n```\r\nType 'string' is not assignable to type 'string & number'.\r\n  Type 'string' is not assignable to type 'number'.\r\n```\r\n\r\nThis is a reasonable error IMO, the change should just be noted somewhere (an issue may already exist but I wasn't sure which keywords to search for). We saw this in the VS Code codebase\r\n\r\n**Playground Link:** \u003c!-- A link to a TypeScript Playground \"Share\" link which demonstrates this behavior -->\r\n\r\nhttps://www.typescriptlang.org/play/#src=export%20interface%20I%20%7B%0D%0A%20%20%20%20x%3A%20string%3B%0D%0A%20%20%20%20y%3A%20number%3B%0D%0A%7D%0D%0A%0D%0Afunction%20copy(from%3A%20I%2C%20to%3A%20I%2C%20key%3A%20keyof%20I)%20%7B%0D%0A%20%20%20%20const%20value%20%3D%20from%5Bkey%5D%3B%0D%0A%20%20%20%20if%20(typeof%20value%20%3D%3D%3D%20'string')%20%7B%0D%0A%20%20%20%20%20%20%20%20to%5Bkey%5D%20%3D%20value%0D%0A%20%20%20%20%7D%0D%0A%7D%20\r\n\r\n**Related Issues:** \u003c!-- Did you find other bugs that looked similar? -->\r\n- #31380","author":{"url":"https://github.com/mjbvz","@type":"Person","name":"mjbvz"},"datePublished":"2019-05-13T23:25:38Z","url":"https://github.com/microsoft/TypeScript/issues/31382"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:63da0caf-82a3-8037-658e-0c8020812458
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB4E2:117C62:8E3C36:BF9B56:6B00E63C
html-safe-nonce6c70bf5e926eded466a6f2485af1302c2758de637818739f02118d487c8fc386
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEUyOjExN0M2Mjo4RTNDMzY6QkY5QjU2OjZCMDBFNjNDIiwidmlzaXRvcl9pZCI6IjgwODI0NDY0MjkyNDA0ODU0MzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac669b8fe2c2a83f9aa6a6fbb7e17fa276f278a3a760829eb8ab16893805975aff
hovercard-subject-tagissue:443643887
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/31382/issue_layout
twitter:imagehttps://opengraph.githubassets.com/8a5cf90b555e177000388fe88c568226d62cd8fb5fb2bf397a85b41d98b018fc/microsoft/TypeScript/issues/31382
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8a5cf90b555e177000388fe88c568226d62cd8fb5fb2bf397a85b41d98b018fc/microsoft/TypeScript/issues/31382
og:image:altTypeScript Version: 3.4.0-dev.201xxxxx Search Terms: keyof property Code export interface I { x: string; y: number; } function copy(from: I, to: I, key: keyof I) { const value = from[key]; if (type...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemjbvz
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/31382#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F31382
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F31382
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/31382
Reloadhttps://github.com/microsoft/TypeScript/issues/31382
Reloadhttps://github.com/microsoft/TypeScript/issues/31382
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/31382
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/31382
TS 3.5 new error when using keyof with assignment to copy propertyhttps://github.com/microsoft/TypeScript/issues/31382#top
Breaking ChangeWould introduce errors in existing codehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Breaking%20Change%22
TypeScript 3.6.0https://github.com/microsoft/TypeScript/milestone/93
https://github.com/mjbvz
Matt Bierner (mjbvz)https://github.com/mjbvz
on May 13, 2019https://github.com/microsoft/TypeScript/issues/31382#issue-443643887
https://www.typescriptlang.org/play/#src=export%20interface%20I%20%7B%0D%0A%20%20%20%20x%3A%20string%3B%0D%0A%20%20%20%20y%3A%20number%3B%0D%0A%7D%0D%0A%0D%0Afunction%20copy(from%3A%20I%2C%20to%3A%20I%2C%20key%3A%20keyof%20I)%20%7B%0D%0A%20%20%20%20const%20value%20%3D%20from%5Bkey%5D%3B%0D%0A%20%20%20%20if%20(typeof%20value%20%3D%3D%3D%20'string')%20%7B%0D%0A%20%20%20%20%20%20%20%20to%5Bkey%5D%20%3D%20value%0D%0A%20%20%20%20%7D%0D%0A%7D%20https://www.typescriptlang.org/play/#src=export%20interface%20I%20%7B%0D%0A%20%20%20%20x%3A%20string%3B%0D%0A%20%20%20%20y%3A%20number%3B%0D%0A%7D%0D%0A%0D%0Afunction%20copy(from%3A%20I%2C%20to%3A%20I%2C%20key%3A%20keyof%20I)%20%7B%0D%0A%20%20%20%20const%20value%20%3D%20from%5Bkey%5D%3B%0D%0A%20%20%20%20if%20(typeof%20value%20%3D%3D%3D%20'string')%20%7B%0D%0A%20%20%20%20%20%20%20%20to%5Bkey%5D%20%3D%20value%0D%0A%20%20%20%20%7D%0D%0A%7D%20
TypeScript 3.5 compile errors in the VS Code codebase #31380https://github.com/microsoft/TypeScript/issues/31380
https://github.com/jack-williams
Jack Williams (jack-williams)https://github.com/jack-williams
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31382#issuecomment-492029636
#30769https://github.com/microsoft/TypeScript/pull/30769
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Breaking ChangeWould introduce errors in existing codehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Breaking%20Change%22
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31382#event-2341717218
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
TypeScript 3.5.0https://github.com/microsoft/TypeScript/milestone/89
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31382#event-2341717275
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
TypeScript 3.5.0https://github.com/microsoft/TypeScript/milestone/89
TypeScript 3.6.0https://github.com/microsoft/TypeScript/milestone/93
on Jun 12, 2019https://github.com/microsoft/TypeScript/issues/31382#event-2407838342
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jun 12, 2019https://github.com/microsoft/TypeScript/issues/31382#event-2407881091
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/31382
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/31382
Breaking ChangeWould introduce errors in existing codehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Breaking%20Change%22
TypeScript 3.6.0https://github.com/microsoft/TypeScript/milestone/93
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.