Title: TS 3.5 new error when using keyof with assignment to copy property · Issue #31382 · microsoft/TypeScript · GitHub
Open Graph Title: TS 3.5 new error when using keyof with assignment to copy property · Issue #31382 · microsoft/TypeScript
X Title: TS 3.5 new error when using keyof with assignment to copy property · Issue #31382 · microsoft/TypeScript
Description: TypeScript Version: 3.4.0-dev.201xxxxx Search Terms: keyof property Code export interface I { x: string; y: number; } function copy(from: I, to: I, key: keyof I) { const value = from[key]; if (typeof value === 'string') { to[key] = value...
Open Graph Description: TypeScript Version: 3.4.0-dev.201xxxxx Search Terms: keyof property Code export interface I { x: string; y: number; } function copy(from: I, to: I, key: keyof I) { const value = from[key]; if (type...
X Description: TypeScript Version: 3.4.0-dev.201xxxxx Search Terms: keyof property Code export interface I { x: string; y: number; } function copy(from: I, to: I, key: keyof I) { const value = from[key]; if (type...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/31382
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"TS 3.5 new error when using keyof with assignment to copy property","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** 3.4.0-dev.201xxxxx\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:**\r\n- keyof\r\n- property\r\n\r\n\r\n**Code**\r\n\r\n```ts\r\nexport interface I {\r\n x: string;\r\n y: number;\r\n}\r\n\r\nfunction copy(from: I, to: I, key: keyof I) {\r\n const value = from[key];\r\n if (typeof value === 'string') {\r\n to[key] = value\r\n }\r\n} \r\n```\r\n\r\n**Expected behavior:**\r\nThis compiles under TS 3.4.5 without any errors\r\n\r\n**Actual behavior:**\r\nIn TS 3.5, this is a compile error: \r\n\r\n```\r\nType 'string' is not assignable to type 'string & number'.\r\n Type 'string' is not assignable to type 'number'.\r\n```\r\n\r\nThis is a reasonable error IMO, the change should just be noted somewhere (an issue may already exist but I wasn't sure which keywords to search for). We saw this in the VS Code codebase\r\n\r\n**Playground Link:** \u003c!-- A link to a TypeScript Playground \"Share\" link which demonstrates this behavior -->\r\n\r\nhttps://www.typescriptlang.org/play/#src=export%20interface%20I%20%7B%0D%0A%20%20%20%20x%3A%20string%3B%0D%0A%20%20%20%20y%3A%20number%3B%0D%0A%7D%0D%0A%0D%0Afunction%20copy(from%3A%20I%2C%20to%3A%20I%2C%20key%3A%20keyof%20I)%20%7B%0D%0A%20%20%20%20const%20value%20%3D%20from%5Bkey%5D%3B%0D%0A%20%20%20%20if%20(typeof%20value%20%3D%3D%3D%20'string')%20%7B%0D%0A%20%20%20%20%20%20%20%20to%5Bkey%5D%20%3D%20value%0D%0A%20%20%20%20%7D%0D%0A%7D%20\r\n\r\n**Related Issues:** \u003c!-- Did you find other bugs that looked similar? -->\r\n- #31380","author":{"url":"https://github.com/mjbvz","@type":"Person","name":"mjbvz"},"datePublished":"2019-05-13T23:25:38Z","url":"https://github.com/microsoft/TypeScript/issues/31382"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:63da0caf-82a3-8037-658e-0c8020812458 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B4E2:117C62:8E3C36:BF9B56:6B00E63C |
| html-safe-nonce | 6c70bf5e926eded466a6f2485af1302c2758de637818739f02118d487c8fc386 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEUyOjExN0M2Mjo4RTNDMzY6QkY5QjU2OjZCMDBFNjNDIiwidmlzaXRvcl9pZCI6IjgwODI0NDY0MjkyNDA0ODU0MzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 669b8fe2c2a83f9aa6a6fbb7e17fa276f278a3a760829eb8ab16893805975aff |
| hovercard-subject-tag | issue:443643887 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/31382/issue_layout |
| twitter:image | https://opengraph.githubassets.com/8a5cf90b555e177000388fe88c568226d62cd8fb5fb2bf397a85b41d98b018fc/microsoft/TypeScript/issues/31382 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/8a5cf90b555e177000388fe88c568226d62cd8fb5fb2bf397a85b41d98b018fc/microsoft/TypeScript/issues/31382 |
| og:image:alt | TypeScript Version: 3.4.0-dev.201xxxxx Search Terms: keyof property Code export interface I { x: string; y: number; } function copy(from: I, to: I, key: keyof I) { const value = from[key]; if (type... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mjbvz |
| hostname | github.com |
| expected-hostname | github.com |
| None | 27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 624179fb8b88d26ba5bba08894eb60a1c5a1d93d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width