René's URL Explorer Experiment


Title: TypeScript 3.5 compile errors in the VS Code codebase · Issue #31380 · microsoft/TypeScript · GitHub

Open Graph Title: TypeScript 3.5 compile errors in the VS Code codebase · Issue #31380 · microsoft/TypeScript

X Title: TypeScript 3.5 compile errors in the VS Code codebase · Issue #31380 · microsoft/TypeScript

Description: TypeScript Version: 3.5.0-dev.20190512 Repo Build VS Code with TypeScript@next: git clone https://github.com/microsoft/vscode.git cd vscode yarn add typescript@next yarn run watch Potential issues There are 68 compile errors on TS@next, ...

Open Graph Description: TypeScript Version: 3.5.0-dev.20190512 Repo Build VS Code with TypeScript@next: git clone https://github.com/microsoft/vscode.git cd vscode yarn add typescript@next yarn run watch Potential issues ...

X Description: TypeScript Version: 3.5.0-dev.20190512 Repo Build VS Code with TypeScript@next: git clone https://github.com/microsoft/vscode.git cd vscode yarn add typescript@next yarn run watch Potential issues ...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/31380

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"TypeScript 3.5 compile errors in the VS Code codebase","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:**  3.5.0-dev.20190512\r\n\r\n**Repo**\r\nBuild VS Code with TypeScript@next:\r\n\r\n```bash\r\ngit clone https://github.com/microsoft/vscode.git\r\ncd vscode\r\nyarn add typescript@next\r\nyarn run watch\r\n```\r\n\r\n**Potential issues**\r\nThere are 68 compile errors on `TS@next`, compared to zero when compiling with `TS@3.4.5`:\r\n\r\n```\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/welcome/walkThrough/browser/editor/editorWalkThrough.ts(53,9): Property 'deserialize' in type 'EditorWalkThroughInputFactory' is not assignable to the same property in base type 'IEditorInputFactory'.\r\n  Type '(instantiationService: IInstantiationService, serializedEditorInput: string) => WalkThroughInput' is not assignable to type '(instantiationService: IInstantiationService, serializedEditorInput: string) => EditorInput | undefined'.\r\n    Type 'WalkThroughInput' is not assignable to type 'EditorInput'.\r\n      Types of property 'getTelemetryDescriptor' are incompatible.\r\n        Type '() => object' is not assignable to type '() => { [key: string]: unknown; }'.\r\n          Type 'object' is not assignable to type '{ [key: string]: unknown; }'.\r\n            Index signature is missing in type '{}'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/welcome/walkThrough/common/walkThroughInput.ts(83,2): Property 'getTelemetryDescriptor' in type 'WalkThroughInput' is not assignable to the same property in base type 'EditorInput'.\r\n  Type '() => object' is not assignable to type '() => { [key: string]: unknown; }'.\r\n    Type 'object' is not assignable to type '{ [key: string]: unknown; }'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/welcome/walkThrough/browser/walkThroughPart.ts(254,2): Property 'setInput' in type 'WalkThroughPart' is not assignable to the same property in base type 'BaseEditor'.\r\n  Type '(input: WalkThroughInput, options: EditorOptions, token: CancellationToken) => Promise\u003cvoid>' is not assignable to type '(input: EditorInput, options: EditorOptions | null, token: CancellationToken) => Promise\u003cvoid>'.\r\n    Types of parameters 'input' and 'input' are incompatible.\r\n      Type 'EditorInput' is missing the following properties from type 'WalkThroughInput': disposables, promise, maxTopScroll, maxBottomScroll, and 5 more.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/welcome/walkThrough/browser/walkThroughPart.ts(262,25): Argument of type 'WalkThroughInput' is not assignable to parameter of type 'EditorInput'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/welcome/walkThrough/browser/walkThroughPart.ts(266,10): Parameter 'model' implicitly has an 'any' type.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/welcome/walkThrough/browser/walkThroughPart.ts(298,29): Parameter 'snippet' implicitly has an 'any' type.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/welcome/walkThrough/browser/walkThroughPart.ts(298,38): Parameter 'i' implicitly has an 'any' type.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/welcome/walkThrough/browser/walkThroughPart.ts(481,51): Argument of type 'WalkThroughInput' is not assignable to parameter of type 'EditorInput'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/welcome/walkThrough/browser/walkThroughPart.ts(492,65): Argument of type 'WalkThroughInput' is not assignable to parameter of type 'EditorInput'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/welcome/walkThrough/browser/walkThrough.contribution.ts(24,3): Argument of type 'typeof WalkThroughPart' is not assignable to parameter of type 'IConstructorSignature0\u003cBaseEditor>'.\r\n  Type 'WalkThroughPart' is not assignable to type 'BaseEditor'.\r\n    Types of property 'setInput' are incompatible.\r\n      Type '(input: WalkThroughInput, options: EditorOptions, token: CancellationToken) => Promise\u003cvoid>' is not assignable to type '(input: EditorInput, options: EditorOptions | null, token: CancellationToken) => Promise\u003cvoid>'.\r\n        Types of parameters 'input' and 'input' are incompatible.\r\n          Type 'EditorInput' is not assignable to type 'WalkThroughInput'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/welcome/walkThrough/browser/walkThrough.contribution.ts(35,147): Argument of type 'typeof EditorWalkThroughInputFactory' is not assignable to parameter of type 'IConstructorSignature0\u003cIEditorInputFactory>'.\r\n  Type 'EditorWalkThroughInputFactory' is not assignable to type 'IEditorInputFactory'.\r\n    Types of property 'deserialize' are incompatible.\r\n      Type '(instantiationService: IInstantiationService, serializedEditorInput: string) => WalkThroughInput' is not assignable to type '(instantiationService: IInstantiationService, serializedEditorInput: string) => EditorInput | undefined'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/welcome/page/browser/welcomePage.ts(610,9): Property 'deserialize' in type 'WelcomeInputFactory' is not assignable to the same property in base type 'IEditorInputFactory'.\r\n  Type '(instantiationService: IInstantiationService, serializedEditorInput: string) => WalkThroughInput' is not assignable to type '(instantiationService: IInstantiationService, serializedEditorInput: string) => EditorInput | undefined'.\r\n    Type 'WalkThroughInput' is not assignable to type 'EditorInput'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/welcome/page/browser/welcomePage.contribution.ts(45,132): Argument of type 'typeof WelcomeInputFactory' is not assignable to parameter of type 'IConstructorSignature0\u003cIEditorInputFactory>'.\r\n  Type 'WelcomeInputFactory' is not assignable to type 'IEditorInputFactory'.\r\n    Types of property 'deserialize' are incompatible.\r\n      Type '(instantiationService: IInstantiationService, serializedEditorInput: string) => WalkThroughInput' is not assignable to type '(instantiationService: IInstantiationService, serializedEditorInput: string) => EditorInput | undefined'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/services/themes/common/fileIconThemeData.ts(121,7): Type 'any' is not assignable to type 'never'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/services/themes/common/colorThemeData.ts(254,7): Type 'any' is not assignable to type 'never'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/services/keybinding/common/keybindingEditing.ts(213,17): Object is of type 'unknown'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/services/extensions/node/extensionPoints.ts(292,16): Property 'hasOwnProperty' does not exist on type 'T'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/services/editor/browser/editorService.ts(510,4): Type 'SideBySideEditorInput' is not assignable to type 'EditorInput'.\r\n  Types of property 'getTelemetryDescriptor' are incompatible.\r\n    Type '() => object' is not assignable to type '() => { [key: string]: unknown; }'.\r\n      Type 'object' is not assignable to type '{ [key: string]: unknown; }'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/services/editor/browser/editorService.ts(525,4): Type 'DiffEditorInput' is not assignable to type 'EditorInput'.\r\n  Types of property 'getTelemetryDescriptor' are incompatible.\r\n    Type '() => object' is not assignable to type '() => { [key: string]: unknown; }'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/test/common/editor/editorGroups.test.ts(213,31): Argument of type 'DiffEditorInput' is not assignable to parameter of type 'EditorInput'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/test/common/editor/editorGroups.test.ts(214,31): Argument of type 'DiffEditorInput' is not assignable to parameter of type 'EditorInput'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/tasks/common/problemMatcher.ts(268,4): Type 'string' is not assignable to type 'undefined'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/tasks/common/problemMatcher.ts(280,5): Type 'string' is not assignable to type 'undefined'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/tasks/common/problemMatcher.ts(899,5): Type 'number' is not assignable to type 'undefined & RegExp'.\r\n  Type 'number' is not assignable to type 'undefined'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/search/browser/searchView.ts(647,66): Argument of type 'ITreeContextMenuEvent\u003cFileMatch | Match | BaseFolderMatch | FolderMatch | null>' is not assignable to parameter of type 'ITreeContextMenuEvent\u003cRenderableMatch>'.\r\n  Type 'FileMatch | Match | BaseFolderMatch | FolderMatch | null' is not assignable to type 'RenderableMatch'.\r\n    Type 'null' is not assignable to type 'RenderableMatch'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/preferences/electron-browser/preferences.contribution.ts(49,3): Argument of type 'typeof PreferencesEditor' is not assignable to parameter of type 'IConstructorSignature0\u003cBaseEditor>'.\r\n  Type 'PreferencesEditor' is not assignable to type 'BaseEditor'.\r\n    Types of property 'setInput' are incompatible.\r\n      Type '(newInput: PreferencesEditorInput, options: SettingsEditorOptions, token: CancellationToken) => Promise\u003cvoid>' is not assignable to type '(input: EditorInput, options: EditorOptions | null, token: CancellationToken) => Promise\u003cvoid>'.\r\n        Types of parameters 'newInput' and 'input' are incompatible.\r\n          Type 'EditorInput' is missing the following properties from type 'PreferencesEditorInput': name, description, _details, _master, and 3 more.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/preferences/electron-browser/preferences.contribution.ts(134,5): Type 'PreferencesEditorInput' is not assignable to type 'EditorInput'.\r\n  Types of property 'getTelemetryDescriptor' are incompatible.\r\n    Type '() => object' is not assignable to type '() => { [key: string]: unknown; }'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/preferences/browser/preferencesEditor.ts(157,2): Property 'setInput' in type 'PreferencesEditor' is not assignable to the same property in base type 'BaseEditor'.\r\n  Type '(newInput: PreferencesEditorInput, options: SettingsEditorOptions, token: CancellationToken) => Promise\u003cvoid>' is not assignable to type '(input: EditorInput, options: EditorOptions | null, token: CancellationToken) => Promise\u003cvoid>'.\r\n    Types of parameters 'newInput' and 'input' are incompatible.\r\n      Type 'EditorInput' is not assignable to type 'PreferencesEditorInput'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/preferences/browser/preferencesEditor.ts(164,25): Argument of type 'PreferencesEditorInput' is not assignable to parameter of type 'EditorInput'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/output/browser/outputPanel.ts(100,8): Object is of type 'unknown'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/output/browser/outputPanel.ts(103,29): Object is of type 'unknown'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/output/browser/outputPanel.ts(104,24): Object is of type 'unknown'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/extensions/electron-browser/extensionTipsService.ts(975,83): Object is of type 'unknown'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/extensions/electron-browser/extensionTipsService.ts(975,121): Object is of type 'unknown'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/experiments/node/experimentService.ts(181,36): Object is of type 'unknown'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/experiments/node/experimentService.ts(181,61): Object is of type 'unknown'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/contrib/debug/electron-browser/debugService.ts(746,8): Argument of type 'unknown' is not assignable to parameter of type 'ITaskSummary | Thenable\u003cITaskSummary | null> | null | undefined'.\r\n  Type 'unknown' is not assignable to type 'Thenable\u003cITaskSummary | null>'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/browser/parts/notifications/notificationsList.ts(222,4): Type 'string | null' is not assignable to type 'string'.\r\n  Type 'null' is not assignable to type 'string'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/browser/parts/editor/textDiffEditor.ts(164,48): Argument of type 'string | null' is not assignable to parameter of type 'string'.\r\n  Type 'null' is not assignable to type 'string'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/browser/parts/editor/tabsTitleControl.ts(713,4): Type 'null' is not assignable to type 'string'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/browser/parts/editor/tabsTitleControl.ts(714,4): Type 'null' is not assignable to type 'string'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/browser/parts/editor/tabsTitleControl.ts(715,4): Type 'string | null' is not assignable to type 'string'.\r\n  Type 'null' is not assignable to type 'string'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/browser/parts/editor/tabsTitleControl.ts(716,4): Type 'null' is not assignable to type 'string'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/browser/parts/editor/tabsTitleControl.ts(853,3): Type 'string | null' is not assignable to type 'string'.\r\n  Type 'null' is not assignable to type 'string'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/browser/parts/editor/sideBySideEditor.ts(96,2): Property 'setInput' in type 'SideBySideEditor' is not assignable to the same property in base type 'BaseEditor'.\r\n  Type '(newInput: SideBySideEditorInput, options: EditorOptions, token: CancellationToken) => Promise\u003cvoid>' is not assignable to type '(input: EditorInput, options: EditorOptions | null, token: CancellationToken) => Promise\u003cvoid>'.\r\n    Types of parameters 'newInput' and 'input' are incompatible.\r\n      Type 'EditorInput' is missing the following properties from type 'SideBySideEditorInput': name, description, _details, _master, and 3 more.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/browser/parts/editor/sideBySideEditor.ts(98,25): Argument of type 'SideBySideEditorInput' is not assignable to parameter of type 'EditorInput'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/browser/parts/editor/editorStatus.ts(1022,48): Object is of type 'unknown'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/browser/parts/editor/editorDropTarget.ts(91,3): Type 'string | null' is not assignable to type 'string'.\r\n  Type 'null' is not assignable to type 'string'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/browser/parts/editor/editorDropTarget.ts(92,3): Type '\"-2px\" | null' is not assignable to type 'string'.\r\n  Type 'null' is not assignable to type 'string'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/browser/parts/editor/editorDropTarget.ts(93,3): Type '\"dashed\" | null' is not assignable to type 'string'.\r\n  Type 'null' is not assignable to type 'string'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/browser/parts/editor/editorDropTarget.ts(94,3): Type '\"2px\" | null' is not assignable to type 'string'.\r\n  Type 'null' is not assignable to type 'string'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/browser/parts/editor/editor.contribution.ts(84,3): Argument of type 'typeof BinaryResourceDiffEditor' is not assignable to parameter of type 'IConstructorSignature0\u003cBaseEditor>'.\r\n  Type 'BinaryResourceDiffEditor' is not assignable to type 'BaseEditor'.\r\n    Types of property 'setInput' are incompatible.\r\n      Type '(newInput: SideBySideEditorInput, options: EditorOptions, token: CancellationToken) => Promise\u003cvoid>' is not assignable to type '(input: EditorInput, options: EditorOptions | null, token: CancellationToken) => Promise\u003cvoid>'.\r\n        Types of parameters 'newInput' and 'input' are incompatible.\r\n          Type 'EditorInput' is not assignable to type 'SideBySideEditorInput'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/browser/parts/editor/editor.contribution.ts(95,3): Argument of type 'typeof SideBySideEditor' is not assignable to parameter of type 'IConstructorSignature0\u003cBaseEditor>'.\r\n  Type 'SideBySideEditor' is not assignable to type 'BaseEditor'.\r\n    Types of property 'setInput' are incompatible.\r\n      Type '(newInput: SideBySideEditorInput, options: EditorOptions, token: CancellationToken) => Promise\u003cvoid>' is not assignable to type '(input: EditorInput, options: EditorOptions | null, token: CancellationToken) => Promise\u003cvoid>'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/browser/parts/editor/editor.contribution.ts(148,52): Types of property 'language' are incompatible.\r\n  Type 'string | null' is not assignable to type 'string | undefined'.\r\n    Type 'null' is not assignable to type 'string | undefined'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/browser/parts/editor/editor.contribution.ts(209,5): Type 'SideBySideEditorInput' is not assignable to type 'EditorInput'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/browser/parts/editor/breadcrumbsPicker.ts(391,10): Conversion of type 'WorkbenchAsyncDataTree\u003cURI | IWorkspace | IWorkspaceFolder | IFileStat, URI | IWorkspace | IWorkspaceFolder | IFileStat, [number, number, number]>' to type 'WorkbenchAsyncDataTree\u003cBreadcrumbElement, any, [number, number, number]>' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.\r\n  Type 'URI | IWorkspace | IWorkspaceFolder | IFileStat' is not comparable to type 'BreadcrumbElement'.\r\n    Type 'IFileStat' is not comparable to type 'BreadcrumbElement'.\r\n      Type 'IFileStat' is missing the following properties from type 'OutlineElement': marker, id, parent, symbol, and 2 more.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/browser/parts/activitybar/activitybarPart.ts(211,3): Type '\"border-box\" | null' is not assignable to type 'string'.\r\n  Type 'null' is not assignable to type 'string'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/base/browser/ui/selectBox/selectBoxCustom.ts(399,4): Type 'string | null' is not assignable to type 'string'.\r\n  Type 'null' is not assignable to type 'string'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/platform/instantiation/common/instantiationService.ts(226,13): Object is of type 'unknown'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/platform/instantiation/common/instantiationService.ts(229,6): Object is of type 'unknown'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/editor/contrib/colorPicker/colorDetector.ts(81,26): Object is of type 'unknown'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/base/test/node/config.test.ts(27,28): Argument of type 'unknown' is not assignable to parameter of type 'object'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/common/editor.ts(569,2): Property 'getTelemetryDescriptor' in type 'SideBySideEditorInput' is not assignable to the same property in base type 'EditorInput'.\r\n  Type '() => object' is not assignable to type '() => { [key: string]: unknown; }'.\r\n    Type 'object' is not assignable to type '{ [key: string]: unknown; }'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/workbench/browser/dnd.ts(84,22): Types of property 'viewState' are incompatible.\r\n  Type 'ICodeEditorViewState | IDiffEditorViewState | null' is not assignable to type 'ICodeEditorViewState | IDiffEditorViewState | undefined'.\r\n    Type 'null' is not assignable to type 'ICodeEditorViewState | IDiffEditorViewState | undefined'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/base/common/parsers.ts(83,15): Argument of type 'T' is not assignable to parameter of type 'object'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/src/vs/base/common/objects.ts(17,14): Argument of type 'T' is not assignable to parameter of type 'object'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/extensions/typescript-language-features/src/utils/surveyor.ts(107,27): Object is of type 'unknown'.\r\n[15:39:42] Error: /Users/matb/projects/vscode/extensions/typescript-language-features/src/utils/surveyor.ts(107,41): Object is of type 'unknown'.\r\n```\r\n\r\nSome of these seem related to https://github.com/Microsoft/TypeScript/pull/30637 but other ones seem suspect (or should be noted in the breaking changes)","author":{"url":"https://github.com/mjbvz","@type":"Person","name":"mjbvz"},"datePublished":"2019-05-13T22:45:28Z","url":"https://github.com/microsoft/TypeScript/issues/31380"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:4e1076e5-60cb-93f2-3082-e1ff80ccc9c7
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC100:A99C2:908E78:BBFECC:6B00DCDD
html-safe-noncecb6694ba88d2e0ff1dc8ed37355ed6dfa13f5bb29802412a46612991965e02e6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTAwOkE5OUMyOjkwOEU3ODpCQkZFQ0M6NkIwMERDREQiLCJ2aXNpdG9yX2lkIjoiNTQxMDI4Nzc4MTA2NDc5MzMwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5e527342d6f5ed2f388b31ec438136775f7318f9c64c2cf1f9172e3e25edd322
hovercard-subject-tagissue:443633765
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/31380/issue_layout
twitter:imagehttps://opengraph.githubassets.com/69b43a8b4671327b276d01780dcb8b50342ab9a5d76acc7bb408eb486fdcf2fa/microsoft/TypeScript/issues/31380
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/69b43a8b4671327b276d01780dcb8b50342ab9a5d76acc7bb408eb486fdcf2fa/microsoft/TypeScript/issues/31380
og:image:altTypeScript Version: 3.5.0-dev.20190512 Repo Build VS Code with TypeScript@next: git clone https://github.com/microsoft/vscode.git cd vscode yarn add typescript@next yarn run watch Potential issues ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemjbvz
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/31380#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F31380
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F31380
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/31380
Reloadhttps://github.com/microsoft/TypeScript/issues/31380
Reloadhttps://github.com/microsoft/TypeScript/issues/31380
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/31380
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/31380
TypeScript 3.5 compile errors in the VS Code codebasehttps://github.com/microsoft/TypeScript/issues/31380#top
https://github.com/RyanCavanaugh
https://github.com/mjbvz
Matt Bierner (mjbvz)https://github.com/mjbvz
on May 13, 2019https://github.com/microsoft/TypeScript/issues/31380#issue-443633765
#30637https://github.com/microsoft/TypeScript/pull/30637
https://github.com/mjbvz
Matt Bierner (mjbvz)https://github.com/mjbvz
on May 13, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492015784
TS 3.5 regression casting object to { [key: string]: unknown }; #31381https://github.com/microsoft/TypeScript/issues/31381
TS 3.5 new error when using keyof with assignment to copy property #31382https://github.com/microsoft/TypeScript/issues/31382
https://github.com/mjbvz
Matt Bierner (mjbvz)https://github.com/mjbvz
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492039405
microsoft/vscode@fd1ac75https://github.com/microsoft/vscode/commit/fd1ac7561b05cdd0fdeb8a89c4eeac5eb2677226
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31380#event-2340952955
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492342850
microsoft/vscode@fd1ac75#diff-fed321a94e979ed6f2aaaf1001dbac36L17https://github.com/microsoft/vscode/commit/fd1ac7561b05cdd0fdeb8a89c4eeac5eb2677226#diff-fed321a94e979ed6f2aaaf1001dbac36L17
#27089https://github.com/microsoft/TypeScript/pull/27089
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492348977
microsoft/vscode@fd1ac75#diff-4414fa1e065d93e77c72eec3db97c187L105https://github.com/microsoft/vscode/commit/fd1ac7561b05cdd0fdeb8a89c4eeac5eb2677226#diff-4414fa1e065d93e77c72eec3db97c187L105
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492349533
microsoft/vscode@fd1ac75#diff-11b5b53dd82e487bffdf3b724fad9d83L82https://github.com/microsoft/vscode/commit/fd1ac7561b05cdd0fdeb8a89c4eeac5eb2677226#diff-11b5b53dd82e487bffdf3b724fad9d83L82
#27089https://github.com/microsoft/TypeScript/pull/27089
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492353185
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492353789
microsoft/vscode@fd1ac75#diff-6c07482b4bc75dfd16bc0d2239065809R162https://github.com/microsoft/vscode/commit/fd1ac7561b05cdd0fdeb8a89c4eeac5eb2677226#diff-6c07482b4bc75dfd16bc0d2239065809R162
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492355980
microsoft/vscode@fd1ac75#diff-1e9db0aff31fe7167a26aef6c4176a19R23https://github.com/microsoft/vscode/commit/fd1ac7561b05cdd0fdeb8a89c4eeac5eb2677226#diff-1e9db0aff31fe7167a26aef6c4176a19R23
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492356665
microsoft/vscode@fd1ac75#diff-6037e7fbd0459b235fcaf18ffc6bfba5L79https://github.com/microsoft/vscode/commit/fd1ac7561b05cdd0fdeb8a89c4eeac5eb2677226#diff-6037e7fbd0459b235fcaf18ffc6bfba5L79
#31380 (comment)https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492353789
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492357618
microsoft/vscode@fd1ac75#diff-949c71ea10759301f6b17fa57cb9a9e0L223https://github.com/microsoft/vscode/commit/fd1ac7561b05cdd0fdeb8a89c4eeac5eb2677226#diff-949c71ea10759301f6b17fa57cb9a9e0L223
#31380 (comment)https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492353789
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492361460
microsoft/vscode@fd1ac75#diff-641fa4cc338f106854e4b4a33964acbdR84https://github.com/microsoft/vscode/commit/fd1ac7561b05cdd0fdeb8a89c4eeac5eb2677226#diff-641fa4cc338f106854e4b4a33964acbdR84
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492364142
microsoft/vscode@fd1ac75#diff-b7604f54db2a2f61d2bf5af1fcc5047fL391https://github.com/microsoft/vscode/commit/fd1ac7561b05cdd0fdeb8a89c4eeac5eb2677226#diff-b7604f54db2a2f61d2bf5af1fcc5047fL391
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492364255
#31380https://github.com/microsoft/TypeScript/issues/31380
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492365619
microsoft/vscode@fd1ac75#diff-1ba53e60093143b29593e77afffaacb6L1036https://github.com/microsoft/vscode/commit/fd1ac7561b05cdd0fdeb8a89c4eeac5eb2677226#diff-1ba53e60093143b29593e77afffaacb6L1036
microsoft/vscode@fd1ac75#diff-0b973b67f859d3b8fa68baec97534643R98https://github.com/microsoft/vscode/commit/fd1ac7561b05cdd0fdeb8a89c4eeac5eb2677226#diff-0b973b67f859d3b8fa68baec97534643R98
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492368875
microsoft/vscode@fd1ac75#diff-0f1abf8ff5283dac48ea3231f2dddfa0R96https://github.com/microsoft/vscode/commit/fd1ac7561b05cdd0fdeb8a89c4eeac5eb2677226#diff-0f1abf8ff5283dac48ea3231f2dddfa0R96
microsoft/vscode@fd1ac75#diff-d6d4527bd487a54f95c554d21f5e05ebhttps://github.com/microsoft/vscode/commit/fd1ac7561b05cdd0fdeb8a89c4eeac5eb2677226#diff-d6d4527bd487a54f95c554d21f5e05eb
microsoft/vscode@fd1ac75#diff-022291e875d46b01fc7f4e6ba724f466https://github.com/microsoft/vscode/commit/fd1ac7561b05cdd0fdeb8a89c4eeac5eb2677226#diff-022291e875d46b01fc7f4e6ba724f466
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492370028
microsoft/vscode@fd1ac75#diff-00578f406c825a8136fefeb491625f65L722https://github.com/microsoft/vscode/commit/fd1ac7561b05cdd0fdeb8a89c4eeac5eb2677226#diff-00578f406c825a8136fefeb491625f65L722
#31381https://github.com/microsoft/TypeScript/issues/31381
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492375228
Matt Bierner (@mjbvz)https://github.com/mjbvz
#30769https://github.com/microsoft/TypeScript/pull/30769
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492376222
microsoft/vscode@fd1ac75#diff-00578f406c825a8136fefeb491625f65L722https://github.com/microsoft/vscode/commit/fd1ac7561b05cdd0fdeb8a89c4eeac5eb2677226#diff-00578f406c825a8136fefeb491625f65L722
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492377922
microsoft/vscode@fd1ac75#diff-4a12537872685c49f4dc5c42f1537c45https://github.com/microsoft/vscode/commit/fd1ac7561b05cdd0fdeb8a89c4eeac5eb2677226#diff-4a12537872685c49f4dc5c42f1537c45
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on May 14, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492381510
microsoft/vscode@fd1ac75#diff-203c27e756d1503a7f55c19fd8440959R268https://github.com/microsoft/vscode/commit/fd1ac7561b05cdd0fdeb8a89c4eeac5eb2677226#diff-203c27e756d1503a7f55c19fd8440959R268
https://github.com/mjbvz
Matt Bierner (mjbvz)https://github.com/mjbvz
on May 15, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492459291
#31380 (comment)https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492361460
#27089https://github.com/microsoft/TypeScript/pull/27089
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on May 15, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-492781043
https://github.com/mjbvz
Matt Bierner (mjbvz)https://github.com/mjbvz
on May 24, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-495805689
Matt Bierner (mjbvz)https://github.com/mjbvz
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on May 24, 2019https://github.com/microsoft/TypeScript/issues/31380#event-2366820672
https://github.com/NoelAbrahams
Noel Abrahams (NoelAbrahams)https://github.com/NoelAbrahams
on Jun 5, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-498978123
Matt Bierner (@mjbvz)https://github.com/mjbvz
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
on Jun 5, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-498981979
https://github.com/NoelAbrahams
Noel Abrahams (NoelAbrahams)https://github.com/NoelAbrahams
on Jun 5, 2019https://github.com/microsoft/TypeScript/issues/31380#issuecomment-499024226
Wesley Wigham (@weswigham)https://github.com/weswigham
microsofthttps://github.com/microsoft
on Oct 21, 2025https://github.com/microsoft/TypeScript/issues/31380#event-20416677676
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/31380
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/31380
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.