René's URL Explorer Experiment


Title: react-redux type inference is broken since v3.1 · Issue #30874 · microsoft/TypeScript · GitHub

Open Graph Title: react-redux type inference is broken since v3.1 · Issue #30874 · microsoft/TypeScript

X Title: react-redux type inference is broken since v3.1 · Issue #30874 · microsoft/TypeScript

Description: TypeScript Version: 3.1.0-dev.20180810 Search Terms: react-redux connect type inference I've noticed this issue while upgrading from v3.0.3. Type inferrence got broken on some of redux's connect calls. I was able to isolate the issue (se...

Open Graph Description: TypeScript Version: 3.1.0-dev.20180810 Search Terms: react-redux connect type inference I've noticed this issue while upgrading from v3.0.3. Type inferrence got broken on some of redux's connect ca...

X Description: TypeScript Version: 3.1.0-dev.20180810 Search Terms: react-redux connect type inference I've noticed this issue while upgrading from v3.0.3. Type inferrence got broken on some of redux's co...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/30874

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"react-redux type inference is broken since v3.1","articleBody":"\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:**  3.1.0-dev.20180810\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** react-redux connect type inference\r\n\r\nI've noticed this issue while upgrading from v3.0.3. Type inferrence got broken on some of redux's `connect` calls. I was able to isolate the issue (see the code below). The issue is reproducible on `@next` and `@latest`. I ran some regression tests and was able to narrow it down to `3.1.0-dev.20180810` where the bug was introduced. The last version where the code works as expected was `3.1.0-dev.20180809`.\r\n\r\n**Code**\r\n\r\n```ts\r\ntype MapStateToProps\u003cTStateProps> = () => TStateProps;\r\n\r\ntype MergeProps\u003cTStateProps, TMergedProps> = (stateProps: TStateProps) => TMergedProps;\r\n\r\nfunction connect\u003cTStateProps = {}, TMergedProps = {}>(\r\n   mapStateToProps: MapStateToProps\u003cTStateProps>,\r\n   mergeProps: MergeProps\u003cTStateProps, TMergedProps>) {\r\n}\r\n\r\nconnect(() => ({ time: 123 }), ({ time }) => ({\r\n   time,\r\n   doSomething() {\r\n   },\r\n}))\r\n```\r\n\r\n**Expected behavior:** compiles without errors\r\n\r\n**Actual behavior:** `error TS2459: Type 'TStateProps' has no property 'time' and no string index signature.`\r\n\r\n**Playground Link:** [here](https://www.typescriptlang.org/play/#src=type%20MapStateToProps%3CTStateProps%3E%20%3D%20()%20%3D%3E%20TStateProps%3B%0D%0A%0D%0Atype%20MergeProps%3CTStateProps%2C%20TMergedProps%3E%20%3D%20(stateProps%3A%20TStateProps)%20%3D%3E%20TMergedProps%3B%0D%0A%0D%0Afunction%20connect%3CTStateProps%20%3D%20%7B%7D%2C%20TMergedProps%20%3D%20%7B%7D%3E(%0D%0A%20%20%20mapStateToProps%3A%20MapStateToProps%3CTStateProps%3E%2C%0D%0A%20%20%20mergeProps%3A%20MergeProps%3CTStateProps%2C%20TMergedProps%3E)%20%7B%0D%0A%7D%0D%0A%0D%0Aconnect(()%20%3D%3E%20(%7B%20time%3A%20123%20%7D)%2C%20(%7B%20time%20%7D)%20%3D%3E%20%7B%0D%0A%20%20%20return%20%7B%0D%0A%20%20%20%20%20%20time%2C%0D%0A%20%20%20%20%20%20doSomething()%20%7B%0D%0A%20%20%20%20%20%20%7D%2C%0D%0A%20%20%20%7D%0D%0A%7D)%0D%0A%0D%0Aconnect(()%20%3D%3E%20(%7B%20time%3A%20123%20%7D)%2C%20(%7B%20time%20%7D)%20%3D%3E%20(%7B%0D%0A%20%20%20doSomething()%20%7B%0D%0A%20%20%20%7D%2C%0D%0A%7D))%0D%0A%0D%0A%0D%0Aconnect(()%20%3D%3E%20(%7B%20time%3A%20123%20%7D)%2C%20(%7B%20time%20%7D)%20%3D%3E%20(%7B%0D%0A%20%20%20time%2C%0D%0A%20%20%20doSomething%3A%20()%20%3D%3E%20%7B%0D%0A%20%20%20%7D%2C%0D%0A%7D))%0D%0A%0D%0A%0D%0Aconnect(()%20%3D%3E%20(%7B%20time%3A%20123%20%7D)%2C%20(%7B%20time%20%7D)%20%3D%3E%20(%7B%0D%0A%20%20%20time%2C%0D%0A%20%20%20doSomething()%20%7B%0D%0A%20%20%20%7D%2C%0D%0A%7D))%0D%0A)\r\n\r\nSomehow these examples compile without problem though:\r\n```ts\r\n// no 'expression body' in C# terms\r\nconnect(() => ({ time: 123 }), ({ time }) => {\r\n   return {\r\n      time,\r\n      doSomething() {\r\n      },\r\n   }\r\n})\r\n\r\n// no 'time' on TMergedProps\r\nconnect(() => ({ time: 123 }), ({ time }) => ({\r\n   doSomething() {\r\n   },\r\n}))\r\n\r\n// property instead of a function\r\nconnect(() => ({ time: 123 }), ({ time }) => ({\r\n   time,\r\n   doSomething: () => {\r\n   },\r\n}))\r\n```","author":{"url":"https://github.com/Torvin","@type":"Person","name":"Torvin"},"datePublished":"2019-04-12T00:17:51Z","url":"https://github.com/microsoft/TypeScript/issues/30874"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:97cf64e8-6071-f0be-6ad9-8bfb804c84ca
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8370:172B92:28380EC:359A3B6:6B01B458
html-safe-nonce97ab367d107f446e3f67af308b960e9402d0e845abf2196f03a9ffc04e01a66a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzcwOjE3MkI5MjoyODM4MEVDOjM1OUEzQjY6NkIwMUI0NTgiLCJ2aXNpdG9yX2lkIjoiNTQ2MTEzNzg3NDU2NzE0ODYzMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf67e9411cdc785de3829d2f449bee492f9636ee03ee91bc9c7326794f553c207
hovercard-subject-tagissue:432334206
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/30874/issue_layout
twitter:imagehttps://opengraph.githubassets.com/eb0c136c615141553ef88e7aa114ed12e32197c9cde4d682e5c5e0b4fd50595d/microsoft/TypeScript/issues/30874
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/eb0c136c615141553ef88e7aa114ed12e32197c9cde4d682e5c5e0b4fd50595d/microsoft/TypeScript/issues/30874
og:image:altTypeScript Version: 3.1.0-dev.20180810 Search Terms: react-redux connect type inference I've noticed this issue while upgrading from v3.0.3. Type inferrence got broken on some of redux's connect ca...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameTorvin
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/30874#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F30874
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F30874
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/30874
Reloadhttps://github.com/microsoft/TypeScript/issues/30874
Reloadhttps://github.com/microsoft/TypeScript/issues/30874
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/30874
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/30874
react-redux type inference is broken since v3.1https://github.com/microsoft/TypeScript/issues/30874#top
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
Backloghttps://github.com/microsoft/TypeScript/milestone/29
https://github.com/Torvin
Torvinhttps://github.com/Torvin
on Apr 12, 2019https://github.com/microsoft/TypeScript/issues/30874#issue-432334206
herehttps://www.typescriptlang.org/play/#src=type%20MapStateToProps%3CTStateProps%3E%20%3D%20()%20%3D%3E%20TStateProps%3B%0D%0A%0D%0Atype%20MergeProps%3CTStateProps%2C%20TMergedProps%3E%20%3D%20(stateProps%3A%20TStateProps)%20%3D%3E%20TMergedProps%3B%0D%0A%0D%0Afunction%20connect%3CTStateProps%20%3D%20%7B%7D%2C%20TMergedProps%20%3D%20%7B%7D%3E(%0D%0A%20%20%20mapStateToProps%3A%20MapStateToProps%3CTStateProps%3E%2C%0D%0A%20%20%20mergeProps%3A%20MergeProps%3CTStateProps%2C%20TMergedProps%3E)%20%7B%0D%0A%7D%0D%0A%0D%0Aconnect(()%20%3D%3E%20(%7B%20time%3A%20123%20%7D)%2C%20(%7B%20time%20%7D)%20%3D%3E%20%7B%0D%0A%20%20%20return%20%7B%0D%0A%20%20%20%20%20%20time%2C%0D%0A%20%20%20%20%20%20doSomething()%20%7B%0D%0A%20%20%20%20%20%20%7D%2C%0D%0A%20%20%20%7D%0D%0A%7D)%0D%0A%0D%0Aconnect(()%20%3D%3E%20(%7B%20time%3A%20123%20%7D)%2C%20(%7B%20time%20%7D)%20%3D%3E%20(%7B%0D%0A%20%20%20doSomething()%20%7B%0D%0A%20%20%20%7D%2C%0D%0A%7D))%0D%0A%0D%0A%0D%0Aconnect(()%20%3D%3E%20(%7B%20time%3A%20123%20%7D)%2C%20(%7B%20time%20%7D)%20%3D%3E%20(%7B%0D%0A%20%20%20time%2C%0D%0A%20%20%20doSomething%3A%20()%20%3D%3E%20%7B%0D%0A%20%20%20%7D%2C%0D%0A%7D))%0D%0A%0D%0A%0D%0Aconnect(()%20%3D%3E%20(%7B%20time%3A%20123%20%7D)%2C%20(%7B%20time%20%7D)%20%3D%3E%20(%7B%0D%0A%20%20%20time%2C%0D%0A%20%20%20doSomething()%20%7B%0D%0A%20%20%20%7D%2C%0D%0A%7D))%0D%0A
https://github.com/Dudeonyx
Umeayo Onyekachukwu (Dudeonyx)https://github.com/Dudeonyx
on Apr 13, 2019https://github.com/microsoft/TypeScript/issues/30874#issuecomment-482813189
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
on Apr 16, 2019https://github.com/microsoft/TypeScript/issues/30874#event-2281032341
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Backloghttps://github.com/microsoft/TypeScript/milestone/29
on Apr 16, 2019https://github.com/microsoft/TypeScript/issues/30874#event-2281032419
https://github.com/Torvin
Torvinhttps://github.com/Torvin
on Aug 1, 2019https://github.com/microsoft/TypeScript/issues/30874#issuecomment-517088099
https://github.com/jakebailey
Jake Bailey (jakebailey)https://github.com/jakebailey
on Jul 18, 2023https://github.com/microsoft/TypeScript/issues/30874#issuecomment-1640888212
#31574https://github.com/microsoft/TypeScript/pull/31574
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jul 24, 2025https://github.com/microsoft/TypeScript/issues/30874#event-18803172410
microsofthttps://github.com/microsoft
on Jan 21, 2026https://github.com/microsoft/TypeScript/issues/30874#event-22197155691
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/30874
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/30874
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
BacklogNo due datehttps://github.com/microsoft/TypeScript/milestone/29
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.