René's URL Explorer Experiment


Title: Design Meeting Notes, 3/29/2019 · Issue #30645 · microsoft/TypeScript · GitHub

Open Graph Title: Design Meeting Notes, 3/29/2019 · Issue #30645 · microsoft/TypeScript

X Title: Design Meeting Notes, 3/29/2019 · Issue #30645 · microsoft/TypeScript

Description: Design Meeting Notes 3/29/2019 Safeness of indexed access types (#30603) This code is patently unsafe: function f2(obj: { a: number, b: string }, key: 'a' | 'b') { obj[key] = 123; } We need to get different types for reading and writing ...

Open Graph Description: Design Meeting Notes 3/29/2019 Safeness of indexed access types (#30603) This code is patently unsafe: function f2(obj: { a: number, b: string }, key: 'a' | 'b') { obj[key] = 123; } We need to get ...

X Description: Design Meeting Notes 3/29/2019 Safeness of indexed access types (#30603) This code is patently unsafe: function f2(obj: { a: number, b: string }, key: 'a' | 'b') { obj[key] = 123; }...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/30645

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Design Meeting Notes, 3/29/2019","articleBody":"# Design Meeting Notes 3/29/2019\r\n\r\n### Safeness of indexed access types (#30603)\r\n\r\nThis code is patently unsafe:\r\n```ts\r\nfunction f2(obj: { a: number, b: string }, key: 'a' | 'b') {\r\n    obj[key] = 123;\r\n}\r\n```\r\n\r\nWe need to get different types for reading and writing an indexed access type.\r\n\r\nAlso has implications for constraints and assignability\r\n\r\nConsider this code:\r\n```ts\r\nfunction foo\u003cT, K extends keyof T>(obj: T, key: K) {\r\n    obj[key] = 123;\r\n}\r\n```\r\n\r\nFrom a constraint perspective, the correct way to look at a reduction of `T[K]` is:\r\n * If `T extends C`, then we try to resolve `T[K]` using the constraint (possibly recursively)\r\n   * Better form: During simplification, specify whether this is a simplification for reading or writing\r\n     * Simplification today: `T[A | B]` simplifies to `T[A] | T[B]`, which is only correct for reading\r\n     * Similar: Given `(T | U)[K]`, the read simplification is `T[K] | U[K]` and the write simplification is `T[K] & U[K]`\r\n   * During assignability checks, simplify the source for reading and the target for writing\r\n   * Once the unions, etc are removed via simplification, we still might have constraints\r\n     * e.g. `T[K] = S` where `T extends { a: string, b: number }` and `K extends keyof T`\r\n     * We need to pick the widest `K` (`\"a\" | \"b\")` and then distribute that (`T['a'] | T['b']`]) into the narrowest target value\r\n     * Seems to work pretty well\r\n   * In the unconstrained `T` case, what do we do?\r\n     * Disallow assignment\r\n   * What about `T extends { [x: string]: any }` ?\r\n     * Is the intent that any assignment is legal here?\r\n       * Seems bad?\r\n   * What about `T extends { [x: string]: number }` ?\r\n     * All writes via constraints are suspect...\r\n       * Equally suspect?\r\n     * Is `T[\"\"] = 0` OK or no?\r\n       * 🤷‍\r\n       * This is a subtyping violating if it's inconsistent with `T[K] = 0`\r\n\r\n\r\n### https://github.com/Microsoft/TypeScript/pull/30637\r\n\r\n```ts\r\nfunction print\u003cT>(x: T): void {\r\n    console.log(x.toString());\r\n}\r\n\r\nprint(null); // A-OK!\r\n```\r\n\r\n * This was OK because the default constraint of `T` is `{}` and `{}` acquires the `Object` apparent members.\r\n   * (Non-SNC back compat accomplished by adding the Object apparent members back to `unknown`)\r\n * Now you have to write `print\u003cT extends {}>` which becomes meaningful.\r\n * Some breaks in react-redux\r\n * lodash has some breaks where they seem to rely on `{}` coming from broken inference (wow)\r\n   * Most changes are actually just different error spans\r\n * Back compat means what\r\n   * Fix lodash and react-redux\r\n   * Circular constraints keep hobbling on\r\n * Should we lint-ban `{}` in DT (in files with sufficiently-high version)?\r\n   * Yes (use `unknown` or `object` or `string | number | boolean | object | symbol`)\r\n   * \"Goodbye `{}`, we hardly knew ye\" - @rbuckton","author":{"url":"https://github.com/RyanCavanaugh","@type":"Person","name":"RyanCavanaugh"},"datePublished":"2019-03-29T18:51:36Z","url":"https://github.com/microsoft/TypeScript/issues/30645"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:945eaeff-0db4-4720-6582-9801337a6f10
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9ED2:1148D3:4F2214:672E16:6B00D9B7
html-safe-noncec59c1530d737276b24e8f1911c88ca1fce1d987d83be75a480daebc8e261d63c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUQyOjExNDhEMzo0RjIyMTQ6NjcyRTE2OjZCMDBEOUI3IiwidmlzaXRvcl9pZCI6IjM1MjkyMTI5MTQyNTY4OTQzOTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2d886bf11666cfa99d563112eec9a5abf50d5eb47cfc3a66a2e7b5803f557689
hovercard-subject-tagissue:427132180
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/30645/issue_layout
twitter:imagehttps://opengraph.githubassets.com/43be5000d5f40bc93e3cdae728c5b9c0d17c39a66bc67f30f904821ad27cc8ac/microsoft/TypeScript/issues/30645
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/43be5000d5f40bc93e3cdae728c5b9c0d17c39a66bc67f30f904821ad27cc8ac/microsoft/TypeScript/issues/30645
og:image:altDesign Meeting Notes 3/29/2019 Safeness of indexed access types (#30603) This code is patently unsafe: function f2(obj: { a: number, b: string }, key: 'a' | 'b') { obj[key] = 123; } We need to get ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameRyanCavanaugh
hostnamegithub.com
expected-hostnamegithub.com
Nonea481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release84c8c5cc25e2fb7f2308428458538436baecc6d2
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/30645#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F30645
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F30645
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/30645
Reloadhttps://github.com/microsoft/TypeScript/issues/30645
Reloadhttps://github.com/microsoft/TypeScript/issues/30645
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests307 (307)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/30645
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/30645
Design Meeting Notes, 3/29/2019https://github.com/microsoft/TypeScript/issues/30645#top
Design NotesNotes from our design meetingshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Notes%22
https://github.com/RyanCavanaugh
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on Mar 29, 2019https://github.com/microsoft/TypeScript/issues/30645#issue-427132180
#30603https://github.com/microsoft/TypeScript/issues/30603
#30637https://github.com/microsoft/TypeScript/pull/30637
Ron Buckton (@rbuckton)https://github.com/rbuckton
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Design NotesNotes from our design meetingshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Notes%22
on Mar 29, 2019https://github.com/microsoft/TypeScript/issues/30645#event-2240154092
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jan 5, 2020https://github.com/microsoft/TypeScript/issues/30645#event-2922205902
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/30645
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/30645
Design NotesNotes from our design meetingshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Design%20Notes%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.