Title: Design Meeting Notes, 3/29/2019 · Issue #30645 · microsoft/TypeScript · GitHub
Open Graph Title: Design Meeting Notes, 3/29/2019 · Issue #30645 · microsoft/TypeScript
X Title: Design Meeting Notes, 3/29/2019 · Issue #30645 · microsoft/TypeScript
Description: Design Meeting Notes 3/29/2019 Safeness of indexed access types (#30603) This code is patently unsafe: function f2(obj: { a: number, b: string }, key: 'a' | 'b') { obj[key] = 123; } We need to get different types for reading and writing ...
Open Graph Description: Design Meeting Notes 3/29/2019 Safeness of indexed access types (#30603) This code is patently unsafe: function f2(obj: { a: number, b: string }, key: 'a' | 'b') { obj[key] = 123; } We need to get ...
X Description: Design Meeting Notes 3/29/2019 Safeness of indexed access types (#30603) This code is patently unsafe: function f2(obj: { a: number, b: string }, key: 'a' | 'b') { obj[key] = 123; }...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/30645
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Design Meeting Notes, 3/29/2019","articleBody":"# Design Meeting Notes 3/29/2019\r\n\r\n### Safeness of indexed access types (#30603)\r\n\r\nThis code is patently unsafe:\r\n```ts\r\nfunction f2(obj: { a: number, b: string }, key: 'a' | 'b') {\r\n obj[key] = 123;\r\n}\r\n```\r\n\r\nWe need to get different types for reading and writing an indexed access type.\r\n\r\nAlso has implications for constraints and assignability\r\n\r\nConsider this code:\r\n```ts\r\nfunction foo\u003cT, K extends keyof T>(obj: T, key: K) {\r\n obj[key] = 123;\r\n}\r\n```\r\n\r\nFrom a constraint perspective, the correct way to look at a reduction of `T[K]` is:\r\n * If `T extends C`, then we try to resolve `T[K]` using the constraint (possibly recursively)\r\n * Better form: During simplification, specify whether this is a simplification for reading or writing\r\n * Simplification today: `T[A | B]` simplifies to `T[A] | T[B]`, which is only correct for reading\r\n * Similar: Given `(T | U)[K]`, the read simplification is `T[K] | U[K]` and the write simplification is `T[K] & U[K]`\r\n * During assignability checks, simplify the source for reading and the target for writing\r\n * Once the unions, etc are removed via simplification, we still might have constraints\r\n * e.g. `T[K] = S` where `T extends { a: string, b: number }` and `K extends keyof T`\r\n * We need to pick the widest `K` (`\"a\" | \"b\")` and then distribute that (`T['a'] | T['b']`]) into the narrowest target value\r\n * Seems to work pretty well\r\n * In the unconstrained `T` case, what do we do?\r\n * Disallow assignment\r\n * What about `T extends { [x: string]: any }` ?\r\n * Is the intent that any assignment is legal here?\r\n * Seems bad?\r\n * What about `T extends { [x: string]: number }` ?\r\n * All writes via constraints are suspect...\r\n * Equally suspect?\r\n * Is `T[\"\"] = 0` OK or no?\r\n * 🤷\r\n * This is a subtyping violating if it's inconsistent with `T[K] = 0`\r\n\r\n\r\n### https://github.com/Microsoft/TypeScript/pull/30637\r\n\r\n```ts\r\nfunction print\u003cT>(x: T): void {\r\n console.log(x.toString());\r\n}\r\n\r\nprint(null); // A-OK!\r\n```\r\n\r\n * This was OK because the default constraint of `T` is `{}` and `{}` acquires the `Object` apparent members.\r\n * (Non-SNC back compat accomplished by adding the Object apparent members back to `unknown`)\r\n * Now you have to write `print\u003cT extends {}>` which becomes meaningful.\r\n * Some breaks in react-redux\r\n * lodash has some breaks where they seem to rely on `{}` coming from broken inference (wow)\r\n * Most changes are actually just different error spans\r\n * Back compat means what\r\n * Fix lodash and react-redux\r\n * Circular constraints keep hobbling on\r\n * Should we lint-ban `{}` in DT (in files with sufficiently-high version)?\r\n * Yes (use `unknown` or `object` or `string | number | boolean | object | symbol`)\r\n * \"Goodbye `{}`, we hardly knew ye\" - @rbuckton","author":{"url":"https://github.com/RyanCavanaugh","@type":"Person","name":"RyanCavanaugh"},"datePublished":"2019-03-29T18:51:36Z","url":"https://github.com/microsoft/TypeScript/issues/30645"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:945eaeff-0db4-4720-6582-9801337a6f10 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9ED2:1148D3:4F2214:672E16:6B00D9B7 |
| html-safe-nonce | c59c1530d737276b24e8f1911c88ca1fce1d987d83be75a480daebc8e261d63c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RUQyOjExNDhEMzo0RjIyMTQ6NjcyRTE2OjZCMDBEOUI3IiwidmlzaXRvcl9pZCI6IjM1MjkyMTI5MTQyNTY4OTQzOTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2d886bf11666cfa99d563112eec9a5abf50d5eb47cfc3a66a2e7b5803f557689 |
| hovercard-subject-tag | issue:427132180 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/30645/issue_layout |
| twitter:image | https://opengraph.githubassets.com/43be5000d5f40bc93e3cdae728c5b9c0d17c39a66bc67f30f904821ad27cc8ac/microsoft/TypeScript/issues/30645 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/43be5000d5f40bc93e3cdae728c5b9c0d17c39a66bc67f30f904821ad27cc8ac/microsoft/TypeScript/issues/30645 |
| og:image:alt | Design Meeting Notes 3/29/2019 Safeness of indexed access types (#30603) This code is patently unsafe: function f2(obj: { a: number, b: string }, key: 'a' | 'b') { obj[key] = 123; } We need to get ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | RyanCavanaugh |
| hostname | github.com |
| expected-hostname | github.com |
| None | a481f62a1e04c9b9bdcb5628230682c66d59006f5b13b080f79cba84a176905b |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 84c8c5cc25e2fb7f2308428458538436baecc6d2 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width