Title: Control flow analysis fails to account for possible assignments to captured variables in closures. · Issue #30097 · microsoft/TypeScript · GitHub
Open Graph Title: Control flow analysis fails to account for possible assignments to captured variables in closures. · Issue #30097 · microsoft/TypeScript
X Title: Control flow analysis fails to account for possible assignments to captured variables in closures. · Issue #30097 · microsoft/TypeScript
Description: TypeScript Version: 3.4.0-dev.20190223 Search Terms: union narrow control flow closure Code // with strictNullChecks enabled let x: number | null = null; const f = () => { x = 3; }; f(); // at this point x is a number (3), but typescript...
Open Graph Description: TypeScript Version: 3.4.0-dev.20190223 Search Terms: union narrow control flow closure Code // with strictNullChecks enabled let x: number | null = null; const f = () => { x = 3; }; f(); // at this...
X Description: TypeScript Version: 3.4.0-dev.20190223 Search Terms: union narrow control flow closure Code // with strictNullChecks enabled let x: number | null = null; const f = () => { x = 3; }; f(); // at t...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/30097
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Control flow analysis fails to account for possible assignments to captured variables in closures.","articleBody":"\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** 3.4.0-dev.20190223\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:**\r\nunion narrow control flow closure\r\n\r\n**Code**\r\n\r\n```ts\r\n// with strictNullChecks enabled\r\n\r\nlet x: number | null = null;\r\n\r\nconst f = () => { x = 3; };\r\n\r\nf();\r\n// at this point x is a number (3), but typescript thinks it has type null (NOT number | null)\r\n\r\nMath.abs(x as number); // type error\r\n````\r\n**Expected behavior:**\r\n\r\nCompilation succeeds. Inferred type of `x` at the line marked \"type error\" should be `number | null`. (In a perfect world the inferred type would actually be `number`, but I'm not expecting that.)\r\n\r\n**Actual behavior:**\r\n\r\nCompiler emits the following error message:\r\n\r\n`error TS2352: Conversion of type 'null' to type 'number' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.`\r\n\r\nHovering over the `x` in the line with the type error shows the inferred type as `x: null`.\r\n\r\nNote that, unlike (most of?) the related issues below, the problem here is not that the inferred type is less specific than expected, but rather that it is _more_ specific, and specifically wrong. Because the captured variable `x` is assigned a number in the closure, the compiler should assume the assignment _might_ happen at any time, and should not narrow the type `number|null` to `null`.\r\n\r\n**Playground Link:** \u003c!-- A link to a TypeScript Playground \"Share\" link which demonstrates this behavior -->\r\n(Make sure 'strictNullChecks' is checked in Options.)\r\n\r\nhttps://www.typescriptlang.org/play/index.html#src=%2F%2F%20with%20strictNullChecks%20enabled%0D%0A%0D%0Alet%20x%3A%20number%20%7C%20null%20%3D%20null%3B%0D%0A%0D%0Aconst%20f%20%3D%20()%20%3D%3E%20%7B%20x%20%3D%203%3B%20%7D%3B%0D%0A%0D%0Af()%3B%0D%0A%2F%2F%20at%20this%20point%20x%20is%20a%20number%20(3)%2C%20but%20typescript%20thinks%20it%20has%20type%20null%20(NOT%20number%20%7C%20null)%0D%0A%0D%0AMath.abs(x%20as%20number)%3B%20%2F%2F%20type%20error%0D%0A\r\n\r\n**Related Issues:** \u003c!-- Did you find other bugs that looked similar? -->\r\n\r\n#9263, #7719, #8541, #8552, #9491 (and others)\r\n\r\n\r\n","author":{"url":"https://github.com/AndrewGlynn","@type":"Person","name":"AndrewGlynn"},"datePublished":"2019-02-26T06:55:14Z","url":"https://github.com/microsoft/TypeScript/issues/30097"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:dcf8139e-5e47-9eeb-545b-0ce1eae54025 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8778:399E4B:28B7E9F:360C82D:6B01AB3D |
| html-safe-nonce | 419585444ce2852fa75768f9d402bb5d2ad3b02f4fd4e8d99b7db82c8173fbbb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Nzc4OjM5OUU0QjoyOEI3RTlGOjM2MEM4MkQ6NkIwMUFCM0QiLCJ2aXNpdG9yX2lkIjoiNjA0ODM3Mzk0MzkwMTk4OTY5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1bca7752ac4f310469fc1a5e317036f5955fee9eb1d4640844f2bcc91b06a417 |
| hovercard-subject-tag | issue:414459119 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/30097/issue_layout |
| twitter:image | https://opengraph.githubassets.com/498bbb46eaa4698d5bde3a9219730d79e1d6a9b7b59f1de99818e59979e31443/microsoft/TypeScript/issues/30097 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/498bbb46eaa4698d5bde3a9219730d79e1d6a9b7b59f1de99818e59979e31443/microsoft/TypeScript/issues/30097 |
| og:image:alt | TypeScript Version: 3.4.0-dev.20190223 Search Terms: union narrow control flow closure Code // with strictNullChecks enabled let x: number | null = null; const f = () => { x = 3; }; f(); // at this... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | AndrewGlynn |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width