Title: Exponential compilation slowdown with property accessors and conditional types · Issue #29350 · microsoft/TypeScript · GitHub
Open Graph Title: Exponential compilation slowdown with property accessors and conditional types · Issue #29350 · microsoft/TypeScript
X Title: Exponential compilation slowdown with property accessors and conditional types · Issue #29350 · microsoft/TypeScript
Description: Apologies, I have had to break from the template in order to describe this issue since it is not easily reproduced in a simple demo. TypeScript Version: 3.0.3, 3.2.2, 3.3.0-dev.20190110 Search Terms: compilation performance, generic prop...
Open Graph Description: Apologies, I have had to break from the template in order to describe this issue since it is not easily reproduced in a simple demo. TypeScript Version: 3.0.3, 3.2.2, 3.3.0-dev.20190110 Search Term...
X Description: Apologies, I have had to break from the template in order to describe this issue since it is not easily reproduced in a simple demo. TypeScript Version: 3.0.3, 3.2.2, 3.3.0-dev.20190110 Search Term...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/29350
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Exponential compilation slowdown with property accessors and conditional types","articleBody":"Apologies, I have had to break from the template in order to describe this issue since it is not easily reproduced in a simple demo.\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** 3.0.3, 3.2.2, 3.3.0-dev.20190110\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** compilation performance, generic property accessor, conditional types\r\n\r\n**Code**\r\n\r\nSo far in investigating this issue I have identified this code block as the culprit, due to [this commit](\r\nhttps://github.com/alexfoxgill/biselect/commit/e28e0070074dc52cfff6ba586c44fa6649885d03)\r\n\r\n```typescript\r\nexport type PropOverloads\u003cD extends Dimensionality, S extends Structure, A, B, Params extends {}> = {\r\n \u003cK1 extends keyof B>(key: K1)\r\n : Composable.ComposeResult\u003cA, B[K1], Params, D, Dimensionality.Single, S, Structure.Select>\r\n\r\n \u003cK1 extends keyof B, K2 extends keyof B[K1]>(k1: K1, k2: K2)\r\n : Composable.ComposeResult\u003cA, B[K1][K2], Params, D, Dimensionality.Single, S, Structure.Select>\r\n\r\n \u003cK1 extends keyof B, K2 extends keyof B[K1], K3 extends keyof B[K1][K2]>(k1: K1, k2: K2, k3: K3)\r\n : Composable.ComposeResult\u003cA, B[K1][K2][K3], Params, D, Dimensionality.Single, S, Structure.Select>\r\n\r\n \u003cK1 extends keyof B, K2 extends keyof B[K1], K3 extends keyof B[K1][K2], K4 extends keyof B[K1][K2][K3]>(k1: K1, k2: K2, k3: K3, k4: K4)\r\n : Composable.ComposeResult\u003cA, B[K1][K2][K3][K4], Params, D, Dimensionality.Single, S, Structure.Select>\r\n}\r\n```\r\n\r\n\"Supporting\" code:\r\n\r\n```typescript\r\nexport enum Dimensionality {\r\n Single = \"single\",\r\n Maybe = \"maybe\"\r\n}\r\n\r\nexport namespace Dimensionality {\r\n export type Highest\u003cT extends Dimensionality, U extends Dimensionality> =\r\n Dimensionality extends T ? never\r\n : Dimensionality extends U ? never\r\n : Dimensionality.Maybe extends (T | U) ? Dimensionality.Maybe\r\n : Dimensionality.Single extends (T | U) ? Dimensionality.Single\r\n : never\r\n}\r\n\r\nexport enum Structure {\r\n Get = \"get\",\r\n Select = \"select\",\r\n Convert = \"convert\"\r\n}\r\n\r\nexport namespace Structure {\r\n export type Narrowest\u003cT extends Structure, U extends Structure> =\r\n Structure extends T ? never\r\n : Structure extends U ? never\r\n : Structure.Get extends (T | U) ? Structure.Get\r\n : Structure.Select extends (T | U) ? Structure.Select\r\n : Structure.Convert extends (T | U) ? Structure.Convert\r\n : never\r\n}\r\n\r\nexport type Composable\u003cA, B, Params extends {}> =\r\n | Get\u003cA, B, Params>\r\n | MaybeGet\u003cA, B, Params>\r\n | Selector\u003cA, B, Params>\r\n | MaybeSelector\u003cA, B, Params>\r\n | Converter\u003cA, B, Params>\r\n | MaybeConverter\u003cA, B, Params>\r\n\r\nexport type ShapeResult\u003cD1 extends Dimensionality, D2 extends Dimensionality, S1 extends Structure, S2 extends Structure> =\r\n Shape\u003cDimensionality.Highest\u003cD1, D2>, Structure.Narrowest\u003cS1, S2>>\r\n\r\nexport type ComposeResult\u003cA, B, P extends {}, D1 extends Dimensionality, D2 extends Dimensionality, S1 extends Structure, S2 extends Structure> =\r\n Extract\u003cComposable\u003cA, B, P>, ShapeResult\u003cD1, D2, S1, S2>>\r\n```\r\n\r\n**Expected behavior:** A compilation time of ~3 seconds, akin to the previous commit\r\n\r\n**Actual behavior:** A compilation time of ~80 seconds\r\n\r\n**Related Issues:** \u003c!-- Did you find other bugs that looked similar? --> none that I could find\r\n\r\n---\r\n\r\n# Output of `tsc --diagnostics`\r\n\r\nBefore this change, in the previous commit:\r\n```\r\nSymbols: 121139\r\nTypes: 67276\r\nMemory used: 131777K\r\nCheck time: 2.36s\r\nTotal time: 3.19s\r\n```\r\n\r\nAfter this change:\r\n```\r\nSymbols: 1313985\r\nTypes: 788655\r\nMemory used: 911104K\r\nCheck time: 78.97s\r\nTotal time: 79.67s\r\n```\r\n\r\nWithout the 4-argument overload:\r\n```\r\nSymbols: 1085472\r\nTypes: 650274\r\nMemory used: 763202K\r\nCheck time: 45.22s\r\nTotal time: 45.97s\r\n```\r\n\r\nWith only the 1- and 2-argument overloads:\r\n```\r\nSymbols: 868055\r\nTypes: 522824\r\nMemory used: 619599K\r\nCheck time: 27.51s\r\nTotal time: 28.21s\r\n```\r\n\r\nWith only the 1-argument overload:\r\n```\r\nSymbols: 651404\r\nTypes: 399632\r\nMemory used: 499634K\r\nCheck time: 16.01s\r\nTotal time: 16.68s\r\n```\r\n\r\nI am not really sure how to narrow this down to a particular problem or debug the compilation time; I only notice that the number of types and symbols increases hugely with just a single method interface","author":{"url":"https://github.com/alexfoxgill","@type":"Person","name":"alexfoxgill"},"datePublished":"2019-01-10T20:07:51Z","url":"https://github.com/microsoft/TypeScript/issues/29350"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:2d20f93c-a608-576b-4aad-4cf10af3a058 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A9D8:215B92:2835AD8:3592C13:6B01B363 |
| html-safe-nonce | 8fce83ce79d406696e14afb6afb3b683d36aac3ec30334df53b8b0322e24aeb7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOUQ4OjIxNUI5MjoyODM1QUQ4OjM1OTJDMTM6NkIwMUIzNjMiLCJ2aXNpdG9yX2lkIjoiNjkyNzUzNDQyMjA0MDM1OTc4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ee659ddc3497f52c8e886cf3399ce203589e92452585107fb705d9c7c4997454 |
| hovercard-subject-tag | issue:397994160 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/29350/issue_layout |
| twitter:image | https://opengraph.githubassets.com/9b2c9640e449d3e875e6f59489af3e7f9460d921b2630ebbf4142cf93d1c8070/microsoft/TypeScript/issues/29350 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9b2c9640e449d3e875e6f59489af3e7f9460d921b2630ebbf4142cf93d1c8070/microsoft/TypeScript/issues/29350 |
| og:image:alt | Apologies, I have had to break from the template in order to describe this issue since it is not easily reproduced in a simple demo. TypeScript Version: 3.0.3, 3.2.2, 3.3.0-dev.20190110 Search Term... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | alexfoxgill |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width