Title: new cache for readFile, fileExists, directoryExist, is not working as advertised · Issue #29107 · microsoft/TypeScript · GitHub
Open Graph Title: new cache for readFile, fileExists, directoryExist, is not working as advertised · Issue #29107 · microsoft/TypeScript
X Title: new cache for readFile, fileExists, directoryExist, is not working as advertised · Issue #29107 · microsoft/TypeScript
Description: I encountered a significant performance drop in ts-jest which I was able to track down to typescript reading package.json files over and over. After doing so I realized that you knew of this problem and that you even already pushed a fix...
Open Graph Description: I encountered a significant performance drop in ts-jest which I was able to track down to typescript reading package.json files over and over. After doing so I realized that you knew of this proble...
X Description: I encountered a significant performance drop in ts-jest which I was able to track down to typescript reading package.json files over and over. After doing so I realized that you knew of this proble...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/29107
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"new cache for readFile, fileExists, directoryExist, is not working as advertised","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\nI encountered [a significant performance drop in ts-jest ]( https://github.com/kulshekhar/ts-jest/issues/908) which I was able to track down to typescript reading package.json files over and over.\r\n\r\nAfter doing so I realized that you [knew of this problem](https://github.com/Microsoft/TypeScript/pull/27068) and that you even already [pushed a fix for it](https://github.com/Microsoft/TypeScript/pull/28629)\r\n\r\nSo I updated typescript and it got even worse. The node_modules folder of the demo repository contains **600 package.json files** which result in about **35k readFile calls** to these files.\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** 3.3.0-dev.20181220\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** cache readFile fileExists directoryExist readJson\r\n\r\n**Code** https://gitlab.com/Farbdose/ts-jest-multiple-fileread/tree/typescript-3.3.0\r\nThis almost empty repository takes now 45 seconds in the gitlab build pipeline to run an empty jest test-suite. \r\nBe aware that there is a non-zero chance that this is caused by some bad interaction between typescript, jest, ts-jest and ionic but I'm out of ideas...\r\n\r\n**Expected behavior:** read each package.json only once\r\n\r\n**Actual behavior:** each file in the node_modules folder causes at least one readFile-call to the package.json of the module it's located in\r\n\r\n**Related Issues:** \u003c!-- Did you find other bugs that looked similar? -->\r\nhttps://github.com/Microsoft/TypeScript/pull/27068 https://github.com/Microsoft/TypeScript/pull/28629\r\nhttps://github.com/kulshekhar/ts-jest/issues/908\r\nhttps://github.com/ionic-team/ionic/issues/16703","author":{"url":"https://github.com/Farbdose","@type":"Person","name":"Farbdose"},"datePublished":"2018-12-20T14:10:33Z","url":"https://github.com/microsoft/TypeScript/issues/29107"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e4790035-b973-f417-0060-5704e985a975 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D352:3DCD28:CC079A:10EFE12:6B01CA96 |
| html-safe-nonce | df72a87d4882307f80d88614eb027d150e6adc732c874ca86dec99c593eae8b3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzUyOjNEQ0QyODpDQzA3OUE6MTBFRkUxMjo2QjAxQ0E5NiIsInZpc2l0b3JfaWQiOiI2MjAzMjk3MTMyNjg4MDQyNDciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f239af27da87314175e58e17df594e81be0acbfd470db3aa171649aa405fb034 |
| hovercard-subject-tag | issue:393062670 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/29107/issue_layout |
| twitter:image | https://opengraph.githubassets.com/39151ca4fb3443a979caa148a44e232a58f1ef12e703f792590a6bfeba922960/microsoft/TypeScript/issues/29107 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/39151ca4fb3443a979caa148a44e232a58f1ef12e703f792590a6bfeba922960/microsoft/TypeScript/issues/29107 |
| og:image:alt | I encountered a significant performance drop in ts-jest which I was able to track down to typescript reading package.json files over and over. After doing so I realized that you knew of this proble... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Farbdose |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width