René's URL Explorer Experiment


Title: String Indexer Assignable to Generic Mapped Type · Issue #28798 · microsoft/TypeScript · GitHub

Open Graph Title: String Indexer Assignable to Generic Mapped Type · Issue #28798 · microsoft/TypeScript

X Title: String Indexer Assignable to Generic Mapped Type · Issue #28798 · microsoft/TypeScript

Description: TypeScript Version: Version 3.3.0-dev Search Terms: string indexer generic mapped type assignable Code This seems like a regression (if it is a bug). I get the expected behaviour on the playground 3.1. function tester(x: R...

Open Graph Description: TypeScript Version: Version 3.3.0-dev Search Terms: string indexer generic mapped type assignable Code This seems like a regression (if it is a bug). I get the expected behaviour on the playground ...

X Description: TypeScript Version: Version 3.3.0-dev Search Terms: string indexer generic mapped type assignable Code This seems like a regression (if it is a bug). I get the expected behaviour on the playground ...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/28798

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"String Indexer Assignable to Generic Mapped Type","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** Version 3.3.0-dev\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** string indexer generic mapped type assignable\r\n\r\n**Code**\r\nThis seems like a regression (if it is a bug). I get the expected behaviour on the playground 3.1.\r\n\r\n```ts\r\nfunction tester\u003cK extends 'a'>(x: Record\u003cK, number>, y: { [x: string]: number }) {\r\n    x = y; // no error: not expected\r\n    y = x; // no error: expected\r\n}\r\n\r\nfunction tester2(x: Record\u003c'a', number>, y: { [x: string]: number }) {\r\n    x = y; // error: expected\r\n    y = x; // no error: expected\r\n}\r\n```\r\n\r\n**Expected behavior:**\r\n\r\nA string indexer should not be assignable to a mapped type with a generic constraint.\r\n\r\n**Actual behavior:**\r\n\r\nString indexer appears to be assignable to generic record type.\r\n\r\n**Playground Link:** [playground with expected behaviour](https://www.typescriptlang.org/play/#src=function%20tester%3CK%20extends%20'a'%3E(x%3A%20Record%3CK%2C%20number%3E%2C%20y%3A%20%7B%20%5Bx%3A%20string%5D%3A%20number%20%7D)%20%7B%0D%0A%20%20%20%20x%20%3D%20y%3B%20%2F%2F%20error%3A%20expected%0D%0A%20%20%20%20y%20%3D%20x%3B%20%2F%2F%20no%20error%3A%20expected%0D%0A%7D)\r\n\r\n**Update**. I think this was introduced by #28218.\r\n\r\n```ts\r\n// A source type T is related to a target type { [P in Q]: X } if Q is related to keyof T and T[Q] is related to X.\r\nif (!isGenericMappedType(source) && isRelatedTo(getConstraintTypeFromMappedType(target), getIndexType(source))) {\r\n    const indexedAccessType = getIndexedAccessType(source, getTypeParameterFromMappedType(target));\r\n    const templateType = getTemplateTypeFromMappedType(target);\r\n    if (result = isRelatedTo(indexedAccessType, templateType, reportErrors)) {\r\n        return result;\r\n    }\r\n}\r\n```\r\n\r\nIn this instance we have `'a'` is related `string`, but a type with a key set of type `string` is not guaranteed to have the key `a`. When relating keys I think `string` and `number` should really be bottom types, so a possible fix is to filter them from the source index type:\r\n\r\n```ts\r\nfilterType(getIndexType(source), t => !(t.flags & (TypeFlags.String | TypeFlags.Number)\r\n// and symbol??\r\n```","author":{"url":"https://github.com/jack-williams","@type":"Person","name":"jack-williams"},"datePublished":"2018-12-02T01:32:43Z","url":"https://github.com/microsoft/TypeScript/issues/28798"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:762e4ccc-abfb-ac36-874a-1042a128ef9d
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC14A:21AC3F:3960E7F:489E907:6B01D912
html-safe-nonce43da51e3cf4aceb18a01b221423158b58e74249cf7750e9b7edc39dad22336b8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTRBOjIxQUMzRjozOTYwRTdGOjQ4OUU5MDc6NkIwMUQ5MTIiLCJ2aXNpdG9yX2lkIjoiNDY3MjE1MzkyODQ4MDE4NDU5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac98fa0fa2ddc1891ef9f74df5592123255dcd13ab9d3cb1aec296517351ecab61
hovercard-subject-tagissue:386516203
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/28798/issue_layout
twitter:imagehttps://opengraph.githubassets.com/ed0866c549d96fe97d7781afe7621dd67aba49068259e0ed58f4c87b0d02c6f7/microsoft/TypeScript/issues/28798
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ed0866c549d96fe97d7781afe7621dd67aba49068259e0ed58f4c87b0d02c6f7/microsoft/TypeScript/issues/28798
og:image:altTypeScript Version: Version 3.3.0-dev Search Terms: string indexer generic mapped type assignable Code This seems like a regression (if it is a bug). I get the expected behaviour on the playground ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejack-williams
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/28798#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F28798
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F28798
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/28798
Reloadhttps://github.com/microsoft/TypeScript/issues/28798
Reloadhttps://github.com/microsoft/TypeScript/issues/28798
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/28798
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/28798
String Indexer Assignable to Generic Mapped Typehttps://github.com/microsoft/TypeScript/issues/28798#top
https://github.com/weswigham
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
Backloghttps://github.com/microsoft/TypeScript/milestone/29
https://github.com/jack-williams
Jack Williams (jack-williams)https://github.com/jack-williams
on Dec 2, 2018https://github.com/microsoft/TypeScript/issues/28798#issue-386516203
playground with expected behaviourhttps://www.typescriptlang.org/play/#src=function%20tester%3CK%20extends%20'a'%3E(x%3A%20Record%3CK%2C%20number%3E%2C%20y%3A%20%7B%20%5Bx%3A%20string%5D%3A%20number%20%7D)%20%7B%0D%0A%20%20%20%20x%20%3D%20y%3B%20%2F%2F%20error%3A%20expected%0D%0A%20%20%20%20y%20%3D%20x%3B%20%2F%2F%20no%20error%3A%20expected%0D%0A%7D
#28218https://github.com/microsoft/TypeScript/pull/28218
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
on Dec 2, 2018https://github.com/microsoft/TypeScript/issues/28798#issuecomment-443520834
Jack Williams (@jack-williams)https://github.com/jack-williams
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
on Dec 2, 2018https://github.com/microsoft/TypeScript/issues/28798#event-2000028626
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
Wesley Wigham (weswigham)https://github.com/weswigham
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
on Dec 2, 2018https://github.com/microsoft/TypeScript/issues/28798#event-2000028628
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
TypeScript 3.3https://github.com/microsoft/TypeScript/milestone/79
on Dec 11, 2018https://github.com/microsoft/TypeScript/issues/28798#event-2019447571
https://github.com/jack-williams
Jack Williams (jack-williams)https://github.com/jack-williams
on Dec 13, 2018https://github.com/microsoft/TypeScript/issues/28798#issuecomment-447098871
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
TypeScript 3.3https://github.com/microsoft/TypeScript/milestone/79
TypeScript 3.4.0https://github.com/microsoft/TypeScript/milestone/86
on Feb 1, 2019https://github.com/microsoft/TypeScript/issues/28798#event-2113053509
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Backloghttps://github.com/microsoft/TypeScript/milestone/29
on Mar 14, 2019https://github.com/microsoft/TypeScript/issues/28798#event-2204258341
https://github.com/jack-williams
Jack Williams (jack-williams)https://github.com/jack-williams
on Apr 10, 2019https://github.com/microsoft/TypeScript/issues/28798#issuecomment-481810673
#30769https://github.com/microsoft/TypeScript/pull/30769
Jack Williams (jack-williams)https://github.com/jack-williams
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Apr 16, 2019https://github.com/microsoft/TypeScript/issues/28798#event-2281077581
microsofthttps://github.com/microsoft
on Oct 21, 2025https://github.com/microsoft/TypeScript/issues/28798#event-20415857496
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/28798
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/28798
Wesley Wigham (weswigham)https://github.com/weswigham
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
BacklogNo due datehttps://github.com/microsoft/TypeScript/milestone/29
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.