Title: Generic rest of intersection should be assignable to its type parameter constituents · Issue #28636 · microsoft/TypeScript · GitHub
Open Graph Title: Generic rest of intersection should be assignable to its type parameter constituents · Issue #28636 · microsoft/TypeScript
X Title: Generic rest of intersection should be assignable to its type parameter constituents · Issue #28636 · microsoft/TypeScript
Description: Search Terms generic rest intersection type parameter Suggestion The rest of an intersection containing type parameters and object types should be assignable to the type parameters if the rest removed all the properties from the object t...
Open Graph Description: Search Terms generic rest intersection type parameter Suggestion The rest of an intersection containing type parameters and object types should be assignable to the type parameters if the rest remo...
X Description: Search Terms generic rest intersection type parameter Suggestion The rest of an intersection containing type parameters and object types should be assignable to the type parameters if the rest remo...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/28636
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Generic rest of intersection should be assignable to its type parameter constituents","articleBody":"## Search Terms\r\n\r\ngeneric rest intersection type parameter\r\n\r\n## Suggestion\r\n\r\nThe rest of an intersection containing type parameters and object types should be assignable to the type parameters if the rest removed all the properties from the object types. For example:\r\n\r\n```ts\r\nfunction ripoff\u003cT>(augmented: T & { a }): T {\r\n const { a, ...original } = augmented;\r\n return original;\r\n}\r\n```\r\n\r\nThis is technically not safe — the instantiation of the type parameters could overlap with the object types — but it is how higher-order spread currently behaves. I believe the most common use of rest is with disjoint types. (Spread is similar, but identical types is the most common use there.)\r\n\r\nOne way to allow this is to create a new assignability rule:\r\n\r\nPick\u003cT & U & ... & { a } & { b } & ..., Exclude\u003ckeyof T & U & ..., 'a' | 'b' | ...>> ⟹ T & U & ...\r\n\r\nIn prose, the rule is that the pick of an intersection that consists of only type parameters and object types is assignable to the intersection of the type parameters if the second argument is an Exclude, and the Exclude's first argument is `keyof` the intersection of the type parameters, and the Exclude's second argument is the keys of the intersection of the object types.\r\n\r\nAnother optional is a simpler rule, where the pick of *any* intersection with a type parameter T is assignable to T:\r\n\r\nPick\u003cT & ..., Exclude\u003ckeyof T & ..., K>> ⟹ T\r\n\r\nNote that these rules don't cover what to do with constrained type parameters. The second rule is inaccurate enough already that it probably doesn't matter, but the first rule should probably have an additional restriction on Exclude's second argument.\r\n\r\n## Use Cases\r\n\r\nReact HOCs basically all do this.\r\n\r\n## Examples\r\n\r\nFrom [this comment](https://github.com/Microsoft/TypeScript/pull/28312#issuecomment-440226162):\r\n\r\n```ts\r\nimport React, { Component } from 'react'\r\n\r\nimport { Counter } from './counter-render-prop'\r\nimport { Subtract } from '../types'\r\n\r\ntype ExtractFuncArguments\u003cT> = T extends (...args: infer A) => any ? A : never;\r\n\r\n// get props that Counter injects via children as a function\r\ntype InjectedProps = ExtractFuncArguments\u003cCounter['props']['children']>[0];\r\n\r\n// withCounter will enhance returned component by ExtendedProps\r\ntype ExtendedProps = { maxCount?: number };\r\n\r\n// P is constrained to InjectedProps as we wanna make sure that wrapped component\r\n// implements this props API\r\nconst withCounter = \u003cP extends InjectedProps>(Cmp: React.ComponentType\u003cP>) => {\r\n class WithCounter extends Component\u003c\r\n // enhanced component will not include InjectedProps anymore as they are injected within render of this HoC and API surface is gonna be extended by ExtendedProps\r\n Subtract\u003cP, InjectedProps> & ExtendedProps\r\n > {\r\n static displayName = `WithCounter(${Cmp.name})`;\r\n\r\n render() {\r\n const { maxCount, ...passThroughProps } = this.props;\r\n\r\n return (\r\n // we use Counter which has children as a function API for injecting props\r\n \u003cCounter>\r\n {(injectedProps) =>\r\n maxCount && injectedProps.count >= maxCount ? (\r\n \u003cp className=\"alert alert-danger\">\r\n You've reached maximum count! GO HOME {maxCount}\r\n \u003c/p>\r\n ) : (\r\n // here cast to as P is needed otherwise compile error will occur\r\n \u003cCmp {...injectedProps as P} {...passThroughProps} />\r\n )\r\n }\r\n \u003c/Counter>\r\n );\r\n }\r\n }\r\n\r\n return WithCounter;\r\n};\r\n\r\n// CounterWannabe implement InjectedProps on it's props\r\nclass CounterWannabe extends Component\u003c\r\n InjectedProps & { colorType?: 'primary' | 'secondary' | 'success' }\r\n> {\r\n render() {\r\n const { count, inc, colorType } = this.props;\r\n\r\n const cssClass = `alert alert-${colorType}`;\r\n\r\n return (\r\n \u003cdiv style={{ cursor: 'pointer' }} className={cssClass} onClick={inc}>\r\n {count}\r\n \u003c/div>\r\n );\r\n }\r\n}\r\n\r\n// if CounterWannabe would not implement InjectedProps this line would get compile error\r\nconst ExtendedComponent = withCounter(CounterWannabe);\r\n```\r\n\r\n## Checklist\r\n\r\nMy suggestion meets these guidelines:\r\n\r\n* [x] This **probably** wouldn't be a breaking change in existing TypeScript/JavaScript code. Would need to be tested.\r\n* [x] This wouldn't change the runtime behavior of existing JavaScript code\r\n* [x] This could be implemented without emitting different JS based on the types of the expressions\r\n* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)\r\n* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).\r\n\r\n","author":{"url":"https://github.com/sandersn","@type":"Person","name":"sandersn"},"datePublished":"2018-11-21T17:47:06Z","url":"https://github.com/microsoft/TypeScript/issues/28636"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:01dc2e83-69dd-69ec-68dd-1d1de28ac8e3 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A7C2:27E5CD:33904A8:41F2E49:6B01D124 |
| html-safe-nonce | a1684cb9bb25645fec5962676eb7b6b3942e78fc0ee1f2e80c733589ed2de345 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBN0MyOjI3RTVDRDozMzkwNEE4OjQxRjJFNDk6NkIwMUQxMjQiLCJ2aXNpdG9yX2lkIjoiMzU3Mzg4NDYwNzEwOTY0ODY3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e436ea938001cfdcf802747aaf56c1dfecd703249eee4c575cde7326d5e11443 |
| hovercard-subject-tag | issue:383230852 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/28636/issue_layout |
| twitter:image | https://opengraph.githubassets.com/a8fc0a1aab8e145f2cb07335db7f85a3069eee4b1dd65e96fe437c8c5916546b/microsoft/TypeScript/issues/28636 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a8fc0a1aab8e145f2cb07335db7f85a3069eee4b1dd65e96fe437c8c5916546b/microsoft/TypeScript/issues/28636 |
| og:image:alt | Search Terms generic rest intersection type parameter Suggestion The rest of an intersection containing type parameters and object types should be assignable to the type parameters if the rest remo... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sandersn |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width