René's URL Explorer Experiment


Title: Side-effect imports are checked if file uses JSX: unintentional breaking change? · Issue #28538 · microsoft/TypeScript · GitHub

Open Graph Title: Side-effect imports are checked if file uses JSX: unintentional breaking change? · Issue #28538 · microsoft/TypeScript

X Title: Side-effect imports are checked if file uses JSX: unintentional breaking change? · Issue #28538 · microsoft/TypeScript

Description: Commit 7a71887 (#27340) appears to have introduced an unintentional breaking change: side-effect module imports are now checked, but only if the file uses JSX. This is currently causing the DefinitelyTyped CI (which uses typescript@next)...

Open Graph Description: Commit 7a71887 (#27340) appears to have introduced an unintentional breaking change: side-effect module imports are now checked, but only if the file uses JSX. This is currently causing the Definit...

X Description: Commit 7a71887 (#27340) appears to have introduced an unintentional breaking change: side-effect module imports are now checked, but only if the file uses JSX. This is currently causing the Definit...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/28538

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Side-effect imports are checked if file uses JSX: unintentional breaking change?","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\nCommit 7a71887c23a110009bc974f626245f03066e6926 (#27340) appears to have introduced an unintentional breaking change: side-effect module imports are now checked, but only if the file uses JSX.  This is currently causing the DefinitelyTyped CI (which uses `typescript@next`) to fail on `@types/react-table`.\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:**  7a71887c23a110009bc974f626245f03066e6926 (problem does not occur in 12e371beaaa67a65a79e18a3a20244c4cd102044)\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** side effect module import jsx\r\n\r\n**Code**\r\n```ts\r\n// code.tsx\r\nimport * as React from \"react\";\r\nimport \"nope\";\r\n\u003cdiv/>;\r\n// tsconfig.json\r\n{\r\n    \"compilerOptions\": {\r\n        \"jsx\": \"react\",\r\n        \"strict\": true\r\n    }\r\n}\r\n// package.json\r\n{\r\n  \"devDependencies\": {\r\n    \"@types/react\": \"^16.7.6\"\r\n  }\r\n}\r\n```\r\n\r\n**Expected behavior:** No compile error.\r\n\r\n**Actual behavior:** `error TS2307: Cannot find module 'nope'.`  But if the JSX element is removed from the file, the error goes away.\r\n\r\n**Playground Link:** N/A, React dependency\r\n\r\n**Related Issues:** #28032, etc. for the previous behavior\r\n","author":{"url":"https://github.com/mattmccutchen","@type":"Person","name":"mattmccutchen"},"datePublished":"2018-11-15T00:17:40Z","url":"https://github.com/microsoft/TypeScript/issues/28538"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:1e93d7de-5076-717b-628a-095b9e53cc39
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8F92:14F601:3306C74:40B81FE:6B01BC76
html-safe-nonce755b806d840bfd0dbf7b0099ee80e393c1176062a1d53afe5fe65f2070417028
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjkyOjE0RjYwMTozMzA2Qzc0OjQwQjgxRkU6NkIwMUJDNzYiLCJ2aXNpdG9yX2lkIjoiMTE4ODMyNzY2MDk4OTc5OTU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacca347afb2d2fefbd2dfe766acdaaa7d92a866f10ba4748d2252110ec0ea9a731
hovercard-subject-tagissue:380944828
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/28538/issue_layout
twitter:imagehttps://opengraph.githubassets.com/bd277a581849967122fddac2024c7192cc53715e0c066a1da87d204b666db100/microsoft/TypeScript/issues/28538
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bd277a581849967122fddac2024c7192cc53715e0c066a1da87d204b666db100/microsoft/TypeScript/issues/28538
og:image:altCommit 7a71887 (#27340) appears to have introduced an unintentional breaking change: side-effect module imports are now checked, but only if the file uses JSX. This is currently causing the Definit...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemattmccutchen
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/28538#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F28538
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F28538
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/28538
Reloadhttps://github.com/microsoft/TypeScript/issues/28538
Reloadhttps://github.com/microsoft/TypeScript/issues/28538
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/28538
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/28538
Side-effect imports are checked if file uses JSX: unintentional breaking change?https://github.com/microsoft/TypeScript/issues/28538#top
https://github.com/weswigham
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
Domain: Declaration EmitThe issue relates to the emission of d.ts fileshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20Declaration%20Emit%22
Domain: JSX/TSXRelates to the JSX parser and emitterhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20JSX%2FTSX%22
High Priorityhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22High%20Priority%22
TypeScript 3.2.1https://github.com/microsoft/TypeScript/milestone/84
https://github.com/mattmccutchen
Matt McCutchen (mattmccutchen)https://github.com/mattmccutchen
on Nov 15, 2018https://github.com/microsoft/TypeScript/issues/28538#issue-380944828
7a71887https://github.com/microsoft/TypeScript/commit/7a71887c23a110009bc974f626245f03066e6926
#27340https://github.com/microsoft/TypeScript/pull/27340
7a71887https://github.com/microsoft/TypeScript/commit/7a71887c23a110009bc974f626245f03066e6926
12e371bhttps://github.com/microsoft/TypeScript/commit/12e371beaaa67a65a79e18a3a20244c4cd102044
#28032https://github.com/microsoft/TypeScript/issues/28032
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
TypeScript 3.2.1https://github.com/microsoft/TypeScript/milestone/84
on Nov 15, 2018https://github.com/microsoft/TypeScript/issues/28538#event-1967890750
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Wesley Wigham (weswigham)https://github.com/weswigham
on Nov 15, 2018https://github.com/microsoft/TypeScript/issues/28538#event-1967890829
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
Domain: JSX/TSXRelates to the JSX parser and emitterhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20JSX%2FTSX%22
Domain: Declaration EmitThe issue relates to the emission of d.ts fileshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20Declaration%20Emit%22
High Priorityhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22High%20Priority%22
on Nov 15, 2018https://github.com/microsoft/TypeScript/issues/28538#event-1967891126
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
on Nov 15, 2018https://github.com/microsoft/TypeScript/issues/28538#issuecomment-438973065
herehttps://github.com/Microsoft/TypeScript/pull/28524#discussion_r233633527
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
on Nov 15, 2018https://github.com/microsoft/TypeScript/issues/28538#issuecomment-438973351
Wesley Wigham (weswigham)https://github.com/weswigham
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#28558https://github.com/microsoft/TypeScript/pull/28558
on Nov 17, 2018https://github.com/microsoft/TypeScript/issues/28538#event-1972548518
microsofthttps://github.com/microsoft
on Oct 21, 2025https://github.com/microsoft/TypeScript/issues/28538#event-20415847001
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/28538
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/28538
Wesley Wigham (weswigham)https://github.com/weswigham
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
Domain: Declaration EmitThe issue relates to the emission of d.ts fileshttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20Declaration%20Emit%22
Domain: JSX/TSXRelates to the JSX parser and emitterhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20JSX%2FTSX%22
High Priorityhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22High%20Priority%22
TypeScript 3.2.1https://github.com/microsoft/TypeScript/milestone/84
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.