Title: Side-effect imports are checked if file uses JSX: unintentional breaking change? · Issue #28538 · microsoft/TypeScript · GitHub
Open Graph Title: Side-effect imports are checked if file uses JSX: unintentional breaking change? · Issue #28538 · microsoft/TypeScript
X Title: Side-effect imports are checked if file uses JSX: unintentional breaking change? · Issue #28538 · microsoft/TypeScript
Description: Commit 7a71887 (#27340) appears to have introduced an unintentional breaking change: side-effect module imports are now checked, but only if the file uses JSX. This is currently causing the DefinitelyTyped CI (which uses typescript@next)...
Open Graph Description: Commit 7a71887 (#27340) appears to have introduced an unintentional breaking change: side-effect module imports are now checked, but only if the file uses JSX. This is currently causing the Definit...
X Description: Commit 7a71887 (#27340) appears to have introduced an unintentional breaking change: side-effect module imports are now checked, but only if the file uses JSX. This is currently causing the Definit...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/28538
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Side-effect imports are checked if file uses JSX: unintentional breaking change?","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\nCommit 7a71887c23a110009bc974f626245f03066e6926 (#27340) appears to have introduced an unintentional breaking change: side-effect module imports are now checked, but only if the file uses JSX. This is currently causing the DefinitelyTyped CI (which uses `typescript@next`) to fail on `@types/react-table`.\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** 7a71887c23a110009bc974f626245f03066e6926 (problem does not occur in 12e371beaaa67a65a79e18a3a20244c4cd102044)\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** side effect module import jsx\r\n\r\n**Code**\r\n```ts\r\n// code.tsx\r\nimport * as React from \"react\";\r\nimport \"nope\";\r\n\u003cdiv/>;\r\n// tsconfig.json\r\n{\r\n \"compilerOptions\": {\r\n \"jsx\": \"react\",\r\n \"strict\": true\r\n }\r\n}\r\n// package.json\r\n{\r\n \"devDependencies\": {\r\n \"@types/react\": \"^16.7.6\"\r\n }\r\n}\r\n```\r\n\r\n**Expected behavior:** No compile error.\r\n\r\n**Actual behavior:** `error TS2307: Cannot find module 'nope'.` But if the JSX element is removed from the file, the error goes away.\r\n\r\n**Playground Link:** N/A, React dependency\r\n\r\n**Related Issues:** #28032, etc. for the previous behavior\r\n","author":{"url":"https://github.com/mattmccutchen","@type":"Person","name":"mattmccutchen"},"datePublished":"2018-11-15T00:17:40Z","url":"https://github.com/microsoft/TypeScript/issues/28538"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:1e93d7de-5076-717b-628a-095b9e53cc39 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8F92:14F601:3306C74:40B81FE:6B01BC76 |
| html-safe-nonce | 755b806d840bfd0dbf7b0099ee80e393c1176062a1d53afe5fe65f2070417028 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjkyOjE0RjYwMTozMzA2Qzc0OjQwQjgxRkU6NkIwMUJDNzYiLCJ2aXNpdG9yX2lkIjoiMTE4ODMyNzY2MDk4OTc5OTU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ca347afb2d2fefbd2dfe766acdaaa7d92a866f10ba4748d2252110ec0ea9a731 |
| hovercard-subject-tag | issue:380944828 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/28538/issue_layout |
| twitter:image | https://opengraph.githubassets.com/bd277a581849967122fddac2024c7192cc53715e0c066a1da87d204b666db100/microsoft/TypeScript/issues/28538 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/bd277a581849967122fddac2024c7192cc53715e0c066a1da87d204b666db100/microsoft/TypeScript/issues/28538 |
| og:image:alt | Commit 7a71887 (#27340) appears to have introduced an unintentional breaking change: side-effect module imports are now checked, but only if the file uses JSX. This is currently causing the Definit... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mattmccutchen |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width