René's URL Explorer Experiment


Title: TS Server API proposal: Commit Characters · Issue #27623 · microsoft/TypeScript · GitHub

Open Graph Title: TS Server API proposal: Commit Characters · Issue #27623 · microsoft/TypeScript

X Title: TS Server API proposal: Commit Characters · Issue #27623 · microsoft/TypeScript

Description: Problem VS Code (and Visual Studio) have the concept of commit characters for suggestions. This is a set of characters that, when typed, accept the current suggestion. For example, a suggestion for a function may treat ( as a commit char...

Open Graph Description: Problem VS Code (and Visual Studio) have the concept of commit characters for suggestions. This is a set of characters that, when typed, accept the current suggestion. For example, a suggestion for...

X Description: Problem VS Code (and Visual Studio) have the concept of commit characters for suggestions. This is a set of characters that, when typed, accept the current suggestion. For example, a suggestion for...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/27623

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"TS Server API proposal: Commit Characters","articleBody":"## Problem\r\nVS Code (and Visual Studio) have the concept of commit characters for suggestions. This is a set of characters that, when typed, accept the current suggestion. For example, a suggestion for a function may treat `(` as a commit character.\r\n\r\nVS Code currently computes these commit characters itself using the metadata that typescript returns for each completion entry. This has two problems:\r\n\r\n- This logic is VS Code specific and may be out of sync with how VS and other editors handle commit characters.\r\n\r\n- There are some cases where it is difficult to determine what the commit characters should be. A classic example is:\r\n\r\n```js\r\nconst a = {\r\n    b: 1,\r\n    .|\r\n}\r\n```\r\n\r\nWhere the user has just typed `.`. Currently we show a suggestion for `b` when the user types the `.`. If the user then types another `.` as part of a spread, we incorrectly end up accepting that completion, which leaves the code as:\r\n\r\n```js\r\nconst a = {\r\n    b: 1,\r\n    .b.\r\n}\r\n```\r\n\r\nTypeScript, with its access to the ast, should be able to determine that `.` should not be a commit character in this case\r\n\r\n\r\n## Proposal\r\nIntroduce the concept of a commit characters to the TypeScript server aAPI. This would be an optional set of characters returned on each `CompletionEntry`:\r\n\r\n```ts\r\n interface CompletionEntry {\r\n     ...\r\n\r\n     commitCharacters?: ReadonlyArray\u003cstring>;\r\n}\r\n```\r\n\r\nReturn these commit characters on completions. Here's an approximation of how VS Code computes commit characters:\r\n\r\n* `.` and `;` are commit characters for most completion types except for keywords and a few others.\r\n* Additionally, `(` and `,` are commit characters for variables.\r\n* There are no commit characters if `isNewIdentifierLocation` is set.\r\n","author":{"url":"https://github.com/mjbvz","@type":"Person","name":"mjbvz"},"datePublished":"2018-10-08T22:08:06Z","url":"https://github.com/microsoft/TypeScript/issues/27623"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8511838e-d4a7-315c-3a3c-c58205853713
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8140:2C3566:B62E54:F2C4C8:6B00ED3D
html-safe-noncef7e5b57f63cc5189da67a1c4cce99e0181353001662a00e87f430d01792a8b57
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MTQwOjJDMzU2NjpCNjJFNTQ6RjJDNEM4OjZCMDBFRDNEIiwidmlzaXRvcl9pZCI6IjY1NTAwMDUxNDMxNTk1MDAwOTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac365a2787423dc9f279542de76782f0aa65a7936745a88cb6ecd475b4a5f37e0c
hovercard-subject-tagissue:367969831
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/27623/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b51acdf2ff506d9750d9ec2511b645eb2b020b49b04d97169c201c2cf0659a21/microsoft/TypeScript/issues/27623
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b51acdf2ff506d9750d9ec2511b645eb2b020b49b04d97169c201c2cf0659a21/microsoft/TypeScript/issues/27623
og:image:altProblem VS Code (and Visual Studio) have the concept of commit characters for suggestions. This is a set of characters that, when typed, accept the current suggestion. For example, a suggestion for...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemjbvz
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/27623#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F27623
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F27623
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/27623
Reloadhttps://github.com/microsoft/TypeScript/issues/27623
Reloadhttps://github.com/microsoft/TypeScript/issues/27623
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/27623
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/27623
#59339https://github.com/microsoft/TypeScript/pull/59339
TS Server API proposal: Commit Charactershttps://github.com/microsoft/TypeScript/issues/27623#top
#59339https://github.com/microsoft/TypeScript/pull/59339
https://github.com/gabritto
CommittedThe team has roadmapped this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Committed%22
Domain: LS: TSServerIssues related to the TSServerhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20LS%3A%20TSServer%22
Fix AvailableA PR has been opened for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fix%20Available%22
In DiscussionNot yet reached consensushttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22In%20Discussion%22
RescheduledThis issue was previously scheduled to an earlier milestonehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Rescheduled%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
TypeScript 5.5.0https://github.com/microsoft/TypeScript/milestone/179
https://github.com/mjbvz
Matt Bierner (mjbvz)https://github.com/mjbvz
on Oct 8, 2018https://github.com/microsoft/TypeScript/issues/27623#issue-367969831
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
In DiscussionNot yet reached consensushttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22In%20Discussion%22
Domain: LS: TSServerIssues related to the TSServerhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20LS%3A%20TSServer%22
on Oct 9, 2018https://github.com/microsoft/TypeScript/issues/27623#event-1891912688
https://github.com/mjbvz
Matt Bierner (mjbvz)https://github.com/mjbvz
on Oct 15, 2018https://github.com/microsoft/TypeScript/issues/27623#issuecomment-429972067
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
on Jan 23, 2020https://github.com/microsoft/TypeScript/issues/27623#issuecomment-577476200
#31244https://github.com/microsoft/TypeScript/issues/31244
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
CommittedThe team has roadmapped this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Committed%22
In DiscussionNot yet reached consensushttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22In%20Discussion%22
on May 5, 2021https://github.com/microsoft/TypeScript/issues/27623#event-4690730845
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
TypeScript 4.4.0https://github.com/microsoft/TypeScript/milestone/141
on May 5, 2021https://github.com/microsoft/TypeScript/issues/27623#event-4690731058
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Orta Therox (orta)https://github.com/orta
Armando Aguirre (armanio123)https://github.com/armanio123
Orta Therox (orta)https://github.com/orta
on May 5, 2021https://github.com/microsoft/TypeScript/issues/27623#event-4690733716
Andrew Branch (andrewbranch)https://github.com/andrewbranch
TypeScript 4.4.0 (Beta)https://github.com/microsoft/TypeScript/milestone/141
TypeScript 4.4.1 (RC)https://github.com/microsoft/TypeScript/milestone/144
on Jun 30, 2021https://github.com/microsoft/TypeScript/issues/27623#event-4960292031
Andrew Branch (andrewbranch)https://github.com/andrewbranch
RescheduledThis issue was previously scheduled to an earlier milestonehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Rescheduled%22
on Aug 30, 2021https://github.com/microsoft/TypeScript/issues/27623#event-5229232254
Andrew Branch (andrewbranch)https://github.com/andrewbranch
TypeScript 4.4.1 (RC)https://github.com/microsoft/TypeScript/milestone/144
TypeScript 4.5.0https://github.com/microsoft/TypeScript/milestone/147
on Aug 31, 2021https://github.com/microsoft/TypeScript/issues/27623#event-5229238489
https://github.com/armanio123
Armando Aguirre (armanio123)https://github.com/armanio123
on Sep 8, 2021https://github.com/microsoft/TypeScript/issues/27623#issuecomment-915533399
microsoft/vscode@76885d7https://github.com/microsoft/vscode/commit/76885d753d6749294ab4745e3ceccb6b352b7dfd
Armando Aguirre (armanio123)https://github.com/armanio123
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Sep 8, 2021https://github.com/microsoft/TypeScript/issues/27623#event-5274495991
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Armando Aguirre (armanio123)https://github.com/armanio123
on May 10, 2023https://github.com/microsoft/TypeScript/issues/27623#event-9214769166
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
TypeScript 4.5.0https://github.com/microsoft/TypeScript/milestone/147
on May 10, 2023https://github.com/microsoft/TypeScript/issues/27623#event-9214769415
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
on May 10, 2023https://github.com/microsoft/TypeScript/issues/27623#event-9214769911
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
In DiscussionNot yet reached consensushttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22In%20Discussion%22
on May 16, 2023https://github.com/microsoft/TypeScript/issues/27623#event-9262918618
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Maria Solano (MariaSolOs)https://github.com/MariaSolOs
on May 16, 2023https://github.com/microsoft/TypeScript/issues/27623#event-9262921714
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
TypeScript 5.2.0https://github.com/microsoft/TypeScript/milestone/182
on May 16, 2023https://github.com/microsoft/TypeScript/issues/27623#event-9262922235
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
TypeScript 5.2.0https://github.com/microsoft/TypeScript/milestone/182
TypeScript 5.5.0https://github.com/microsoft/TypeScript/milestone/179
on Mar 4, 2024https://github.com/microsoft/TypeScript/issues/27623#event-12004880009
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
Maria Solano (MariaSolOs)https://github.com/MariaSolOs
on Jul 17, 2024https://github.com/microsoft/TypeScript/issues/27623#event-13541932454
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
Fix AvailableA PR has been opened for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fix%20Available%22
on Jul 18, 2024https://github.com/microsoft/TypeScript/issues/27623#event-13545476957
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#59339https://github.com/microsoft/TypeScript/pull/59339
on Jul 23, 2024https://github.com/microsoft/TypeScript/issues/27623#event-13620591887
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/27623
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/27623
Gabriela Araujo Britto (gabritto)https://github.com/gabritto
CommittedThe team has roadmapped this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Committed%22
Domain: LS: TSServerIssues related to the TSServerhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20LS%3A%20TSServer%22
Fix AvailableA PR has been opened for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fix%20Available%22
In DiscussionNot yet reached consensushttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22In%20Discussion%22
RescheduledThis issue was previously scheduled to an earlier milestonehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Rescheduled%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
TypeScript 5.5.0https://github.com/microsoft/TypeScript/milestone/179
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.