René's URL Explorer Experiment


Title: React higher-order components run into trouble with assignability of `Readonly` intersections · Issue #27484 · microsoft/TypeScript · GitHub

Open Graph Title: React higher-order components run into trouble with assignability of `Readonly` intersections · Issue #27484 · microsoft/TypeScript

X Title: React higher-order components run into trouble with assignability of `Readonly` intersections · Issue #27484 · microsoft/TypeScript

Description: I'm trying to answer this Stack Overflow question on typing a React higher-order component. I've been recommending intersections rather than Exclude for expressing the inner and outer prop types for a higher-order component since TypeScr...

Open Graph Description: I'm trying to answer this Stack Overflow question on typing a React higher-order component. I've been recommending intersections rather than Exclude for expressing the inner and outer prop types fo...

X Description: I'm trying to answer this Stack Overflow question on typing a React higher-order component. I've been recommending intersections rather than Exclude for expressing the inner and outer prop ...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/27484

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"React higher-order components run into trouble with assignability of `Readonly` intersections","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\nI'm trying to answer [this Stack Overflow question](https://stackoverflow.com/q/52525133) on typing a React higher-order component.  I've been recommending intersections rather than `Exclude` for expressing the inner and outer prop types for a higher-order component since TypeScript's type relations and inference seem to handle intersections better than `Exclude` in general.  (I know [this practice has problems](https://github.com/Microsoft/TypeScript/issues/27201#issuecomment-423704673); if you know a better way, please let me know!  For now, `Object.assign` and JSX spreads still generate intersections.)  However, React also uses `Readonly` for prop types, and I've hit an ugly case in which `Readonly` is getting in the way of matching up the intersections between the supplied and expected props.  Many simpler cases seem to work OK, but this one fails.\r\n\r\nI'm not sure if this is a bug but would like the TypeScript team's feedback on the scenario, since the question has been up on Stack Overflow and I doubt anyone from the TypeScript team will ever look at it there.  Hopefully, in consideration of my answering hundreds of TypeScript questions on Stack Overflow and helping triage tens of other issues here, I can have the privilege of occasionally escalating questions I can't answer to the TypeScript team.  Thanks!\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:**  master (8feddcd16d2765afa0ec87305dcf39a619ad61af)\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** readonly mapped type intersection assignable assignability higher order components\r\n\r\n**Code**\r\n```ts\r\nimport * as React from \"react\";\r\n\r\nfunction myHigherOrderComponent\u003cP>(Inner: React.ComponentClass\u003cP & {name: string}>): React.ComponentClass\u003cP> {\r\n    return class OuterComponent extends React.Component\u003cP> {\r\n        render() {\r\n            // Type 'Readonly\u003c{ children?: ReactNode; }> & Readonly\u003cP> & { name: \"Matt\"; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes\u003cComponent\u003cP & { name: string; }, any, any>> & Readonly\u003c{ children?: ReactNode; }> & Readonly\u003cP & { name: string; }>'.\r\n            //   Type 'Readonly\u003c{ children?: ReactNode; }> & Readonly\u003cP> & { name: \"Matt\"; }' is not assignable to type 'Readonly\u003cP & { name: string; }>'.\r\n            return \u003cInner {...this.props} name=\"Matt\"/>;\r\n        }\r\n    };\r\n}\r\n```\r\n\r\nNote: if we replace `React.ComponentClass` with `React.ComponentType`, then the issue does not reproduce due to #27385.  This may be why it hasn't been noticed so far.\r\n\r\n**Expected behavior:** No error.\r\n\r\n**Actual behavior:** Error as marked.\r\n\r\n**Playground Link:** [Link for non-React example](https://www.typescriptlang.org/play/#src=function%20foo%3CP%3E(props%3A%20Readonly%3C%7Bchildren%3F%3A%20string%7D%3E%20%26%20Readonly%3CP%3E)%20%7B%0A%20%20%20%20let%20x%3A%20Readonly%3CP%20%26%20%7B%20name%3A%20string%20%7D%3E%20%3D%20Object.assign(%7B%7D%2C%20props%2C%20%7Bname%3A%20%22Matt%22%7D)%3B%0A%7D%0A)\r\n\r\n**Related Issues:** Possibly #27201\r\n","author":{"url":"https://github.com/mattmccutchen","@type":"Person","name":"mattmccutchen"},"datePublished":"2018-10-01T20:11:03Z","url":"https://github.com/microsoft/TypeScript/issues/27484"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:32df3cce-962b-c304-98f0-99edde473fb0
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDD98:27E5CD:325CC40:406A4DF:6B01CA81
html-safe-nonceb8fd6f5e3b4bb8f0e57090cd242cdbcb60b0ec479e40f147463845c52095136b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDk4OjI3RTVDRDozMjVDQzQwOjQwNkE0REY6NkIwMUNBODEiLCJ2aXNpdG9yX2lkIjoiMjg4MDYwNTU0NjEyODQ2MDQxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac06e77fffe00aad427c8723770b26c93892eb46641f211b9e239311a3e77b0902
hovercard-subject-tagissue:365623151
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/27484/issue_layout
twitter:imagehttps://opengraph.githubassets.com/95f666c727735afd2bd3f932d786250f275077efc9d38977c7eac699833ba823/microsoft/TypeScript/issues/27484
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/95f666c727735afd2bd3f932d786250f275077efc9d38977c7eac699833ba823/microsoft/TypeScript/issues/27484
og:image:altI'm trying to answer this Stack Overflow question on typing a React higher-order component. I've been recommending intersections rather than Exclude for expressing the inner and outer prop types fo...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemattmccutchen
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/27484#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F27484
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F27484
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/27484
Reloadhttps://github.com/microsoft/TypeScript/issues/27484
Reloadhttps://github.com/microsoft/TypeScript/issues/27484
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/27484
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/27484
React higher-order components run into trouble with assignability of Readonly intersectionshttps://github.com/microsoft/TypeScript/issues/27484#top
https://github.com/weswigham
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 3.2https://github.com/microsoft/TypeScript/milestone/77
https://github.com/mattmccutchen
Matt McCutchen (mattmccutchen)https://github.com/mattmccutchen
on Oct 1, 2018https://github.com/microsoft/TypeScript/issues/27484#issue-365623151
this Stack Overflow questionhttps://stackoverflow.com/q/52525133
this practice has problemshttps://github.com/Microsoft/TypeScript/issues/27201#issuecomment-423704673
8feddcdhttps://github.com/microsoft/TypeScript/commit/8feddcd16d2765afa0ec87305dcf39a619ad61af
#27385https://github.com/microsoft/TypeScript/issues/27385
Link for non-React examplehttps://www.typescriptlang.org/play/#src=function%20foo%3CP%3E(props%3A%20Readonly%3C%7Bchildren%3F%3A%20string%7D%3E%20%26%20Readonly%3CP%3E)%20%7B%0A%20%20%20%20let%20x%3A%20Readonly%3CP%20%26%20%7B%20name%3A%20string%20%7D%3E%20%3D%20Object.assign(%7B%7D%2C%20props%2C%20%7Bname%3A%20%22Matt%22%7D)%3B%0A%7D%0A
#27201https://github.com/microsoft/TypeScript/issues/27201
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Wesley Wigham (weswigham)https://github.com/weswigham
on Oct 1, 2018https://github.com/microsoft/TypeScript/issues/27484#event-1877964344
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
Needs InvestigationThis issue needs a team member to investigate its status.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Investigation%22
on Oct 1, 2018https://github.com/microsoft/TypeScript/issues/27484#event-1877964441
Ryan Cavanaugh (RyanCavanaugh)https://github.com/RyanCavanaugh
TypeScript 3.2https://github.com/microsoft/TypeScript/milestone/77
on Oct 1, 2018https://github.com/microsoft/TypeScript/issues/27484#event-1877967321
Matt McCutchen (mattmccutchen)https://github.com/mattmccutchen
on Oct 7, 2018https://github.com/microsoft/TypeScript/issues/27484#event-1888853107
Make T assignable to Readonly if T is assignable to U, not just ifhttps://github.com/mattmccutchen/TypeScript/commit/5cdce29653d4b020c54e48a8ffe0df0267bf422c
https://docs.github.com/articles/closing-issues-via-commit-messages
5cdce29https://github.com/mattmccutchen/TypeScript/commit/5cdce29653d4b020c54e48a8ffe0df0267bf422c
Let assignability checking of generic mapped types decomposehttps://github.com/mattmccutchen/TypeScript/commit/04521dab5fe2a43340b613a5c1c5c22957e22247
https://docs.github.com/articles/closing-issues-via-commit-messages
04521dahttps://github.com/mattmccutchen/TypeScript/commit/04521dab5fe2a43340b613a5c1c5c22957e22247
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
on Oct 9, 2018https://github.com/microsoft/TypeScript/issues/27484#issuecomment-428383935
https://github.com/mattmccutchen
Matt McCutchen (mattmccutchen)https://github.com/mattmccutchen
on Oct 10, 2018https://github.com/microsoft/TypeScript/issues/27484#issuecomment-428402719
#27590https://github.com/microsoft/TypeScript/pull/27590
Matt McCutchen (mattmccutchen)https://github.com/mattmccutchen
on Oct 10, 2018https://github.com/microsoft/TypeScript/issues/27484#event-1894293060
Wesley Wigham (weswigham)https://github.com/weswigham
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
Needs InvestigationThis issue needs a team member to investigate its status.https://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20Investigation%22
on Oct 29, 2018https://github.com/microsoft/TypeScript/issues/27484#event-1933670568
Wesley Wigham (weswigham)https://github.com/weswigham
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#28218https://github.com/microsoft/TypeScript/pull/28218
on Oct 31, 2018https://github.com/microsoft/TypeScript/issues/27484#event-1939088200
microsofthttps://github.com/microsoft
on Oct 21, 2025https://github.com/microsoft/TypeScript/issues/27484#event-20415813474
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/27484
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/27484
Wesley Wigham (weswigham)https://github.com/weswigham
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 3.2https://github.com/microsoft/TypeScript/milestone/77
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.