Title: React higher-order components run into trouble with assignability of `Readonly` intersections · Issue #27484 · microsoft/TypeScript · GitHub
Open Graph Title: React higher-order components run into trouble with assignability of `Readonly` intersections · Issue #27484 · microsoft/TypeScript
X Title: React higher-order components run into trouble with assignability of `Readonly` intersections · Issue #27484 · microsoft/TypeScript
Description: I'm trying to answer this Stack Overflow question on typing a React higher-order component. I've been recommending intersections rather than Exclude for expressing the inner and outer prop types for a higher-order component since TypeScr...
Open Graph Description: I'm trying to answer this Stack Overflow question on typing a React higher-order component. I've been recommending intersections rather than Exclude for expressing the inner and outer prop types fo...
X Description: I'm trying to answer this Stack Overflow question on typing a React higher-order component. I've been recommending intersections rather than Exclude for expressing the inner and outer prop ...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/27484
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"React higher-order components run into trouble with assignability of `Readonly` intersections","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\nI'm trying to answer [this Stack Overflow question](https://stackoverflow.com/q/52525133) on typing a React higher-order component. I've been recommending intersections rather than `Exclude` for expressing the inner and outer prop types for a higher-order component since TypeScript's type relations and inference seem to handle intersections better than `Exclude` in general. (I know [this practice has problems](https://github.com/Microsoft/TypeScript/issues/27201#issuecomment-423704673); if you know a better way, please let me know! For now, `Object.assign` and JSX spreads still generate intersections.) However, React also uses `Readonly` for prop types, and I've hit an ugly case in which `Readonly` is getting in the way of matching up the intersections between the supplied and expected props. Many simpler cases seem to work OK, but this one fails.\r\n\r\nI'm not sure if this is a bug but would like the TypeScript team's feedback on the scenario, since the question has been up on Stack Overflow and I doubt anyone from the TypeScript team will ever look at it there. Hopefully, in consideration of my answering hundreds of TypeScript questions on Stack Overflow and helping triage tens of other issues here, I can have the privilege of occasionally escalating questions I can't answer to the TypeScript team. Thanks!\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** master (8feddcd16d2765afa0ec87305dcf39a619ad61af)\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** readonly mapped type intersection assignable assignability higher order components\r\n\r\n**Code**\r\n```ts\r\nimport * as React from \"react\";\r\n\r\nfunction myHigherOrderComponent\u003cP>(Inner: React.ComponentClass\u003cP & {name: string}>): React.ComponentClass\u003cP> {\r\n return class OuterComponent extends React.Component\u003cP> {\r\n render() {\r\n // Type 'Readonly\u003c{ children?: ReactNode; }> & Readonly\u003cP> & { name: \"Matt\"; }' is not assignable to type 'IntrinsicAttributes & IntrinsicClassAttributes\u003cComponent\u003cP & { name: string; }, any, any>> & Readonly\u003c{ children?: ReactNode; }> & Readonly\u003cP & { name: string; }>'.\r\n // Type 'Readonly\u003c{ children?: ReactNode; }> & Readonly\u003cP> & { name: \"Matt\"; }' is not assignable to type 'Readonly\u003cP & { name: string; }>'.\r\n return \u003cInner {...this.props} name=\"Matt\"/>;\r\n }\r\n };\r\n}\r\n```\r\n\r\nNote: if we replace `React.ComponentClass` with `React.ComponentType`, then the issue does not reproduce due to #27385. This may be why it hasn't been noticed so far.\r\n\r\n**Expected behavior:** No error.\r\n\r\n**Actual behavior:** Error as marked.\r\n\r\n**Playground Link:** [Link for non-React example](https://www.typescriptlang.org/play/#src=function%20foo%3CP%3E(props%3A%20Readonly%3C%7Bchildren%3F%3A%20string%7D%3E%20%26%20Readonly%3CP%3E)%20%7B%0A%20%20%20%20let%20x%3A%20Readonly%3CP%20%26%20%7B%20name%3A%20string%20%7D%3E%20%3D%20Object.assign(%7B%7D%2C%20props%2C%20%7Bname%3A%20%22Matt%22%7D)%3B%0A%7D%0A)\r\n\r\n**Related Issues:** Possibly #27201\r\n","author":{"url":"https://github.com/mattmccutchen","@type":"Person","name":"mattmccutchen"},"datePublished":"2018-10-01T20:11:03Z","url":"https://github.com/microsoft/TypeScript/issues/27484"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:32df3cce-962b-c304-98f0-99edde473fb0 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | DD98:27E5CD:325CC40:406A4DF:6B01CA81 |
| html-safe-nonce | b8fd6f5e3b4bb8f0e57090cd242cdbcb60b0ec479e40f147463845c52095136b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDk4OjI3RTVDRDozMjVDQzQwOjQwNkE0REY6NkIwMUNBODEiLCJ2aXNpdG9yX2lkIjoiMjg4MDYwNTU0NjEyODQ2MDQxNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 06e77fffe00aad427c8723770b26c93892eb46641f211b9e239311a3e77b0902 |
| hovercard-subject-tag | issue:365623151 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/27484/issue_layout |
| twitter:image | https://opengraph.githubassets.com/95f666c727735afd2bd3f932d786250f275077efc9d38977c7eac699833ba823/microsoft/TypeScript/issues/27484 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/95f666c727735afd2bd3f932d786250f275077efc9d38977c7eac699833ba823/microsoft/TypeScript/issues/27484 |
| og:image:alt | I'm trying to answer this Stack Overflow question on typing a React higher-order component. I've been recommending intersections rather than Exclude for expressing the inner and outer prop types fo... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mattmccutchen |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width