René's URL Explorer Experiment


Title: Slow error reporting in TSX. · Issue #26680 · microsoft/TypeScript · GitHub

Open Graph Title: Slow error reporting in TSX. · Issue #26680 · microsoft/TypeScript

X Title: Slow error reporting in TSX. · Issue #26680 · microsoft/TypeScript

Description: TypeScript Version: 3.1.0-dev.20180825 Search Terms: jsx, performance, slow Issue We find out that an error reporting in medium size React project is quite slow, especially in entry component like App.tsx. For example, our App.tsx contai...

Open Graph Description: TypeScript Version: 3.1.0-dev.20180825 Search Terms: jsx, performance, slow Issue We find out that an error reporting in medium size React project is quite slow, especially in entry component like ...

X Description: TypeScript Version: 3.1.0-dev.20180825 Search Terms: jsx, performance, slow Issue We find out that an error reporting in medium size React project is quite slow, especially in entry component like ...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/26680

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Slow error reporting in TSX.","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:**  3.1.0-dev.20180825\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** jsx, performance, slow\r\n\r\n**Issue**\r\nWe find out that an error reporting in medium size React project is quite slow, especially in entry component like `App.tsx`.\r\n\r\nFor example, our `App.tsx` contains a lot of routes (react-router v4). These routes are rendering another components, which contains another bunch of routes, etc.\r\n\r\nThis approach is quite normal as you actually defining a whole application hierarchy in `App.tsx`. So, basically this entry component is referring to each component in a project.\r\n \r\nWe find out that error reporting is much slower in `App.tsx` than in some other component in hierarchy.  Here is a simplified code:\r\n\r\n```ts\r\n\r\n// App.tsx\r\nexport default function App() {\r\n  return (\r\n    \u003cFragment>\r\n      \u003cUntrustedLink href=\"https://www.typescriptlang.org/\" />\r\n      \u003cAdminSection />\r\n      ...\r\n    \u003c/Fragment>\r\n  );\r\n}\r\n\r\n// AdminSection.tsx\r\nexport default function AdminSection() {\r\n  return (\r\n    \u003cFragment>\r\n      \u003cRoute path=\"...\" component={Cmp1} />\r\n      \u003cRoute path=\"...\" component={Cmp2} />\r\n      ...\r\n    \u003c/Fragment>\r\n  );\r\n}\r\n```\r\n\r\nNow, when I do some mistake in `App.tsx` like changing `href=\"...\"` to `hrefa=\"...\"`, VSCode fires a request to `tsserver` and it responds with an error message. However, it took like 2 seconds to complete.\r\n\r\nHowever, if we add a return type to AdminSection function\r\n```ts\r\nexport default function AdminSection(): any {\r\n```\r\n\r\nthen it is much faster and it took like 1 second.\r\n\r\nIt was measured in simplified code. In our real code, it took like 3 -4 seconds to report a proper error.\r\n\r\n**This leads me to my question**: Is there any caching for unchanged files? Because it looks like TS is trying to infer the return type of a referred function each time I change an `App.tsx` even when other files didn't change. Providing an explicit return type obviously speed up this process as TS is probably skipping inferring process. Adding more components without explicit return type makes this slower and slower.\r\n\r\n*I'm not sure if it is related to JSX. Probably not, but it is definitely most noticeable in React apps.*\r\n\r\nTested on macOS, Node 10.9, VSCode (insiders), TS 3.0.1 and  3.1.0-dev.20180825.\r\n\r\n**Possibly related:** https://github.com/Microsoft/TypeScript/pull/25302\r\n\r\n**TSServer logs (with inferred return types)**\r\nInfo 1132 [9:44:0.481] request:\r\n{\"seq\":27,\"type\":\"request\",\"command\":\"change\",\"arguments\":{\"insertString\":\"a\",\"file\":\"/Users/deftomat/Development/projects/efa-test/src/pages/App.tsx\",\"line\":83,\"offset\":32,\"endLine\":83,\"endOffset\":32}}\r\n\r\nInfo 1155 [9:44:2.413] event:\r\n{\"seq\":0,\"type\":\"event\",\"event\":\"semanticDiag\",\"body\":{\"file\":\"/Users/deftomat/Development/projects/efa-test/src/pages/App.tsx\",\"diagnostics\":[{\"start\":{\"line\":83,\"offset\":14},\"end\":{\"line\":83,\"offset\":27},\"text\":\"Type '{ hrefa: string; }' is not assignable to type 'Props'.\\n  Property 'href' is missing in type '{ hrefa: string; }'.\",\"code\":2322,\"category\":\"error\"}]}}\r\n\r\n**TSServer logs (with explicit return types)**\r\nInfo 1630 [9:48:10.441] request:\r\n{\"seq\":127,\"type\":\"request\",\"command\":\"change\",\"arguments\":{\"insertString\":\"a\",\"file\":\"/Users/deftomat/Development/projects/efa-test/src/pages/App.tsx\",\"line\":83,\"offset\":32,\"endLine\":83,\"endOffset\":32}}\r\n\r\nInfo 1653 [9:48:11.52] event:\r\n{\"seq\":0,\"type\":\"event\",\"event\":\"semanticDiag\",\"body\":{\"file\":\"/Users/deftomat/Development/projects/efa-test/src/pages/App.tsx\",\"diagnostics\":[{\"start\":{\"line\":83,\"offset\":14},\"end\":{\"line\":83,\"offset\":27},\"text\":\"Type '{ hrefa: string; }' is not assignable to type 'Props'.\\n  Property 'href' is missing in type '{ hrefa: string; }'.\",\"code\":2322,\"category\":\"error\"}]}}\r\n","author":{"url":"https://github.com/deftomat","@type":"Person","name":"deftomat"},"datePublished":"2018-08-26T08:18:52Z","url":"https://github.com/microsoft/TypeScript/issues/26680"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:3ae47f12-8668-39b9-adfe-1af3a8a19b5c
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB36C:928E2:D97264:1231BF8:6B010279
html-safe-nonce395add454c13fb7eaa4695535a53e52f2765b1fad325adbe06cb4d70e09a8b55
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzZDOjkyOEUyOkQ5NzI2NDoxMjMxQkY4OjZCMDEwMjc5IiwidmlzaXRvcl9pZCI6IjIyMjgwMjc5NDAyOTYyNjIyNjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacba019ec109fbb579ee73d78d23f79b9ffaa0688d4f0705aa0c21e0014bd0a81d
hovercard-subject-tagissue:354076433
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/26680/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b31f62efac6086e567235df8d9ee211f60e17f6bd9f98ca20b9a4e5dc625edf5/microsoft/TypeScript/issues/26680
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b31f62efac6086e567235df8d9ee211f60e17f6bd9f98ca20b9a4e5dc625edf5/microsoft/TypeScript/issues/26680
og:image:altTypeScript Version: 3.1.0-dev.20180825 Search Terms: jsx, performance, slow Issue We find out that an error reporting in medium size React project is quite slow, especially in entry component like ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedeftomat
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/26680#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F26680
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F26680
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/26680
Reloadhttps://github.com/microsoft/TypeScript/issues/26680
Reloadhttps://github.com/microsoft/TypeScript/issues/26680
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/26680
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/26680
Slow error reporting in TSX.https://github.com/microsoft/TypeScript/issues/26680#top
https://github.com/weswigham
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
Needs More InfoThe issue still hasn't been fully clarifiedhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20More%20Info%22
TypeScript 3.2https://github.com/microsoft/TypeScript/milestone/77
https://github.com/deftomat
Tomáš Szabo (deftomat)https://github.com/deftomat
on Aug 26, 2018https://github.com/microsoft/TypeScript/issues/26680#issue-354076433
#25302https://github.com/microsoft/TypeScript/pull/25302
Tomáš Szabo (deftomat)https://github.com/deftomat
on Aug 30, 2018https://github.com/microsoft/TypeScript/issues/26680#event-1817293836
Tomáš Szabo (deftomat)https://github.com/deftomat
on Aug 30, 2018https://github.com/microsoft/TypeScript/issues/26680#event-1817294118
Tomáš Szabo (deftomat)https://github.com/deftomat
on Aug 30, 2018https://github.com/microsoft/TypeScript/issues/26680#event-1817294240
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Wesley Wigham (weswigham)https://github.com/weswigham
on Sep 7, 2018https://github.com/microsoft/TypeScript/issues/26680#event-1832126976
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
TypeScript 3.2https://github.com/microsoft/TypeScript/milestone/77
on Sep 7, 2018https://github.com/microsoft/TypeScript/issues/26680#event-1832127056
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
on Sep 7, 2018https://github.com/microsoft/TypeScript/issues/26680#event-1832127308
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
on Sep 7, 2018https://github.com/microsoft/TypeScript/issues/26680#issuecomment-419342500
Wesley Wigham (@weswigham)https://github.com/weswigham
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Needs More InfoThe issue still hasn't been fully clarifiedhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20More%20Info%22
on Sep 7, 2018https://github.com/microsoft/TypeScript/issues/26680#event-1832129335
Tomáš Szabo (deftomat)https://github.com/deftomat
on Sep 7, 2018https://github.com/microsoft/TypeScript/issues/26680#event-1832200509
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
on Sep 7, 2018https://github.com/microsoft/TypeScript/issues/26680#issuecomment-419499232
https://github.com/deftomat
Tomáš Szabo (deftomat)https://github.com/deftomat
on Sep 7, 2018https://github.com/microsoft/TypeScript/issues/26680#issuecomment-419513399
Wesley Wigham (@weswigham)https://github.com/weswigham
https://github.com/deftomat
Tomáš Szabo (deftomat)https://github.com/deftomat
on Sep 11, 2018https://github.com/microsoft/TypeScript/issues/26680#issuecomment-420170723
Wesley Wigham (@weswigham)https://github.com/weswigham
https://github.com/deftomat/error-reporting-in-tsxhttps://github.com/deftomat/error-reporting-in-tsx
this linehttps://github.com/deftomat/error-reporting-in-tsx/blob/master/src/pages/App.tsx#L46
microsoft/vscode#56909https://github.com/microsoft/vscode/issues/56909
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
on Sep 26, 2018https://github.com/microsoft/TypeScript/issues/26680#issuecomment-424877019
Tomáš Szabo (@deftomat)https://github.com/deftomat
Wesley Wigham (weswigham)https://github.com/weswigham
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#27378https://github.com/microsoft/TypeScript/pull/27378
on Oct 5, 2018https://github.com/microsoft/TypeScript/issues/26680#event-1888166957
https://github.com/deftomat
Tomáš Szabo (deftomat)https://github.com/deftomat
on Oct 8, 2018https://github.com/microsoft/TypeScript/issues/26680#issuecomment-427775935
Wesley Wigham (@weswigham)https://github.com/weswigham
microsofthttps://github.com/microsoft
on Oct 21, 2025https://github.com/microsoft/TypeScript/issues/26680#event-20415780973
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/26680
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/26680
Wesley Wigham (weswigham)https://github.com/weswigham
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
Needs More InfoThe issue still hasn't been fully clarifiedhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Needs%20More%20Info%22
TypeScript 3.2https://github.com/microsoft/TypeScript/milestone/77
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.