Title: Slow error reporting in TSX. · Issue #26680 · microsoft/TypeScript · GitHub
Open Graph Title: Slow error reporting in TSX. · Issue #26680 · microsoft/TypeScript
X Title: Slow error reporting in TSX. · Issue #26680 · microsoft/TypeScript
Description: TypeScript Version: 3.1.0-dev.20180825 Search Terms: jsx, performance, slow Issue We find out that an error reporting in medium size React project is quite slow, especially in entry component like App.tsx. For example, our App.tsx contai...
Open Graph Description: TypeScript Version: 3.1.0-dev.20180825 Search Terms: jsx, performance, slow Issue We find out that an error reporting in medium size React project is quite slow, especially in entry component like ...
X Description: TypeScript Version: 3.1.0-dev.20180825 Search Terms: jsx, performance, slow Issue We find out that an error reporting in medium size React project is quite slow, especially in entry component like ...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/26680
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Slow error reporting in TSX.","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** 3.1.0-dev.20180825\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** jsx, performance, slow\r\n\r\n**Issue**\r\nWe find out that an error reporting in medium size React project is quite slow, especially in entry component like `App.tsx`.\r\n\r\nFor example, our `App.tsx` contains a lot of routes (react-router v4). These routes are rendering another components, which contains another bunch of routes, etc.\r\n\r\nThis approach is quite normal as you actually defining a whole application hierarchy in `App.tsx`. So, basically this entry component is referring to each component in a project.\r\n \r\nWe find out that error reporting is much slower in `App.tsx` than in some other component in hierarchy. Here is a simplified code:\r\n\r\n```ts\r\n\r\n// App.tsx\r\nexport default function App() {\r\n return (\r\n \u003cFragment>\r\n \u003cUntrustedLink href=\"https://www.typescriptlang.org/\" />\r\n \u003cAdminSection />\r\n ...\r\n \u003c/Fragment>\r\n );\r\n}\r\n\r\n// AdminSection.tsx\r\nexport default function AdminSection() {\r\n return (\r\n \u003cFragment>\r\n \u003cRoute path=\"...\" component={Cmp1} />\r\n \u003cRoute path=\"...\" component={Cmp2} />\r\n ...\r\n \u003c/Fragment>\r\n );\r\n}\r\n```\r\n\r\nNow, when I do some mistake in `App.tsx` like changing `href=\"...\"` to `hrefa=\"...\"`, VSCode fires a request to `tsserver` and it responds with an error message. However, it took like 2 seconds to complete.\r\n\r\nHowever, if we add a return type to AdminSection function\r\n```ts\r\nexport default function AdminSection(): any {\r\n```\r\n\r\nthen it is much faster and it took like 1 second.\r\n\r\nIt was measured in simplified code. In our real code, it took like 3 -4 seconds to report a proper error.\r\n\r\n**This leads me to my question**: Is there any caching for unchanged files? Because it looks like TS is trying to infer the return type of a referred function each time I change an `App.tsx` even when other files didn't change. Providing an explicit return type obviously speed up this process as TS is probably skipping inferring process. Adding more components without explicit return type makes this slower and slower.\r\n\r\n*I'm not sure if it is related to JSX. Probably not, but it is definitely most noticeable in React apps.*\r\n\r\nTested on macOS, Node 10.9, VSCode (insiders), TS 3.0.1 and 3.1.0-dev.20180825.\r\n\r\n**Possibly related:** https://github.com/Microsoft/TypeScript/pull/25302\r\n\r\n**TSServer logs (with inferred return types)**\r\nInfo 1132 [9:44:0.481] request:\r\n{\"seq\":27,\"type\":\"request\",\"command\":\"change\",\"arguments\":{\"insertString\":\"a\",\"file\":\"/Users/deftomat/Development/projects/efa-test/src/pages/App.tsx\",\"line\":83,\"offset\":32,\"endLine\":83,\"endOffset\":32}}\r\n\r\nInfo 1155 [9:44:2.413] event:\r\n{\"seq\":0,\"type\":\"event\",\"event\":\"semanticDiag\",\"body\":{\"file\":\"/Users/deftomat/Development/projects/efa-test/src/pages/App.tsx\",\"diagnostics\":[{\"start\":{\"line\":83,\"offset\":14},\"end\":{\"line\":83,\"offset\":27},\"text\":\"Type '{ hrefa: string; }' is not assignable to type 'Props'.\\n Property 'href' is missing in type '{ hrefa: string; }'.\",\"code\":2322,\"category\":\"error\"}]}}\r\n\r\n**TSServer logs (with explicit return types)**\r\nInfo 1630 [9:48:10.441] request:\r\n{\"seq\":127,\"type\":\"request\",\"command\":\"change\",\"arguments\":{\"insertString\":\"a\",\"file\":\"/Users/deftomat/Development/projects/efa-test/src/pages/App.tsx\",\"line\":83,\"offset\":32,\"endLine\":83,\"endOffset\":32}}\r\n\r\nInfo 1653 [9:48:11.52] event:\r\n{\"seq\":0,\"type\":\"event\",\"event\":\"semanticDiag\",\"body\":{\"file\":\"/Users/deftomat/Development/projects/efa-test/src/pages/App.tsx\",\"diagnostics\":[{\"start\":{\"line\":83,\"offset\":14},\"end\":{\"line\":83,\"offset\":27},\"text\":\"Type '{ hrefa: string; }' is not assignable to type 'Props'.\\n Property 'href' is missing in type '{ hrefa: string; }'.\",\"code\":2322,\"category\":\"error\"}]}}\r\n","author":{"url":"https://github.com/deftomat","@type":"Person","name":"deftomat"},"datePublished":"2018-08-26T08:18:52Z","url":"https://github.com/microsoft/TypeScript/issues/26680"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:3ae47f12-8668-39b9-adfe-1af3a8a19b5c |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B36C:928E2:D97264:1231BF8:6B010279 |
| html-safe-nonce | 395add454c13fb7eaa4695535a53e52f2765b1fad325adbe06cb4d70e09a8b55 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzZDOjkyOEUyOkQ5NzI2NDoxMjMxQkY4OjZCMDEwMjc5IiwidmlzaXRvcl9pZCI6IjIyMjgwMjc5NDAyOTYyNjIyNjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ba019ec109fbb579ee73d78d23f79b9ffaa0688d4f0705aa0c21e0014bd0a81d |
| hovercard-subject-tag | issue:354076433 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/26680/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b31f62efac6086e567235df8d9ee211f60e17f6bd9f98ca20b9a4e5dc625edf5/microsoft/TypeScript/issues/26680 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b31f62efac6086e567235df8d9ee211f60e17f6bd9f98ca20b9a4e5dc625edf5/microsoft/TypeScript/issues/26680 |
| og:image:alt | TypeScript Version: 3.1.0-dev.20180825 Search Terms: jsx, performance, slow Issue We find out that an error reporting in medium size React project is quite slow, especially in entry component like ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | deftomat |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width