Title: Jsdoc error at jakefile · Issue #25657 · microsoft/TypeScript · GitHub
Open Graph Title: Jsdoc error at jakefile · Issue #25657 · microsoft/TypeScript
X Title: Jsdoc error at jakefile · Issue #25657 · microsoft/TypeScript
Description: While doing #25656 I see that jakefile has an error at https://github.com/Microsoft/TypeScript/blob/47e513e1517b4d7e96c4a31448189fea4d9534ab/Jakefile.js#L504 because that function has three needed parameters. See jsdoc at implementation ...
Open Graph Description: While doing #25656 I see that jakefile has an error at https://github.com/Microsoft/TypeScript/blob/47e513e1517b4d7e96c4a31448189fea4d9534ab/Jakefile.js#L504 because that function has three needed ...
X Description: While doing #25656 I see that jakefile has an error at https://github.com/Microsoft/TypeScript/blob/47e513e1517b4d7e96c4a31448189fea4d9534ab/Jakefile.js#L504 because that function has three needed ...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/25657
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Jsdoc error at jakefile","articleBody":"While doing #25656 I see that jakefile has an error at https://github.com/Microsoft/TypeScript/blob/47e513e1517b4d7e96c4a31448189fea4d9534ab/Jakefile.js#L504\r\nbecause that function has three needed parameters. See jsdoc at implementation (the third is not optional):\r\nhttps://github.com/Microsoft/TypeScript/blob/47e513e1517b4d7e96c4a31448189fea4d9534ab/Jakefile.js#L816-L839\r\n\r\nThe implementation treats the third parameter as optional, but the only call to this function don't use it.\r\nIs better remove the third parameter or make it optional?\r\n\r\nCC @RyanCavanaugh since you changed this code the last time.","author":{"url":"https://github.com/j-oliveras","@type":"Person","name":"j-oliveras"},"datePublished":"2018-07-13T23:17:37Z","url":"https://github.com/microsoft/TypeScript/issues/25657"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:fc031ca4-9520-9f3d-f1dd-b952c92cdfa5 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C8FC:36A3E:2299FCE:2E2394A:6B01936D |
| html-safe-nonce | bca4a4c24999661b3c0e8c0b9da1f94ad82be63c66cca50140504056d2ed8dc3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOEZDOjM2QTNFOjIyOTlGQ0U6MkUyMzk0QTo2QjAxOTM2RCIsInZpc2l0b3JfaWQiOiIxODMyNTkxMTUxNzU3MTAzOTgxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c8a20b4855a451d2e8131f6340a3cd3b881866401caa4a3f9f2d2489a1bc8cd7 |
| hovercard-subject-tag | issue:341184994 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/25657/issue_layout |
| twitter:image | https://opengraph.githubassets.com/3a783ef408336a7f62b16c120252006b20c147009c5e5a1df0c44fb0b029c68c/microsoft/TypeScript/issues/25657 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3a783ef408336a7f62b16c120252006b20c147009c5e5a1df0c44fb0b029c68c/microsoft/TypeScript/issues/25657 |
| og:image:alt | While doing #25656 I see that jakefile has an error at https://github.com/Microsoft/TypeScript/blob/47e513e1517b4d7e96c4a31448189fea4d9534ab/Jakefile.js#L504 because that function has three needed ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | j-oliveras |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width