Title: Expressions in JS special assignments don't use jsdoc for contextual type · Issue #25571 · microsoft/TypeScript · GitHub
Open Graph Title: Expressions in JS special assignments don't use jsdoc for contextual type · Issue #25571 · microsoft/TypeScript
X Title: Expressions in JS special assignments don't use jsdoc for contextual type · Issue #25571 · microsoft/TypeScript
Description: TypeScript Version: 3.0.0-dev.20180710 Search Terms: tagged discriminated union property this jsdoc checkjs allowjs literal The following typescript works great: type DoneStatus = { status: 'done'; count: number; }; type ErrorStatus = { ...
Open Graph Description: TypeScript Version: 3.0.0-dev.20180710 Search Terms: tagged discriminated union property this jsdoc checkjs allowjs literal The following typescript works great: type DoneStatus = { status: 'done';...
X Description: TypeScript Version: 3.0.0-dev.20180710 Search Terms: tagged discriminated union property this jsdoc checkjs allowjs literal The following typescript works great: type DoneStatus = { status: 'do...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/25571
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Expressions in JS special assignments don't use jsdoc for contextual type","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** 3.0.0-dev.20180710\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** tagged discriminated union property this jsdoc checkjs allowjs literal\r\n\r\nThe following typescript works great:\r\n```ts\r\ntype DoneStatus = {\r\n status: 'done';\r\n count: number;\r\n};\r\n\r\ntype ErrorStatus = {\r\n status: 'error';\r\n error: Error;\r\n};\r\n\r\ntype Status = DoneStatus | ErrorStatus;\r\n\r\nclass Thing {\r\n s: Status;\r\n constructor() {\r\n this.s = { status: 'done', count: 3 };\r\n }\r\n\r\n fail() {\r\n this.s = { status: 'error', error: new Error() };\r\n }\r\n}\r\n```\r\n\r\nHowever, the equivalent JS does not:\r\n\r\n```js\r\n/**\r\n * @typedef DoneStatus\r\n * @property {'done'} status\r\n * @property {number} count\r\n */\r\n\r\n/**\r\n * @typedef ErrorStatus\r\n * @property {'error'} status\r\n * @property {Error} error\r\n */\r\n\r\n/** @typedef {DoneStatus | ErrorStatus} Status */\r\n\r\nclass Thing {\r\n constructor() {\r\n /** @type {Status} */\r\n this.s = { status: 'done', count: 3 }; // ts error\r\n }\r\n\r\n fail() {\r\n this.s = { status: 'error', error: new Error() }; // ts error\r\n }\r\n}\r\n```\r\nBoth assignments give the error:\r\n```\r\n[ts] Type 'string' is not assignable to type '\"error\" | \"done\"'.\r\ntest.js(3, 4): The expected type comes from property 'status' which is declared here on type 'DoneStatus | ErrorStatus'\r\n(property) status: string\r\n```\r\n**Expected behavior:**\r\nJS behaves the same as TS version\r\n","author":{"url":"https://github.com/akdor1154","@type":"Person","name":"akdor1154"},"datePublished":"2018-07-11T05:24:31Z","url":"https://github.com/microsoft/TypeScript/issues/25571"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:3285e0a0-39a2-7f3b-4e52-42d2698b6236 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 82FE:215B92:22DB6D1:2E63C11:6B019056 |
| html-safe-nonce | 410ed772a643bfe863885fb8052257e1eb81ccb6eb72110c7f2355a472c4f5df |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MkZFOjIxNUI5MjoyMkRCNkQxOjJFNjNDMTE6NkIwMTkwNTYiLCJ2aXNpdG9yX2lkIjoiOTcyNDAwMTU1ODY4MjQyNzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 2e8f6da94d1c6b43785d0af1748c3668368621ea1e6e729d88f3f5ad144cc70a |
| hovercard-subject-tag | issue:340096252 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/25571/issue_layout |
| twitter:image | https://opengraph.githubassets.com/ea7a8907f1802c186500ca31de7f9a6df783c516aa14e23a662e89202d96124e/microsoft/TypeScript/issues/25571 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/ea7a8907f1802c186500ca31de7f9a6df783c516aa14e23a662e89202d96124e/microsoft/TypeScript/issues/25571 |
| og:image:alt | TypeScript Version: 3.0.0-dev.20180710 Search Terms: tagged discriminated union property this jsdoc checkjs allowjs literal The following typescript works great: type DoneStatus = { status: 'done';... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | akdor1154 |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width