René's URL Explorer Experiment


Title: Change to references' lineText property breaks find-all-references in emacs · Issue #25489 · microsoft/TypeScript · GitHub

Open Graph Title: Change to references' lineText property breaks find-all-references in emacs · Issue #25489 · microsoft/TypeScript

X Title: Change to references' lineText property breaks find-all-references in emacs · Issue #25489 · microsoft/TypeScript

Description: var g = function (x) { console.log(x) return x/**/ } Find all references at x (any of them) in emacs. Expected behavior: Three lines: test.js 6:var g = function (x) { 7: console.log(x) 8: return x Actual behavior: Crash with emacs' inscr...

Open Graph Description: var g = function (x) { console.log(x) return x/**/ } Find all references at x (any of them) in emacs. Expected behavior: Three lines: test.js 6:var g = function (x) { 7: console.log(x) 8: return x ...

X Description: var g = function (x) { console.log(x) return x/**/ } Find all references at x (any of them) in emacs. Expected behavior: Three lines: test.js 6:var g = function (x) { 7: console.log(x) 8: return x ...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/25489

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Change to references' lineText property breaks find-all-references in emacs","articleBody":"```ts\r\nvar g = function (x) {\r\n  console.log(x)\r\n  return x/**/\r\n}\r\n```\r\n\r\nFind all references at x (any of them) in emacs.\r\n\r\n**Expected behavior:**\r\nThree lines:\r\n\r\n```\r\ntest.js\r\n  6:var g = function (x) {\r\n  7:  console.log(x)\r\n  8:  return x\r\n```\r\n\r\n**Actual behavior:**\r\nCrash with emacs' inscrutable equivalent of index out of bounds (\"let: Args out of range: 18, 19\"). Deleting the body of `tide-annotate-line` stops the crash and exposes the real problem:\r\n\r\n```\r\ntest.js\r\n  6:x\r\n  7:x\r\n  8:x\r\n```\r\n\r\nlineText was previously the entire line text and is now just the text of the identifier. I am pretty sure that #25283 caused this change. I *think* it is unintentional and incorrect based on the description in protocol.ts:\r\n\r\n```ts\r\n        /** Text of line containing the reference.  Including this\r\n         *  with the response avoids latency of editor loading files\r\n         * to show text of reference line (the server already has\r\n         * loaded the referencing files).\r\n         */\r\n        lineText: string;\r\n```\r\n\r\nActually setting up emacs + tide + custom tsserver + custom logger is cumbersome and probably not necessary. Here is the before/after json object for this request:\r\n\r\n## 2.9.2\r\n\r\n```json\r\n{\"seq\":0,\"type\":\"response\",\"command\":\"references\",\"request_seq\":\"200\",\"success\":true,\"body\":{\"refs\":[\r\n    {\"file\":\"/home/n/src/test/test.js\",\"start\":{\"line\":6,\"offset\":19},\"lineText\":\"var g = function (x) {\",\"end\":{\"line\":6,\"offset\":20},\"isWriteAccess\":true,\"isDefinition\":true},\r\n    {\"file\":\"/home/n/src/test/test.js\",\"start\":{\"line\":7,\"offset\":17},\"lineText\":\"    console.log(x);\",\"end\":{\"line\":7,\"offset\":18},\"isWriteAccess\":false,\"isDefinition\":false},\r\n    {\"file\":\"/home/n/src/test/test.js\",\"start\":{\"line\":8,\"offset\":12},\"lineText\":\"    return x }\",\"end\":{\"line\":8,\"offset\":13},\"isWriteAccess\":false,\"isDefinition\":false}],\"symbolName\":\"x\",\"symbolStartOffset\":12,\"symbolDisplayString\":\"(parameter) x: HTMLElement\"}}\r\n```\r\n\r\n## 3.0\r\n```\r\n{\"seq\":0,\"type\":\"response\",\"command\":\"references\",\"request_seq\":\"203\",\"success\":true,\"body\":{\"refs\":[\r\n    {\"file\":\"/home/n/src/test/test.js\",\"start\":{\"line\":6,\"offset\":19},\"end\":{\"line\":6,\"offset\":20},\"lineText\":\"x\",\"isWriteAccess\":true,\"isDefinition\":true},\r\n    {\"file\":\"/home/n/src/test/test.js\",\"start\":{\"line\":7,\"offset\":17},\"end\":{\"line\":7,\"offset\":18},\"lineText\":\"x\",\"isWriteAccess\":false,\"isDefinition\":false},\r\n    {\"file\":\"/home/n/src/test/test.js\",\"start\":{\"line\":8,\"offset\":12},\"end\":{\"line\":8,\"offset\":13},\"lineText\":\"x\",\"isWriteAccess\":false,\"isDefinition\":false}],\"symbolName\":\"x\",\"symbolStartOffset\":12,\"symbolDisplayString\":\"(parameter) x: HTMLElement\"}}\r\n```","author":{"url":"https://github.com/sandersn","@type":"Person","name":"sandersn"},"datePublished":"2018-07-06T22:10:13Z","url":"https://github.com/microsoft/TypeScript/issues/25489"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:40fb3e22-6643-838e-9ab8-5a8a9d3e650a
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE812:2BE220:1F96222:2A1ADD3:6B017CAC
html-safe-noncef245c6288bd7a6089d4d2cfeac3fd5d2b942055e35f563159438c28086942fab
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODEyOjJCRTIyMDoxRjk2MjIyOjJBMUFERDM6NkIwMTdDQUMiLCJ2aXNpdG9yX2lkIjoiMTIzMDk1ODgyNDQ5MjQ2NTMyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7b55e7354749a5899af5b3d48abb02fa5f61a3930b1b190213bc38a132f35210
hovercard-subject-tagissue:339084640
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/25489/issue_layout
twitter:imagehttps://opengraph.githubassets.com/68cf72e310e02dba6feccd4aa3842081191f2c3d3d36b511128a3bfea1420f38/microsoft/TypeScript/issues/25489
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/68cf72e310e02dba6feccd4aa3842081191f2c3d3d36b511128a3bfea1420f38/microsoft/TypeScript/issues/25489
og:image:altvar g = function (x) { console.log(x) return x/**/ } Find all references at x (any of them) in emacs. Expected behavior: Three lines: test.js 6:var g = function (x) { 7: console.log(x) 8: return x ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesandersn
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/25489#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F25489
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F25489
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/25489
Reloadhttps://github.com/microsoft/TypeScript/issues/25489
Reloadhttps://github.com/microsoft/TypeScript/issues/25489
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/25489
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/25489
Change to references' lineText property breaks find-all-references in emacshttps://github.com/microsoft/TypeScript/issues/25489#top
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 3.0.1https://github.com/microsoft/TypeScript/milestone/75
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
on Jul 6, 2018https://github.com/microsoft/TypeScript/issues/25489#issue-339084640
#25283https://github.com/microsoft/TypeScript/pull/25283
https://github.com/sandersn
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
on Jul 6, 2018https://github.com/microsoft/TypeScript/issues/25489#issuecomment-403159263
Anantha Kumaran (@ananthakumaran)https://github.com/ananthakumaran
Nathan Shively-Sanders (sandersn)https://github.com/sandersn
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#25494https://github.com/microsoft/TypeScript/pull/25494
on Jul 6, 2018https://github.com/microsoft/TypeScript/issues/25489#event-1721229051
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
on Jul 6, 2018https://github.com/microsoft/TypeScript/issues/25489#event-1721244213
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
TypeScript 3.0.1https://github.com/microsoft/TypeScript/milestone/75
on Jul 6, 2018https://github.com/microsoft/TypeScript/issues/25489#event-1721244247
microsofthttps://github.com/microsoft
on Oct 21, 2025https://github.com/microsoft/TypeScript/issues/25489#event-20415728791
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/25489
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/25489
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 3.0.1https://github.com/microsoft/TypeScript/milestone/75
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.