Title: Setters not accounted for by strictNullChecks & strictPropertyInitialization · Issue #24937 · microsoft/TypeScript · GitHub
Open Graph Title: Setters not accounted for by strictNullChecks & strictPropertyInitialization · Issue #24937 · microsoft/TypeScript
X Title: Setters not accounted for by strictNullChecks & strictPropertyInitialization · Issue #24937 · microsoft/TypeScript
Description: TypeScript Version: 2.9.2 & 3.0.0-dev.20180609 Search Terms: setter Code When enabling the strictNullChecks and strictPropertyInitialization tsconfig options tsc produces an error when it shouldn't. It looks like the rule implementation ...
Open Graph Description: TypeScript Version: 2.9.2 & 3.0.0-dev.20180609 Search Terms: setter Code When enabling the strictNullChecks and strictPropertyInitialization tsconfig options tsc produces an error when it shouldn't...
X Description: TypeScript Version: 2.9.2 & 3.0.0-dev.20180609 Search Terms: setter Code When enabling the strictNullChecks and strictPropertyInitialization tsconfig options tsc produces an error when it shoul...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/24937
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Setters not accounted for by strictNullChecks & strictPropertyInitialization","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** 2.9.2 & 3.0.0-dev.20180609\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** \r\nsetter\r\n\r\n**Code**\r\n\r\nWhen enabling the `strictNullChecks` and `strictPropertyInitialization` tsconfig options tsc produces an error when it shouldn't. It looks like the rule implementation of the aforementioned strict flags might not account for setters? Easily verifiable in the [typescript repl](http://www.typescriptlang.org/play/#src=class%20Foo%20%7B%0D%0A%20%20%20%20private%20_x%3A%20number%3B%0D%0A%20%20%20%20public%20set%20x(nx%3A%20number)%20%7B%0D%0A%20%20%20%20%20%20%20%20this._x%20%3D%20nx%3B%0D%0A%20%20%20%20%7D%0D%0A%20%20%20%20constructor()%20%7B%0D%0A%20%20%20%20%20%20%20%20this.x%20%3D%201%3B%0D%0A%20%20%20%20%7D%0D%0A%7D%0D%0A) too, once enabling the flags.\r\n\r\n```ts\r\nclass Foo {\r\n private _x: number;\r\n public set x(nx: number) {\r\n this._x = nx;\r\n }\r\n constructor() {\r\n this.x = 1;\r\n }\r\n}\r\n```\r\n\r\ntsc: `Property '_x' has no initializer and is not definitely assigned in the constructor.`\r\n\r\n**Expected behavior:**\r\nNo errors.\r\n\r\n**Actual behavior:**\r\ntsc emits `Property '_x' has no initializer and is not definitely assigned in the constructor.` error.\r\n\r\n**Playground Link:** \u003c!-- A link to a TypeScript Playground \"Share\" link which demonstrates this behavior --> \r\nhttp://www.typescriptlang.org/play/#src=class%20Foo%20%7B%0D%0A%20%20%20%20private%20_x%3A%20number%3B%0D%0A%20%20%20%20public%20set%20x(nx%3A%20number)%20%7B%0D%0A%20%20%20%20%20%20%20%20this._x%20%3D%20nx%3B%0D%0A%20%20%20%20%7D%0D%0A%20%20%20%20constructor()%20%7B%0D%0A%20%20%20%20%20%20%20%20this.x%20%3D%201%3B%0D%0A%20%20%20%20%7D%0D%0A%7D%0D%0A\r\n\r\n**Related Issues:** \u003c!-- Did you find other bugs that looked similar? -->\r\n","author":{"url":"https://github.com/tbillington","@type":"Person","name":"tbillington"},"datePublished":"2018-06-13T22:18:52Z","url":"https://github.com/microsoft/TypeScript/issues/24937"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:af4142b3-2311-e6b8-9b3e-ef7d018ce9df |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D57C:1AE20C:5FCD48:7B0732:6B00DD58 |
| html-safe-nonce | 527a3935ddb449b7b7efd5c3d34bef20ed45476783dfdbee04adfb44dd610cb7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENTdDOjFBRTIwQzo1RkNENDg6N0IwNzMyOjZCMDBERDU4IiwidmlzaXRvcl9pZCI6IjgxNDM3MjYxNjM2MjYzNTE5NjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 5d2beb1ac551f7f202971ffba53c006f25f88ef95d4d8dd2eb61ad38970d0063 |
| hovercard-subject-tag | issue:332185208 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/24937/issue_layout |
| twitter:image | https://opengraph.githubassets.com/32c4bbe5f67ea762c5ccfcfc0dbced01496a2f961e7b9a5e700994f11453b989/microsoft/TypeScript/issues/24937 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/32c4bbe5f67ea762c5ccfcfc0dbced01496a2f961e7b9a5e700994f11453b989/microsoft/TypeScript/issues/24937 |
| og:image:alt | TypeScript Version: 2.9.2 & 3.0.0-dev.20180609 Search Terms: setter Code When enabling the strictNullChecks and strictPropertyInitialization tsconfig options tsc produces an error when it shouldn't... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tbillington |
| hostname | github.com |
| expected-hostname | github.com |
| None | 043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5425dc24e8bd8d6fca9641a12afc984825a43875 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width