Title: Move to new file refactoring adds import before header comment · Issue #24918 · microsoft/TypeScript · GitHub
Open Graph Title: Move to new file refactoring adds import before header comment · Issue #24918 · microsoft/TypeScript
X Title: Move to new file refactoring adds import before header comment · Issue #24918 · microsoft/TypeScript
Description: TypeScript Version: 3.0.0-dev.20180609 Search Terms: move to new file refactor / refactoring Code For a project: a.js export const a = 1; c.js /*--------------------------------------------------------------------------------------------...
Open Graph Description: TypeScript Version: 3.0.0-dev.20180609 Search Terms: move to new file refactor / refactoring Code For a project: a.js export const a = 1; c.js /*----------------------------------------------------...
X Description: TypeScript Version: 3.0.0-dev.20180609 Search Terms: move to new file refactor / refactoring Code For a project: a.js export const a = 1; c.js /*----------------------------------------------------...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/24918
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Move to new file refactoring adds import before header comment","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** 3.0.0-dev.20180609\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** \r\n- move to new file refactor / refactoring\r\n\r\n**Code**\r\nFor a project:\r\n\r\n`a.js`\r\n```ts\r\nexport const a = 1;\r\n```\r\n\r\n`c.js`\r\n```js\r\n/*---------------------------------------------------------------------------------------------\r\n * Copyright (c) Microsoft Corporation. All rights reserved.\r\n * Licensed under the MIT License. See License.txt in the project root for license information.\r\n *--------------------------------------------------------------------------------------------*/\r\n\r\nimport { a } from './a';\r\n\r\nclass B {\r\n f() {\r\n console.log(a);\r\n }\r\n}\r\n\r\nexport class C {\r\n c() {\r\n new B(a);\r\n }\r\n}\r\n```\r\n\r\n1. Run the `move to new file` refactoring on `B`\r\n\r\n**Expected behavior:**\r\nIn `c.js`, the import is added next to the existing import for `a.js`\r\n\r\n**Actual behavior:**\r\nImport inserted at the top of the file:\r\n\r\n`c.js`:\r\n```js\r\nimport { b } from './b';\r\n\r\n/*---------------------------------------------------------------------------------------------\r\n * Copyright (c) Microsoft Corporation. All rights reserved.\r\n * Licensed under the MIT License. See License.txt in the project root for license information.\r\n *--------------------------------------------------------------------------------------------*/\r\n\r\nimport { a } from './a';\r\n\r\nexport class c {\r\n c() {\r\n new b(a);\r\n }\r\n}\r\n```","author":{"url":"https://github.com/mjbvz","@type":"Person","name":"mjbvz"},"datePublished":"2018-06-13T00:19:42Z","url":"https://github.com/microsoft/TypeScript/issues/24918"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:63eee337-dc2a-4881-de7c-556444e6b9ec |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | EE3A:14F601:2738F64:31C8050:6B017D32 |
| html-safe-nonce | 2859c32703af7477c475951cdd0d2af5c2d6720053a40c5b7acce81d2b4a6532 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRTNBOjE0RjYwMToyNzM4RjY0OjMxQzgwNTA6NkIwMTdEMzIiLCJ2aXNpdG9yX2lkIjoiMTMzODU5OTUxMzkwODE0OTU1NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 1d91513e1dd4b885dd144ef4c1fcb774df5d22f9c2ee9528b022fc3fb639fbcb |
| hovercard-subject-tag | issue:331798005 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/24918/issue_layout |
| twitter:image | https://opengraph.githubassets.com/becd5652649bccf3e0dc1e1f4e4af245e89c0064ff845b68fb508f0296f38ac6/microsoft/TypeScript/issues/24918 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/becd5652649bccf3e0dc1e1f4e4af245e89c0064ff845b68fb508f0296f38ac6/microsoft/TypeScript/issues/24918 |
| og:image:alt | TypeScript Version: 3.0.0-dev.20180609 Search Terms: move to new file refactor / refactoring Code For a project: a.js export const a = 1; c.js /*----------------------------------------------------... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mjbvz |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width