René's URL Explorer Experiment


Title: Incorrect assumption around host being defined in base64encode/base64decode · Issue #24638 · microsoft/TypeScript · GitHub

Open Graph Title: Incorrect assumption around host being defined in base64encode/base64decode · Issue #24638 · microsoft/TypeScript

X Title: Incorrect assumption around host being defined in base64encode/base64decode · Issue #24638 · microsoft/TypeScript

Description: TypeScript Version: 2.9.1+ Code Any code under deno with TypeScript 2.9.1 or later. #22658 introduced a significant refactor of code. One of the areas defines the base64encode function which assumes that the argument host is always defin...

Open Graph Description: TypeScript Version: 2.9.1+ Code Any code under deno with TypeScript 2.9.1 or later. #22658 introduced a significant refactor of code. One of the areas defines the base64encode function which assume...

X Description: TypeScript Version: 2.9.1+ Code Any code under deno with TypeScript 2.9.1 or later. #22658 introduced a significant refactor of code. One of the areas defines the base64encode function which assume...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/24638

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Incorrect assumption around host being defined in base64encode/base64decode","articleBody":"**TypeScript Version:**  2.9.1+\r\n\r\n**Code**\r\n\r\nAny code under [deno](https://github.com/ry/deno/) with TypeScript 2.9.1 or later.\r\n\r\n#22658 introduced a significant refactor of code.  One of the [areas](https://github.com/Microsoft/TypeScript/pull/22658/files#diff-942ae3cd2a8bbd85ed86a60cd7c43307R3515) defines the `base64encode` function which assumes that the argument `host` is always defined.  In practice, this comes from `ts.sys` in which `ts.sys` is possibly undefined, but without the strict checking, this does not throw a compiler error, but at runtime in certain environments (like deno) an exception is thrown.\r\n\r\nA simple check of `host && host.base64encode` there (and the following function `base64decode` restores functionality).\r\n\r\n**Expected behavior:**\r\n\r\nThe code actually runs.\r\n\r\n**Actual behavior:**\r\n\r\n```\r\nTypeError: Cannot read property 'base64encode' of undefined\r\n    at Object.base64encode (../node_modules/typescript/lib/typescript.js:12079:18)\r\n    at Object.getSourceMappingURL (../node_modules/typescript/lib/typescript.js:73929:46)\r\n    at printSourceFileOrBundle (../node_modules/typescript/lib/typescript.js:74550:48)\r\n    at emitJsFileOrBundle (../node_modules/typescript/lib/typescript.js:74499:13)\r\n    at emitSourceFileOrBundle (../node_modules/typescript/lib/typescript.js:74456:13)\r\n    at forEachEmittedFile (../node_modules/typescript/lib/typescript.js:74365:30)\r\n    at Object.emitFiles (../node_modules/typescript/lib/typescript.js:74446:9)\r\n    at emitWorker (../node_modules/typescript/lib/typescript.js:78992:33)\r\n    at ../node_modules/typescript/lib/typescript.js:78952:66\r\n    at runWithCancellationToken (../node_modules/typescript/lib/typescript.js:79043:24)\r\n```\r\n\r\n**Related Issues:**\r\nRefs: ry/deno#117\r\n","author":{"url":"https://github.com/kitsonk","@type":"Person","name":"kitsonk"},"datePublished":"2018-06-03T20:56:28Z","url":"https://github.com/microsoft/TypeScript/issues/24638"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:df22911a-105f-1f6f-1e7c-5219835eedbc
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDA06:19E4BB:272549F:31EE57B:6B019BB2
html-safe-nonce57f7ba770c6c26e69a545ef2676de9a5d51b8698f18c2f515882fb027bbb6249
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTA2OjE5RTRCQjoyNzI1NDlGOjMxRUU1N0I6NkIwMTlCQjIiLCJ2aXNpdG9yX2lkIjoiNjc1ODQyMjEzMzQ1OTc1MzkwNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9a5ec98456c265fd840f3c1674a02c95c5c4ec30148084cc272395d00864142e
hovercard-subject-tagissue:328861375
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/24638/issue_layout
twitter:imagehttps://opengraph.githubassets.com/774a29130d9866225149dcdfe87c7d5685b3e4928d7f6eb8967005bc5278e260/microsoft/TypeScript/issues/24638
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/774a29130d9866225149dcdfe87c7d5685b3e4928d7f6eb8967005bc5278e260/microsoft/TypeScript/issues/24638
og:image:altTypeScript Version: 2.9.1+ Code Any code under deno with TypeScript 2.9.1 or later. #22658 introduced a significant refactor of code. One of the areas defines the base64encode function which assume...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekitsonk
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/24638#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F24638
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F24638
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/24638
Reloadhttps://github.com/microsoft/TypeScript/issues/24638
Reloadhttps://github.com/microsoft/TypeScript/issues/24638
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests312 (312)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/24638
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/24638
Incorrect assumption around host being defined in base64encode/base64decodehttps://github.com/microsoft/TypeScript/issues/24638#top
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 3.0https://github.com/microsoft/TypeScript/milestone/70
https://github.com/kitsonk
Kitson Kelly (kitsonk)https://github.com/kitsonk
on Jun 3, 2018https://github.com/microsoft/TypeScript/issues/24638#issue-328861375
denohttps://github.com/ry/deno/
#22658https://github.com/microsoft/TypeScript/pull/22658
areashttps://github.com/Microsoft/TypeScript/pull/22658/files#diff-942ae3cd2a8bbd85ed86a60cd7c43307R3515
https://github.com/kitsonk
Kitson Kelly (kitsonk)https://github.com/kitsonk
on Jun 3, 2018https://github.com/microsoft/TypeScript/issues/24638#issuecomment-394201642
TODOhttps://github.com/Microsoft/TypeScript/blob/e53e56cf8212e45d0ebdd6affe462d161c7e0dc5/src/compiler/sys.ts#L521
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#24641https://github.com/microsoft/TypeScript/pull/24641
on Jun 4, 2018https://github.com/microsoft/TypeScript/issues/24638#event-1661756563
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on Jun 4, 2018https://github.com/microsoft/TypeScript/issues/24638#event-1661757733
Treat host as possibly undefined for base64encode/base64decodehttps://github.com/microsoft/TypeScript/commit/a9cb33db04534211cf103d403e61020e8ea10026
https://docs.github.com/articles/closing-issues-via-commit-messages
a9cb33dhttps://github.com/microsoft/TypeScript/commit/a9cb33db04534211cf103d403e61020e8ea10026
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
on Jun 4, 2018https://github.com/microsoft/TypeScript/issues/24638#event-1661757831
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
TypeScript 3.0https://github.com/microsoft/TypeScript/milestone/70
on Jun 4, 2018https://github.com/microsoft/TypeScript/issues/24638#event-1661757914
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
on Jun 4, 2018https://github.com/microsoft/TypeScript/issues/24638#event-1661758126
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on Jun 4, 2018https://github.com/microsoft/TypeScript/issues/24638#issuecomment-394419173
Kitson Kelly (@kitsonk)https://github.com/kitsonk
microsofthttps://github.com/microsoft
on Aug 3, 2018https://github.com/microsoft/TypeScript/issues/24638#event-1770872825
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/24638
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/24638
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 3.0https://github.com/microsoft/TypeScript/milestone/70
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.