René's URL Explorer Experiment


Title: Conditional Type is assignable to a discriminated union, yet not working with type guards as expected. · Issue #23985 · microsoft/TypeScript · GitHub

Open Graph Title: Conditional Type is assignable to a discriminated union, yet not working with type guards as expected. · Issue #23985 · microsoft/TypeScript

X Title: Conditional Type is assignable to a discriminated union, yet not working with type guards as expected. · Issue #23985 · microsoft/TypeScript

Description: (Apologies if this is a duplicate; I suspect that it is after seeing so many related questions being marked "behaving as designed," but am having a hard time figuring out exactly which issue this may be duplicating). TypeScript Version: ...

Open Graph Description: (Apologies if this is a duplicate; I suspect that it is after seeing so many related questions being marked "behaving as designed," but am having a hard time figuring out exactly which issue this m...

X Description: (Apologies if this is a duplicate; I suspect that it is after seeing so many related questions being marked "behaving as designed," but am having a hard time figuring out exactly which is...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/23985

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Conditional Type is assignable to a discriminated union, yet not working with type guards as expected.","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨\r\n\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common \"Bugs\" That Aren't Bugs section!\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n  * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n  * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n\r\nPlease fill in the *entire* template below.\r\n-->\r\n\r\n(Apologies if this is a duplicate; I suspect that it is after seeing so many related questions being marked \"behaving as designed,\" but am having a hard time figuring out exactly _which_ issue this may be duplicating).\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:**  2.8.3\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** discriminated union, conditional generic, etc...\r\n\r\n**Code**\r\n\r\n```ts\r\ninterface Foo {\r\n    hasADate: true;\r\n    obj: Date;\r\n}\r\n\r\ninterface Bar {\r\n    hasADate: false;\r\n    obj: number;\r\n}\r\n\r\ntype FooBar = Foo | Bar;\r\ntype GenericFooBar\u003cT> = T extends Function ? Foo : Bar;\r\n\r\nfunction testing\u003cT>(doesntWork: GenericFooBar\u003cT>) {\r\n    if (doesntWork.hasADate === true) {\r\n        return doesntWork.obj.getDate(); // ERROR: arg.obj is still type number | Date\r\n    }\r\n\r\n    let works: FooBar = doesntWork;\r\n    if (works.hasADate === true) {\r\n        return works.obj.getDate();     // WORKS: arg.obj is type Date\r\n    }\r\n}\r\n```\r\n\r\n**Expected behavior:** \r\nInside of the `doesntWork.hasADate === true` type guard, `doesntWork.obj` should be narrowed to a `Date`\r\n\r\n**Actual behavior:** \r\n`doesntWork.obj` is still a `number | Date`. The compiler _does_ allow me to assign `doesntWork` to `works` (whose type is the respective discriminated union), and with that variable everything works as expected. It seems odd that the compiler recognizes that `GenericFooBar\u003cT>` extends `Foo | Bar` (as it allows the assignment), yet doesn't work with the discriminated type guard.\r\n\r\n","author":{"url":"https://github.com/DavidKDeutsch","@type":"Person","name":"DavidKDeutsch"},"datePublished":"2018-05-08T22:55:36Z","url":"https://github.com/microsoft/TypeScript/issues/23985"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:4902f3e0-199c-c2b3-bc6e-eddfc30b00ba
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE744:21AC3F:E3E12F:1238263:6B00F355
html-safe-noncef14656868e9ba8321b31532490dc625c8deb94bdd32f42be22af23ccf3d40973
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNzQ0OjIxQUMzRjpFM0UxMkY6MTIzODI2Mzo2QjAwRjM1NSIsInZpc2l0b3JfaWQiOiI3NzIxNzY0ODU5NjU3OTA5MDc3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacb5f3e04d0e788eeea90d641961155003d3ddb7fe0944aa0f8d3a7df84652a2f9
hovercard-subject-tagissue:321374548
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/23985/issue_layout
twitter:imagehttps://opengraph.githubassets.com/d35f6d75ed0795f59fbc8785a7f62bd674824289edb941393cf94bda69caff32/microsoft/TypeScript/issues/23985
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d35f6d75ed0795f59fbc8785a7f62bd674824289edb941393cf94bda69caff32/microsoft/TypeScript/issues/23985
og:image:alt(Apologies if this is a duplicate; I suspect that it is after seeing so many related questions being marked "behaving as designed," but am having a hard time figuring out exactly which issue this m...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameDavidKDeutsch
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/23985#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F23985
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F23985
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/23985
Reloadhttps://github.com/microsoft/TypeScript/issues/23985
Reloadhttps://github.com/microsoft/TypeScript/issues/23985
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/23985
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/23985
Conditional Type is assignable to a discriminated union, yet not working with type guards as expected.https://github.com/microsoft/TypeScript/issues/23985#top
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
https://github.com/DavidKDeutsch
David Deutsch (DavidKDeutsch)https://github.com/DavidKDeutsch
on May 8, 2018https://github.com/microsoft/TypeScript/issues/23985#issue-321374548
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
In DiscussionNot yet reached consensushttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22In%20Discussion%22
In DiscussionNot yet reached consensushttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22In%20Discussion%22
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
on May 8, 2018https://github.com/microsoft/TypeScript/issues/23985#event-1616465245
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on May 8, 2018https://github.com/microsoft/TypeScript/issues/23985#issuecomment-387577915
#22348https://github.com/microsoft/TypeScript/pull/22348
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
on May 8, 2018https://github.com/microsoft/TypeScript/issues/23985#event-1616517216
https://github.com/ahejlsberg
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
on May 8, 2018https://github.com/microsoft/TypeScript/issues/23985#issuecomment-387578391
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
https://github.com/DavidKDeutsch
David Deutsch (DavidKDeutsch)https://github.com/DavidKDeutsch
on May 9, 2018https://github.com/microsoft/TypeScript/issues/23985#issuecomment-387591518
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
David Deutsch (DavidKDeutsch)https://github.com/DavidKDeutsch
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on May 9, 2018https://github.com/microsoft/TypeScript/issues/23985#event-1616600267
https://github.com/KSXGitHub
Khải (KSXGitHub)https://github.com/KSXGitHub
on May 15, 2018https://github.com/microsoft/TypeScript/issues/23985#issuecomment-389182712
David Deutsch (@DavidKDeutsch)https://github.com/DavidKDeutsch
https://github.com/DavidKDeutsch
David Deutsch (DavidKDeutsch)https://github.com/DavidKDeutsch
on May 16, 2018https://github.com/microsoft/TypeScript/issues/23985#issuecomment-389577832
Khải (@KSXGitHub)https://github.com/KSXGitHub
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
#22348https://github.com/microsoft/TypeScript/pull/22348
Mohamed Hegazy (@mhegazy)https://github.com/mhegazy
microsofthttps://github.com/microsoft
on Jul 31, 2018https://github.com/microsoft/TypeScript/issues/23985#event-1763326576
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/23985
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/23985
SuggestionAn idea for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Suggestion%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.