René's URL Explorer Experiment


Title: indexing with T extends keyof causes OOM · Issue #23977 · microsoft/TypeScript · GitHub

Open Graph Title: indexing with T extends keyof causes OOM · Issue #23977 · microsoft/TypeScript

X Title: indexing with T extends keyof causes OOM · Issue #23977 · microsoft/TypeScript

Description: This breaks glimmer, and thereby our RWC (once sufficiently fixed in other ways) Code Isolated repro (needs dom lib for ElementTagNameMap and associated types): export function assertIsElement(node: Node | null): node is Element { let no...

Open Graph Description: This breaks glimmer, and thereby our RWC (once sufficiently fixed in other ways) Code Isolated repro (needs dom lib for ElementTagNameMap and associated types): export function assertIsElement(node...

X Description: This breaks glimmer, and thereby our RWC (once sufficiently fixed in other ways) Code Isolated repro (needs dom lib for ElementTagNameMap and associated types): export function assertIsElement(node...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/23977

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"indexing with T extends keyof \u003cLarge Union> causes OOM","articleBody":"This breaks `glimmer`, and thereby our RWC (once sufficiently fixed in other ways)\r\n\r\n**Code**\r\n\r\nIsolated repro (needs `dom` lib for `ElementTagNameMap` and associated types):\r\n```ts\r\nexport function assertIsElement(node: Node | null): node is Element {\r\n    let nodeType = node === null ? null : node.nodeType;\r\n    return nodeType === 1;\r\n}\r\n  \r\nexport function assertNodeTagName\u003c\r\n    T extends keyof ElementTagNameMap,\r\n    U extends ElementTagNameMap[T]>(node: Node | null, tagName: T): node is U {\r\n    if (assertIsElement(node)) {\r\n        const nodeTagName = node.tagName.toLowerCase();\r\n         return nodeTagName === tagName;\r\n    }\r\n    return false;\r\n}\r\n  \r\nexport function assertNodeProperty\u003c\r\n    T extends keyof ElementTagNameMap,\r\n    P extends keyof ElementTagNameMap[T],\r\n    V extends HTMLElementTagNameMap[T][P]>(node: Node | null, tagName: T, prop: P, value: V) {\r\n    if (assertNodeTagName(node, tagName)) {\r\n        node[prop];\r\n    }\r\n}\r\n```\r\n\r\n**Expected behavior:**\r\nNo crash.\r\n\r\n**Actual behavior:**\r\nOOM crash after a _very_ long delay.\r\n\r\nPreliminary investigation shows the OOM occurs when we try to get the distributed form of `keyof \u003cLarge Union>` - namely the process is defined recursively, so when the union has ~170 members, we create _170 intermediate types_ (flattening one member at a time, while also wasting time recalculating type flags and other bits we will never need) before getting the final, distributed result. Now, picture doing this on every relation comparison operation for `P` (this distribution is uncached), and _multiplying it_ for `V` in `assertNodeProperty` - the complexity is huge.\r\n\r\ncc @DanielRosenwasser since I think you care about when we break glimmer.\r\n","author":{"url":"https://github.com/weswigham","@type":"Person","name":"weswigham"},"datePublished":"2018-05-08T21:44:15Z","url":"https://github.com/microsoft/TypeScript/issues/23977"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:18e30ddc-b9e9-8608-5dea-35af2e5c8a42
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA864:B53AF:EF667C:13F4A20:6B010A7A
html-safe-nonceefb4ee960c9220244d4e8b7d14be1fb97004c27a91e4ea9fe2226219ee60eb4d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBODY0OkI1M0FGOkVGNjY3QzoxM0Y0QTIwOjZCMDEwQTdBIiwidmlzaXRvcl9pZCI6IjQ0NzMzNDUxOTIzMzc5MzQ5NzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac52e18b336dbabc3f0d3c6fcd366155a7e01ef2660f87abcb670854d438e1bd49
hovercard-subject-tagissue:321357683
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/23977/issue_layout
twitter:imagehttps://opengraph.githubassets.com/65d34fd621f95ab4248bd70927a22b7c497f5663ad3d0931e16a94f6b43910d3/microsoft/TypeScript/issues/23977
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/65d34fd621f95ab4248bd70927a22b7c497f5663ad3d0931e16a94f6b43910d3/microsoft/TypeScript/issues/23977
og:image:altThis breaks glimmer, and thereby our RWC (once sufficiently fixed in other ways) Code Isolated repro (needs dom lib for ElementTagNameMap and associated types): export function assertIsElement(node...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameweswigham
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/23977#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F23977
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F23977
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/23977
Reloadhttps://github.com/microsoft/TypeScript/issues/23977
Reloadhttps://github.com/microsoft/TypeScript/issues/23977
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests310 (310)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/23977
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/23977
indexing with T extends keyof causes OOMhttps://github.com/microsoft/TypeScript/issues/23977#top
https://github.com/ahejlsberg
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 2.9.1https://github.com/microsoft/TypeScript/milestone/71
https://github.com/weswigham
Wesley Wigham (weswigham)https://github.com/weswigham
on May 8, 2018https://github.com/microsoft/TypeScript/issues/23977#issue-321357683
Daniel Rosenwasser (@DanielRosenwasser)https://github.com/DanielRosenwasser
Wesley Wigham (weswigham)https://github.com/weswigham
on May 8, 2018https://github.com/microsoft/TypeScript/issues/23977#event-1616379025
Wesley Wigham (weswigham)https://github.com/weswigham
on May 8, 2018https://github.com/microsoft/TypeScript/issues/23977#event-1616379289
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
on May 8, 2018https://github.com/microsoft/TypeScript/issues/23977#event-1616521442
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
TypeScript 2.9https://github.com/microsoft/TypeScript/milestone/67
on May 8, 2018https://github.com/microsoft/TypeScript/issues/23977#event-1616521535
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
on May 8, 2018https://github.com/microsoft/TypeScript/issues/23977#event-1616521573
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on May 8, 2018https://github.com/microsoft/TypeScript/issues/23977#issuecomment-387578629
Anders Hejlsberg (@ahejlsberg)https://github.com/ahejlsberg
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
TypeScript 2.9https://github.com/microsoft/TypeScript/milestone/67
TypeScript 2.9.1https://github.com/microsoft/TypeScript/milestone/71
on May 10, 2018https://github.com/microsoft/TypeScript/issues/23977#event-1620224038
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
on May 15, 2018https://github.com/microsoft/TypeScript/issues/23977#event-1628071850
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#24137https://github.com/microsoft/TypeScript/pull/24137
on May 17, 2018https://github.com/microsoft/TypeScript/issues/23977#event-1632865720
microsofthttps://github.com/microsoft
on Jul 31, 2018https://github.com/microsoft/TypeScript/issues/23977#event-1763326390
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/23977
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/23977
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 2.9.1https://github.com/microsoft/TypeScript/milestone/71
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.