Title: Make watcher symlink-aware (currently follows symlinks) · Issue #23418 · microsoft/TypeScript · GitHub
Open Graph Title: Make watcher symlink-aware (currently follows symlinks) · Issue #23418 · microsoft/TypeScript
X Title: Make watcher symlink-aware (currently follows symlinks) · Issue #23418 · microsoft/TypeScript
Description: TypeScript Version: 2.8.1 Search Terms: watch symlink AFAICS there is actually a lot of issues related to this. Code There is not really any code to show. We do have a mono-repo, that for some issues with one of our dependencies creates ...
Open Graph Description: TypeScript Version: 2.8.1 Search Terms: watch symlink AFAICS there is actually a lot of issues related to this. Code There is not really any code to show. We do have a mono-repo, that for some issu...
X Description: TypeScript Version: 2.8.1 Search Terms: watch symlink AFAICS there is actually a lot of issues related to this. Code There is not really any code to show. We do have a mono-repo, that for some issu...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/23418
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Make watcher symlink-aware (currently follows symlinks)","articleBody":"\u003c!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 -->\r\n\u003c!--\r\nHalf of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.\r\n\r\nPlease help us by doing the following steps before logging an issue:\r\n * Search: https://github.com/Microsoft/TypeScript/search?type=Issues\r\n * Read the CONTRIBUTING guidelines: https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md\r\n * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ\r\n-->\r\n\r\n\u003c!-- If you have a QUESTION:\r\n THIS IS NOT A FORUM FOR QUESTIONS.\r\n Ask questions at http://stackoverflow.com/questions/tagged/typescript\r\n or https://gitter.im/Microsoft/TypeScript\r\n-->\r\n\r\n\u003c!-- If you have a SUGGESTION:\r\n Most suggestion reports are duplicates, please search extra hard before logging a new suggestion.\r\n See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md\r\n-->\r\n\r\n\u003c!-- If you have a BUG:\r\n Please fill in the *entire* template below.\r\n-->\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** 2.8.1\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** \r\n\r\n* watch\r\n* symlink\r\n\r\nAFAICS there is actually a lot of issues related to this.\r\n\r\n**Code**\r\n\r\nThere is not really any *code* to show.\r\nWe do have a mono-repo, that for some issues with one of our dependencies creates manual symlinks between out packages.\r\n\r\n**Expected behavior:**\r\n\r\nThings should work \r\n\r\n**Actual behavior:**\r\n\r\nWhen I do a `tsc --watch`, it takes roughly ~30s to watch all the files, because it actually follows the symlinks.\r\nWhen running `tsserver`, either via `code` or `typescript-language-server`, the process hangs for >60s with 100% cpu usage. I have attached a debugger and found out that all the time is spent following symlinks and watching those files.\r\nHere is a screenshot of a short profile I have done:\r\n\r\n\r\n(The profile only shows ~18s worth of directory walking, but in reality its *way* more.\r\n\r\nAlso, the `tsserver` process uses in excess of ~1400M of RAM, so it may also explain some of the OOM bugs that I have found with the search.\r\n\r\n**Playground Link:** \u003c!-- A link to a TypeScript Playground \"Share\" link which demonstrates this behavior --> \r\n\r\n**Related Issues:**\r\n\r\nI think https://github.com/Microsoft/TypeScript/issues/10873 would be an extreme example of this\r\nOtherwise there is a lot of issues mentioning watch mode and extremely slow performance, some of those mention mono-repos, so I guess a lot of this is related.","author":{"url":"https://github.com/Swatinem","@type":"Person","name":"Swatinem"},"datePublished":"2018-04-15T15:30:18Z","url":"https://github.com/microsoft/TypeScript/issues/23418"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:553e7904-228f-4390-e577-4b1d125c0e73 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BC54:33444D:27E28A3:350BDFF:6B01B186 |
| html-safe-nonce | 7fddd9c18d606cf723f0a77e771e281ea261b1ffb81f4b6d8dabc91c811bdce3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzU0OjMzNDQ0RDoyN0UyOEEzOjM1MEJERkY6NkIwMUIxODYiLCJ2aXNpdG9yX2lkIjoiNDc2NzM2MTE2MDAyMDM0MTEyNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 19f004b2343a94ae3d584a9780268c982c06cb6e8df3b088f3b373de19f3ffa4 |
| hovercard-subject-tag | issue:314425354 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/23418/issue_layout |
| twitter:image | https://opengraph.githubassets.com/749c7f25999ecfb617cdae97d12d1505baa162f9039ce92f14ebf42d141955fd/microsoft/TypeScript/issues/23418 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/749c7f25999ecfb617cdae97d12d1505baa162f9039ce92f14ebf42d141955fd/microsoft/TypeScript/issues/23418 |
| og:image:alt | TypeScript Version: 2.8.1 Search Terms: watch symlink AFAICS there is actually a lot of issues related to this. Code There is not really any code to show. We do have a mono-repo, that for some issu... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Swatinem |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width