René's URL Explorer Experiment


Title: createDiagnosticCollection should be @internal, or DiagnosticCollection should not be · Issue #2268 · microsoft/TypeScript · GitHub

Open Graph Title: createDiagnosticCollection should be @internal, or DiagnosticCollection should not be · Issue #2268 · microsoft/TypeScript

X Title: createDiagnosticCollection should be @internal, or DiagnosticCollection should not be · Issue #2268 · microsoft/TypeScript

Description: Generated definitions in bin/typescriptServices_internal.d.ts are invalid, causing compilation error if used: typescriptServices_internal.d.ts 2304 272:43 Cannot find name 'DiagnosticCollection' declare module ts { // ... function create...

Open Graph Description: Generated definitions in bin/typescriptServices_internal.d.ts are invalid, causing compilation error if used: typescriptServices_internal.d.ts 2304 272:43 Cannot find name 'DiagnosticCollection' de...

X Description: Generated definitions in bin/typescriptServices_internal.d.ts are invalid, causing compilation error if used: typescriptServices_internal.d.ts 2304 272:43 Cannot find name 'DiagnosticCollection...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/2268

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"createDiagnosticCollection should be @internal, or DiagnosticCollection should not be","articleBody":"Generated definitions in [bin/typescriptServices_internal.d.ts](https://github.com/Microsoft/TypeScript/blob/f351916fc203b19e3cef062c6ff3e77a368f89e7/bin/typescriptServices_internal.d.ts#L273) are invalid, causing compilation error if used:\n\ntypescriptServices_internal.d.ts 2304 @272:43 Cannot find name 'DiagnosticCollection'\n\n``` typescript\ndeclare module ts {\n    // ...\n    function createDiagnosticCollection(): DiagnosticCollection;\n```\n\nThis is because DiagnosticCollection is defined with @internal flag in [src/compiler/types.ts](https://github.com/Microsoft/TypeScript/blob/c6cd57d18c85e59b2fbe9d316725748a0af8ac2b/src/compiler/types.ts#L1761):\n\n``` typescript\nmodule ts {\n    // ...\n\n    // @internal\n    export interface DiagnosticCollection {\n        // Adds a diagnostic to this diagnostic collection.\n        add(diagnostic: Diagnostic): void;\n\n        // Gets all the diagnostics that aren't associated with a file.\n        getGlobalDiagnostics(): Diagnostic[];\n\n        // If fileName is provided, gets all the diagnostics associated with that file name.\n        // Otherwise, returns all the diagnostics (global and file associated) in this colletion.\n        getDiagnostics(fileName?: string): Diagnostic[];\n\n        // Gets a count of how many times this collection has been modified.  This value changes\n        // each time 'add' is called (regardless of whether or not an equivalent diagnostic was\n        // already in the collection).  As such, it can be used as a simple way to tell if any\n        // operation caused diagnostics to be returned by storing and comparing the return value \n        // of this method before/after the operation is performed.\n        getModificationCount(): number;\n    }\n```\n\nThe interface looks internal enough, so I guess ts.createDiagnosticCollection() function should go under the internal flag together with the interface.\n\nAlso there need to be tests for the validity of all the generated d.ts files, shouldn't there?\n","author":{"url":"https://github.com/mihailik","@type":"Person","name":"mihailik"},"datePublished":"2015-03-09T10:41:40Z","url":"https://github.com/microsoft/TypeScript/issues/2268"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:52415ab2-1467-111e-62ab-98b2344167df
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8A78:23CF06:6FE0AA:926876:6B00D447
html-safe-nonceb59b38c2a5e9c168e240059c8d4e95c6cf20bbf7ee870df90cadce3a4d73d74c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTc4OjIzQ0YwNjo2RkUwQUE6OTI2ODc2OjZCMDBENDQ3IiwidmlzaXRvcl9pZCI6Ijg2MDU2NDEzOTIyNzU5MDM1NTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac4540bdaa237e7a00a41f904eadfb62b7b1b0070aa6b1aa27aa04c4f1180116eb
hovercard-subject-tagissue:60325343
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/2268/issue_layout
twitter:imagehttps://opengraph.githubassets.com/de979ec9fdefb3c839982c4801605c72f12e2974d08079402285092b79f0798e/microsoft/TypeScript/issues/2268
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/de979ec9fdefb3c839982c4801605c72f12e2974d08079402285092b79f0798e/microsoft/TypeScript/issues/2268
og:image:altGenerated definitions in bin/typescriptServices_internal.d.ts are invalid, causing compilation error if used: typescriptServices_internal.d.ts 2304 272:43 Cannot find name 'DiagnosticCollection' de...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemihailik
hostnamegithub.com
expected-hostnamegithub.com
None85bbdfe2b6ba16e234513bc6ceff5d848ef8449820c900692a2b4e67061931e5
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release4943239a6d2c591325dad6e5c313e1cafda877f6
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/2268#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F2268
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F2268
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/2268
Reloadhttps://github.com/microsoft/TypeScript/issues/2268
Reloadhttps://github.com/microsoft/TypeScript/issues/2268
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests307 (307)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/2268
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/2268
createDiagnosticCollection should be @internal, or DiagnosticCollection should not behttps://github.com/microsoft/TypeScript/issues/2268#top
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 1.5https://github.com/microsoft/TypeScript/milestone/7
https://github.com/mihailik
mihailikhttps://github.com/mihailik
on Mar 9, 2015https://github.com/microsoft/TypeScript/issues/2268#issue-60325343
bin/typescriptServices_internal.d.tshttps://github.com/Microsoft/TypeScript/blob/f351916fc203b19e3cef062c6ff3e77a368f89e7/bin/typescriptServices_internal.d.ts#L273
272https://github.com/272
internalhttps://github.com/internal
src/compiler/types.tshttps://github.com/Microsoft/TypeScript/blob/c6cd57d18c85e59b2fbe9d316725748a0af8ac2b/src/compiler/types.ts#L1761
https://github.com/mihailik
mihailikhttps://github.com/mihailik
on Mar 9, 2015https://github.com/microsoft/TypeScript/issues/2268#issuecomment-77832809
#2269https://github.com/microsoft/TypeScript/issues/2269
https://github.com/mihailik
mihailikhttps://github.com/mihailik
on Mar 9, 2015https://github.com/microsoft/TypeScript/issues/2268#issuecomment-77835830
src/compiler/utilities.tshttps://github.com/Microsoft/TypeScript/blob/c6cd57d18c85e59b2fbe9d316725748a0af8ac2b/src/compiler/utilities.ts#L1210
src/compiler/program.tshttps://github.com/Microsoft/TypeScript/blob/24141f05dbf96f7682af2bf2679c010d876acabe/src/compiler/program.ts#L119
Dan Quirk (danquirk)https://github.com/danquirk
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
on Mar 9, 2015https://github.com/microsoft/TypeScript/issues/2268#event-248975879
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on Mar 10, 2015https://github.com/microsoft/TypeScript/issues/2268#event-249572425
Merge pull request #2270 from mihailik/patch-1https://github.com/microsoft/TypeScript/commit/3e4955bc0f26093fe6c4b2876473538c9adc1cef
#2270https://github.com/microsoft/TypeScript/pull/2270
3e4955bhttps://github.com/microsoft/TypeScript/commit/3e4955bc0f26093fe6c4b2876473538c9adc1cef
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
on Mar 11, 2015https://github.com/microsoft/TypeScript/issues/2268#event-249864492
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
TypeScript 1.5https://github.com/microsoft/TypeScript/milestone/7
on Mar 11, 2015https://github.com/microsoft/TypeScript/issues/2268#event-249864511
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Mar 11, 2015https://github.com/microsoft/TypeScript/issues/2268#event-249864528
microsofthttps://github.com/microsoft
on Jun 18, 2018https://github.com/microsoft/TypeScript/issues/2268#event-1686924592
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/2268
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/2268
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 1.5https://github.com/microsoft/TypeScript/milestone/7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.