Title: getEditsForRefactor debug failure on jsx selection · Issue #21772 · microsoft/TypeScript · GitHub
Open Graph Title: getEditsForRefactor debug failure on jsx selection · Issue #21772 · microsoft/TypeScript
X Title: getEditsForRefactor debug failure on jsx selection · Issue #21772 · microsoft/TypeScript
Description: TypeScript Version: 2.8.1-insiders-20180206 Search Terms: JSX Refactor Extract Code import * as React from 'react' class Foo extends React.Component { render() { return (
Open Graph Description: TypeScript Version: 2.8.1-insiders-20180206 Search Terms: JSX Refactor Extract Code import * as React from 'react' class Foo extends React.Component { render() { return (
X Description: TypeScript Version: 2.8.1-insiders-20180206 Search Terms: JSX Refactor Extract Code import * as React from 'react' class Foo extends React.Component { render() { return ( <div> <b&...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/21772
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"getEditsForRefactor debug failure on jsx selection","articleBody":"**TypeScript Version:** 2.8.1-insiders-20180206\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** \r\n- JSX\r\n- Refactor\r\n- Extract\r\n\r\n**Code**\r\n\r\n```tsx\r\nimport * as React from 'react'\r\n\r\nclass Foo extends React.Component {\r\n render() {\r\n return (\r\n \u003cdiv>\r\n \u003cb>bold\u003c/b>\r\n \u003c/div>\r\n )\r\n }\r\n}\r\n```\r\n\r\nTry running extract method on `\u003cb>bold\u003c/b>`\r\n\r\n**Bug:**\r\n\r\nThe call to `getEditsForRefactor` fails:\r\n\r\n```\r\n[Trace - 12:41:58 PM] Sending request: getEditsForRefactor (377). Response expected: yes. Current queue length: 0\r\nArguments: {\r\n \"file\": \"/Users/matb/projects/san/src/index.tsx\",\r\n \"startLine\": 7,\r\n \"startOffset\": 13,\r\n \"endLine\": 7,\r\n \"endOffset\": 24,\r\n \"refactor\": \"Extract Symbol\",\r\n \"action\": \"function_scope_1\"\r\n}\r\n[Trace - 12:41:59 PM] Response received: getEditsForRefactor (377). Request took 590 ms. Success: false . Message: Error processing request. Debug Failure. False expression.\r\nError: Debug Failure. False expression.\r\n at getPos (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:76906:22)\r\n at assignPositionsToNodeArray (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77437:29)\r\n at Object.visitEachChild (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45884:53)\r\n at assignPositionsToNode (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77425:30)\r\n at visitNode (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45562:23)\r\n at Object.visitEachChild (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45876:118)\r\n at assignPositionsToNode (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77425:30)\r\n at visitNode (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45562:23)\r\n at Object.visitEachChild (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45872:50)\r\n at assignPositionsToNode (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77425:30)\r\n at visitNode (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45562:23)\r\n at Object.visitEachChild (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45816:46)\r\n at assignPositionsToNode (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77425:30)\r\n at Object.visitNodes (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45599:48)\r\n at assignPositionsToNodeArray (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77432:30)\r\n at Object.visitEachChild (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45794:45)\r\n at assignPositionsToNode (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77425:30)\r\n at visitNode (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45562:23)\r\n at visitFunctionBody (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45645:23)\r\n at Object.visitEachChild (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45684:510)\r\n at assignPositionsToNode (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77425:30)\r\n at getNonformattedText (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77401:52)\r\n at ChangeTracker.getFormattedTextOfNode (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77368:40)\r\n at ChangeTracker.computeNewText (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77362:33)\r\n at /Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77338:118\r\n at Map.forEach (native)\r\n at ChangeTracker.getChanges (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77333:32)\r\n at extractFunctionInScope (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:81665:43)\r\n at getFunctionExtractionAtIndex (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:81404:24)\r\n at Object.getEditsForAction (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:81072:28)\r\n at Object.getEditsForRefactor (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77709:41)\r\n at Object.getEditsForRefactor (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:83928:32)\r\n at IOSession.Session.getEditsForRefactor (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:90792:59)\r\n at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:89745:61)\r\n at /Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:90985:88\r\n at IOSession.Session.executeWithRequestId (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:90976:28)\r\n at IOSession.Session.executeCommand (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:90985:33)\r\n at IOSession.Session.onMessage (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:91005:35)\r\n at Interface.\u003canonymous> (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:92206:27)\r\n at emitOne (events.js:96:13)\r\n at Interface.emit (events.js:191:7)\r\n at Interface._onLine (readline.js:241:10)\r\n at Interface._normalWrite (readline.js:384:12)\r\n at Socket.ondata (readline.js:101:10)\r\n at emitOne (events.js:96:13)\r\n at Socket.emit (events.js:191:7)\r\n at readableAddChunk (_stream_readable.js:178:18)\r\n at Socket.Readable.push (_stream_readable.js:136:10)\r\n at Pipe.onread (net.js:560:20)\r\n```\r\n\r\n**Playground Link:** \u003c!-- A link to a TypeScript Playground \"Share\" link which demonstrates this behavior --> \r\n\r\n**Related Issues:**\r\n- https://github.com/Microsoft/TypeScript/issues/15090","author":{"url":"https://github.com/mjbvz","@type":"Person","name":"mjbvz"},"datePublished":"2018-02-08T20:45:31Z","url":"https://github.com/microsoft/TypeScript/issues/21772"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:eccefc7b-3385-d272-56b5-e46a23145618 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C092:2F9718:B397F9:F1F901:6B00F8B0 |
| html-safe-nonce | 3326426b86885808138a66cfcddbab572e0377877e6257e00b3870124fd21b5c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDkyOjJGOTcxODpCMzk3Rjk6RjFGOTAxOjZCMDBGOEIwIiwidmlzaXRvcl9pZCI6IjQ2NTkyNzIyNjQ5OTc0NjgzMzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d12a64a8a480cd81f55b723dba62ef1e6c32da2ed178e7bdec02e88fb62a95ff |
| hovercard-subject-tag | issue:295659365 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/21772/issue_layout |
| twitter:image | https://opengraph.githubassets.com/a8eff91ed932f02e8fb2ddd027c9b7b14c3f9f32a433294d56137fbe68b1c0d3/microsoft/TypeScript/issues/21772 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a8eff91ed932f02e8fb2ddd027c9b7b14c3f9f32a433294d56137fbe68b1c0d3/microsoft/TypeScript/issues/21772 |
| og:image:alt | TypeScript Version: 2.8.1-insiders-20180206 Search Terms: JSX Refactor Extract Code import * as React from 'react' class Foo extends React.Component { render() { return ( bold )... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mjbvz |
| hostname | github.com |
| expected-hostname | github.com |
| None | e208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7dafd017fb7809a839c443dba08622af38e63c09 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width