René's URL Explorer Experiment


Title: getEditsForRefactor debug failure on jsx selection · Issue #21772 · microsoft/TypeScript · GitHub

Open Graph Title: getEditsForRefactor debug failure on jsx selection · Issue #21772 · microsoft/TypeScript

X Title: getEditsForRefactor debug failure on jsx selection · Issue #21772 · microsoft/TypeScript

Description: TypeScript Version: 2.8.1-insiders-20180206 Search Terms: JSX Refactor Extract Code import * as React from 'react' class Foo extends React.Component { render() { return (

bold
) } } Try running extract method on bo...

Open Graph Description: TypeScript Version: 2.8.1-insiders-20180206 Search Terms: JSX Refactor Extract Code import * as React from 'react' class Foo extends React.Component { render() { return (

bold
)...

X Description: TypeScript Version: 2.8.1-insiders-20180206 Search Terms: JSX Refactor Extract Code import * as React from 'react' class Foo extends React.Component { render() { return ( <div> <b&...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/21772

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"getEditsForRefactor debug failure on jsx selection","articleBody":"**TypeScript Version:**  2.8.1-insiders-20180206\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** \r\n- JSX\r\n- Refactor\r\n- Extract\r\n\r\n**Code**\r\n\r\n```tsx\r\nimport * as React from 'react'\r\n\r\nclass Foo extends React.Component {\r\n    render() {\r\n        return (\r\n            \u003cdiv>\r\n            \u003cb>bold\u003c/b>\r\n            \u003c/div>\r\n        )\r\n    }\r\n}\r\n```\r\n\r\nTry running extract method on `\u003cb>bold\u003c/b>`\r\n\r\n**Bug:**\r\n\r\nThe call to `getEditsForRefactor` fails:\r\n\r\n```\r\n[Trace  - 12:41:58 PM] Sending request: getEditsForRefactor (377). Response expected: yes. Current queue length: 0\r\nArguments: {\r\n    \"file\": \"/Users/matb/projects/san/src/index.tsx\",\r\n    \"startLine\": 7,\r\n    \"startOffset\": 13,\r\n    \"endLine\": 7,\r\n    \"endOffset\": 24,\r\n    \"refactor\": \"Extract Symbol\",\r\n    \"action\": \"function_scope_1\"\r\n}\r\n[Trace  - 12:41:59 PM] Response received: getEditsForRefactor (377). Request took 590 ms. Success: false . Message: Error processing request. Debug Failure. False expression.\r\nError: Debug Failure. False expression.\r\n    at getPos (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:76906:22)\r\n    at assignPositionsToNodeArray (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77437:29)\r\n    at Object.visitEachChild (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45884:53)\r\n    at assignPositionsToNode (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77425:30)\r\n    at visitNode (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45562:23)\r\n    at Object.visitEachChild (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45876:118)\r\n    at assignPositionsToNode (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77425:30)\r\n    at visitNode (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45562:23)\r\n    at Object.visitEachChild (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45872:50)\r\n    at assignPositionsToNode (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77425:30)\r\n    at visitNode (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45562:23)\r\n    at Object.visitEachChild (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45816:46)\r\n    at assignPositionsToNode (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77425:30)\r\n    at Object.visitNodes (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45599:48)\r\n    at assignPositionsToNodeArray (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77432:30)\r\n    at Object.visitEachChild (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45794:45)\r\n    at assignPositionsToNode (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77425:30)\r\n    at visitNode (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45562:23)\r\n    at visitFunctionBody (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45645:23)\r\n    at Object.visitEachChild (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:45684:510)\r\n    at assignPositionsToNode (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77425:30)\r\n    at getNonformattedText (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77401:52)\r\n    at ChangeTracker.getFormattedTextOfNode (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77368:40)\r\n    at ChangeTracker.computeNewText (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77362:33)\r\n    at /Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77338:118\r\n    at Map.forEach (native)\r\n    at ChangeTracker.getChanges (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77333:32)\r\n    at extractFunctionInScope (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:81665:43)\r\n    at getFunctionExtractionAtIndex (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:81404:24)\r\n    at Object.getEditsForAction (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:81072:28)\r\n    at Object.getEditsForRefactor (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:77709:41)\r\n    at Object.getEditsForRefactor (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:83928:32)\r\n    at IOSession.Session.getEditsForRefactor (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:90792:59)\r\n    at Session.handlers.ts.createMapFromTemplate._a.(anonymous function) (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:89745:61)\r\n    at /Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:90985:88\r\n    at IOSession.Session.executeWithRequestId (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:90976:28)\r\n    at IOSession.Session.executeCommand (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:90985:33)\r\n    at IOSession.Session.onMessage (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:91005:35)\r\n    at Interface.\u003canonymous> (/Users/matb/projects/san/node_modules/typescript/lib/tsserver.js:92206:27)\r\n    at emitOne (events.js:96:13)\r\n    at Interface.emit (events.js:191:7)\r\n    at Interface._onLine (readline.js:241:10)\r\n    at Interface._normalWrite (readline.js:384:12)\r\n    at Socket.ondata (readline.js:101:10)\r\n    at emitOne (events.js:96:13)\r\n    at Socket.emit (events.js:191:7)\r\n    at readableAddChunk (_stream_readable.js:178:18)\r\n    at Socket.Readable.push (_stream_readable.js:136:10)\r\n    at Pipe.onread (net.js:560:20)\r\n```\r\n\r\n**Playground Link:** \u003c!-- A link to a TypeScript Playground \"Share\" link which demonstrates this behavior --> \r\n\r\n**Related Issues:**\r\n- https://github.com/Microsoft/TypeScript/issues/15090","author":{"url":"https://github.com/mjbvz","@type":"Person","name":"mjbvz"},"datePublished":"2018-02-08T20:45:31Z","url":"https://github.com/microsoft/TypeScript/issues/21772"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:eccefc7b-3385-d272-56b5-e46a23145618
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC092:2F9718:B397F9:F1F901:6B00F8B0
html-safe-nonce3326426b86885808138a66cfcddbab572e0377877e6257e00b3870124fd21b5c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDkyOjJGOTcxODpCMzk3Rjk6RjFGOTAxOjZCMDBGOEIwIiwidmlzaXRvcl9pZCI6IjQ2NTkyNzIyNjQ5OTc0NjgzMzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd12a64a8a480cd81f55b723dba62ef1e6c32da2ed178e7bdec02e88fb62a95ff
hovercard-subject-tagissue:295659365
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/21772/issue_layout
twitter:imagehttps://opengraph.githubassets.com/a8eff91ed932f02e8fb2ddd027c9b7b14c3f9f32a433294d56137fbe68b1c0d3/microsoft/TypeScript/issues/21772
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a8eff91ed932f02e8fb2ddd027c9b7b14c3f9f32a433294d56137fbe68b1c0d3/microsoft/TypeScript/issues/21772
og:image:altTypeScript Version: 2.8.1-insiders-20180206 Search Terms: JSX Refactor Extract Code import * as React from 'react' class Foo extends React.Component { render() { return (
bold
)...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemjbvz
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/21772#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F21772
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F21772
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/21772
Reloadhttps://github.com/microsoft/TypeScript/issues/21772
Reloadhttps://github.com/microsoft/TypeScript/issues/21772
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests309 (309)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/21772
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/21772
#21777https://github.com/microsoft/TypeScript/pull/21777
getEditsForRefactor debug failure on jsx selectionhttps://github.com/microsoft/TypeScript/issues/21772#top
#21777https://github.com/microsoft/TypeScript/pull/21777
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 2.8.1https://github.com/microsoft/TypeScript/milestone/66
https://github.com/mjbvz
Matt Bierner (mjbvz)https://github.com/mjbvz
on Feb 8, 2018https://github.com/microsoft/TypeScript/issues/21772#issue-295659365
Add refactoring action to export selected JSX code as stateless component #15090https://github.com/microsoft/TypeScript/issues/15090
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
on Feb 8, 2018https://github.com/microsoft/TypeScript/issues/21772#event-1465451090
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on Feb 8, 2018https://github.com/microsoft/TypeScript/issues/21772#event-1465451191
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
TypeScript 2.8https://github.com/microsoft/TypeScript/milestone/61
on Feb 8, 2018https://github.com/microsoft/TypeScript/issues/21772#event-1465451237
https://github.com/mjbvz
Matt Bierner (mjbvz)https://github.com/mjbvz
on Feb 8, 2018https://github.com/microsoft/TypeScript/issues/21772#issuecomment-364258178
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
on Feb 12, 2018https://github.com/microsoft/TypeScript/issues/21772#event-1470265517
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
TypeScript 2.8https://github.com/microsoft/TypeScript/milestone/61
TypeScript 2.8.1https://github.com/microsoft/TypeScript/milestone/66
on Mar 9, 2018https://github.com/microsoft/TypeScript/issues/21772#event-1514255344
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#21777https://github.com/microsoft/TypeScript/pull/21777
on Mar 12, 2018https://github.com/microsoft/TypeScript/issues/21772#event-1517258711
microsofthttps://github.com/microsoft
on Jul 25, 2018https://github.com/microsoft/TypeScript/issues/21772#event-1753418952
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/21772
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/21772
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 2.8.1https://github.com/microsoft/TypeScript/milestone/66
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.