Title: Renaming the discrimnant of a union should always rename all occurrences · Issue #21288 · microsoft/TypeScript · GitHub
Open Graph Title: Renaming the discrimnant of a union should always rename all occurrences · Issue #21288 · microsoft/TypeScript
X Title: Renaming the discrimnant of a union should always rename all occurrences · Issue #21288 · microsoft/TypeScript
Description: TypeScript Version: master Search Terms: rename all locations find references discriminated union Code type Result = { kind: "success", code: number } | // 1 { kind: "failure", message: string }; // 2 function fn(): Result { if (Math.ran...
Open Graph Description: TypeScript Version: master Search Terms: rename all locations find references discriminated union Code type Result = { kind: "success", code: number } | // 1 { kind: "failure", message: string }; /...
X Description: TypeScript Version: master Search Terms: rename all locations find references discriminated union Code type Result = { kind: "success", code: number } | // 1 { kind: "failure", ...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/21288
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Renaming the discrimnant of a union should always rename all occurrences","articleBody":"**TypeScript Version:** master\r\n\r\n\u003c!-- Search terms you tried before logging this (so others can find this issue more easily) -->\r\n**Search Terms:** rename all locations find references discriminated union\r\n\r\n**Code**\r\n\r\n```ts\r\ntype Result =\r\n { kind: \"success\", code: number } | // 1\r\n { kind: \"failure\", message: string }; // 2\r\nfunction fn(): Result {\r\n if (Math.random() > 0.5) {\r\n return { kind: \"failure\", message: \"oops\" } // 3\r\n } else {\r\n return { kind: \"success\", code: 200 } // 4\r\n }\r\n}\r\n\r\nconst r = fn();\r\nif (r.kind === \"failure\") { // 5\r\n r.message;\r\n} else if (r.kind === \"success\") { // 6\r\n r.code;\r\n}\r\n```\r\n\r\nThere are 6 occurrences of `kind` in this program (annotated above); renaming at locations 1 and 2 does not produce an error-free program, locations 3 and 4 do, location 5 does, but location 6 does not.\r\n\r\n**Playground Link:** [link](http://www.typescriptlang.org/play/#src=type%20Result%20%3D%0D%0A%20%20%20%20%7B%20kind%3A%20%22success%22%2C%20code%3A%20number%20%7D%20%7C%0D%0A%20%20%20%20%7B%20kind%3A%20%22failure%22%2C%20message%3A%20string%20%7D%3B%0D%0Afunction%20fn()%3A%20Result%20%7B%0D%0A%20%20%20%20if%20(Math.random()%20%3E%200.5)%20%7B%0D%0A%20%20%20%20%20%20%20%20return%20%7B%20kind%3A%20%22failure%22%2C%20message%3A%20%22oops%22%20%7D%0D%0A%20%20%20%20%7D%20else%20%7B%0D%0A%20%20%20%20%20%20%20%20return%20%7B%20kind%3A%20%22success%22%2C%20code%3A%20200%20%7D%0D%0A%20%20%20%20%7D%0D%0A%7D%0D%0A%0D%0Aconst%20r%20%3D%20fn()%3B%0D%0Aif%20(r.kind%20%3D%3D%3D%20%22failure%22)%20%7B%0D%0A%20%20%20%20r.message%3B%0D%0A%7D%20else%20if%20(r.kind%20%3D%3D%3D%20%22success%22)%20%7B%0D%0A%20%20%20%20r.code%3B%0D%0A%7D%0D%0A)\r\n\r\n**Related Issues:** ?\r\n","author":{"url":"https://github.com/RyanCavanaugh","@type":"Person","name":"RyanCavanaugh"},"datePublished":"2018-01-19T00:02:31Z","url":"https://github.com/microsoft/TypeScript/issues/21288"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:416d2451-1ae8-2308-2606-df00ad21916a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E99C:19F84C:E2F0E7:123B8C9:6B00F60C |
| html-safe-nonce | f3e29e6a22de15f768fb760f6e173f4bf6bd610c8b9fd8d488d300db87bb8344 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTlDOjE5Rjg0QzpFMkYwRTc6MTIzQjhDOTo2QjAwRjYwQyIsInZpc2l0b3JfaWQiOiI0OTUxNjc5MTEwMjk3NDgyNzY0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7f40a07dbd7e5ce4e09f2255363e6086bc76c7e80b8573aa735d5584921fb2f8 |
| hovercard-subject-tag | issue:289819050 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/21288/issue_layout |
| twitter:image | https://opengraph.githubassets.com/f8ea172581da26ab44cc3fe8023e0286c0409b201c6214563bfa688a86d41528/microsoft/TypeScript/issues/21288 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f8ea172581da26ab44cc3fe8023e0286c0409b201c6214563bfa688a86d41528/microsoft/TypeScript/issues/21288 |
| og:image:alt | TypeScript Version: master Search Terms: rename all locations find references discriminated union Code type Result = { kind: "success", code: number } | // 1 { kind: "failure", message: string }; /... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | RyanCavanaugh |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width