René's URL Explorer Experiment


Title: isTypeOfExpression is broken · Issue #20875 · microsoft/TypeScript · GitHub

Open Graph Title: isTypeOfExpression is broken · Issue #20875 · microsoft/TypeScript

X Title: isTypeOfExpression is broken · Issue #20875 · microsoft/TypeScript

Description: TypeScript Version: 2.6.2 Code import * as ts from 'typescript' const testTypeOf = ts.createTypeOf(ts.createLiteral("")) const testAwait = ts.createAwait(ts.createLiteral("")) console.log(testTypeOf.kind, testAwait.kind) // 189, 191 cons...

Open Graph Description: TypeScript Version: 2.6.2 Code import * as ts from 'typescript' const testTypeOf = ts.createTypeOf(ts.createLiteral("")) const testAwait = ts.createAwait(ts.createLiteral("")) console.log(testTypeO...

X Description: TypeScript Version: 2.6.2 Code import * as ts from 'typescript' const testTypeOf = ts.createTypeOf(ts.createLiteral("")) const testAwait = ts.createAwait(ts.createLiteral("&q...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/20875

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"isTypeOfExpression is broken","articleBody":"\u003c!-- BUGS: Please use this template. -->\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:**  2.6.2 \r\n**Code**\r\n```ts\r\nimport * as ts from 'typescript'\r\n\r\nconst testTypeOf = ts.createTypeOf(ts.createLiteral(\"\"))\r\nconst testAwait = ts.createAwait(ts.createLiteral(\"\"))\r\n\r\nconsole.log(testTypeOf.kind, testAwait.kind) // 189, 191\r\n\r\nconsole.log(ts.isTypeOfExpression(testTypeOf)) // Prints false, should be true\r\nconsole.log(ts.isTypeOfExpression(testAwait)) // Prints true, should be false\r\n```\r\n\r\n**Expected behavior:**\r\n`ts.isTypeofExpression` should return `true` (only) for `TypeOfExpression` nodes.\r\n\r\n**Actual behavior:**\r\nIt returns `true` for `AwaitExpression` nodes instead.\r\n\r\n**Reason**\r\nThe nodes both get created correctly (`TypeOfExpression` has kind `189` like it should), but the generated code for `isTypeOfExpression` uses the wrong number for `kind`: (from [`tsc.ts`](https://github.com/Microsoft/TypeScript/blob/release-2.6/lib/tsc.js), starting on line 9132)\r\n```ts\r\n    function isTypeOfExpression(node) {\r\n        return node.kind === 191;\r\n    }\r\n    ts.isTypeOfExpression = isTypeOfExpression;\r\n    function isVoidExpression(node) {\r\n        return node.kind === 190;\r\n    }\r\n    ts.isVoidExpression = isVoidExpression;\r\n    function isAwaitExpression(node) {\r\n        return node.kind === 191;\r\n    }\r\n    ts.isAwaitExpression = isAwaitExpression;\r\n```\r\nNote that some code uses the correct `kind`:\r\n```ts\r\n    function createTypeOf(expression) {\r\n        var node = createSynthesizedNode(189);\r\n        node.expression = ts.parenthesizePrefixOperand(expression);\r\n        return node;\r\n    }\r\n```\r\nNote that this issue also exists on [master](https://github.com/Microsoft/TypeScript/tree/8118cc76295d5f3a1bb65bd97807d649ee0a5bc9), even though the numbers for `SyntaxKind` enum values have changed.\r\n\r\nI couldn't find where this code gets generated, so I haven't been able to investigate further.","author":{"url":"https://github.com/tehwalris","@type":"Person","name":"tehwalris"},"datePublished":"2017-12-23T14:04:23Z","url":"https://github.com/microsoft/TypeScript/issues/20875"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:71ce9b2a-032c-da19-c83d-0cdd11e6b636
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA344:21AC3F:BBD3C6:F14B21:6B00E79B
html-safe-noncedeabbc0dc1779e8869850c2a8e5e199ee5be8926753e2319b0302a11a5ed5ad8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMzQ0OjIxQUMzRjpCQkQzQzY6RjE0QjIxOjZCMDBFNzlCIiwidmlzaXRvcl9pZCI6IjY0NDA1OTA4MTY5MzQxNjAyODMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd7a23d0ff915ea193ebd729af23e427fab7db35eb487b549ae2c3aff4d732627
hovercard-subject-tagissue:284308104
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/20875/issue_layout
twitter:imagehttps://opengraph.githubassets.com/b3c1a6ca9ae1525ecfbbc28c604109d9a53421a38ffb7f17e727d6f168f3b245/microsoft/TypeScript/issues/20875
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b3c1a6ca9ae1525ecfbbc28c604109d9a53421a38ffb7f17e727d6f168f3b245/microsoft/TypeScript/issues/20875
og:image:altTypeScript Version: 2.6.2 Code import * as ts from 'typescript' const testTypeOf = ts.createTypeOf(ts.createLiteral("")) const testAwait = ts.createAwait(ts.createLiteral("")) console.log(testTypeO...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametehwalris
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/20875#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F20875
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F20875
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/20875
Reloadhttps://github.com/microsoft/TypeScript/issues/20875
Reloadhttps://github.com/microsoft/TypeScript/issues/20875
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/20875
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/20875
isTypeOfExpression is brokenhttps://github.com/microsoft/TypeScript/issues/20875#top
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
Domain: APIRelates to the public API for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20API%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 2.7.1https://github.com/microsoft/TypeScript/milestone/62
https://github.com/tehwalris
Philippe Voinov (tehwalris)https://github.com/tehwalris
on Dec 23, 2017https://github.com/microsoft/TypeScript/issues/20875#issue-284308104
tsc.tshttps://github.com/Microsoft/TypeScript/blob/release-2.6/lib/tsc.js
masterhttps://github.com/Microsoft/TypeScript/tree/8118cc76295d5f3a1bb65bd97807d649ee0a5bc9
https://github.com/magcius
Jasper St. Pierre (magcius)https://github.com/magcius
on Dec 23, 2017https://github.com/microsoft/TypeScript/issues/20875#issuecomment-353739440
https://github.com/Microsoft/TypeScript/blob/81fbe12c541d47ead85c7ae77c7eb3880b5eff68/src/compiler/utilities.ts#L4634-L4636https://github.com/Microsoft/TypeScript/blob/81fbe12c541d47ead85c7ae77c7eb3880b5eff68/src/compiler/utilities.ts#L4634-L4636
Anders Hejlsberg (ahejlsberg)https://github.com/ahejlsberg
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
on Dec 23, 2017https://github.com/microsoft/TypeScript/issues/20875#event-1400449118
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
good first issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22good%20first%20issue%22
help wantedhttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22help%20wanted%22
on Dec 23, 2017https://github.com/microsoft/TypeScript/issues/20875#event-1400493608
https://github.com/DanielRosenwasser
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
on Dec 23, 2017https://github.com/microsoft/TypeScript/issues/20875#issuecomment-353749844
Daniel Rosenwasser (DanielRosenwasser)https://github.com/DanielRosenwasser
Domain: APIRelates to the public API for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20API%22
on Dec 23, 2017https://github.com/microsoft/TypeScript/issues/20875#event-1400493703
Philippe Voinov (tehwalris)https://github.com/tehwalris
on Dec 24, 2017https://github.com/microsoft/TypeScript/issues/20875#event-1400595412
Fix isTypeOfExpression in compiler API (microsoft#20875).https://github.com/tehwalris/TypeScript/commit/a16e87f17240892163ad8878c6d1f973ad7a072b
microsoft#20875https://github.com/microsoft/TypeScript/issues/20875
a16e87fhttps://github.com/tehwalris/TypeScript/commit/a16e87f17240892163ad8878c6d1f973ad7a072b
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on Jan 4, 2018https://github.com/microsoft/TypeScript/issues/20875#event-1408800602
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#20884https://github.com/microsoft/TypeScript/pull/20884
on Jan 20, 2018https://github.com/microsoft/TypeScript/issues/20875#event-1433514358
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
on Jan 20, 2018https://github.com/microsoft/TypeScript/issues/20875#event-1433514410
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
TypeScript 2.7.1https://github.com/microsoft/TypeScript/milestone/62
on Jan 20, 2018https://github.com/microsoft/TypeScript/issues/20875#event-1433514425
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on Jan 20, 2018https://github.com/microsoft/TypeScript/issues/20875#event-1433514455
Fix isTypeOfExpression in compiler API (#20875). (#20884)https://github.com/microsoft/TypeScript/commit/a7c53c70d2d74520483a892eb3e9ca55daf655cf
#20875https://github.com/microsoft/TypeScript/issues/20875
#20884https://github.com/microsoft/TypeScript/pull/20884
a7c53c7https://github.com/microsoft/TypeScript/commit/a7c53c70d2d74520483a892eb3e9ca55daf655cf
Albert Siddhartha Slawinski (errendir)https://github.com/errendir
on Jan 20, 2018https://github.com/microsoft/TypeScript/issues/20875#event-1433853374
Merge remote-tracking branch 'origin/master' into faster-interface-checkhttps://github.com/errendir/TypeScript/commit/bff2f37b3ddc6235de53da9a493f80a24dd6ca7b
bff2f37https://github.com/errendir/TypeScript/commit/bff2f37b3ddc6235de53da9a493f80a24dd6ca7b
microsofthttps://github.com/microsoft
on Jul 3, 2018https://github.com/microsoft/TypeScript/issues/20875#event-1712804747
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/20875
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/20875
BugA bug in TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Bug%22
Domain: APIRelates to the public API for TypeScripthttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Domain%3A%20API%22
FixedA PR has been merged for this issuehttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Fixed%22
TypeScript 2.7.1https://github.com/microsoft/TypeScript/milestone/62
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.