Title: Apply type inference to mapObject[s.kind] · Issue #20190 · microsoft/TypeScript · GitHub
Open Graph Title: Apply type inference to mapObject[s.kind] · Issue #20190 · microsoft/TypeScript
X Title: Apply type inference to mapObject[s.kind] · Issue #20190 · microsoft/TypeScript
Description: TypeScript Version: 2.6.1 Description I am very impressed by the type inference TypeScript can do with switch and for...else statements. I miss, however, type inference for map object lookups. Code type Named = { kind: "named", id: strin...
Open Graph Description: TypeScript Version: 2.6.1 Description I am very impressed by the type inference TypeScript can do with switch and for...else statements. I miss, however, type inference for map object lookups. Code...
X Description: TypeScript Version: 2.6.1 Description I am very impressed by the type inference TypeScript can do with switch and for...else statements. I miss, however, type inference for map object lookups. Code...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/20190
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Apply type inference to mapObject[s.kind]","articleBody":"\u003c!-- BUGS: Please use this template. -->\r\n\u003c!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->\r\n\u003c!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** 2.6.1\r\n\r\n**Description**\r\n\r\nI am very impressed by the type inference TypeScript can do with `switch` and `for...else` statements.\r\nI miss, however, type inference for map object lookups.\r\n\r\n**Code**\r\n\r\n```ts\r\ntype Named = { kind: \"named\", id: string };\r\ntype Decimal = { kind: \"decimal\", id: number };\r\ntype Hex = { kind: \"hex\", id: number };\r\ntype Entity = Named | Decimal | Hex;\r\nlet areaFunctions = {\r\n \"named\": function (s: Named) { return \"&\"+s.id+\";\"; },\r\n \"decimal\": function (s: Decimal) { return \"\"+s.id+\";\"; },\r\n \"hex\": function (s: Hex) { return \"\"+s.id+\";\"; },\r\n \"something else\": {}\r\n}\r\n// works\r\nlet printEntity1 = function (s: Entity) {\r\n switch (s.kind) {\r\n case \"named\": return areaFunctions[\"named\"](s);\r\n // This works perfectly, TS knows that s can only be to type 'named', here\r\n // It also knows the function definition and sees that both match\r\n case \"decimal\": return areaFunctions[\"decimal\"](s);\r\n case \"hex\": return areaFunctions[\"hex\"](s);\r\n }\r\n}\r\n// does not work\r\nlet printEntity2 = function (s: Entity) {\r\n return areaFunctions[s.kind](s); // error, although it is equivalent to printEntity1\r\n}\r\n// does not work, although a common JS pattern\r\nlet printEntity3 = function (s: Entity) {\r\n if (areaFunctions[s.kind]) {\r\n return areaFunctions[s.kind](s); // type inference does not work\r\n }\r\n return \"-\";\r\n}\r\n```\r\n\r\n**Expected behavior:**\r\nprintEntity2 would compile\r\n\r\n**Actual behavior:**\r\nBut it doesn't. I am forced to expand a single line into a long switch statement (just 3 lines here, but a lot more -- and often used -- in my project).","author":{"url":"https://github.com/mhchem","@type":"Person","name":"mhchem"},"datePublished":"2017-11-21T12:38:43Z","url":"https://github.com/microsoft/TypeScript/issues/20190"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:11f0c98b-7aad-8c52-5a87-84c57429512c |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 8330:29FFA9:6B33E5:8985AF:6B00E0EF |
| html-safe-nonce | 7d314b1f7544d74f8b3eb6fee843f21f0c3dacd0de3b041194aed1f7639cc5a7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MzMwOjI5RkZBOTo2QjMzRTU6ODk4NUFGOjZCMDBFMEVGIiwidmlzaXRvcl9pZCI6IjMwMDc4MjUyNTE5ODQ3OTM4MzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 533de6af5a208a3a64bc373958ed8a0c57950b1db5c8cdcc220601408efbf32b |
| hovercard-subject-tag | issue:275697235 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/20190/issue_layout |
| twitter:image | https://opengraph.githubassets.com/337ea76b7801981d01f1c5f5d37dc79a4db057a3313da813f978fc7db95d8f50/microsoft/TypeScript/issues/20190 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/337ea76b7801981d01f1c5f5d37dc79a4db057a3313da813f978fc7db95d8f50/microsoft/TypeScript/issues/20190 |
| og:image:alt | TypeScript Version: 2.6.1 Description I am very impressed by the type inference TypeScript can do with switch and for...else statements. I miss, however, type inference for map object lookups. Code... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | mhchem |
| hostname | github.com |
| expected-hostname | github.com |
| None | 043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 5425dc24e8bd8d6fca9641a12afc984825a43875 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width