Title: Design Meeting Notes, 11/10/2017 · Issue #20121 · microsoft/TypeScript · GitHub
Open Graph Title: Design Meeting Notes, 11/10/2017 · Issue #20121 · microsoft/TypeScript
X Title: Design Meeting Notes, 11/10/2017 · Issue #20121 · microsoft/TypeScript
Description: CommonJS interop #19675 Let's call this esModuleInterop. This PR gives people the Babel behavior that synthesizes a namespace with a default export with plucked properties. We want people to actually use this because it gives people a mi...
Open Graph Description: CommonJS interop #19675 Let's call this esModuleInterop. This PR gives people the Babel behavior that synthesizes a namespace with a default export with plucked properties. We want people to actual...
X Description: CommonJS interop #19675 Let's call this esModuleInterop. This PR gives people the Babel behavior that synthesizes a namespace with a default export with plucked properties. We want people to ac...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/20121
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Design Meeting Notes, 11/10/2017","articleBody":"# CommonJS interop\r\n\r\n#19675\r\n\r\n* Let's call this `esModuleInterop`.\r\n* This PR gives people the Babel behavior that synthesizes a namespace with a default export with plucked properties.\r\n * We want people to actually use this because it gives people a migration path to using Node's interop scheme for ES modules.\r\n* One change: `allowSyntheticDefaultExports` no longer actually allows you to default-import from `.ts` and `.js` files where inappropriate. Only from `.d.ts` files.\r\n* What about calling and constructing namespace imports?\r\n\r\n ```ts\r\n import * as express from \"express\"\r\n express();\r\n ```\r\n * When using this flag, this will break; otherwise, users will get the same behavior.\r\n* Do we want to introduce an error?\r\n * That's considered breaking for most people.\r\n* But we want to push people to use best practices.\r\n * Put it as a default in `tsc --init`.\r\n* Also, if a `.d.ts` file has a variable named `__esModule`, then we do the \"right\" thing.\r\n * Should we start emitting `__esModule` in `.d.ts` files?\r\n * Seems arguable based on the output and the intent.\r\n * We can revisit this.\r\n\r\n# Comparability Relationship Adjustment\r\n\r\n#19587\r\n#19322\r\n#19926\r\n\r\n* The comparability relationship is somewhat limited in what it can express.\r\n * Original differences between comparability are with union source types and optionality.\r\n\r\n```ts\r\nconst x1 = { a: 1 as 1, b: \"abc\" };\r\nconst x2 = { a: 1, b: \"abc\" as \"abc\" };\r\n\r\nif (x1 === x2) {\r\n// ~~~~~~~~~\r\n// Error\r\n}\r\n\r\ninterface T1 { x: number }\r\ninterface T2 { y: number }\r\nlet x = { x: 100, y: 200 } as T1\r\nlet y = { x: 100, y: 200 } as T2\r\nif (x === y) {\r\n// ~~~~~~~\r\n// Error\r\n}\r\n\r\nfunction f\u003cT extends { a: number }, U>(x: T, y: U, z: { a: number}) {\r\n // All of these are allowed...\r\n let o = {};\r\n z === {};\r\n x === {};\r\n o === {};\r\n o === y;\r\n x === { a: 42 }\r\n\r\n // but not this...\r\n x === y;\r\n// ~~~~~~~\r\n// Error!\r\n}\r\n```\r\n\r\n* These are incomparable - we don't go bidirectionally on the `a` property nor the `b` property.\r\n * We only check both ways at the top level.\r\n* Other issues: seems arguable whether `never` should be comparable to/from anything apart from `never`.\r\n* Perhaps we want to change comparability to only concern itself when things are *potentially* true.\r\n * Only disallow when a comparison could *never* occur.\r\n* Primitives/literal types are comparable to/from their base primitive \"family\" type.\r\n* When comparing two object types, only check for properties present in both.\r\n* We speculated about this when we first did comparable; do people actually run into this a lot?\r\n * Well it's not unsound.\r\n * Could you compare a function to an array?\r\n * Yes.\r\n* If you want to do this, it seems like you want to give users a way to say \"no, this type is really not the type\"\r\n* Sounds like we need two type relationships: comparable and castable.\r\n* It also feels kind of weird that in the true branch, you can't even assign one to the other after the fact.\r\n* Should we just stop applying checks entirely around type assertions?\r\n * No.\r\n* Conclusion:\r\n * Original use case should still be fixed - base primitive types & enum types are always comparable to/from their literal type.\r\n * Hold off on the other changes.","author":{"url":"https://github.com/DanielRosenwasser","@type":"Person","name":"DanielRosenwasser"},"datePublished":"2017-11-17T23:44:22Z","url":"https://github.com/microsoft/TypeScript/issues/20121"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:40d69a3a-cdd3-5961-a0ad-bc1970eccd91 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B0FE:CB549:13EE0E:1ACCD4:6AFBDDB4 |
| html-safe-nonce | e8b98ca4d259823b90c0e7ecacc97d8d95a935b820cb7034bd3f78bda0a18e02 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMEZFOkNCNTQ5OjEzRUUwRToxQUNDRDQ6NkFGQkREQjQiLCJ2aXNpdG9yX2lkIjoiNTE1OTQyMTQ2ODYwOTMzODgwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 781633865b476599c30f7659d553a89962b7f2f54d5a9c99b61f8af1bfb345ee |
| hovercard-subject-tag | issue:275028984 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/20121/issue_layout |
| twitter:image | https://opengraph.githubassets.com/0ae9e0923b273dcfce894fb19ef48b1be91f735e4f09e217e0bb7000ead19866/microsoft/TypeScript/issues/20121 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0ae9e0923b273dcfce894fb19ef48b1be91f735e4f09e217e0bb7000ead19866/microsoft/TypeScript/issues/20121 |
| og:image:alt | CommonJS interop #19675 Let's call this esModuleInterop. This PR gives people the Babel behavior that synthesizes a namespace with a default export with plucked properties. We want people to actual... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | DanielRosenwasser |
| hostname | github.com |
| expected-hostname | github.com |
| None | 744d4381b1c4dbd6d8736c7d7e5bbe7dc11217584e457a3555020c631764e8ec |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | df859c48a4c8b4c0009c19bb4e82101aacb4b998 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width