René's URL Explorer Experiment


Title: Typescript generator function assumes asynchronous global Promise · Issue #19909 · microsoft/TypeScript · GitHub

Open Graph Title: Typescript generator function assumes asynchronous global Promise · Issue #19909 · microsoft/TypeScript

X Title: Typescript generator function assumes asynchronous global Promise · Issue #19909 · microsoft/TypeScript

Description: This may sound like a silly report -- please bear with me (: I'm the author of synchronous-promise, an A+ Promise-like implementation which doesn't defer (and allows pausing and resuming), so makes testing certain scenarios clearer / eas...

Open Graph Description: This may sound like a silly report -- please bear with me (: I'm the author of synchronous-promise, an A+ Promise-like implementation which doesn't defer (and allows pausing and resuming), so makes...

X Description: This may sound like a silly report -- please bear with me (: I'm the author of synchronous-promise, an A+ Promise-like implementation which doesn't defer (and allows pausing and resuming), ...

Opengraph URL: https://github.com/microsoft/TypeScript/issues/19909

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Typescript generator function assumes asynchronous global Promise","articleBody":"This may sound like a silly report -- please bear with me (:\r\n\r\nI'm the author of [synchronous-promise](https://github.com/fluffynuts/synchronous-promise), an A+ Promise-_like_ implementation which doesn't defer (and allows pausing and resuming), so makes testing certain scenarios clearer / easier. Mostly, it's worked well with TypeScript because of how awesome TypeScript's async/await logic is.\r\n\r\nThe problem is _very_ specific is this: if `SynchronousPromise` is installed globally (overriding `Promise` -- and we could do this so that client code returning a `Promise` actually returns a `SynchronousPromise`, during test-time), _and_ a `SynchronousPromise` resolution happens in a `setTimeout`, the TS generator function also makes use of `SynchronousPromise` and doesn't complete awaiting the following:\r\n\r\n```ts\r\nimport { SynchronousPromise } from \"./index\";\r\nimport { expect } from 'chai';\r\n\r\n// install SynchronousPromise globally\r\nglobal.Promise = SynchronousPromise;\r\n\r\ndescribe(\"typescript async/await\", () => {\r\n  it(\"should not hang\", async function() {\r\n    // Arrange\r\n    // Act\r\n    await new SynchronousPromise(function(resolve, reject) {\r\n      setTimeout(() => {\r\n        resolve(\"done!\");\r\n      }, 0);\r\n    });\r\n  })\r\n});\r\n```\r\n\r\nThe problem seems to track down to the generated `generator` code which expects a `P` (short-handed global `Promise`) to defer. If I comment out the line:\r\n```ts\r\n// global.Promise = SynchronousPromise;\r\n```\r\nthen the test completes, as expected.\r\n\r\nNow, I realise that there is a valid argument that `SynchronousPromise`, being _not_ async in nature, violates the A+ specification and that this whole issue shouldn't be the problem of TypeScript at all. This is a fair argument, which has a counter-argument: that all TypeScript is a super-set of Javascript. The following Javascript works fine:\r\n```js\r\n\"use strict\";\r\nvar\r\n  expect = require(\"chai\").expect,\r\n  sut = require(\"./index\"),\r\n  SynchronousPromise = sut.SynchronousPromise,\r\ndescribe(\"with timeout in ctor\", () => {\r\n  it(\"should complete when the timeout does\", (done) => {\r\n    // Arrange\r\n    var\r\n      captured,\r\n      sut = new SynchronousPromise(function(resolve, reject) {\r\n        setTimeout(function() {\r\n          resolve(\"moo\");\r\n        }, 0);\r\n      }).then(function(result) {\r\n        captured = result;\r\n      });\r\n    // Act\r\n    // Assert\r\n    setTimeout(function() {\r\n      expect(captured).to.equal(\"moo\");\r\n        done();\r\n     }, 500);\r\n  });\r\n});\r\n```\r\n\r\nAnd debugging the prior snippet has shown that all promises (even the TS-generated / wrapper ones created for async/await) are resolved. Execution is simply not continued by the generator.\r\n\r\n**Expected behavior:**\r\nThe first snippet (TypeScript) should complete like the second snippet (Javascript)\r\n\r\n**Actual behavior:**\r\nThe Javascript completes where the TypeScript does not\r\n\r\n**Proposed solutions.**\r\n1) Since the generator function requires deferral, perhaps use `setTimeout` -- however, this is subject to the same problems as testing frameworks like `jasmine` can install a testing clock which has to be manually advanced by the test code.\r\n2) \"var off\" the global Promise implementation before allowing client code to run and use that version inside the generator code. This seems to be the lowest-hanging fruit for solving this problem, from my point of view.\r\n\r\nOf course, the response could also be that this is just an issue with `synchronous-promise`, but it also highlights that TS compiled execution can be interfered with by client code -- which may not be optimal.\r\n","author":{"url":"https://github.com/fluffynuts","@type":"Person","name":"fluffynuts"},"datePublished":"2017-11-10T13:47:46Z","url":"https://github.com/microsoft/TypeScript/issues/19909"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:00ec965d-90e6-993b-daa2-319f66b44567
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idEA78:2564D8:81DC76:AE2320:6B00DD31
html-safe-noncec2ac6086349b2de75fd31c68ef30550f05dbd8b57a3e67c03c266a181e79fb1e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQTc4OjI1NjREODo4MURDNzY6QUUyMzIwOjZCMDBERDMxIiwidmlzaXRvcl9pZCI6IjYzMjk3Mzc2NjM3Nzk3NTczNjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb64ed9c8a269e831fbad5464fe2ddb9a0eb7ad9f983b39133243093686b49cc3
hovercard-subject-tagissue:272937619
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/19909/issue_layout
twitter:imagehttps://opengraph.githubassets.com/885a92faa48778179dec487ff11ecc02e6d02b1c870376aff784bcf0765e97c9/microsoft/TypeScript/issues/19909
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/885a92faa48778179dec487ff11ecc02e6d02b1c870376aff784bcf0765e97c9/microsoft/TypeScript/issues/19909
og:image:altThis may sound like a silly report -- please bear with me (: I'm the author of synchronous-promise, an A+ Promise-like implementation which doesn't defer (and allows pausing and resuming), so makes...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamefluffynuts
hostnamegithub.com
expected-hostnamegithub.com
None043c3f30fbcbe2c6c8e729e10cbbbc90c406546f9fbbb67c648d38f6b7d16daf
turbo-cache-controlno-preview
go-importgithub.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git
octolytics-dimension-user_id6154722
octolytics-dimension-user_loginmicrosoft
octolytics-dimension-repository_id20929025
octolytics-dimension-repository_nwomicrosoft/TypeScript
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id20929025
octolytics-dimension-repository_network_root_nwomicrosoft/TypeScript
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5425dc24e8bd8d6fca9641a12afc984825a43875
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/microsoft/TypeScript/issues/19909#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F19909
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmicrosoft%2FTypeScript%2Fissues%2F19909
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=microsoft%2FTypeScript
Reloadhttps://github.com/microsoft/TypeScript/issues/19909
Reloadhttps://github.com/microsoft/TypeScript/issues/19909
Reloadhttps://github.com/microsoft/TypeScript/issues/19909
microsofthttps://github.com/microsoft
TypeScripthttps://github.com/microsoft/TypeScript
Codehttps://github.com/microsoft/TypeScript
Issues5k (5k)https://github.com/microsoft/TypeScript/issues
Pull requests308 (308)https://github.com/microsoft/TypeScript/pulls
Actionshttps://github.com/microsoft/TypeScript/actions
Projectshttps://github.com/microsoft/TypeScript/projects
Wikihttps://github.com/microsoft/TypeScript/wiki
Security and qualityhttps://github.com/microsoft/TypeScript/security
Insightshttps://github.com/microsoft/TypeScript/insights
https://github.com/microsoft/TypeScript
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/19909
New issuehttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/19909
Typescript generator function assumes asynchronous global Promisehttps://github.com/microsoft/TypeScript/issues/19909#top
Working as IntendedThe behavior described is the intended behavior; this is not a bughttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Working%20as%20Intended%22
https://github.com/fluffynuts
Davyd McColl (fluffynuts)https://github.com/fluffynuts
on Nov 10, 2017https://github.com/microsoft/TypeScript/issues/19909#issue-272937619
synchronous-promisehttps://github.com/fluffynuts/synchronous-promise
https://github.com/mhegazy
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
on Nov 10, 2017https://github.com/microsoft/TypeScript/issues/19909#issuecomment-343613389
#6631https://github.com/microsoft/TypeScript/pull/6631
#6068https://github.com/microsoft/TypeScript/issues/6068
Mohamed Hegazy (mhegazy)https://github.com/mhegazy
Working as IntendedThe behavior described is the intended behavior; this is not a bughttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Working%20as%20Intended%22
on Nov 10, 2017https://github.com/microsoft/TypeScript/issues/19909#event-1336963536
https://github.com/fluffynuts
Davyd McColl (fluffynuts)https://github.com/fluffynuts
on Nov 11, 2017https://github.com/microsoft/TypeScript/issues/19909#issuecomment-343643785
Nested promise is changing the parent promise fluffynuts/synchronous-promise#7https://github.com/fluffynuts/synchronous-promise/issues/7
https://github.com/kitsonk
Kitson Kelly (kitsonk)https://github.com/kitsonk
on Nov 11, 2017https://github.com/microsoft/TypeScript/issues/19909#issuecomment-343647960
https://github.com/fluffynuts
Davyd McColl (fluffynuts)https://github.com/fluffynuts
on Nov 11, 2017https://github.com/microsoft/TypeScript/issues/19909#issuecomment-343650675
https://github.com/fluffynuts
Davyd McColl (fluffynuts)https://github.com/fluffynuts
on Nov 11, 2017https://github.com/microsoft/TypeScript/issues/19909#issuecomment-343655118
https://github.com/typescript-bot
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
on Nov 27, 2017https://github.com/microsoft/TypeScript/issues/19909#issuecomment-347281324
TypeScript Bot (typescript-bot)https://github.com/typescript-bot
completedhttps://github.com/microsoft/TypeScript/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Nov 27, 2017https://github.com/microsoft/TypeScript/issues/19909#event-1359865628
microsofthttps://github.com/microsoft
on Jun 14, 2018https://github.com/microsoft/TypeScript/issues/19909#event-1682113874
Sign up for freehttps://github.com/signup?return_to=https://github.com/microsoft/TypeScript/issues/19909
Sign in to commenthttps://github.com/login?return_to=https://github.com/microsoft/TypeScript/issues/19909
Working as IntendedThe behavior described is the intended behavior; this is not a bughttps://github.com/microsoft/TypeScript/issues?q=state%3Aopen%20label%3A%22Working%20as%20Intended%22
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.