Title: Property type is not narrowed for readonly object in some contexts · Issue #19469 · microsoft/TypeScript · GitHub
Open Graph Title: Property type is not narrowed for readonly object in some contexts · Issue #19469 · microsoft/TypeScript
X Title: Property type is not narrowed for readonly object in some contexts · Issue #19469 · microsoft/TypeScript
Description: TypeScript Version: 2.4.1 and 2.6.0-rc Code { type User = { name: string }; const logUser = (_user: User) => {}; type State = { user: User | undefined; }; const fn = function
Open Graph Description: TypeScript Version: 2.4.1 and 2.6.0-rc Code { type User = { name: string }; const logUser = (_user: User) => {}; type State = { user: User | undefined; }; const fn = function
X Description: TypeScript Version: 2.4.1 and 2.6.0-rc Code { type User = { name: string }; const logUser = (_user: User) => {}; type State = { user: User | undefined; }; const fn = function<Own extends {}&g...
Opengraph URL: https://github.com/microsoft/TypeScript/issues/19469
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Property type is not narrowed for readonly object in some contexts","articleBody":"\u003c!-- BUGS: Please use this template. -->\r\n\u003c!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->\r\n\u003c!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->\r\n\r\n\u003c!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->\r\n**TypeScript Version:** 2.4.1 and 2.6.0-rc\r\n\r\n**Code**\r\n\r\n```ts\r\n{\r\n type User = { name: string };\r\n const logUser = (_user: User) => {};\r\n\r\n type State = {\r\n user: User | undefined;\r\n };\r\n\r\n const fn = function\u003cOwn extends {}>(p: Readonly\u003cOwn & State>) {\r\n const { user } = p;\r\n if (user !== undefined) {\r\n // Unexpected error: Type 'undefined' is not assignable to type 'User'\r\n // `user` should be narrowed to exclude `undefined` here.\r\n logUser(user);\r\n }\r\n };\r\n}\r\n\r\n//\r\n// KNOWN WORKAROUNDS\r\n//\r\n\r\n{\r\n type User = { name: string };\r\n const logUser = (_user: User) => {};\r\n\r\n type State = {\r\n user: User | undefined;\r\n };\r\n\r\n const fn = function\u003cOwn extends {}>(p: Own & State) {\r\n const { user } = p;\r\n if (user !== undefined) {\r\n // No error when `Readonly` is dropped\r\n logUser(user);\r\n }\r\n };\r\n}\r\n\r\n{\r\n type User = { name: string };\r\n const logUser = (_user: User) => {};\r\n\r\n type State = {\r\n user: User | undefined;\r\n };\r\n\r\n const fn = function\u003cOwn extends {}>(p: Readonly\u003cOwn & State>) {\r\n const user: User | undefined = p.user;\r\n if (user !== undefined) {\r\n // No error when `user` is manually annotated\r\n logUser(user);\r\n }\r\n };\r\n}\r\n\r\n{\r\n type User = { name: string };\r\n const logUser = (_user: User) => {};\r\n\r\n type State = {\r\n user: User | undefined;\r\n };\r\n\r\n type Own = {};\r\n type P = Readonly\u003cOwn & State>\r\n const p = {} as any as P;\r\n\r\n const { user } = p;\r\n if (user !== undefined) {\r\n // No error if origin of `p` value and `Own` type is not from function\r\n logUser(user);\r\n }\r\n}\r\n```\r\n\r\n**Expected behavior:**\r\n(See comments in code.)","author":{"url":"https://github.com/OliverJAsh","@type":"Person","name":"OliverJAsh"},"datePublished":"2017-10-25T14:29:04Z","url":"https://github.com/microsoft/TypeScript/issues/19469"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:bb90f3fb-1a83-71ab-2c22-cfabc0beec9a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E54E:33F146:F71205:13DC911:6B00FF1F |
| html-safe-nonce | 8f6c5d64ba08c6b6ea2515b040adf97f7e63dde6d9eef3e764303e042563520d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTRFOjMzRjE0NjpGNzEyMDU6MTNEQzkxMTo2QjAwRkYxRiIsInZpc2l0b3JfaWQiOiIzMjEyNTUwOTYyNzA3MjM0NTkyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | c388ffa8e351ec4616d0cb934b99ffbe1a84d1dd91c266179cb545b7beea2cfd |
| hovercard-subject-tag | issue:268419919 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/microsoft/TypeScript/19469/issue_layout |
| twitter:image | https://opengraph.githubassets.com/b7fccf78ab5920f128d6382e3c9c9a00076c8d4fd79fc311408e4b8566a1614d/microsoft/TypeScript/issues/19469 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/b7fccf78ab5920f128d6382e3c9c9a00076c8d4fd79fc311408e4b8566a1614d/microsoft/TypeScript/issues/19469 |
| og:image:alt | TypeScript Version: 2.4.1 and 2.6.0-rc Code { type User = { name: string }; const logUser = (_user: User) => {}; type State = { user: User | undefined; }; const fn = function |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | OliverJAsh |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/microsoft/TypeScript git https://github.com/microsoft/TypeScript.git |
| octolytics-dimension-user_id | 6154722 |
| octolytics-dimension-user_login | microsoft |
| octolytics-dimension-repository_id | 20929025 |
| octolytics-dimension-repository_nwo | microsoft/TypeScript |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 20929025 |
| octolytics-dimension-repository_network_root_nwo | microsoft/TypeScript |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width